- 09 Jul, 2019 40 commits
-
-
Jordy Greenblatt authored
http://crbug.com/982375: The callback onCloseMenu_() is only defined in the language page JavaScript file in CrOS and Windows however it is bound as a callback in the HTML file regardless of the OS, causing console warnings [1]. http://crbug.com/982390: Also, the private functions section of the language_page's JS [1] is complicated unnecessarily by OS specific blocks for the same conditions that are separated for no logical reason. The first patchset in this CL consolidates the OS specific blocks of complete private methods (i.e. fixes http://crbug.com/982390). The second patch set prevents the onCloseMenu_() callback from being bound unless the OS is CrOS or window (i.e. fixes http://crbug.com/982375). [1] https://imgur.com/a/O5IFCE4 Bug: 982375, 982390 Change-Id: Ic72e7f0e8e1d1680907b4ab8aa99b45f221e4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693385Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#675847}
-
Robert Ogden authored
Bug: 977603 Change-Id: I659c9c6096c00ecdc73994860e30d51606447a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692497Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#675846}
-
Kehuang Li authored
This is the receiver side of Cast audio capture service that will observing platform audio input hoocked in assistant service. More info can be found in the design go/comms-virtual-mic. tests on desktop. Bug: internal: 133880006 Merge-With: eureka-internal/274195 Test: Make OTT call on Home after patching all CLs. Run and pass unit Change-Id: I662c77f4fae819ced791861ca5b762cdf08e8f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655085 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#675845}
-
Maksym Onufriienko authored
If tests run is interrupted(e.g. lost connection to testservice, test was stuck and no output for 3 mins and was killed then), xcodebuild_runner needs to parse test_output, collect passed tests and re-run test_bundle by filtering already passed tests (e.g. https://chromium-swarm.appspot.com/task?id=45c892feae862110). Removed _make_cmd_list_for_failed_tests because now tests will filter by passed tests for both cases when tests were interrupted and not. At the end of run also add a check whether all tests from test-bundle were executed and if not add 'not executed tests' record. Created the radar 'After primaryInstrumentsServerWithError xcodebuild did not finish its execution' https://feedbackassistant.apple.com/feedback/6476415 Bug: 979267 Change-Id: I596945e10bd8382c41487633456a3c80a3569419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680973Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#675844}
-
Dan Harrington authored
Change-Id: I46655436935303fae59c1c90e74b7f18d5ac1dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693204Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#675843}
-
Devlin Cronin authored
Update toolbar actions metrics: - Remove Toolbar.ActionsModel.ToolbarActionsVisible. It's redundant with ExtensionToolbarModel.BrowserActionsVisible. - Push back expiration on Toolbar.ActionsModel.ToolbarActionsVisible, and ExtensionToolbarModel.BrowserActionsCount to December 2019. Bug: 975789 Change-Id: Iea2e548f90fa3f8a16dd25b8cff9c25dbb270997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683362Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#675842}
-
Matt Falkenhagen authored
Bug: 982200 Change-Id: I68547d2d5b097ab0fd816e44ca548a0024acec70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692223Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#675841}
-
Michael Crouse authored
This change stores a fetched metadata entry in the hint cache store upon a successful fetch request when the response contains an empty set of hints. This ensures that a hints fetch is not attempted again before kUpdateFetchedHintsDelay. Bug: 932707 Change-Id: I5ced57b08446eb3537741a76b63e07c397e3853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692183 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#675840}
-
Hector Carmona authored
This reverts commit a0d64f3d. Reason for revert: Suspecting this CL of breaking generate_build_files step in Mac ASan 64 Builder. First failure here: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/86877 Original change's description: > Add brotli compression to grit > > -Add the "compress='brotli'" flag option in grdp files > -Grit will now automatically brotli compress if flag is included > -Previous Cl that was split into this one: > https://chromium-review.googlesource.com/c/chromium/src/+/1660352 > > > Bug: 826858 > Change-Id: I010ad1650394e4bdd58e066486b161cf74f2fff5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692234 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675763} TBR=dbeam@chromium.org,dpapad@chromium.org,agrieve@chromium.org,tiborg@chromium.org,smaier@chromium.org,jacqueschen@google.com Change-Id: I724ed738b56529fe4b4ac1c2ad3e0b9adbee9671 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693809Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#675839}
-
Devlin Cronin authored
Extensions.InjectedScriptExecutionTime measures the time it takes for content scripts to inject on a page, which is a useful metric when evaluating script performance. Since content scripts are fairly core to the platform, mark this histogram as never expiring. Bug: 975006 Change-Id: Ic64f75de7cdf61ae123e2b1040ecd7618f23ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691588Reviewed-by:
-
Maggie Chen authored
The data collected from these histograms is still relevant. Extend the expiration date of these histograms to 2020-12-01 GPU.D3D12FeatureLevel GPU.SupportsDX12 GPU.SupportsVulkan GPU.VulkanExtSupport.VK_KHR_external_memory_win32 GPU.VulkanExtSupport.VK_KHR_external_semaphore_win32 GPU.VulkanExtSupport.VK_KHR_win32_keyed_mutex GPU.VulkanVersion Bug: 975566 Change-Id: Ib05455e49e284fe0d0ceae65beec7bdfef25f190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693391Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Julian Watson authored
BUG=chromium:978332 Change-Id: I7a2d955990caa7d80ebe48feddf78b4ae8e8cb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686969Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#675836}
-
Wei Li authored
Implement the necessary UI elements to display survey banner in a bubble and survey questions in a web dialog. We no longer use WebUI, so remove WebUI related implementation. BUG=979530 Change-Id: Ie35d7a5c6168f5eadd5b6fe05282aab44f846e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681294 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#675835}
-
Mark Mentovai authored
This metric is still valuable. It informs traffic analysis and is particularly valuable in bandwidth-constrained mobile cases. In fact, we're doing a project now that's guided partially by this data. Bug: 975805 Change-Id: I86d079be0f964c245af9010893247408bb114fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693183Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#675834}
-
Bryan McQuade authored
android_webview was missed in previous change https://chromium-review.googlesource.com/c/chromium/src/+/1692971 TBR=jwd@chromium.org Change-Id: I3a656648aaae2785b3306ea2d1af87ea04fa8c0c Bug: 981338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693421Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#675833}
-
Joshua LeVasseur authored
Bug: b/136266872 Test: Terminate an IoT process with SIGABRT and confirm that it deposits a minidump. Change-Id: I8c6ff5d48e2473d921f4ef9c7576309055e89dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682527Reviewed-by:Mark Mentovai <mark@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f93d4fb40451..75b74536acd5 Created with: gclient setdep -r src-internal@75b74536acd5 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mcnee@google.com,hcarmona@google.com,hajimehoshi@google.com Change-Id: Ic1b9cca0a0803621415405867fbff38bb986f078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693448Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675831}
-
Ian Vollick authored
We test that mjpeg capture is supported on android, but VideoCaptureDeviceFactoryAndroid's GetSupportedFormats will never support it. Consequently, we should mark this test as disabled on the platform. Bug: 976160 Change-Id: I3a288cda32ffe8593e5272de2c0bc621e0d79d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685854Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#675830}
-
Matt Mueller authored
Bug: 634470 Change-Id: Id2a78794fd73a3590ceea0e8fa30a91ba789dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693392Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675829}
-
Hongchan Choi authored
This is the first step of reporting graph change to the devtool. The CL implants a unique ID for every element in the audio graph. (i.e. AudioNode, AudioParam) - The constructor of AudioNode and AudioParam now takes an UUID of the parent element (BaseAudioContext and AudioNode respectively). Bug: 972733 Change-Id: I8912620f4b8568faaaa7108b74324ac44ddeebad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666736 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#675828}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/726371f57927..cdf9e8af5713 git log 726371f57927..cdf9e8af5713 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 rsavitski@google.com Merge "Fix chrome roll (-Wsign-compare violation in test)" 2019-07-09 primiano@google.com Merge "A boutique CI based on Google Cloud" 2019-07-09 hjd@google.com Merge "Fix tslint failures" 2019-07-09 rsavitski@google.com Merge changes I4f736f6c,I68687617 2019-07-09 ilkos@google.com Merge "Process priority breakdown and span duration improvements" 2019-07-09 lalitm@google.com trace_processor: group all kernel threads under kthreadd Created with: gclient setdep -r src/third_party/perfetto@cdf9e8af5713 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:136635390 TBR=perfetto-bugs@google.com Change-Id: I3b1c081f1b2cf3805c9cbf473655d58bc55e587b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#675827}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1bd6c15c7664..babd1d4ac7c4 git log 1bd6c15c7664..babd1d4ac7c4 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 thestig@chromium.org Roll third_party/catapult/ a7b331246..123c46068 (182 commits) 2019-07-09 tsepez@chromium.org Convert test for bug 981288 to pixel test 2019-07-09 tsepez@chromium.org Add test case for bug 981347 2019-07-09 thestig@chromium.org Roll third_party/depot_tools/ 26af0d34d..3b07526ae (85 commits; 52 trivial rolls) Created with: gclient setdep -r src/third_party/pdfium@babd1d4ac7c4 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:981288,chromium:981347 TBR=pdfium-deps-rolls@chromium.org Change-Id: Ied573db3bdfa13a19cd22baa1d8ce9643008e359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693445Reviewed-by:
-
François Doray authored
This is a required step to make the official keyboard work without BEST_EFFORT tasks. BEST_EFFORT tasks can be arbitrarily delayed. They should not be on the critical path of behavior the user is actively waiting on. Test: - On a branch that has both this CL and https://chromium-review.googlesource.com/c/chromium/src/+/1680760, run Chrome with --enable-virtual-keyboard --disable-best-effort-tasks. - Click on the omnibox to enter text. - Expected result: The official virtual keyboard is displayed. Bug: 976542 Change-Id: I05338afd019d769da18c272dbf300128b8d891bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693184Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#675825}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c5abeafb24a..ad2a337ea4a6 git log 8c5abeafb24a..ad2a337ea4a6 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 miahsanchez@google.com vm_unittest: testing for errors in _SetQemuPath 2019-07-09 groeck@chromium.org config: Prepare rename of kernel version specific builders Created with: gclient setdep -r src/third_party/chromite@ad2a337ea4a6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I4b5d2001cd2150716bc354f050e2cef502b14a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693446Reviewed-by:
-
Todd Broch authored
- Change expiration for metrics that are still useful from M77 -> M100 - Modify snanda -> tbroch Bug: 975009 Change-Id: I5ac73d94be0f369a5178c7a055cd06e383999420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684698Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
François Doray authored
This is a required step to make the official keyboard work without BEST_EFFORT tasks. BEST_EFFORT tasks can be arbitrarily delayed. They should not be on the critical path of behavior the user is actively waiting on. Bug: 976542 Change-Id: I9a0207830a00bedd57f295d4d0e4072189e1881a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680760 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#675822}
-
Nate Fischer authored
This swaps script_common.InitializeEnvironment() for devil_chromium.Initialize(). These two methods are mutually exclusive (calling both turns the latter into a NOOP, as devil_env.config.Initialize() only has an effect the first time it's called). This changes the default 'adb' to be the one in chromium's Android SDK (v40) rather than devil's default (v32). This continues to support the '--adb-path' switch. Bug: 978697 Test: build/android/adb_system_webview_command_line -vv (uses //third_party/android_sdk/public/platform-tools/adb) Test: build/android/adb_system_webview_command_line -vv --adb-path=`which adb` (uses specified adb) Change-Id: I8ba4eb683f47eeed758a935455a39b9dcef113f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692201 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Matt Mueller authored
The test was checking the CertVerifier_Job_Latency_TrialSecondary and CertVerifier_TrialComparisonResult histogram values, but those histograms are recorded by a background task that is independent of page loading, so they may not be finished by the time the ui_test_utils::NavigateToURL call completes. Checking the CertVerifier_Job_Latency_TrialPrimary histogram is sufficient to tell whether the trial was enabled or not, and that histogram is recorded synchronously when the main verification completes, so should always be present when NavigateToURL returns. Bug: 981325 Change-Id: I1c7ab99d79e5ba58d4bc561d88b00024e22f3cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689399Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675820}
-
Mustaq Ahmed authored
A single key press fires a sequence of |WebKeyboardEvent|s that starts with a |kRawKeyDown| or |kKeyDown|, ends with a |kKeyUp|, possibly also contains a |kKeyChar|. We used to trigger user activation notification for all these events so that developers can call activation-gated-APIs (like popup or fullscreen) from any of these events. The problem was that malicious sites could open multiple popups for a single user action (the key press here) which is bad. With User Activation v2 (shipped in M72), multiple triggering in the event sequence is unnecessary: the activation state is not stack-scoped so triggering only on the first event in the sequence still allows calling activation-gated-APIs on any follow-up event. At the same time, single trigger means at most one popup is possible. This CL removes user activation trigger from all keyboard events except key-down and fixes a few security bugs related to popups. Bug: 982413 Change-Id: I63542d1e4ba32d3707329c8821d2ca4c627c91aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674450 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#675819}
-
Devlin Cronin authored
Update the metrics reloaded to the sideload wipeout bubble: - Remove ExtensionBubble.WipeoutUserSelection. It's not interesting, since there is no choice presented to the user (it's informational only). - Push back expiration of ExtensionBubble.ExtensionWipeoutCount to December 2020, and update the description (it previously stated it was only logged if any extensions affected by the wipeout were found; this is incorrect. It's logged on every profile startup). Bug: 975659 Change-Id: I99fe82f69cf48fb77cc791b826c7da4ce0c647b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689342Reviewed-by:
-
Yuly Novikov authored
as flaky on ANGLE Android. Skip suppression was lifted in https://chromium-review.googlesource.com/c/chromium/src/+/1355239, so this can be simplified now. TBR=kbr Bug: 979444 No-try: true Change-Id: I1f27637be5da63442dead3a1cc723c3f4c49b5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693173Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#675817}
-
Brian Sheedy authored
Updates some portions of the GPU Skia Gold markdown documentation, such as the new triage process using the links reported in Milo. Bug: 965234 Change-Id: If22ee0f6e7af1054df98630f2f9ebb616a8fdbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668092 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Spec on blur radius says [1]: "... Specifies the blur radius. Negative values are not allowed." Current implementation performs parse time range check, which is incorrect as calc() doesn't always have a double value. And spec requires clamping instead of parse time check for calc() [2]: "Parse-time range-checking of values is not performed within math functions, and therefore out-of-range values do not cause the declaration to become invalid. However, the value resulting from an expression must be clamped to the range allowed in the target context." This patch changes it to pass |kValueRangeNonNegative| to |ConsumeLength| as it handles non-negative calc() more properly. This is also preparation for adding DCHECK into GetDoubleValue() to avoid calling it on calc() without a double value. [1] https://drafts.csswg.org/css-backgrounds-3/#shadow-blur-radius [2] https://drafts.csswg.org/css-values-4/#calc-range Bug: 979895 Change-Id: Ia8c36641f4ec4111ecf5a94a6ffc6eaacf22049c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691747Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#675815}
-
Harsh Patel authored
Encoded each table in address_rewriter_rules into single strings separated by the null terminator. As a result address_rewriter parses these strings instead. This results in a decrease in binary size due to less read only relocations. Bug: 958792 Change-Id: I672c3541ddc52c9324bccf5f8ccae674c119518d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682550 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#675814}
-
Eric Orth authored
As per-platform differences are now separated out at a deeper level (per-platform DnsConfigService inside SystemDnsConfigChangeNotifier), unified the DNS config stuff to be located directly in NetworkChangeNotifier rather than in per-platform subclasses. Required some minor fixes to mock NCN usage, especially custom mocks that were overriding NCN and now getting full DNS config changes (and added env threading requirements that those tests were not setup to handle). For now, HostResolverManager is still listening through NetworkChangeNotifier. It will be updated to directly use SystemDnsConfigChangeNotifier in the next CL. Bug: 971411 Change-Id: Ib0353041dbf60f311e993eb98f8d4b719ce0d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666288 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#675813}
-
Ella Ge authored
Previously we use tick_clock_->Now() on dispatching queued input for scroll resampling, but the time is not actual vsync time/frame time. It's not regular and can affect by delays in the pipeline, and this causes some bad prediction result. This CL changes to use frame_time from BeginFrameArgs, which is the correct vsync time. Besides, this also disable deliver input on high latency mode when resampling is enable. Because resampling/prediction on high latency doesn't make sense, there is no "correct" timestamp in this case. Bug: 969697 Change-Id: I5516656c1d1419cf5fbf990a23122bb04a4fbe33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681263Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#675812}
-
Kristi Park authored
Change-Id: Ib0a2a79f3a1b60f212911b8e95701b5d3d7c027f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691681Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#675811}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb8b4a5716ba..3fe8c3a30396 git log cb8b4a5716ba..3fe8c3a30396 --date=short --no-merges --format='%ad %ae %s' 2019-07-09 geofflang@chromium.org Refactor the wait/signalSemaphore entry points to be on the Semaphore object 2019-07-09 shrekshao@google.com Fix regex parenthesis missing escaping backslash 2019-07-09 ianelliott@google.com Vulkan: Add support for GL_RGBA8-to-GL_RGB5_A1 2019-07-09 ianelliott@google.com Vulkan: Note that KHR-GLES3.texture_repeat_mode.* tests pass Created with: gclient setdep -r src/third_party/angle@3fe8c3a30396 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I544a4a305b6720e75c19fd3ade12aa63e181dbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693443Reviewed-by:
-
rbpotter authored
It is clear from current data that rotating the PDF in Print Preview is a very uncommon user action, and the usage does not change significantly over time, so it is not necessary to retain this histogram. Bug: 975060 Change-Id: Iea2c21e6d7bf0dee4cc3cf59aa2746edbb1e8a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691337Reviewed-by:
-
Yuly Novikov authored
In preparation for upgrade to Ubuntu 19.04, where these tests are flaky. Only 'Linux FYI Release (AMD R7 240)' remains. Bug: 927465, 966500, 978103 Change-Id: I270743a1cdd3f9a11f843fd2e30d58608e4de503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691324Reviewed-by:
-
