GitLab

This cl changes ManifestIconDownloader::FindClosestBitmapIndex and
ManifestIconDownloader::FindClosestBitmapIndex to choose the last icon
with ideal size instead of the first one.

Spec:
https://w3c.github.io/manifest/#icons-member

Spec language:
"If there are multiple equally appropriate icons in icons, a user
agent MUST use the last one declared in order at the time that the
user agent collected the list of icons."

Bug: 879741
Change-Id: I59fade75cf2dd84a49cee859f32f6e1243c45001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574889Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653427}

TBR=meacer@chromium.org

Change-Id: Ie3b0098ef7006186e96df1c92618a5682446cb9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579419
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653426}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/33a2e1ab..a8603a71

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If4577b7148f2b55013a2f53d46e9bcb9ca9330d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576272Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653425}

Remove various flags controlling the local NTP in M76+. They
are enabled by default in M75 and enabled via Finch for M73-M75.

Bug: 583289

Change-Id: Iedc5589ceb2e44060482b3be3cec9d1a74249f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553165
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653424}

Bug: 954540
Change-Id: I4156a3ee9ea3109bdd42f15b5d34024f75850b62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575303
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653423}

The DialogPlate in embedded Assistant wishes to be 52dp tall. When the
embedded Assistant view hierarchy is first measured and laid out,
however, it is constrained to the height of the search box which is
48dp tall. This causes the DialogPlate to be laid out at a height of
48dp which, due to padding, does not leave enough room for its child
AssistantButtons to be laid out at their preferred height of 32dp.

To address this, we will now always request that AssistantPageView be
laid out at its preferred size. This will prevent DialogPlate from
shrinking its children due to insufficient available space.

Bug: b:131089000
Change-Id: I52fc4bb17ae79be0ffed084292a951e096b29a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577987
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653422}

Using wpt-import in Chromium 70b812ab.
With Chromium commits locally applied on WPT:
0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2"
4e921520 "[Code Health] Remove unnecessary reference file for web test"
40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope"
e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting."
aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I3c53fbb897a51a671f2b445a9958d1ec42b9a5d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579254Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653421}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d366d8c98e1b..50381cc03752


Created with:
  gclient setdep -r src-internal@50381cc03752

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org

Change-Id: Ia0fd2b98f39a7ab84faf555fcd28ec134b5e4a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579843Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653420}

Bug: 955201
Change-Id: I4424b3a52f6f3290985a5f9960c9c60af3b51b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579769Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#653419}

This was causing screen readers to continuously announce the remaining time.

R=aleventhal@chromium.org, lethalantidote@chromium.org

Bug: 953908
Change-Id: I87bf445862904b9df57d9f79298691bae7d886bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575735
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653418}

Experiment results: https://docs.google.com/document/d/18lCPpkgPGEPvsZtbGzowvRjZSKevEYfknCr_G9hdFLA/edit?usp=sharing
Set the max delayable requests to 8 and the multiplier
to 3.0.

Change-Id: I2ae974becd8a27b168e30ecd1e24809c19ba5500
Bug: 746640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578359Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653417}

Add a summary line for long docstrings.
Use VERBOSE mode for long regular expressions.

Change-Id: Ia4ce8a6a28e33223a448b3652d760f3daeb64e5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579773
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653416}

This is a reland of 91a61a31

Original change's description:
> [Switch Access] Refactor focus for clarity around back button
> 
> Bug: None
> Change-Id: I3318ae4d5f37d67e7fe5abb894f9edacddc785d4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549944
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647532}

Bug: None
Change-Id: If556c775a9a70abe9346b9288b3f3f3138420409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580000
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653415}

https://android.googlesource.com/platform/external/perfetto.git/+log/5929b0ffd0d5..d63e3ca06b1e


git log 5929b0ffd0d5..d63e3ca06b1e --date=short --no-merges --format='%ad %ae %s'
2019-04-23 fmayer@google.com Merge "Do not crash using packages.list ds n debug build."


Created with:
  gclient setdep -r src/third_party/perfetto@d63e3ca06b1e

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I35e5f4e29525c89754092fb25f607a08e23efe45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579842Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653414}

There seems to be a situation where ServiceWorkerProviderHost::controller()
returns a redundant ServiceWorkerVersion. This CL adds instrumentation
code to investigate the situation.

Bug: 951571
Change-Id: Ic07395a6cebef8056a18e8b030a4baba68cd6de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577322
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653413}

Garbage collection can trigger during setup which requires that embedder
tracing is set up.

Change-Id: Ia7ddd3e875c7dd510352fd8de91aa0817d1894a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578572
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653412}

Add an option to make Web UI pages work with the HTMLImports polyfill in
optimized builds. This is in preparation for modifying Web UI pages to
work with the polyfill instead of relying on native imports.

Bug: 925517
Change-Id: I8f6ca8694bd73defa810c304f31b83dc5ec7d19c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566761
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653411}

This is the 12th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

Keyword classification is trivial; i.e. the entirety of the contents and
description are styled uniformly. Descriptions are styled DIM. Contents
are styled 1) DIM (when the user input includes only the keyword), 2)
NONE (when the user input contains text following the keyword), or 3)
MATCH (when the user input contains only the keyword and the keyword has
no replacement text).

This CL changes contents classification in case (3) to use
`emplace_back` instead of `ClassifyLocationInString`. This is both
consistent with how the other cases are handled and inline with our goal
to deprecate `ClassifyLocationInString` and other duplicated
classification helpers.

Bug: 366623
Change-Id: I205a7bea19391d6343bc071574797f9a0f61c324
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579763Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653410}

This is done to clearly separate the public interface of OverlayManager
from its internal implementation files.  Setting the "public" gn
variable for the target ensures that files that depend on overlays are
only allowed to include those files.

Bug: 941745
Change-Id: Ie9f905a857bd268c535804b3243321b6721d7c2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562719
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653409}

We are interested in coverage of SkiaRenderer. This change adds a SkiaRenderer
variant of blink_web_tests.

This will be ran on  "GPU FYI Linux SkiaRenderer Vulkan (NVIDIA)" bot of the
GPU.FYI.

We will not be running the full test suite, due to capacity concerns raised in
an earlier review: https://chromium-review.googlesource.com/c/chromium/src/+/1500784

Instead a subset of tests which have detected regressions in the past will be
ran. Combined with a random selection of other tests from the folders most
impacted by SkiaRenderer.

Test = skia_renderer_blink_web_tests

Bug: 946770
Change-Id: I6e1091af816a41798a3e62c24449ad5bbd4d0c10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576332Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653408}

Adds tests for assistant opt-in flow that's shown during in-session
OOBE.

The tests focus on interaction between assistant opt in flow UI and
assistant settings service, which is faked for the purpose of this test.
(In other words, main focus was logic in
assistant_optin_flow_screen_handler).

This adds logic to log in a user to LoginManagerMixin - assistant opt-in
flow expects a regular user to be logged in. Each test first logs in a
regular user, and then starts login wizard with assistant optin flow UI.

Change-Id: I5305e6d2079099f35de899162433f2bd34f162d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574948
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653407}

This prevents a minor security issue where the hostname of the RP
would have its tail end cut.

Bug: 893258
Change-Id: Ib227f6be8f274a2ddf78917597c217807bba01ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579459
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653406}

Bug: 946224
Change-Id: I2cc565d1e855190c62bdcce42217a8ca003194e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579421
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653405}

A few of these properties were only used on the remote NTP, so
they can now be removed.

Bug: 583289
Change-Id: I9b3270ec20ced7891796ca9d296e20a1f157f019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576032Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653404}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9616947a9374..9b65a0c0b4b1


git log 9616947a9374..9b65a0c0b4b1 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@9b65a0c0b4b1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I2452dcd17feeea0c18eb631e35e89a6523720c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653403}

Update VideoBacking to account for gpu memory only when the backing
is bound to a texture.
This is because there can be video frames which gets created but the
underlying backing/image never gets bound to a texture. Hence only
creating a video frame/backing should not account for gpu memory
tracking.

Bug: 953727
Change-Id: I3eb5ff119e8fb3c1c598d43de3528c694e573fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576267Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653402}

- Introduces a PrintersMap class to keep track of printers. Will replace
the vector of vectors currently used by CupsPrintersManager.

Change-Id: I2328eb2e8c2049b30036d4b599fb27c672c18225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572641Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653401}

******************************Resource Sizes Diff******************************
Specifics:
       +73,760 bytes main lib size
      +209,044 bytes main dex size
      +499,660 bytes secondary dex size
    +1,128,615 bytes normalized apk size
InstallSize:
      +422,512 bytes APK size
    +1,251,695 bytes Estimated installed size (Android Go)
    +3,285,676 bytes Estimated installed size
InstallBreakdown (+3,284,366 bytes):
        +4,010 bytes Native resources (no l10n) size
        +2,688 bytes unwind_cfi (dev and canary only) size
        +2,749 bytes Non-compiled Android resources size
       +73,760 bytes Native code size
          +736 bytes Package metadata size
    +3,172,315 bytes Java code size
       +28,108 bytes Compiled Android resources size
Dex:
        +4,827 entries fields
        +6,819 entries methods
        +2,316 entries types
        +4,995 entries strings

R=pnoland@chromium.org

Change-Id: I529fa3f387880590824ca91da6cb827bf9f13757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579580Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653400}

WiMAX support is deprecated along with daisy. This CL removes the
wimax-status entry under chrome://system and the corresponding debugd
GetWiMaxStatus D-Bus binding.

Bug: 954635
Test: Verify that chrome://system no longer fetches wimax-status from debugd.
Change-Id: Iafa7900dcee718593ef7cbb223d51bec2986d32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577631
Auto-Submit: Ben Chan <benchan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653399}

ReceiverPipe is gone. Reenable the test.

BUG=944429

Change-Id: I281c94bd276d00a6707ba6ff65b8c4cf0d2ebcb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579464Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653398}

We're working on removing SocketParams. Instead, pass the annotations
directly to the SocketPool as part of a request.

Bug: 955125
Change-Id: If124df4de192b6682119b570a33c61ebf18c9e09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578059
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653397}

Bug: None
Change-Id: I0a5611aab2e7f198c361e2c7746192099d9bd54d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579465Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653396}

This CL adds the public interface for OverlayManager, which adds the
OverlayRequests supplied to AddRequest() to the OverlayRequestQueue
for that WebState.

OverlayManagers are fetched based on their OverlayModality, which
specifies the modality of the UI delegate's view controller
presentation context.

Bug: 941745
Change-Id: Idc71632131908814cabd5f5c4e7a787de13a41e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555335
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653395}

WorkerClassicScriptLoader takes fetch client's ResourceFetcher that provides
fetch client's AddressSpace, so it doesn't have to take AddressSpace as a param.

Bug: 878274, 945215
Change-Id: I3ca0ccc7834522fc627f7af746fc6d632629d7eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578145
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653394}

Bug: 955610
Change-Id: I29d2104b74682c458b741c2b771386528ff57d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579365Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653393}

Bug: 929477
Change-Id: I35ca181a114c5051dedad1843adf6bd15f4413bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579251Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653392}

https://chromium.googlesource.com/catapult.git/+log/0c3de1750970..8f48a01dffbb


git log 0c3de1750970..8f48a01dffbb --date=short --no-merges --format='%ad %ae %s'
2019-04-23 simonhatch@chromium.org Dashboard - Remove bisect_report


Created with:
  gclient setdep -r src/third_party/catapult@8f48a01dffbb

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:876899
TBR=crouleau@chromium.org

Change-Id: Ib4f378e9a4e687f049fc77c79e5c48728c4f19af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579679Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#653391}

The SessionRestore.BackgroundUseCaseTabCount.* histograms seems to
indicate that more "background use case tabs" are restore than exist in
general, which should never happen. It's not clear if it's caused by
some noise in the metrics or if it's really an issue, this DCHECK will
hopefully give us more data on this.

Bug: 915714
Change-Id: I38abcb6252abc866064de1a9c48ed7cda9de4cb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1579425
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653390}

https://chromium.googlesource.com/external/leveldb.git/+log/ffabb1ae86cc..3dc9202f78a3

$ git log ffabb1ae8..3dc9202f7 --date=short --no-merges --format='%ad %ae %s'
2019-04-23 no-reply [leveldb] Specifically export the WriteBatch::Handler inner class for Windows link
2019-04-15 cmumford Check for possibly invalid offset in test.
2019-04-13 cmumford Changed Windows specific highlighting from bash to cmd.
2019-04-12 cmumford Initialize class members to default values in constructors.

Created with:
  roll-dep src/third_party/leveldatabase/src

Change-Id: I28ed8e909a29212465eab115a9617d9a5c5047bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578596
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653389}

This gets tricky lifetime-wise when UIDevTools is re-enabled, depending
on the exact ordering, whether any widgets were created or destroyed
while disabled, etc.

Let's just start with a clean slate every time.

Change-Id: I7cb50c2219e0e5c62504791ad7b56bedfac45dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570647
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653388}