- 07 Feb, 2020 40 commits
-
-
Sigurd Schneider authored
This is a clean reland of 4276111d The original patch was reverted due to an unrelated timeout, see https://bugs.chromium.org/p/chromium/issues/detail?id=1049444 Original change's description: > [devtools] Don't continue execution after reload on breakpoint > > This CL fixes an issue where JavaScript execution would continue > after reloading on a breakpoint. See design doc: > https://docs.google.com/document/d/1aO9v0YhoKNqKleqfACGUpwrBUayLFGqktz9ltdgKHMk > > The CL depens on V8 change in crrev.com/c/1924366 and tests should fail until > that change is landed+rolled to chromium. > > Fixed: 1004038 > Fixed: 1014415 > Change-Id: I182393ebd4c68588163dda7c607be8bb09a3eda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926502 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738522} Change-Id: Id6ada47ff10df164ca7ead387907a0a2fff03e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041623Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#739296}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6c23cd33e6fe..8607c59b3c65 git log 6c23cd33e6fe..8607c59b3c65 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 nigi@chromium.org Roll third_party/depot_tools/ e9730d75a..816c2b354 (46 commits; 8 trivial rolls) 2020-02-06 tsepez@chromium.org Move JS helper testIllegalConstructor() to its own .js file. 2020-02-06 tsepez@chromium.org Remove class_name argument from JSSpecialProp methods 2020-02-06 tsepez@chromium.org Remove templates from JSSpecialProp methods. 2020-02-06 tsepez@chromium.org Add tests for XFA's JS global object. 2020-02-06 thestig@chromium.org Roll third_party/skia/ d50cc9587..81d35a72a (1037 commits; 204 trivial rolls) 2020-02-06 tsepez@chromium.org Test removing last instanceManager instance. Created with: gclient setdep -r src/third_party/pdfium@8607c59b3c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ibd69828808601fc97be71cec009961d124a6c7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739295}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97bf6578796c..f3560b680e35 git log 97bf6578796c..f3560b680e35 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src fbfe7df1..d7612dec (2570 commits) Created with: gclient setdep -r src/third_party/skia@f3560b680e35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I2a0341757362d19fb45bfe40b306fe38fa260c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042548Reviewed-by:
-
Jongmok Kim authored
It was noted that the string should be properly capitalized according to Google's style guide. Bug: 1047690 Change-Id: Idbb64754615c4ffc993de3b3685096dbf3458f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041685Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#739293}
-
Manu Cornet authored
This is part of a move to let the top-level (shelf layout manager) handle tablet/config/alignment changes and make the changes trickle down, instead of letting individual widgets respond to changes and make them bubble up, causing duplicated work and event handling. Bug: 1048119 Change-Id: Ic41061b222b83b78400f6ff6074fca6741e8e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042923Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#739292}
-
Joel Hockey authored
Using mocks as provided by @benwells Bug: 1016680 Change-Id: I4f94640a6aa60c99ae3c7fb417bc498b7db2dfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040799 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#739291}
-
Daniel Cheng authored
The goal is to split up modules_idl_files.gni into smaller .gni files that are owned by OWNERS of the corresponding module, so top-level module OWNERS don't need to review every CL that adds a new IDL file. This patch splits out the build files for all remaining IDLs that define partial interfaces or are the target (right hand side) of `implements`. Bug: 1048907 Change-Id: Iefba913ec478b8a6cd2f407fc9d427bc4100d2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043098 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#739290}
-
Koji Ishii authored
This patch changes |NGPaintFragment::DebugName| for the IFC roots to ease the transition to |NGFragmenItem|. |NGPaintFragment| uses the IFC root fragment as |DisplayItemClient|, while |NGFragmentItem| uses |LayoutBlockFlow|. Changing |DebugName| can help the transition easier. Bug: 982194 Change-Id: If98dc8799909800d7d12df9093acc7643993c65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040504 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739289}
-
Ahmed Fakhry authored
An observer of OnWindowActivating or OnWindowActivated may destroy the window losing, or gaining activation. The FocusController should handle these cases, to avoid crashes, and/or returning dangling pointers when querying the active window. BUG=1048870 TEST=Expanded an existing test, which crashes without the fix. Change-Id: I804210e2f3250f69fc02b9a93eaee5d0236fca5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038131 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#739288}
-
David Munro authored
Test: None Bug: None Change-Id: Ied236ecb526d5b35d5d3c70660c622e22f390f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041839 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#739287}
-
Eriko Kurimoto authored
This CL names shared workers identically for each test cases. If not, all shared workers are attempting to connect to the same shared worker whose type and credentials values are specified by the first call. Bug: 1048966 Change-Id: I07f0b57e2fb513851ee35262a08c1f3ef42a9eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040856 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#739286}
-
https://crrev.com/c/2030627Peng Huang authored
Mac promotes all render passes to CALayer, so we don't need to redraw the main surface. Bug: 1048997,1044678 Change-Id: Iefef04a00ff60df882877b5930c90bcc8057e485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039335 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#739285}
-
Kent Tamura authored
HTMLSelectElement::UpdateMenuListLabel() detached and created Text nodes every time by Element's textContent setter, and it was inefficient. We should keep one Text node, and UpdateMenuListLabel() should update the nodeValue of the Text node. Bug: 1048572 Change-Id: Ifef39627b00cc5345a2b0d53ac652e45d064e941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040853Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#739284}
-
Rachel Sugrono authored
Add the function onDeleteButtonTap to delete the currently selected entry when the delete-button icon is clicked. The actual delete-button will be added in an incoming patch. Bug: 803259 Change-Id: Ic6fc3acdafba88537ae5398f3f293f25344702cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041683Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#739283}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f12231d74209..ecd6fc84cf07 git log f12231d74209..ecd6fc84cf07 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 deadbeef@webrtc.org Add DSCP support for POSIX platforms. Created with: gclient setdep -r src/third_party/webrtc@ecd6fc84cf07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I32af7e4bbf57f156e86d3b5447c7be9310a8cca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042916Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/046f9893b953..97bf6578796c git log 046f9893b953..97bf6578796c --date=short --first-parent --format='%ad %ae %s' 2020-02-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e9dc0201af3a..e02f4996c6e9 (4 commits) Created with: gclient setdep -r src/third_party/skia@97bf6578796c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I57c3ede25f45b1bed872cf1f8c48dca77c1d3559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042918Reviewed-by:
-
Noel Gordon authored
This reverts commit afb89420. Reason for revert: seems this bortke the wind builder https://ci.chromium.org/p/chromium/builders/ci/Win%20Builder/87976 Original change's description: > Remove Deprecated ScopedBstr to BSTR Implicit Conversion Operator > > BUG=1034666 > > Change-Id: I678af5925603de6f983e3d12da6832c0661f293c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042194 > Auto-Submit: Robert Liao <robliao@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739275} TBR=robliao@chromium.org,wfh@chromium.org Change-Id: Ica82a0dc2dadfc92792939cdef384285c4a4c989 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041979Reviewed-by:
-
Findit authored
This reverts commit 7a8180fa. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 739179 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2E4MTgwZmFiYzQ0MGE0MWIzMTI2Y2UzNjc1ZmI1ZDg4MTRmYjgxNQw Sample Failed Build: https://ci.chromium.org/b/8889148211576341952 Sample Failed Step: interactive_ui_tests Sample Flaky Test: BrowserFocusTest.NavigateFromOmnibox Original change's description: > Focus tab earlier for browser-initiated, //chrome-layer navigations. > > This CL changes how navigations result in focusing the tab contents: > > 1. Browser-initiated navigations: > - Before this CL: Focus done in FocusTabAfterNavigationHelper > which covers both OpenURL and BeginNavigation code paths. > - After this CL: Focus done in Browser::UpdateUIForNavigationInTab > (similarly to pre-r737502) which covers only the OpenURL code path. > > 2. NTP-initiated navigations: > - No change: Focus done in FocusTabAfterNavigationHelper. > > This CL makes sure that the text in the Omnibox is not temporarily > selected during a navigation, by ensuring that the Omnibox is not > focused when OmniboxViewViews::Update runs (see also > https://crbug.com/1048742#c4 and #c5 and #c7). Regression tests > are added for this problem. > > This CL also makes sure that DevTools-initiated navigations > (browser-initiated navigations which go through the BeginNavigation > path) do not result in focus changes (see also > https://crbug.com/1048591). > > This CL might also (speculating here) address the performance bugs > tracked in bugs 1048333, 1048556, 1048565, 1048988, 1048988. > > Fixed: 1048742, 1048591 > Bug: 1048333, 1048556, 1048565, 1048988, 1048988 > Change-Id: Ia00cd9143991c260615663fae06f096e9d7cf0f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040234 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739179} Change-Id: Ic3ddf4de6a92eecf9175d91b572dacb2b436f371 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048333, 1048556, 1048565, 1048988, 1048988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042929 Cr-Commit-Position: refs/heads/master@{#739279}
-
Benjamin Beaudry authored
When using Narrator on Windows with Scan Mode turned on and navigating with the down arrow, it blocks for a specific accessibility tree. e.g., ++++genericContainer ++++++image ++++textField editable focusable ++++++genericContainer editable ++++++++staticText editable This was caused by a degenerate range where both endpoints were on two different anchors. Apparently, the attribute value returned by AXPlatformNodeTextRangeProvider::GetAttributeValue were incorrect when on a degenerate range, causing Windows ATs to behave undesirably. This issue is fixed by refactoring AXPlatformNodeTextRangeProvider::NormalizeTextRange so that it applies to degenerate ranges too. Now, if both endpoints of a range are equals but on two different anchors, the normalization will move both endpoints to the start of the next anchor. I added a unit test and a descriptive comment about NormalizeTextRange(). Also, I moved the order of NormalizeTextRange() and NormalizeAsUnignoredTextRange(). Bug: 928948 Change-Id: Icd4a3a3d6f569a35b7699d569aaef95449443774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033632 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#739278}
-
Chih-Yu Huang authored
This reverts commit e49e0958. Reason for revert: This feature causes video goes green. crbug.com/1049585 Original change's description: > media: enable ChromeosVideoDecoder feature > > We already enable ChromeosVideoDecoder feature at stable channel for 2 > weeks. It's time to enable it by default. > > Bug: 984482 > Test: ninja media/base > Change-Id: I905d12fb0a53f16b76afd4975f90db6013e07b9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035212 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738037} TBR=mcasas@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,beccahughes@chromium.org,dstaessens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 984482 Bug: 1049585 Change-Id: I587c2fe5a6b51c51c82c5e39a008c65758a6bcc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041838Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#739277}
-
James Cook authored
We don't use the sync overview row (it's never shown today, and won't be used for SplitSettingsSync in the future). Remove the row and the associated strings. This is leftover from when we forked the page from the browser people page. Bug: none Test: existing browser_tests Change-Id: I05581516e396f4fd09bd64a0bc156772a984e40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042304 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#739276}
-
Robert Liao authored
BUG=1034666 Change-Id: I678af5925603de6f983e3d12da6832c0661f293c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042194 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739275}
-
shrekshao authored
Bug: 1000354, skia:9861 Change-Id: I4763b847526e04fe21e875110417a6bfb03013d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040611Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#739274}
-
Eriko Kurimoto authored
This CL adds Timeout in shared-worker-import-referrer.html expectation. This test is currently flaky because of Timeout, and the similar issue is happening as well in dedicated-worker-import-referrer.html. I will continue the investigation about this issue, but we add Timeout expectation for now. Bug: 1049689 Change-Id: I891b80b51186d623c304ecb59a835f725f407a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041374Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739273}
-
Hiroshi Ichikawa authored
To clarify the behavior. Change-Id: Ie9a1ff59b934615c353fb6c11c06b2678fca5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041836 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#739272}
-
Yutaka Hirano authored
These functions were "shared between network service and the old loading path in content/" but now the network service path is the only path, so we don't need to have them separately. Merge them into network::URLLoader. Bug: 1049483 Change-Id: I26026b2f2bc5b763c834cee004d2f7bc04c7d402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040800 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7457e5e4ba27..6737082f1029 git log 7457e5e4ba27..6737082f1029 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@6737082f1029 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9bfb41e53269796a229df704a73f9a144d2abab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042912Reviewed-by:
-
John Chen authored
Updated baseline for the following two tests, due to https://crrev.com/738119: * fast/css/css2-system-color.html * fast/css/test-setting-canvas-color.html Updated TestExpectations for a test that sometimes timeout: * http/tests/misc/slow-loading-image-in-pattern.html Change-Id: I695fab8468a23aa37e84ebfa72984a4ef2aba8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042196Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22f2b82b60a3..fb6c493bb000 Created with: gclient setdep -r src-internal@fb6c493bb000 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4dd5895754510d68c7873f4550fe0fca52423929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043022Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739268}
-
Isabella Scalzi authored
No-try: true No-presubmit: true Test: No change in behavior, no new tests. Bug: 803259 Change-Id: Ifcb8ad66dc70aa94e7dd1d8e3bd0085924fd094a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041718 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I57754be5aa941dbd995f996f22a1c9517546bab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043034Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739266}
-
Ryan Sturm authored
It is possible for the default search provider to be empty, and we should avoid crashing when it is. Bug: 1049861 Change-Id: I21ad12dfa7f6be5a582101a2081ae2725b3c3da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042055 Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#739265}
-
Kyle Horimoto authored
Before this CL, navigating to a settings subpage on browser and OS settings emitted to the same histogram. This caused issues, since some separate subpages have the same name in each settings surface. For example, the "/printing" subpage means a completely different thing in OS vs. browser settings. Bug: 1049417, 1026353 Change-Id: Ifbe15866c61377a8da0413694b8578228401a6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040951 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#739264}
-
Jon Mann authored
Bug: 1047815 Change-Id: I15889b977329b3d4ed1e042b76f2076360c288aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040744 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#739263}
-
Jason Lin authored
In addition, CrostiniInstallerUI::ClickInstallForTesting() is updated so that it works no matter whether this flag is on or not, so if in an unlikely event that we need to re-disable this flag, we do not need to modify it again. Bug: 1016195 Change-Id: I254057ffdff281c2ca01035953adfc737214b646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040635Reviewed-by:
-
Austin Eng authored
Bug: 1049864 Change-Id: I3041a776006a53f4268a38a1786ab5b5c88bb4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043005Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/463c318ab759..e02f4996c6e9 git log 463c318ab759..e02f4996c6e9 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 cnorthrop@google.com Vulkan: Pass correct level count in getLevelDrawImageView 2020-02-06 spang@chromium.org Fuchsia: Fix size & position of test window on Scenic 2020-02-06 jmadill@chromium.org Make TransformFeedbackTest deterministic. Created with: gclient setdep -r src/third_party/angle@e02f4996c6e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: If7e2ce521e15c1b0ef612fb6f86e777dffd0cbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043052Reviewed-by:
-
rbpotter authored
- Autogenerate Polymer 3 versions for files in on_startup_page/* - Update closure compiler and polymer_modulizer/js_modulizer targets for these files - Autogenerate tests for the Polymer 3 files Bug: 1026426 Change-Id: I122bcb77d366b7fc7fd979b235d13d283faf8d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040626 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Isabella Scalzi authored
Create new private helper in |quick_view_controller| called |canDeleteEntry_|, so we can create the promise from |quick_view_controller| rather than |file_manager_commands|. No-try: true Bug: 803259 Change-Id: I829a798e3d19989b880df1e554b23e2ffd67c987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041834 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Wei Lee authored
Adds 'resizeMode: none' in constraints to avoid being cropped unexpectedly by Chrome. Bug: b/148045035 Test: Manually Change-Id: I4e2062cc75b438b1b64e7aa467b7c794a67cce95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041213Reviewed-by:
-
