- 07 Dec, 2020 40 commits
-
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I83e32ab20bf367d4934e7b96fc30ab4c2fc5d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569196Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834207}
-
Rune Lillesveen authored
If the style recalc root is neither the root element, nor body, we can skip propagation from root/body. Skipping that early is more important when you have many containers for container queries which means RecalcStyle will be called multiple times during layout. TEST=external/wpt/css/css-writing-modes/ Bug: 1146097 Change-Id: I12514f54cec3400f028eb7efbb5ec34ce241d672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574280Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#834206}
-
Yunke Zhou authored
Replace cr-dialog with oobe-help-dialog so shelf buttons are disabled properly when dialog is opened. Bug: 1119338 Change-Id: Iebeff98b7b451c17f2679d69ce8819c5e259d418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563481Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#834205}
-
Aaron Leventhal authored
There doesn't seem to be a good reason for this special case, and the condition is in an odd place. If a list marker is inside of an ignored/invisible subtree, it is still marked ignored/invisible. Bug: None Change-Id: I5f3b5b9f1c253658201e554b27e13f3178223bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572936Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834204}
-
Richard Stotz authored
The error message points to win_cross.md, as can be seen in the script https://source.chromium.org/chromium/chromium/tools/depot_tools/+/master:win_toolchain/get_toolchain_if_necessary.py;l=531 Bug: none Change-Id: I562653b401ec039db4f8a83b4bc38e11f8d4d5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577459Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Richard Stotz <rstz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834203}
-
Oriol Brufau authored
Before this patch, setting a value to a property already in the list of declarations, would just update its value, without reordering. The problem was that the order is important when there is a mix of logical and physical properties: el.style.paddingTop = "1px"; el.style.paddingBlockStart = "2px"; el.style.cssText; // "padding-top: 1px; padding-block-start: 2px" el.style.paddingTop = "3px"; el.style.cssText; // "padding-top: 3px; padding-block-start: 2px" getComputedStyle(el).paddingTop; // "2px" -- no effect! Therefore, this patch implements this part of the spec: > If there are CSS declarations in declarations whose property name is > in the same logical property group as property, but has a different > mapping logic, target declaration must be at an index after all of > those CSS declarations. Spec: https://drafts.csswg.org/cssom/#set-a-css-declaration Bug: 1155858 TEST=external/wpt/css/cssom/cssstyledeclaration-setter-logical.html Change-Id: Idb89661c6740dd1bbe3948b58475900e1a353d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575081 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Andy Paicu authored
This is a somewhat speculative fix for the crash in the linked bug. The working hypothesis is that an Android infobar might be calling into `ReasonForUsingQuietUi` after some IPC has already taken place and another event has reset the `current_request_ui_to_use_` member. Either way a more robust `ReasonForUsingQuietUi` should be a net gain. Bug: 1104881 Change-Id: I69825216892c969e968704e97ba162c52cbc4efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569657Reviewed-by:
Illia Klimov <elklm@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#834201}
-
Oriol Brufau authored
In order to have proper CSSOM support for logical properties, we will need to determine whether two properties belong to the same logical property group but with a different mapping logic. Before this patch, we only knew the physical properties belonging to the same logical property group as a given logical property. But given a physical property, we didn't know if there were logical properties that could map to it. Therefore this patch adds: - CSSProperty::IsInLogicalPropertyGroup, which returns true for logical properties and for their corresponding physical ones. - CSSProperty::IsInSameLogicalPropertyGroupWithDifferentMappingLogic which checks what the name says, given a CSSPropertyID. - CSSDirectionAwareResolver::LogicalMapping and PhysicalMapping, representing the properties of a logical property group with a flow- relative or a physical mapping logic, respectively. In css_properties.json5, the terminology becomes closer to the spec: - direction_aware_options becomes logical_property_group, and physical properties have it too. - direction_aware_options.physical_group becomes logical_property_group.name - direction_aware_options.resolver accepts physical axis and box sides (horizontal, vertical, top, right, bottom, left). This patch should have no effect in practice. Bug: 1155858 Change-Id: I1a01e80a2405315d9caaf057e6bfd465f3615cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574940 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
-
Nico Weber authored
I couldn't find the toolchain guarantees doc the other day, so as a first step link to it here. We should probably reorganize the docs a bit -- the perf regression bit in updating_clang.md looks like it belongs in the sheriffing doc, and the "which files belong in the main package" should arguably move to the toolchain guarantees doc. Bug: none Change-Id: I6b9018748c47f5942a970e8bcc76bcf1107784e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576583Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834199}
-
Wolfgang Beyer authored
This CL adds a test which ensures that a `document.write()` when the document is still open does not trigger sending a `Page.documentOpened` CDP event. `Page.documentOpened` CL: https://crrev.com/c/2498482 Design Doc: http://doc/1l-XzjFMdASjRzX4-vMxOoK-MXoxY5uhCe0GNfDsXeDo Change-Id: Ibbe7d539db6ee85168c99972a8e2779dcc982b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567007Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834198}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/393159147685..ea969d287bfe 2020-12-07 perkj@webrtc.org Reland Addd class InterArrivalDelta to goog_cc 2020-12-07 akonradi@google.com Remove nesting of Naggy/Strict/NiceMock 2020-12-06 jonaso@webrtc.org Add field trial WebRTC-AllowMACBasedIPv6 2020-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a04842f6..29886952 (833885:834077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a9b9c175603bd6c786d3fcda7d777e8834bab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834197}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607309475-be47e6675d78a40c2743c701a82c248ac3d955c3.profdata to chrome-win64-master-1607331580-48b245bff1ba8e6eb069e7a15838de53304e6a37.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I077de263674d24a9f1b90b1f1d82b2978b5bfedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575508Reviewed-by:
-
Hayato Ito authored
This is a follow-up to https://crrev.com/c/2560526. This CL changes the implementation of WebBundle subresource loading from "renderer oriented" to "network service oriented". Before this CL, a renderer parses a WebBundle and serves a subresource from there directly. After this CL, they are done in the Network Service, instead of a renderer. The motivation we're changing our design is "we should honor CORB [1]". A renderer shouldn't have cross-origin data in their memory. See the design doc [2] for details. Note this CL removes blink/renderer/platform/loader/fetch/url_loader/web_bundle_subresource_loader_test.cc, which was already moved to services/network/web_bundle_url_loader_factory_unittest.cc in a previous CL. - [1]: https://source.chromium.org/chromium/chromium/src/+/master:services/network/cross_origin_read_blocking_explainer.md - [2]: https://docs.google.com/document/d/1_AqUBS4Gr45MPPtXGTUl7Q0DMIEw2zUeWO0zo6Sj0z4/edit Bug: 1082020 Change-Id: I78b0e81b573f735c84334a4cd2271c248609c2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564924 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834195}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607320769-d0ad4f5a17a630b334cdaa2bc2220f2b7c7c5cc2.profdata to chrome-mac-master-1607341806-857507b5a91b3ce5824fe454e7d197a8b05189bf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia8a57c37d2860aa5e5014759c9b554e31e5400cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577427Reviewed-by:
-
Przemek Pietrzkiewicz authored
This patch implements chromium.cast.DataReset in CastRunner. Upon request to reset persistent state, we: - Block launching new components in the main context - Move all data under /cache to a staging directory that is deleted upon next startup of CastRunner Bug: 1146474, 1146480 Test: run_cast_runner_integration_tests Test: verified manually on device that a file in the cache directory of CastRunner is gone after DataReset and reboot Change-Id: I713133540302a1c0535c778e5957e2c87e0f669b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537840 Commit-Queue: Przemek Pietrzkiewicz <ppi@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Benjamin Lerman <qsr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834193}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607320769-89cdddd8995ad3be12a676e570aae350fc15988d.profdata to chrome-linux-master-1607341806-34092e6e948e6283aae1770f567faca0b14a9512.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica66cc4562dd9a92eb97e1f3fe50dab799702a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577429Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36ad7e1d111..698d1c0a0acb 2020-12-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-07 sigurds@chromium.org Don't generate types for deprecated Console domain 2020-12-07 tvanderlippe@chromium.org Upgrade third_party/acorn to 8.0.4 2020-12-07 jacktfranklin@chromium.org [Dark Mode]: small CSS files 2020-12-07 sigurds@chromium.org Remove twin definitions from ConsoleModel 2020-12-07 wolfi@chromium.org Update link url 2020-12-07 jacktfranklin@chromium.org [Dark mode] disable patching for customPreviewComponent.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152082,chromium:1152736,chromium:1153099 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id13ed33a6517131b32ef1e12d080e2ac9a55f592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576427Reviewed-by:
-
Side Yilmaz authored
This CL gets Profile from WebContents and pass it through the NavigationSheetCoordinator. Bug: 1048632 Change-Id: I5c9f3aca1c9b840f810eb780fc8d05be4be9df2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569738Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834190}
-
Ali Tofigh authored
The std::map in StatsResponse::Report is only used to iterate though the elements. Profiling on Mac shows that a replacing the std::map with a std::vector shaves off about 40% CPU time spent in StatsResponse::Report in some common video conferencing scenarios. Bug: 1156090 Change-Id: I3070000bb534deb18fb0fd9b18b83a947fae64a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576240Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Ali Tofigh <alito@chromium.org> Cr-Commit-Position: refs/heads/master@{#834189}
-
Pavol Marko authored
GetDeviceAttributeUpdatePermission resolves the current user by OAuth token and then checks if that user may change the device's attributes. This is only sensible for manual enrollment where a user has actually authenticated and we have an OAuth token for the user. For enrollment modes without explicit user auth, such as attestation-based enrollment or enrollment-token-based enrollment, the enrolling user is not known so this check is not possible. For now, assume that device attributes should not be changed in this, as there is no way to find out if the enrolling user is permitted to change them. Bug: 942013 Change-Id: I5f7e08ca2af223d0dbcac3839c6eb2b2f45e62b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566820 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
TBR=foolip@chromium.org Bug: 1154574 Change-Id: Ib632013e53de9b69d579890fe0c7b6f3dccb6f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577200Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834187}
-
Victor Vianna authored
The test has been disabled for >2 years. Let's to try to re-enable it. Bug: 860200 Change-Id: Ia425f68d99f3e056226d367f66ab03ac85a13e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574702 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834186}
-
Mikhail Khokhlov authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 2020-12-04 primiano@google.com Merge "service: Add MaybeSaveTraceForBugreport()" Includes empty implementation of SaveTraceForBugreport. Change-Id: Ia351be67f1ad24c87ee9b2f8ee56c0916bf39450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574744Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#834185}
-
Victor Vianna authored
There's been a spike of flakes on this bot following 2020-12-03, let's disable the test. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQFR3b0NsaWVudFdlYkFwcHNCTU9TeW5jVGVzdC5Vbmluc3RhbGxTeW5jZWQM Bug: 1108172 Change-Id: I3c142419ee690165bde93c9d84fe94a4225a18f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577358 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Robbie Gibson authored
The new ThumbStripMediator handles observing the regular/incognito WebStateLists to add the ViewRevealingVerticalPanHandler as a scrollViewProxy observer. This allows it to get scroll delegate callbacks from the active webstate. This CL also slightly fixes the BVC thumb strip hide/reveal behavior to correctly change the scroll view's content insets as well as the content offset. Bug: 1094335 Change-Id: I006a3e72a06b1e327ce0984cf84bc69c2e95fe7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563556Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#834183}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71bbb3b22e98..cf023b3a8cd1 2020-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bae138de13ac to 7c84426d2abe (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ie8cf67c182edc94b1da57edd08c35b1f1229bc26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577418Reviewed-by:
-
Jérémie Boulic authored
Command: ui/file_manager/base/tools/modules.sh [1] [2] [1] build directory (e.g. out/Release) [2] path of JS file to convert (relative to chromium/src) What does the script do: 1. Update BUILD.gn to enable conversion of JS file. 2. Add exports. 3. Run closure compiler. 4. Parse closure compiler output to retrieve unknown types/variables/functions. 6. Parse these dependencies to find relevant exported types/variables/functions. 7. When found, update BUILD.gn and JS file. Made sure that: The script doesn't add any irrelevant import/export. No duplicate lines are added. Steps 3 to 7 are ran until the closure compiler output 'X error(s), Y warning(s), Z% typed' doesn't change. The closure compiler is ran at least 3 times (except if no imports are found), sometimes more. Bug: 1133186 Change-Id: I1528c8187bc1476d6add1bcb14a0d4fd1b64a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550328 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#834181}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607252866-d41b621d05e6450c8f7df54cb40144efff641518.profdata to chrome-win32-master-1607320769-266f8d6f8ffba3874a821f44f98b77515c76c883.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If1be95461ed0505f640019f76b5ab274eaea4121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575504Reviewed-by:
-
Alice Wang authored
This CL cleans up redundant IdentityServicesProvider. Bug: 1152718 Change-Id: Ie056721b377f1a8de747333eafbae7fcaf9daa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574844Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834179}
-
Leo Lai authored
BUG=b:172748724 TEST=build ok. Change-Id: I5a882b830c0920d4f721515aacb34464499fba50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569327Reviewed-by:
-
Jana Grill authored
Adjust the domain placeholder names, descriptions and screenshots in IDS_SETTINGS_UPDATE_REQUIRED_EOL_BANNER_ONE_WEEK and IDS_SETTINGS_UPDATE_REQUIRED_EOL_BANNER_DAYS to prepare them for FlexOrgs and make it easier for the translators to understand the usage of the texts. Additionally replace calls to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with calls to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172683940, b:172683948 Test: Manual Change-Id: I1102446a9d065638a8dd008a751340f6abb6060c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571878Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834177}
-
chrome://predictorsdpapad authored
Bug: None Change-Id: Idf627b30a15a069a44c4d6faf6a63316d6ec38b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574394 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834176}
-
Rainhard Findling authored
Add two string templates with placeholders that allow for concatenating two other string, without the concatenation leading to incorrect translations. The string tuples are: * |IDS_CONCAT_TWO_STRINGS_WITH_COMMA|: "<string1>, <string2>" * |IDS_CONCAT_TWO_STRINGS_WITH_PERIODS|:"<string1>. <string2>." This CL also extends PluralStringProxy to in one step fetch two plural strings and concatenate them into one string, using the templates above. It also fixes one already existing instance of crbug/1060625 in chrome/browser/ui/webui/settings/safety_check_handler.cc by migrating it to the corresponding string tuple. Translation screenshots: IDS_CONCAT_TWO_STRINGS_WITH_COMMA https://storage.cloud.google.com/chromium-translation-screenshots/6139bb64c11e0f921e8d5951367952b62ecb3fcc IDS_CONCAT_TWO_STRINGS_WITH_PERIODS https://storage.cloud.google.com/chromium-translation-screenshots/f39b3eea7e82b711a29c50f7cc12567bae2a80c3 Bug: 1154630 Change-Id: Ie2cb8383448ecc35933a470b28e56ed0fcc12771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566821 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d90e578fb431..f3b959c00071 2020-12-07 kjlubick@google.com [canvaskit] Respect Exif metadata for animated images. 2020-12-07 kjlubick@google.com [canvaskit] Remove 2d point arrays from API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I171f00431365ab42318c88bdf81db637372de65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576425Reviewed-by:
-
Ramin Halavati authored
ToolbarViewWithExtensionsToolbarMenuTest did not correctly disable Ephemeral Guest profiles when they were enabled by default. This issue is fixed. Bug: 1125474 Change-Id: I4f277c3477d76cf3fee51bcd80c283b2929e2ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573104Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#834173}
-
Bartek Nowierski authored
De/RecommitSystemPages() have similar properties under POSIX and Fuchsia, since both use over-commit, but the API implementations differ in their optimizations. Update the Fuchsia implementations with the same optimizations as provided for POSIX. Bug: 766882 Change-Id: I34b98db27ed85543e53b3231ec118d0a2409b454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558122 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dead315abbf8..b36ad7e1d111 2020-12-07 jacktfranklin@chromium.org [Interaction tests] fix running in out/Release 2020-12-07 sigurds@chromium.org Update readme in front_end/Images 2020-12-07 wolfi@chromium.org [Issues] Add UMA for opening the Issues Tab via the command menu 2020-12-07 yiorsi@gmail.com Add "Copy file name" context menu to Workspace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126031,chromium:1153281,chromium:1155120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9c52f61c6075efc7d1a13372d65d891884f7273c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575509Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/731e67da3620..682b3e2b91af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: grt@google.com Change-Id: Ifc9ca19658c01ad31e86105980766b2d31a3b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575634Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834170}
-
Kent Tamura authored
OOF descendants of a fieldset should not be contained by the fieldset because they should be scrolled together with the fieldset contents. This CL makes an anonymous fieldset content box an OOF container by adding |filter: brightness(100%)| or |position: relative| if the fieldset can contain OOF objects. We need to add a special handling for OOF descendants of a LEGEND to FindAncestorByPredicate() because such OOF descendants are contained by fieldsets in NG fragment trees. Without this change, we had some CHECK failures. Bug: 1153042 Change-Id: I993922cfd373a9e0558bc50edb009680f0f1244a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569140Reviewed-by:
-
Tim van der Lippe authored
R=sigurds@chromium.org Bug: 1144171 Change-Id: I88304a0cc6eba84973c2a7ff7c0d93410eb68760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575021 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
