- 16 May, 2019 40 commits
-
-
Huanzhong Huang authored
Currently, we set, but don't subscribe to changes of, Time Range in the new CBD dialog. For this to work, it is implicitly assumed that Time Range can only be changed through CBD. Bug 961340 reveals a glitch that Time Range can actually be changed by other entities. With this the least we can do is to have a more defensive design and subscribe to changes on Time Range, so we can keep the consistency between the interface and the browser state. - CBDManager is chosen to be the Time Range observing entity, as it is the creator of the Time Range item. - Remove the definition (and use) of TimeRangeSelectorTableViewControllerDelegate, which is no longer needed since the observer is by itself actively observing changes on Time Range. - Update unit tests. Bug: 961340 Change-Id: I2f692f770c8b533c1bf3730ba34c08fe2bc49269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602648Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#660330}
-
Satoshi Niwa authored
Removable media items are overlapped with Android picker app items Before : https://screenshot.googleplex.com/EgHOyEjtKur.png After : https://screenshot.googleplex.com/fFuZONAGQBc.png Bug: b:132840819 Test: N/A Change-Id: I97c473b037d74b218c53ff2aa99be9953a12ace9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614730Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#660329}
-
Takashi Sakamoto authored
This reverts commit 144e9e93. Reason for revert: suspect causing PublicSessionWithTermsOfServiceOobeTestImpl timeout on Linux ChromiumOS MSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12947 browser_tests deterministic failures: PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/0 PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/1 PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/2 PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/5 PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/6 PublicSessionWithTermsOfServiceOobeTestImpl/PublicSessionWithTermsOfServiceOobeTest.AcceptTermsOfService/7 Original change's description: > Test oobe screens for public session login > > Tests that the terms of service screen (if required by policy) is the > only screen shown to public session user during login. > > To make environment setup for different configurations eaiser, separate > end to end test setup steps from OobeInteractiveUiTest into a separate > mixin. > > BUG=none > > Change-Id: Ib6580e2b4f63f59c7b262fb0f79982197251724c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607103 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660269} TBR=tbarzic@chromium.org,alemate@chromium.org Change-Id: Iaa5b1073e336935452a184eeb67a4808fb9626fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614005Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#660328}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9a7970de2813..4e4fc628abde git log 9a7970de2813..4e4fc628abde --date=short --no-merges --format='%ad %ae %s' 2019-05-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 34a27578..609f581d (660187:660301) 2019-05-15 steveanton@webrtc.org Thread safe crc32 table initialization Created with: gclient setdep -r src/third_party/webrtc@4e4fc628abde The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e76e2caf18a53af1d3561e288e74666e144c873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660327}
-
Kuo Jen Wei authored
Bug: 960292 Change-Id: Ie2483b4eefe4fd65722fb98bb3852f162b60267b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614654 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660326}
-
Maggie Cai authored
Currently, when we switching between tabs, the intent picker icon will disappear. This CL uses the tab helper to persist the intent picker icon state and ensure it is up to date when switching between tabs. BUG=801712,915949 Bug: b/120113310 Change-Id: I243773a805955b645e833719a4887905f72b311b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605321 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660325}
-
Gauthier Ambard authored
On some cases, the backForwardList gets out of sync with the URL exposed by the WebView. This creates a bug in our code because we are relying on the URL of the current item of the backForward list to get the committed URL and the URL to display in the omnibox. This fix breaks the back/forward navigation in those cases. Bug: 951880 Change-Id: I9d53eb08384d5bd9fc002bf9630bc6da2db17a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1581621Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#660324}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec1c11a907d4..d8e8ffa35b5a Created with: gclient setdep -r src-internal@d8e8ffa35b5a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: Icaa7ee5f5653e844ddccfe667a3caa6cb98adfa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660323}
-
Yi Su authored
This CL refactors all user-interaction logic from CRWWebController into UserInteractionEvent and UserInteractionState. Bug: 956511 Change-Id: I1ae63c395c0b269a30ab0b7b2743103c1ae4ffbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610775 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660322}
-
Huanzhong Huang authored
Reduce the gap above each footnote in the new Clear Browsing Data Dialog by 5 pts, as suggested by UX. Bug: 935346 Change-Id: Ie4263bbbcf41b6181517034429251ae29b7c596b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609854Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#660321}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ddb7768fa25..311e80864a32 git log 6ddb7768fa25..311e80864a32 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 jiajia.qin@intel.com Do struct mapping under conditions Created with: gclient setdep -r src/third_party/angle@311e80864a32 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I4c3a22795600ba516052e7f1d21438c8ef7c72aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660320}
-
Sreerenj Balachandran authored
Current implementation of vp9 parser keeps the segmentation and loop_filter headers as members of the the FrameContext. This patch is for extending the frame_hdr to include a copy of segmentation and loop_filter so that all uncompressed header parameters can be direcly accessible from the frame_hdr. The main intention is to help the components like VEA to depend only on frame_hdr to populate all required parameters in the uncompressed header to va api. Note: The segmentation and loop_filter associated with the Vp9FrameContextManager is possessing the calculated values, not just the parsed bitstream parameters. If the client has to parse the compressed header (which is not required for h/w accelerated decoder and encoder implementation), segmentation and loop_filter in context get updated based on the dequants([1] section 8.6.1) and loop_filter frame init process ([1] 8.8.1). [1] https://tools.ietf.org/html/rfc6386 Bug=chromium:924786 Change-Id: I9f1cdcbc93fd3afb21be731dd8e0bd252b773231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531024Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660319}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7921042df7e5..3f4b4dcb51a7 git log 7921042df7e5..3f4b4dcb51a7 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a01010a5..8c742b26 (455 commits) 2019-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bff32703c75b..6ddb7768fa25 (10 commits) Created with: gclient setdep -r src/third_party/skia@3f4b4dcb51a7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I82991ea680342c8b95b27300c0607d34d1cf6461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614555Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660318}
-
Darren Shen authored
Forgot to delete it when moving its contents out. TBR=sky@chromium.org Bug: 961568 Change-Id: I6daebfd003e6cc7377f2764aacd81d718da7ff57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611626Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#660317}
-
Yang Guo authored
R=machenbach@chromium.org, scottmg@chromium.org Bug: v8:9253 Change-Id: Ie4bf8766a53a09c28ad63d1f74fbecfb5e0888e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611935Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660316}
-
Wei Lee authored
This CL supports dynamically configure photo resolution on Chrome OS VCD. In addition, it fixes the issue that getPhotoCapabilities() of Image Capture API gets same width/height for min/max resolutions on Chrome OS. Bug: b/131874934 Test: Manually Change-Id: Ie84bf476887c56be50d2624d85e352b6efaf99bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612860Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#660315}
-
Gabriel Charette authored
All known issues identified by it have been fixed :) https://bugs.chromium.org/p/chromium/issues/list?can=1&q=TestBrowserThreadBundle+MainThreadIsIdle&x=m&y=releaseblock&cells=ids R=alexclarke@chromium.org Bug: 938126 Change-Id: I3aa25d9d2c65a7520926d7700e45d52fc84104d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614779 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660314}
-
Peter K. Lee authored
Trivial cleanup. No functional change. Change-Id: I28a0579ce2edebbac5197c7730b7f48099d22239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614780 Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#660313}
-
Grzegorz Król Żyszkiewicz authored
Seems the mechanism implemented for aura web contents view was not moved correctly to mac web contents view. This change applies the needed changes to make web contents observers to be notified of lost focus on MAC. This omission on Mac seems to only affect UMA histograms. BUG=680809 Change-Id: I47d8063d3258b9e6c684899f763198b5f9f8ffff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611821Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#660312}
-
Takashi Sakamoto authored
TBR=avi@chromium.org Bug: 963764 Change-Id: Icd8b655091e9d2ea85a7c4ffa49e8e0a79e002f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614002 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#660311}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/61c0db71de93..e4c0a82ecfd5 git log 61c0db71de93..e4c0a82ecfd5 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 jiawei.shao@intel.com D3D12: Create descriptor heaps after computing the required size Created with: gclient setdep -r src/third_party/dawn@e4c0a82ecfd5 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: If5e0a79c9ca3b24924f36382926b499f2022ad41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660310}
-
Victor Costan authored
This unifies SQLite's behavior across Android and other operating systems. Bug: 43939 Change-Id: I873f1b283e7bcfd6875302163c350b1eb20b7fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1146493 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#660309}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3c0bf642613..7921042df7e5 git log b3c0bf642613..7921042df7e5 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3d7b7ea134d1..d61595f367af (10 commits) Created with: gclient setdep -r src/third_party/skia@7921042df7e5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Id15a9f3c0ceea5640f432990d80e0f37a511dd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660308}
-
Maciej Pawlowski authored
This is for consistency, most other code uses underscores to separate words rather than dashes. Bug: 954080 Change-Id: I3b0d1e0a33e5196344fbd7d52f187f87607bbcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608742Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Cr-Commit-Position: refs/heads/master@{#660307}
-
Eliot Courtney authored
This will allow us to solve some synchronisation issues, such as spuriously setting the bounds upon expanding PIP to a freeform window. Bug: b/130314958 Test: bounds change for PIP arrives with correct bounds change reason. Change-Id: I16664994d7018f776e5095e92b432bf86827f481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583900 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#660306}
-
Eric Willigers authored
Test that computed values of the flex properties are as specified. Test that flex-basis computed value is non-negative. Change-Id: I1640dc52f0b72c1cff686eb0d717ef0846bf50ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614857Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#660305}
-
Alex Keng authored
This CL adds shihken@microsoft.com to media_controls WATCHLIST Change-Id: Ibccabaf9e834c9c8622e88b21fce444ebb8fac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614559Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660304}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/142d91dc58f5..ec1c11a907d4 Created with: gclient setdep -r src-internal@ec1c11a907d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I6ea8d85c2c8c8e4806a314bff462dd17268c2e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614806Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660303}
-
Alexey Baskakov authored
We will need it to implement InstallWebAppWithOptions install process. Bug: 901226 Change-Id: Iae64891ceeccbf68b20c8d3113a981938fb7207f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614722Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#660302}
-
Takashi Sakamoto authored
Sheriff: virtual/threaded/http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations.js is falky timeout Bug: 963749 Change-Id: I726d3235e4a5d7c4bf66f5cc5e99f09657e92a4d TBR=avi@chromium.org Change-Id: I726d3235e4a5d7c4bf66f5cc5e99f09657e92a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614652Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#660301}
-
Jeevan Shikaram authored
Hide Apps section in settings expanded menu. Bug: 963388 Change-Id: I47313efb383c8195fa69d954063d4c9467505073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614646 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#660300}
-
Khushal authored
Add the copy-on-write disabled workaround for webview to the shared image path. R=kbr@chromium.org Bug: 946792 Change-Id: I409b8666c5f59702f2d3e6c222d82f73b443271a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610872 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#660299}
-
Jeevan Shikaram authored
Right clicking on an application in the launcher and selecting app info now opens App Management with the application selected. Bug: 949405 Change-Id: I3373f716eacc934f8cd3e939bcbef160c5e4908b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612863 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#660298}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/e3d32ff..64e5d7 Bug: v8:8515 Change-Id: Ibc1503d96c8e7af2f60455f5065e9bbd5a72644b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614694 Commit-Queue: Frank Tang <ftang@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#660297}
-
Kinuko Yasuda authored
It's no longer used by network service code. Change-Id: Idb9d2ed3808f63cb54ee28e557a93a4d45b3a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599821Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#660296}
-
Sheng-Hao Tsao authored
This CL changes the default camera app to CCA (Chrome camera app) for all devices. Before this CL, P and above devices with ARC enabled should open GCA (GoogleCamera app). The flag "force-use-chrome-camera" will be deleted in another CL after M76 is branched. Bug: 962834 Test: Tested on eve that camera icon triggers CCA Change-Id: Ibf09059292eb0b47e162aa7d455dd029fe238fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611421Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660295}
-
Anand K. Mistry authored
Currently, smbprovider itself does this check and prevents a share from being mounted twice. However, smbprovider needs this ability in order to recover from certain situations (i.e. browser process restarts and crashes). Further, there's no technical reason why smbprovider needs this limitation. Adding this check to the browser means it can be removed from smbprovider. In the future, this restriction could be lifted entirely when the UX exists. BUG=961183 Change-Id: I32b2e87fcdd9a900253581b4b8864d94a4cfb09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614858Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#660294}
-
Noel Gordon authored
Module _malloc, _free, and image parameters are {number} ie., they are not optional. Change {?number} to {number} in their interface defines. Bug: 935285 Change-Id: Ic3f61a8d7a0b5a1a9daeea3f965a0f3fec1a3d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614718Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660293}
-
Noel Gordon authored
This function reloads the Image Loader extension to recover from fatal errors in the wasm Module, and hence get it back into a working state. Console log.error these calls so they get logged in the field. Bug: 904630, 935285 Change-Id: I95ad0f24c1621493b6c494a1fccc352fc6a448e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614758Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6821cd9dcfe4..142d91dc58f5 Created with: gclient setdep -r src-internal@142d91dc58f5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I923a778aab6ad6b40e4e92f61c06011db385cdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614802Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660291}
-