- 30 Jul, 2020 40 commits
-
-
Adithya Srinivasan authored
Creates blink::PortalToken to represent tokens used to identify portals, and updates all callsites to use this type. Bug: 1096617 Change-Id: Ic4b5474baa4ab4f03ad2f6d94072d9f5155855ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310129Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#793191}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596088294-504dedae571570b11066feec00ad5216cd478cce.profdata to chrome-win64-master-1596109918-e7fed2d6fa04d0e079da5890487faf0a15a02c82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib6d29289015a04faca055ffdc14b1d4ba1eb8bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793190}
-
minch authored
We are going to add feedback item in the power menu in the login page. So this cl goes to extend the related histograms. Bug: 1097924 Change-Id: I3852949fca8dde01287b8bfb45e19e5ffa79749f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326712Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#793189}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9b215da6..78a8b5cf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I49ab3eb778e9801f90e0e189b9b84380a8f32ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329405Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793188}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45f583aecc0..bcdec7d7076c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0077d84022ebc092b4ba3592f8932a56126c991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793187}
-
David Benjamin authored
This relands https://chromium-review.googlesource.com/c/chromium/src/+/2313160 which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/2320913 due to some test failures. This CL just removes the offending tests. HideShow is no longer applicable for a window-modal dialog, and Basic no longer works now that we're using a plain OS sheet instead of WebContentsModalDialogManager and some SPI to dismiss the sheet. Bug: 762915, 1078158, 1098786, 1110172 Change-Id: Ic3c128a6f2eea0ae3f403c778e2d44444e3aa25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324112Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793186}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a36a91a4450c..38ba51ce7ad8 2020-07-30 kainino@chromium.org Make shim headers at <webgpu/*> that point to <dawn/*> If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie035492ce783af1a8f577c01f046958409abeb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793185}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: Ic31d39ee8be716b4829049db7770ffc1fd1c3273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325428Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#793184}
-
Amr Aboelkher authored
This is needed by SHELL as a direct dependency. Bug: 1106360 Change-Id: Ib184e879f9ad0fdc1fa604ac965979b5045a7e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302153 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#793183}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4b1801b3. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I6c535d2b64f6200385d49d77e7c5e63865269a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329670Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793182}
-
Mike Jackson authored
Takes into account the display_override manifest setting when computing the effective display mode. 1) If the app is not installed locally use 'browser' 2) If the user set a preference for opening in a browser tab, use 'browser'. 3) If display_override is specified in the manifest, and the feature flag is on, use the first entry that is either 'standalone' or 'minimal-ui' 4) Use the existing logic for the display_mode field To test the feature start Chrome with '--enable-features=WebAppManifestDisplayOverride' command line parameters. Explainer: https://github.com/WICG/display-override/blob/master/explainer.md Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Screenshots of https://mwjacksonmsft.github.io/pwa/display-override/index.html : before: https://imgur.com/a/RTHBf75 after: https://imgur.com/a/dmuO90b Bug: 1092667 Change-Id: Ie0763b4918fdde8827346a94e4461ec52c1e8a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314977Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793181}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I99815cc5f70fd0278d5b562e5b3b0890ce305f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328342 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#793180}
-
Andrew Grieve authored
Bug: 1029357 Change-Id: I1ba26e7b1af18f947f4383e8fcb899b5d1cb904d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329831 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#793179}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I71a343ecf62b9a2dba14be48f05aa6fa9c045148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326297Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793178}
-
James Hollyer authored
Previously once the auto_open bubble was set it was never reset so it continued to pop up until the browser was closed. This change resets that on every update so it only prompts when the user selects allow on the per site permission prompt. Bug: 1111087 Change-Id: Ic377cfa8b764a577eaa5acbf0d416865360465fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327467Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793177}
-
Maxime Charland authored
The testCachePositionIsResetWhenNodeIsPermanentAndEmpty test in BookmarksTestCase fails when the illustrated-empty-states flag is enabled because while the functionality remains the same, an assumption about the view's contents is different because of Chrome Empties. The test moves into Mobile Bookmarks, closes Bookmarks, removes all the bookmarks, then reopens Bookmarks to make sure the root level of Bookmarks is opened. While this is still true, the test checks the existence of "Mobile Bookmarks" in the TableView to see if the views is currently displaying the root level. With Chrome Empties, the test will check the absence of a Back button, which is the case with or without Chrome Empties. Bug: 1098328 Change-Id: I52c2c18a5b489febb0ba6e7e76be4c1577de1eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327230Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#793176}
-
Balazs Engedy authored
The following test is flaky on iOS simulator: AddressViewControllerTestCase/testAddressesStateAfterPresentingManageAddresses Bug: 1111076 Change-Id: I81e145bf8e4ea93ebf3139de0707510f93c38f22 TBR: javierrobles@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329532Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793175}
-
Ewann authored
- Adds a new Context Menu with a "Copy" action. - Wraps the old implementation with a feature flag check. - Adds metrics for the new context menu and its action. Bug: 1093302 Change-Id: Ib814b1c16b18f2855a6cc8ad6d9f425a230ce8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325172 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793174}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d755ba27aab7..bcdec7d7076c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9c0bd0aac299a362ed7125e97b3119f37006de75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329050Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793173}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bcdec7d7076c..976db5baa78b 2020-07-30 fmayer@google.com Default stop_timeout_ms if not given. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160400319 Tbr: perfetto-bugs@google.com Test: Test: Use on QT build to profile custom allocator. Change-Id: I0020e2f87ca45f88a832d2da9f1dcb7e3cd305ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793172}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2d177ab9e84..ffea8a6a6482 2020-07-30 janscheffler@chromium.org Add reference to original regression 2020-07-30 janscheffler@chromium.org Migrate `front_end/console` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Migrate `front_end/layer_viewer` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1111256 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I26be2312a6faf0b776a40e20ee311916e666594f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793171}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596103202-ae37a5b5255471047baf735b75fad8695ae7df62.profdata to chrome-win32-master-1596106614-c0cf678d73b5b04fadad07393187258d17226466.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I8eb35ee4eb6a654ebef21af545d53947386b0b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793170}
-
Joey Arhar authored
Making find-in-page scrolling async is needed for a use case with the beforematch event where the page posts a task to modify the layout of the page and then expects find-in-page to scroll to the target location after the style modification takes place. This use case is demonstrated in the test case beforematch-async.html. Bug: 1087536 Change-Id: I46a9e7d6195f02697b6acd1f20263dd9ba0bd679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261138Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793169}
-
Victor Hugo Vianna Silva authored
This CL adds a histogram that records, per data type, what was the number of sync entities that remained undecrypted when it was disabled. Bug: 1109221 Change-Id: I4b97f99286a85f3f5bd4f3ee4cf8de206ff93d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326710 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793168}
-
Roman Arora authored
Bug: 1099917 Change-Id: If5ff51d090940a7f6d994b99adb6d02615c13dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324161Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#793167}
-
Vikas Soni authored
1. max_images was initially set to 2 and was reduced to 1 later since xiaomi mi box 4 didn't supported max_images more than 1. 2. Since using max_images of 1 can have negative impact on playback smoothness, setting it back to 2 for all devices except mi box 4. Bug: 1051705 Change-Id: Ibd466027c97ce7b7266115fd86339ede60bf41e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315217 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793166}
-
Yuki Shiino authored
Blink-V8 bindings team has been developing the new improved Web IDL bindings system, and this patch enables the new bindings implementation of Web IDL interfaces at build time. Note that other IDL definitions (buffer source types, dictionaries, callback functions, etc.) are not affected and the old bindings are still used for them. The new IDL interface implementation is not 100% compatible with the old one, and we see the following changes/improvement that are visible from author script. Behavioral changes: - Cross origin attributes become accessor properties. - Indexed/named properties' behaviors change. - Legacy platform objects with indexed properties support @@iterator property. - Maplike supports size() operation. - [NoInterfaceObject] removes 'constructor' property. - Some of error messages change. For these changes, new behaviors are better conforming to Web IDL specification. Non-behavioral changes: - Keep-alive-GC optimization is removed. For performance, there is no major difference in speed perf and -17KB improvement in APK binary size. Pinpoint results https://pinpoint-dot-chromeperf.appspot.com/job/1230bdd8920000 https://pinpoint-dot-chromeperf.appspot.com/job/14b5b5d0920000 https://pinpoint-dot-chromeperf.appspot.com/job/12ca6424920000 https://pinpoint-dot-chromeperf.appspot.com/job/14e3aa48920000 Bug: 839389 Change-Id: I9de8de3cc9e37b4ee46333c9270fe49bbdd69534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081633 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#793165}
-
Viktor Semeniuk authored
This change adds possibility to edit password on Password Details Screen. Bug: 1075494 Change-Id: I7647237b41c7cabcd93fc4a19bf92f5ea7c3b5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309692 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793164}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8d09e37670ed..8138cbbd875a 2020-07-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc8e77f0e521 to 08a3cc4cfbaa (3 revisions) 2020-07-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c0bf676837e4 to 4400cab64b22 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I55d6d9d4c826e575339b27cd76e32939ac7b72dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793163}
-
Andrew Grieve authored
Bug: 1111004 Change-Id: I0287c7096017b440704d3e79ea6768fd0cf21fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327612 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793162}
-
Alexander Surkov authored
It is shorter and more readable format, allows to skip =* part in property patterns, for example AXRole instead AXRole=*. It also makes the format consistent in case of nested calls, for example, AXTextMarkerForIndex(AXIndexForTextMarker(index))=index, which has no wildcards in it. Bug: 1100991 Change-Id: Ie439d9052b276c15d46b9da990504608706c748a AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318552 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#793161}
-
Benoit Lize authored
Change-Id: I28c8ca1c1d0464ae6b632ff7b1d8440770b0c935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325175Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793160}
-
Matt Jones authored
tabStateInitialized is another method in the SceneOverlay interface that is only used a single time. Since this method is also easily replaced by an observer, the interface method has been removed in favor of that. Bug: 1100332, 882508 Change-Id: Ifb088320dac2ed2143a67fc46d59a30a8aa7c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326012Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#793159}
-
Ewann authored
- Adds a new Context Menu with a "Copy" action for tabs item. - Adds a new empty Context Menu for section header. - Wraps the old implementation with a feature flag check. - Adds metrics for the new context menu and its action. Bug: 1093302 Change-Id: I53d698f5480e201423cf5f28add4c16c2b35b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325730Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#793158}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I2b7ab8c7671cbd492394d453a14fb47517dbc4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328340 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793157}
-
Ali Juma authored
This CL adds a factory for creating RealTimeLookupService instances on iOS, and uses a RealTimeLookupService with SafeBrowsingUrlCheckerImpl when the kRealTimeLookupEnabled feature is enabled. This means that when this feature is enabled, real-time lookups work on iOS. Change-Id: I7126a4224a20bd9fb45360ba2dc46f5d032f4a10 Bug: 1103220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317850 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#793156}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e5c11c069f53..d782fd9e320e $ git log e5c11c069..d782fd9e3 --date=short --no-merges --format='%ad %ae %s' 2020-07-30 vasilvv Fix a typo in CertificateView that prevented P-256 from working. 2020-07-29 dschinazi Cleanup uses of QUIC version 2020-07-29 renjietang Replace gfe2_reloadable_flag_quic_enable_zero_rtt_for_tls with gfe2_restart_flag_quic_enable_zero_rtt_for_tls_v2 2020-07-29 vasilvv Add support for legacy ECDSA private keys to certificate_view.h 2020-07-29 fayang QUIC client do not send new request if now is close to idle timeout. Only affecting client, not protected. 2020-07-29 fayang In QUIC, add a copt to enable overshooting detection. Protected by gfe2_reloadable_flag_quic_enable_overshooting_detection. 2020-07-29 fayang Make sure MaybeCoalescePacketOfHigherSpace is not re-entrant to avoid infinite loop. Protected by gfe2_reloadable_flag_quic_coalesced_packet_of_higher_space2 which replaces gfe2_reloadable_flag_quic_coalesced_packet_of_higher_space. 2020-07-29 fayang In quic, respect enable_half_rtt_tail_loss_probe_ when using pto. protected by gfe2_reloadable_flag_quic_use_half_rtt_as_first_pto. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2e4ce8ba9b1fc158528ae44d2cdf52b9560a57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329246 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793155}
-
Bailey Berro authored
Currently changes to menuOptions via array mutations do not cause shouldDisableMenu_() to be called again. In particular, this causes and issue with the resolution dropdown for CrOS Display Settings since we rebuild the list of resolutions by assigning an empty array and then calling the 'push' array mutation. Fixed: 1105149 Change-Id: I9e275454254af56ea3aab5f83176a51cd447d0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327790 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793154}
-
Bence Béky authored
When moving HTTP2_SESSION_SEND_DATA from SpdySession to SpdyStream at https://crrev.com/c/2309350, I incorrectly changed the event source. This CL fixes it, so that HTTP2_SESSION_SEND_DATA will show up in the HTTP2_SESSION together with HTTP2_SESSION_SEND_HEADERS and HTTP2_SESSION_SEND_GREASED_FRAME. Bug: 1106652 Change-Id: I1ae2776326ac0f680dc4162cea509d779cb09b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327184 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5ba6534884d9..e393c61a1563 2020-07-30 senorblanco@chromium.org Dawn: update for API changes (Buffer). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Id9709806cdb8daac046f355b1243e65fc7493f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793152}
-