- 07 Jun, 2019 40 commits
-
-
Alex Cooper authored
If a user suspends an OpenVR immersive session whether by dropping to a home environment (like the WMR home), or by pressing the "system" button on the controller to show the OpenVR/Vive menu, and then re-enters the session, the controllers would no longer be visualized. This appears to be occuring because while the controller stayed connected, the OpenVRRenderLoop was not able to query it's state, and therefore stopped reporting input information on the controller. When the controller re-connected, the RenderLoop would resume sending data about the controller back up, but did not send a new description because it thought it had been connected all along. In XRSession, when a new XRInputSource was created, it defaulted to being created as a "Gaze" source with no handedness. With no override from the description, it stayed that way; clicks would work on the gaze target, but no controllers/pointers would be rendered. The fix here is to simply mark the controller as inactive if it does not have state, thus ensuring that a new description is sent up when the controller is again tracked/has state. While updating this change, it was discovered that the tests report all devices as connected, and so connecting/disconnecting a controller on the test side would not prompt the device to be registered in product code as newly connected (where it's device type is updated), so it was always ignored if it was ever disconnected. This change modifies the WaitGetPoses method (where GetInputSources gets it's data), to properly report the connected state of controllers. Bug: 934355 Change-Id: Ia61c7568916cc9446366e085e74b55c413c5f6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648654Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#667209}
-
chrome://signin-internalsAlex Ilin authored
My previous CL https://crrev.com/c/1648164 used base::TimeFormatWithPattern() to get a date string in a fixed format. However, base::TimeFormatWithPattern() freely modifies the pattern to make it correspond to the system date format. This CL uses base::TimeToISO8601() for date formatting instead of base::TimeFormatWithPattern(). Bug: 852037 Change-Id: Id63cd5582d5a3259251c5f9d292378511545b662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649173 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#667208}
-
Wez authored
Bug: 971927 Change-Id: I7c3f8c3340bec731fae7cadb9e8a03cc9c2dc0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649029 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#667207}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Ief71174e37070489b6a9c89b28a6950334bd0dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649539 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#667206}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3ff3ecc72ae4..1faba755ff77 git log 3ff3ecc72ae4..1faba755ff77 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 tsepez@chromium.org Prevent CPDF_Type3Font from knowing that CPDF_Type3Char has a form. Created with: gclient setdep -r src/third_party/pdfium@1faba755ff77 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I16c4eb040107582e4471cbebdd8c5612307b25c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667205}
-
Wei-Yin Chen (陳威尹) authored
Updates in Tab-to-Grid transition animation: - Do not show the selected blue border in the grid when the tab resizes - Fade in the selected blue border along with the GTS final fading-in Bug: 971522 Change-Id: If788855ce4659226900759517cf7f8e9ab536e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648835 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/311b8025e35c..af0e045c2ee1 git log 311b8025e35c..af0e045c2ee1 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 saklein@chromium.org BinhostService: Refactor PrepareBinhostUploads and RegenBuildCache Created with: gclient setdep -r src/third_party/chromite@af0e045c2ee1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I880543ee4b810d7b5d231d763d229281e4f52c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649060Reviewed-by:
-
Mythri A authored
Bug: chromium:958441 Change-Id: I89a2d24a57d72c53844b39ed4eabe3198f394bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646791 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#667202}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=chili@chromium.org Change-Id: Id6421b96347e3bfac890f039bcda4aa8329f27b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649578 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#667201}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //ui. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 970209 Change-Id: Ia41e90dc60687f1adb07f0552141e31a4dee83c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648189 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667200}
-
Lindsay Pasricha authored
CIPD packages: infra_internal/ios/xcode/mac 10e1001 infra_internal/ios/xcode/ios 10e1001 Bug: 971671 Change-Id: I64b42e4990a6b8a3a0ee45527a8a3e0deba7c2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646666Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#667199}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=khorimoto@chromium.org Change-Id: I409da52d966a61ce1fe734a06293a4607487687a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649675 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667198}
-
chrome://policyTien Mai authored
A new key "chromeMetadata" will be added to the JSON exported by the chrome://policy page. This new key will contain the following information: "chromeMetadata": { "OS": "Windows 10 OS Version 1709 (Build 16299.1146)", "application": "Google Chrome", "revision": "3e139c3d-refs/heads/master@{#665955}", "version": "77.0.3815.0 (Developer Build) (64-bit)" } Bug: 963506 Change-Id: I0b5fa3ef1904508285a94acbff45dde3fc232aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642817Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#667197}
-
Xianzhu Wang authored
Bug: 969383 Change-Id: Ib29aebde466289ff80b3c693ee90b690ab627ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625869Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667196}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/073b8ac2ff8e..4c5c8ab626d5 git log 073b8ac2ff8e..4c5c8ab626d5 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 ehmaldonado@chromium.org Reland "Reland "gclient: Require a target ref when applying patches."" Created with: gclient setdep -r src/third_party/depot_tools@4c5c8ab626d5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:956807 TBR=agable@chromium.org Change-Id: I2cf625fbce81d11c18eb2fc66ed20bd6e2916a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649063Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=yucliu@chromium.org Change-Id: Idbad32ad54c52846e28dbd56841e4c97b8c44fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649170 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667194}
-
Wei-Yin Chen (陳威尹) authored
Updates in both Tab-to-Grid and Grid-to-Tab transition animations: - Stops showing the tab decoration when the tab resizes - Fade in/fade out the GTS in the background when the tab resizes - Update interpolator for tab resizing Updates in Tab-to-Grid transition animation: - Duration of GTS final fading-in: 218ms -> 50ms - Delay the fading-in of Tab Switcher top toolbar to the second half of the animation Bug: 971522 Change-Id: Ifc34437cb6691b18f0e4c63439b464b637927310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646741 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Erik Chen authored
RecordMemoryStats(RECORD_MEMORY_STATS_TAB_DISCARDED) is only called in one location, and the author indicated that it is unnecessary. Change-Id: I8ecd64337cacbf279e148dd80a4dbbcac872d187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639040Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667192}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=piman@chromium.org Change-Id: Ida93c455e32bf058063b6bf48800b289c972823b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649326 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#667191}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=penghuang@chromium.org Bug: 616447 Change-Id: I42fb5b8d372a39dfe0493d49e09caeea571bd59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637458 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#667190}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=braveyao@chromium.org Change-Id: I574c959c6ab245e188386d0cbad5d8b3c2b4c789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649512 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#667189}
-
Robert Ogden authored
Removes: * feature * previews type * assoc params * triggering logic PreviewsState bit will come in the next CL. Bug: 944286 Change-Id: I65410f30d1efa574a391d61723fd6788b2d2d66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642018 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#667188}
-
Etienne Pierre-doray authored
Change-Id: I4f5b8ba6150924d7ae7a33c4aed9b8ee764b442c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647891Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#667187}
-
Josh Nohle authored
Children of the base CryptAuthDeviceSyncer class will implement the CryptAuth v2 DeviceSync flow, which includes uploading local device metadata, receiving remote device metadata, receiving device feature statuses--supported/unsupported and enabled/disabled--for multidevice (BetterTogether) features, and sharing the group private key with remote devices. The metadata and group private key exchanges are end-to-end encrypted. The analogous class for v2 Enrollment is CryptAuthV2Enroller. See design at https://go/cros-devicesync-v2-syncer. Bug: 951969 Change-Id: Ie069759d72f096ce97ef081a43b7f118ed9ea574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648837 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Sam Maier authored
Bug: 972070 Change-Id: I34eb7fb23bc11c2136413414b00192760ba13282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649718 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Bug: 965663 Change-Id: I07a61658d730c0982e52f7e496d05cb274c9ef2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648695Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667184}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=proberge@chromium.org Change-Id: I05cc6ca56595f4cd8f9ba6887e5a3fa93a6927f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649365 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#667183}
-
Xianzhu Wang authored
Bug: 967281 Change-Id: I17b4ff95c2d31b0af0d3e7eb230cb70aae5532a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648802Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#667182}
-
Vladimir Levin authored
When locking a composited element, we may skip gathering its graphics layer as a foreign layer in local frame view. If we do, we need to ensure to invalidate the root paint artifact when we unlock, so that we can rerun the collection step to discover the unlocked graphics layer R=chrishtr@chromium.org, pdr@chromium.org Bug: 966760 Change-Id: I4a8ca9e08300eed05563fa0e9a08e65f4ea3094e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647752 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Carlos Caballero authored
https://crrev.com/c/1649369 introduced a transitive dependency on //base/test:test_support, I guess presubmit checks do not run here so the submit did not fail on that patch. Change-Id: I30291b3d192041339179e9599bec097ef87c27c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649585Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#667180}
-
Ian Swett authored
Roll src/net/third_party/quiche/src/ 68d15a821..028931750 (16 commits) https://quiche.googlesource.com/quiche.git/+log/68d15a821c88..028931750c1a $ git log 68d15a821..028931750 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 danzh gfe-relnote: n/a(code cleanup) add #include <vector> to quic_hkdf.h 2019-06-05 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_enable_version_46 . 2019-06-05 fayang Enable more QuicConnectionTest for multiple packet number spaces. 2019-06-05 nharper gfe-relnote: Remove more dead Token Binding code in QUIC. Not flag protected. 2019-06-05 fayang gfe-relnote: In QUIC, add connected_ check in OnCanWrite and flusher's destructor. Protected by gfe2_reloadable_flag_quic_check_connected_before_flush. 2019-06-05 wub gfe-relnote: Cleanup stateless reject related stuff from QuicCryptoServerConfig::ProcessClientHello and QuicCryptoServerHandshaker::GenerateConnectionIdForReject. No behavior change, not protected. 2019-06-05 dschinazi Fix flag counts for quic_do_not_override_connection_id 2019-06-05 dschinazi Support QUIC Client connection IDs 2019-06-04 nharper gfe-relnote: QUIC_BUG instead of LOG(ERROR) in CreateQuicVersionLabel if the HandshakeProtocol is unknown 2019-06-04 fayang gfe-relnote: In QUIC, add code counts for RTT status when cwnd gets bootstrapped. Not protected. 2019-06-04 fayang gfe-relnote: In QUIC cwnd bootstrapping experiment, protect decreasing cwnd gain and pacing gain by gfe2_reloadable_flag_quic_conservative_cwnd_and_pacing_gains. 2019-06-03 nharper gfe-relnote: Fix appending padding in QuicPacketCreator::CreateAndSerializeStreamFrame. Protected by QUIC_VERSION_99 2019-06-03 quiche-dev Cleanup: remove unused serialized crypto config from QuartcDispatcher. 2019-06-03 renjietang Allow HttpDecoder visitor to return bool upon receiving HTTP/3 frames. 2019-06-03 fayang gfe-relnote: In QUIC, make QUIC_TOO_MANY_OUTSTANDING_SENT_PACKETS connection close detail more informative. Not protected. 2019-05-31 nharper gfe-relnote: Remove version negotiation packet tests from QuicConnectionTest; test-only change Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Icda8576a47045ae4514f0ea1733c5e76232605a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648280 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#667179}
-
Nicolás Peña Moreno authored
Bug: 942033 Change-Id: Id45597527c69c84296b67b84b26228d1207b59ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648896Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#667178}
-
Erik Chen authored
Bug: 971452 Change-Id: I980b4113a011d37af3ba2582883604cc40b87fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648736Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=lazyboy@chromium.org Change-Id: I235f4f603407ea113d949297e550d4c75dbf94ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649580 Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#667176}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=lazyboy@chromium.org Change-Id: I9696c08d614a0842e494e7fd40566d72235d85fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649509 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 970585 Change-Id: I790264b9fab0e7d88da12c737405130d6dd9f28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647960 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change introduces a couple of small fixes to the Touch To Fill feature. In particular, it breaks a circular dependency between the constructors of the TouchToFillController and the ManualFillingController and exposes the Touch to Fill feature flag to Android. Bug: 957532 Change-Id: Id1c9f227139d7b5273d1db6b0ca13a5004addf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649513 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#667173}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=marq@chromium.org Change-Id: I7db229e812286e0b9f67eafbd2a34756006c3591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649167 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#667172}
-
Ramin Halavati authored
Some minor updated regarding incognito and off the record in profile classes. Bug: 968028 Change-Id: I2e842f43a89f113f615d7c691a26a1326a7ccab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649321Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#667171}
-
Matthew Jones authored
This reverts commit d2d3af26. Reason for revert: Suspected cause of reliable non_network_service_content_browsertests failure on KitKat Phone Tester: https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29 Will reland if issues persist. Original change's description: > Fix flakly content_browsertests > > Looks like BrowserTaskExecutor is being deleted while the IO thread is > still running and thus capable of posting tasks. Also browser tests are > like prod, we shouldn't manually shut down pools and schedulers. > > Bug: 963702 > Change-Id: I1cb953acc4b495631fe269af9e06b94fbe5f2a52 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628748 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667097} TBR=sky@chromium.org,gab@chromium.org,alexclarke@chromium.org,carlscab@google.com Change-Id: I7102aa3311368724320e6490fc329c4f99f9b2d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 963702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649064Reviewed-by:
-
