- 08 Dec, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53a11922..4670e2c2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30ea9a65edbffd602b8ed24b05c0c1385779165c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578865Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834744}
-
Jonah Ryan-Davis authored
This is a reland of 07bb169a This CL moves CollectGraphicsInfoGL and DidUpdateGPUInfo calls onto the main thread, and creates a helper function GpuServiceImpl::UpdateGpuInfoGL to do so. Original change's description: > Populate secondary GPU info after GPU switch on Mac. > > The secondary GPU was not populated with information taken from GL > strings after a GPU switch. This CL addresses this by re-querying > this information each time the GPU is switched. > The active GPU in dual-GPU systems is now computed in the GPU > process and communicated back to the browser process. The > heuristic GpuDataManagerImpl::UpdateActiveGpu has been removed. > > Bug: chromium:1152212 > Change-Id: Ie54dd5dc06c3d0a1c5f0445cc0f313adc8fa24cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560552 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#832610} Bug: chromium:1152212 Bug: chromium:1154752 Change-Id: I981fcabe87d651310ba27b42a0f1e926af67cb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569953 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834743}
-
Yaron Friedman authored
Continue propagation of https://chromium-review.googlesource.com/c/chromium/src/+/2572244 and switching WebContentsObserver to use GURL. BUG=783819 Change-Id: Id081877d817e0db9c86def35f20a96d5e49d75d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577721 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#834742}
-
Basia Zimirska authored
Display translations are missing for bh (see [1]). This is the only language in the list that is missing display translation for en. [1]https://source.chromium.org/chromium/chromium/src/+/master:third_party/icu/source/data/lang/en.txt;bpv=1;bpt=0 Bug: 1006346 Change-Id: Id9e2b1aacdb9a479d2ebecdef0fe810ea6b6f1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578004Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Basia Zimirska <basiaz@google.com> Cr-Commit-Position: refs/heads/master@{#834741}
-
Alexander Surkov authored
Encapsulate AXTreeFormatter::AddDefaultFilters into tree formatter implementations; no one use AddDefaultFilters for anything but to add them to tree formatter's filter set. Bug: 1133330 Change-Id: Iff9d5cbb31a6940b0762c2f9395bd8ea8c552215 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549533Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#834740}
-
James Vecore authored
These icons were moved to shared/nearby_shared_icons.html in: https://crrev.com/c/2571804 and are not longer necessary. Bug: 1156035 Change-Id: I273180b297cf84d6ec315f2d138a2ebf09d6218b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575951 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834739}
-
Ryan Sturm authored
This is a reland of f8a44173 Patchset 1 is the previously landed version. Original change's description: > Adding more navigation-like fields to search prefetch requests > > This CL adds a few fields to the search prefetch resource request to > make it more similar to a navigation request. Additionally, this adds > capability for URLLoader throttles to defer (in this case cancel) or > change headers on the prefetch request allowing things like variation > headers to be added more similarly to how navigation requests have them > added. > > Client hints CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2551671 > > Bug: 1138648 > Change-Id: Ia868aa624b2f9f573a54432eb0fa62834eacd2f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552723 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833987} Bug: 1138648 Change-Id: I1a4fefdff4aa85095e2f9f4e567b697aaa1ca0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575435Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834738}
-
Jérôme Lebel authored
Update expiration date for the following metrics: SSORecallPromo.AccountsAvailable SSORecallPromo.PromoAction SSORecallPromo.PromoSeenCount Fix: 1140004 Change-Id: Ic030682d252ba1611861c737129602589b3886ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573103 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#834737}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67c8b0cbaef8..c205394464ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC domfc@google.com,engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: domfc@google.com,engedy@google.com Change-Id: I05af20f49799a80edce25c4cd3191ef985387d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578744Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834736}
-
kouhei authored
Bug: 1064763 Change-Id: Ie381ae081cbfe13cf7ef8468bed7a4b12391398c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578297 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#834735}
-
Dave Tapuska authored
ZoomLevel and preferences are all accessible via asking the WebView directly. Remove some dead code. BUG=1155202 Change-Id: Idece76ab891815fcd1f241c1453c876d77cc48d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572256 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834734}
-
Andres Calderon Jaramillo authored
This CL changes the size used to create the VA-API context in VaapiTest.LowQualityEncodingSetting. With 128x128, the context creation was failing on atlas, octopus, and coral. On atlas, the problematic combination was VAProfileH264Main/VAEntrypointEncSlice. I have not tracked the root cause why this resolution didn't work in the driver. As far as I can tell, 128x128 is above the minimum resolution. I even tried QVGA and it didn't work. I chose 640x368 because I expect it to be a more typical resolution. Bug: 1156313 Test: graphics.VAAPIUnittest.common on atlas Change-Id: I6d068842b7f101473a6123e2267fdb585beacc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578702 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#834733}
-
Gavin Williams authored
Adds Scan app to the list of essential apps being tracked. Bug: 1059779 Change-Id: I4042ac0e6d8c46516b4456f50eb56264984546b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575424Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834732}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607396289-70fddd0960b2020da66aa7308994f58594fe5850.profdata to chrome-win32-master-1607417661-75f85540ed87ef8a12b8b8faecb9dcd6afc972b8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie4bab96bc31560de13b95b4244dd3de82a028b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578672Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834731}
-
Yuheng Huang authored
CrSearchFieldBehavior uses a timer to delay search after user changes input. This CL overrides the behavior by not scheduling the timer in order to make search more responsive. Bug: 1099917 Change-Id: I9fabbf9d60e0b2f301ecb75539e4def16f676cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577932Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834730}
-
Sebastien Marchand authored
Bug: 1155970 Change-Id: Ib78ba3bc0cc5d6c0b03798a3f23aa699aeaa386a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578396Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#834729}
-
James Vecore authored
This is a mechanical change to move the nearby-preview Polymer component from being chrome://nearby (Poylmer3) only to being shared with chrome://os-settings (Polymer2/3). This necessary for Nearby Share's launch despite Polymer2 being phased out (the conversion won't be complete in time for M-89 launch). Bug: 1156035 Change-Id: If9a326c9646fb5c7861322e0f4c7e6a488dadb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575949 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834728}
-
Muhammad Hasan Khan authored
Move out block of code that decides the error message. BUG=b:166322619 TEST=CQ Change-Id: I0d97a9972a34d2696e8027c6216c3249688ee824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574531Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#834727}
-
adamta authored
NewTabPageViewController uses new DiscoverFeedVC as its primary view for scrolling. ContentSuggestions are set as a subview within the Discover feed, and a content inset is added so that it can act as the collection header. Bug: 1114792 Change-Id: I3e346e2de2c90c7287efdc420147e78a5acb5673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574794Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#834726}
-
Ben Kelly authored
The URL API tests use a data file that is loaded in the the test runner: https://github.com/web-platform-tests/wpt/blob/master/url/resources/urltestdata.json https://github.com/web-platform-tests/wpt/blob/master/url/url-constructor.html Purportedly this helps with other platforms that may want to implement the API maintain test parity by writing their own test runner around the data file. This seems like a good idea since we will likely need to test a polyfill in the future and it could also be used if nodejs adopts the API. This CL is roughly a direct translation of the current test cases. Bug: 1141510 Change-Id: I6cf7dea233fed7751306822738fe86ec3464368e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567178Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#834725}
-
Dominique Fauteux-Chapleau authored
TBR=engedy@chromium.org Bug: 1156634 Change-Id: I1158f342df683588d6c98d49080b798886e98034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578080Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834724}
-
Anastasiia N authored
Bug: 1148246 Change-Id: Idde4e70da6fd753f38c92566cd651e39eb15e57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561387Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#834723}
-
Asanka Herath authored
Use the Document's UkmRecorder and UkmSourceID instead of the ExecutionContext's parameters when there's a document available. This can make a difference when an element is being adoped and other lifecycle events where the ExecutionContext is not available. Bug: 1155600 Bug: 1146855 Change-Id: I5767caa9e7086fbfbffe5bc94c49aba6bbffa903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576634Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834722}
-
Juanmi Huertas authored
CanvasColorParams was not able to store or codify a RBG without Alpha. Adding a test that validates that internally CanvasColorParams codifies correctly the PixelFormat and the BufferFormat and GLData type that is associated to each pixel format. Bug: 1154359 Change-Id: I1d8150c65929187ade15894c609a42847c49d39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567978Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#834721}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a13f6847238e..4f26a81e8710 2020-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7c84426d2abe to 84b9bb6621c7 (2 revisions) 2020-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from dd69df7f3dac to c594de23cdd7 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I0cf8e4b20c2650131d6c3e73065ac4cdac1ff3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834720}
-
Evan Stade authored
InstallableManager and dependencies within //chrome/browser/installable are moved to //components/webapps/installable and placed in the webapps namespace. Bug: 1147276 Change-Id: Ie9a31783db9b8b2923589597e6c9bfdbc4681408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566341Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#834719}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607396289-b814d12d89d9aa0b6942a46cc974733f2726887a.profdata to chrome-win64-master-1607417661-b29be925ba4468c1cb5f7aba9df03f08f5d1a452.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9166047978891d867fccbd233c84feeac55c37e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578671Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834718}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c21938dd6e41..0f9bf8aa6bfe 2020-12-08 kimanh@chromium.org [e2e] Re-enable wasm scope test 2020-12-08 jacktfranklin@chromium.org Fix network category filter being reset if text filter is persisted 2020-12-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-12-08 mathias@chromium.org Remove unnecessary Clipboard API fallback 2020-12-08 alexrudenko@chromium.org Attempt at improving color swatch tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156555 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9102c6707a315a1b2171255ff38ab8d64fedd7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834717}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012080600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/KriBr9HeOCHzyZWAsh77pMzuUefJo2RwHXpOaB1sFX4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/157694064,b/164161478,b/174603791,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: I2d2227f0a63c0e75322a0766a3beaf15899ca9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578742Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834716}
-
Dominique Fauteux-Chapleau authored
TBR= engedy@chromium.org Bug: 1156626 Change-Id: Ifec907c3c058b4086765f940182cde1c48c1eb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578060 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834715}
-
Peter Marshall authored
Previously we would get the trigger_ids for enabled surveys from the finch config via a feature param. We want to enable multiple surveys within one finch group, but due to a limitation in the config format, we can't pass multiple params with the same name within one group, even if the params are for different features. Now there are two options. The existing surveys continue to receive their trigger_ids from finch. The recently introduced DevTools surveys get the trigger_id (finch: 'en_site_id') and trigger (finch: 'survey') from the chrome-side. The survey features are still disabled by default and only get turned on by finch. Bug: 1112738 Change-Id: I35abad0931f1dad13ffc6a332b533a8406a1cd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574276 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#834714}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/554e7574e960..03d69876ff0e 2020-12-08 borenet@google.com [infra] Switch from isolate to RBE-CAS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Ibb2b6ce6c1d3d19ab09662d2bff9a89758ae64ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834713}
-
Vladimir Levin authored
This patch changes the way we process style. Instead of marking style as dirty and needing to use a scoped allowed object, we skip dirtying style when being forced while in style. This happens when we're forcing a nested lock. If any of the style needs dirtying, then it will be updated via AdjustStyleRecalcChangeForChildren R=andruud@chromium.org, chrishtr@chromium.org Change-Id: I24a2f6347ea9c13cf5778c5ba029bb4de49ebff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577577Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834712}
-
Gyuyoung Kim authored
The original CL missed removing unnecessary enum conversion in Manifest's TypeCoverter::Convert(). Bug: 919392 Change-Id: I0cf7f217c9cf60a1b94c42e243d0fe04e9fa224d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577395Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#834711}
-
Antonio Gomes authored
Problem: In HTML fullscreen (eg YouTube video) the shelf slides up when the cursor is at the screen bottom. This CL fixes the problem by changing Lacros to use `ZAURA_SURFACE_FULLSCREEN_MODE_PLAIN` by default, which fixes the HTML fullscreen case, ie no shelf interaction. Then, by implementing the existing hook ImmersiveContextLacros::OnEnteringOrExitingImmersive(bool), this CL allows Lacros to react when the `immersive fullscreen` status changes, toggling ZAURA_SURFACE_FULLSCREEN_MODE_IMMERSIVE on and off on Ozone, accordingly. It enables interaction with ChromeOS' shelf widget when in immersive fullscreen is ON. BUG=1145388 R=jamescook@chromium.org, nickdiego@igalia.com, rjkroege@chromiun.org Change-Id: Ifbb6529ea9dd722a85e9c37723900ee899d5f358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575001 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#834710}
-
Benoit Lize authored
When an allocation hits the thread cache, we still need (at least for some configurations) to get the allocated size, which is the bucket slot size. This requires touching PartitionRoot::buckets[bucket_index], which is not on the same cache line as the rest of the members we access in PartitionRoot. Inline the slot size in ThreadCache, to avoid that. Bug: 998048 Change-Id: Ifad3857b4cadcecd853e7eb0e737a406dc40509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566967 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834709}
-
Polina Bondarenko authored
Wire up ArcDataSnapshotdManager::Update to arc-data-snapshotd daemon to update a UI progress bar with percent of installed required ARC apps. TEST=components_unittests BUG=b:161221001 Change-Id: Ic6bf679f70d14715bd10d747ce12a47d82116ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567004Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#834708}
-
shivanigithub authored
This is not a functional change. Resource::CanReuse() uses both GetResourceRequest() and resource_request_. This CL changes all instances in the function to use GetResourceRequest for consistency and better readability. This also makes it clear that only "const" resource request is getting used in this function. Change-Id: Iac442c4536c9be11d1bc9699b20daff8fa293999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560397 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834707}
-
Anton Bikineev authored
In order to perform a tri-arm experiment of PartitionAlloc-Everywhere and PCScan, adds a new synthetic field trial. Bug: 1121427 Change-Id: I70a1b8384cd066cea2d92000364877e965d6b82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573560 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#834706}
-
Egor Pasko authored
There are two ways to react on a failure to load the native library and create a shared RELRO region: 1. ContentChildProcessServiceDelegate tells the linker to retry "as if" not running in the browser. This is only called from a child process, hence it has no effect, except for a retry with all the same state. 2. Linker.loadLibraryWithCustomLinker() retries to load the library with isFixedAddressPermitted=false Going into fallback (1) means that loading without RELRO already failed with the fallback (2). Remove the fallback (1). This makes Linker.disableSharedRelros() unused, removing it as well. What a relief. Later the plan is to rename |mInBrowserProcess| to something like |mProvidesRelroRegion| because it will run as |true| in the app zygote. Bug: 1154224 Change-Id: I3f8ce8b454b5be34e4b21523905bda19f2570702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576255Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834705}
-