GitLab

Adds a missing EndArray() to the TaskQueue::AsValueInto introduced in r321183

Review URL: https://codereview.chromium.org/1027843002

Cr-Commit-Position: refs/heads/master@{#321588}

Arraysize was being used for destination array sizes in memcpy and
memcmp, which returns the number of elements rather than the number of
bytes, as these functions expect. The result is that the entire arrays
were not getting copied.

BUG=469151

Review URL: https://codereview.chromium.org/1028673002

Cr-Commit-Position: refs/heads/master@{#321587}

This is a step toward having color text for things like an increase in stock price (positive) and a decrease in stock value (negative).  An example would be the text shown in Answers in Suggest.

This CL is groundwork for (and separated out from) CL 795933009.

BUG=455418

Review URL: https://codereview.chromium.org/1020623002

Cr-Commit-Position: refs/heads/master@{#321586}

Makes chrome.dll on Windows not use incremental linking since the ilk files get too large.

This refactors the incremental linking configuration to make it easier to change the default.

BUG=

Review URL: https://codereview.chromium.org/1019353004

Cr-Commit-Position: refs/heads/master@{#321585}

TBR=yurys,smckay
NOTRY=true

Review URL: https://codereview.chromium.org/1022153002

Cr-Commit-Position: refs/heads/master@{#321584}

Upstreams the ios/testing directory, which contains a helper utility
for validating non-ObjC parameters in tests using OCMock.

BUG=None

Review URL: https://codereview.chromium.org/1024443002

Cr-Commit-Position: refs/heads/master@{#321583}

There is no reason to differentiate between sync/async
case. Additionally we may get rid of loading entirely, in which case
the async case would have to change.

TEST=covered by tests
BUG=468458

Review URL: https://codereview.chromium.org/1022583003

Cr-Commit-Position: refs/heads/master@{#321582}

BUG=467796

Review URL: https://codereview.chromium.org/1027463003

Cr-Commit-Position: refs/heads/master@{#321581}

BUG=469160,469166

Review URL: https://codereview.chromium.org/1024753004

Cr-Commit-Position: refs/heads/master@{#321580}

Addresses minor comments from upstreaming ios/web utility code in
a previous CL (<https://codereview.chromium.org/988383002/>)

BUG=None

Review URL: https://codereview.chromium.org/1023013002

Cr-Commit-Position: refs/heads/master@{#321579}

Review URL: https://codereview.chromium.org/1022813002

Cr-Commit-Position: refs/heads/master@{#321578}

BUG=469146

Review URL: https://codereview.chromium.org/1024913002

Cr-Commit-Position: refs/heads/master@{#321577}

Update roll-script to DEPS in the package instead of checking it
in. The new package folder lives at a new place to ensure there
are no issues when rolling back or forward from this CL. The new
location is:
//third_party/dom_distiller_js/dist.

After running `ant package`, the roll-script now takes the content
from out/package and pushes it to an external repository on
GitHub (chromium/dom-distiller-dist) and updates DEPS for
that repo to refer to the newly pushed version.

BUG=467787

Review URL: https://codereview.chromium.org/987793002

Cr-Commit-Position: refs/heads/master@{#321576}

This CL is part of new UMA upload logic. The change is for getting more usage data for Chrome users who exclusively use wireless networks. For that, a new binary on/off-switch is added instead of previous three-option model. However, the upload logic is changed on Android to reduce the data usage.

The new binary switch is also connected to a different pref then previous switch. For the beginning the new settings UI would be enabled for users assigned to experimental group.

BUG=455847

Review URL: https://codereview.chromium.org/978623002

Cr-Commit-Position: refs/heads/master@{#321575}

R=rdsmith
BUG=none

Review URL: https://codereview.chromium.org/1017743002

Cr-Commit-Position: refs/heads/master@{#321574}

This color changed recently for the toolkit-views app list, but the
Cocoa app list isn't ready for it yet.

The Cocoa-specific kHighlightedColor was only used in
apps_search_results_controller.mm, so move it there. kSelectedColor is
used there but also in apps_grid_view_item.mm. However, the latter users
a composited draw, so it's fine with the transparent background views
uses.

BUG=469051

Review URL: https://codereview.chromium.org/1023983002

Cr-Commit-Position: refs/heads/master@{#321573}

It's flaky on Win, Mac, Linux.

BUG=chromium:468660
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/1025653003

Cr-Commit-Position: refs/heads/master@{#321572}

BUG=468723
R=torne@chromium.org

Review URL: https://codereview.chromium.org/1026803002

Cr-Commit-Position: refs/heads/master@{#321571}

This CL reworks the trace generation format for the memory maps
dumper according to latest discussion in the design doc
"Memory Dumping: Mmap and Smap data dumping details"
(http://goo.gl/e6WRnQ).
Furthermore this CL changes the output format of the total dumper to
dump a hex string rather than a float, in order to be consistent with
the mmaps dumper.

See http://pastebin.com/EHdNDMXN for an example of the generated JSON.

BUG=460884

Review URL: https://codereview.chromium.org/947103003

Cr-Commit-Position: refs/heads/master@{#321570}

BUG=

Review URL: https://codereview.chromium.org/1007993003

Cr-Commit-Position: refs/heads/master@{#321569}

This was needed for one click sign in which is no longer used.

https://codereview.chromium.org/959013002/

BUG=260022, 350202

Review URL: https://codereview.chromium.org/964553002

Cr-Commit-Position: refs/heads/master@{#321568}

While investigating flakiness of JavaBridgeBasicsTest#testRemovalNotReflectedUntilReload
I realized that we don't handle invocation of injected objects' methods
properly -- InvokeMethod was bound to a GinJavaBridgeObject instance and was
making two wrong assumptions:
  - that the method can only be called for the wrapper where the method has been
    obtained from -- not true, as it is possible to use `call()` method of
    `Function` to pass a different `this` object;
  - that it is safe to store an unretained pointer to GinJavaBridgeObject --
    it's not, as it is possible to retain a function representing method
    separately from the injected object, which can be collected (if it's not a
    named object).

The issue that was causing the test flakiness originated from the fact that
DidClearWindowObject can be called several times during the page lifecycle.
GinJavaBridgeDispatcher injects new wrappers each time, this isn't a problem
on its own, but leads to premature issuing of wrapper deletion notificiations
when the wrappers of the old generation got cleaned up.

BUG=468679

Review URL: https://codereview.chromium.org/1018413002

Cr-Commit-Position: refs/heads/master@{#321567}

WebRTC 8790:8804
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/78aaaa6..0db69ce

Libjingle 8784:8804
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/628865b..1fe0de1

TBR=
BUG=

Review URL: https://codereview.chromium.org/1027763002

Cr-Commit-Position: refs/heads/master@{#321566}

When the v8.cpu_profiler tracing category is enabled
it starts generating V8Sample events with stack frames and
V8 state.

LockFreeCircularQueue template is taken from V8.

Android and Windows support will be coming.

BUG=406277

Review URL: https://codereview.chromium.org/1017063002

Cr-Commit-Position: refs/heads/master@{#321565}

This CL implements the ability to get notifications for a given Service
Worker up to the point where it hits the browser process, where there's
a NOTIMPLEMENTED() waiting for now. The browser process then replies
with an empty vector of open notifications.

The second part of the implementation depends on the Notification
Database, which is still an in-progress work.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1018613003/
  [2] This CL.
  [3] https://codereview.chromium.org/1016843002/

BUG=442143

Review URL: https://codereview.chromium.org/1014073002

Cr-Commit-Position: refs/heads/master@{#321564}

When TouchEvents are copied the base::NativeEvent of the copy is set as null for
GenericEvent types, such as touchs.

Touch Release and Cancel events are set to remove a native touch id mapping upon
destruction.

This causes copied Touch Release/Cancel events to attempt to remove a mapping on
a null native event. Leading to a crash.

I've explicitly defined a copy constructor on TouchEvent to stop copied events
from attempting to remove this mapping.

TEST=EventsXTest.CopiedTouchEventNotRemovingFromNativeMapping
BUG=467102

Review URL: https://codereview.chromium.org/1026573002

Cr-Commit-Position: refs/heads/master@{#321563}

It's flaky on Windows.

BUG=chromium:469120
TBR=gunsch@chromium.org

Review URL: https://codereview.chromium.org/1021233003

Cr-Commit-Position: refs/heads/master@{#321562}

Cr-Commit-Position: refs/heads/master@{#321561}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/68da64b..166e7b4

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1022033002

Cr-Commit-Position: refs/heads/master@{#321560}

BUG=466091

Review URL: https://codereview.chromium.org/1017183002

Cr-Commit-Position: refs/heads/master@{#321559}

It's flaky on Linux too.

BUG=chromium:469113
NOTRY=True
TBR=kaliamoorthi@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1021213003

Cr-Commit-Position: refs/heads/master@{#321558}

It seems that the first non-empty draw sometimes is missing the link that
the test is supposed to "tap". Waiting for the pixel colour to actually
change to the link colour stabilizes tests.

BUG=456782

Review URL: https://codereview.chromium.org/1026723002

Cr-Commit-Position: refs/heads/master@{#321557}

This adds unnecessary complexity since only //chrome/browser uses
the favicon components and there are no other sub-directories in
//components/favicon/core.

BUG=359513
TBR=sky@chromium.org
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1021223002

Cr-Commit-Position: refs/heads/master@{#321556}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eb476c80..bc4c36e6

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/1021243002

Cr-Commit-Position: refs/heads/master@{#321555}

- When the bread crumbs is updated, we need to keep DOMs for the common path prefix to continue the animation for touch feedback.
- Made each crumbs as <button>, so I removed the unnecessary event listener for 'keydown' in location_line.js.
- Fixed minor issue on truncation algorithm, to prevent crumbs from being too small (smaller than '...').

BUG=446616
TEST=manual test: Check the animation on touch on breadcrumbs, and Check the truncation when window width is changed.

Review URL: https://codereview.chromium.org/1026693003

Cr-Commit-Position: refs/heads/master@{#321554}

BUG=463892

Review URL: https://codereview.chromium.org/1024543003

Cr-Commit-Position: refs/heads/master@{#321553}

The GeolocationBrowserTest runs both with and without permission
bubbles. There's no need to set the permission bubble view into test
mode if the permission bubble isn't being used. This adds an if-check.

BUG=466714

Review URL: https://codereview.chromium.org/1004093004

Cr-Commit-Position: refs/heads/master@{#321552}

BUG=239141,422485,455732
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1027743002

Cr-Commit-Position: refs/heads/master@{#321551}

- Update lots of tests to check that the old and new system match.
- In the process, fix two small bugs in the new system.
- Rename PermissionsData::GetPermissionMessageStrings and GetPermissionMessageDetailsStrings to "*Legacy*", to match the corresponding methods in PermissionMessageProvider.

BUG=398257

TBR=asargent
for a trivial rename in ephemeral_app_launcher.cc

Review URL: https://codereview.chromium.org/980353003

Cr-Commit-Position: refs/heads/master@{#321550}

The new bubble replaces the old one in case the Credential Manager API is activated in chrome://flags.

BUG=400674

Review URL: https://codereview.chromium.org/1001553005

Cr-Commit-Position: refs/heads/master@{#321549}