- 27 May, 2020 40 commits
-
-
Sigurdur Asgeirsson authored
It's an eyesore that we're instantiating and describing this data on non-renderer process nodes. Bug: 1080647 Change-Id: I00ac8f6fc8732b66ffb42516c7d140113c7aa84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218556Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772396}
-
Xianzhu Wang authored
We already have the following logic which renders the original special handling of compositing of the root layer redundant: - We'll composite a LayoutView with the same rules as normal scrollers in PaintLayerScrollableArea::ComputeNeedsCompositedScrollingInternal(); - Any compositing in a frame will trigger compositing of the LayoutView and the PaintLayerCompositor. Change-Id: I15ad83095185defadb1c780a9444acfa1828bb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216858Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772395}
-
David Van Cleve authored
This CL adds metrics timing Trust Token operations, bucketed by operation type and success or failure. They record: - the duration of each Begin (outbound) operation part, and of each Finalize (inbound) part - the "server time" between the end of a Begin and the start of the corresponding Finalize; in order to bucket this by success or failure, it uses the success or failure of the subsequent Finalize part - the total duration of each operation (the time elapsed between the beginning of Begin and the end of Finalize), for operations that make it all the way to the end of Finalize R=csharrison Fixed: 1078541 Change-Id: I1e3541007616b971941aa7deef8a094f76ce3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216599Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772394}
-
Andrew Grieve authored
* Use "Short Name" as fallback for "Name" * Download files concurrently * Generate .info files concurrently * Increase thread count for CIPD * Improve logging around missing licenses (and adds a missing one) * Remove less-used (never-used?) flags * Make --update-all be the default * Always overwrite all files (crbug/1078529) * Don't clobber non-committed local modifications to BUILD.gn * Show gradle output (so it's clear things are happening) The script now runs in < 10 seconds (for a no-op) on my machine. Bug: 1078529 Change-Id: I4eefb7e1442d647854ffa6bbedbf371382fa3cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218561 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#772393}
-
Sinan Sahin authored
There is a NullPointerException in OfflineIndicatorControllerV2 that seem to be caused by a posted ConnectivityDetector#performConnectivityCheck(). While we can't repro the crash, this CL adds a call to from the Handler. It also removes any posted runnables in OfflineIndicatorControllerV2#destroy() that may otherwise cause similar issues. Bug: 1085567 Change-Id: I548dbe4b0c54d382cd9e5684f5e252565f9fc337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216388 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#772392}
-
Mike Frysinger authored
The style guide says to put spaces after colons in JSDoc types: https://google.github.io/styleguide/jsguide.html#jsdoc-whitespace Bug: 469920 Change-Id: I579fd028bd5b55419ae82adcb9de633967a6f911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209535Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#772391}
-
Olivier Li authored
The new behavior (back-end dispatches to the ThreadPool) has been the default on stable since 81.0.4028.0. This CL includes some cleanup of base::Thread specific mechanisms now that a base::Thread is never explicitly instantiated. Bug: 661143 Change-Id: I65bf7af5682025dddf99ea431e2e02f2b525b8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201876 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772390}
-
Yuly Novikov authored
TBR=kbr Bug: 1060024 Change-Id: Ifaa67a559d54df54749d387b73a89f258dfa35e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218693Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772389}
-
Lukasz Anforowicz authored
Fixed: 1087072 Change-Id: I6c88a67575e08df76849b48a338462ddc4689475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218909 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Mike Wittman authored
Moves typedefs for function types exposed by the stack_unwinder DFM into the public feature interface, and shares them across internal feature code and public module code. This enables inconsistencies in function signatures to be detected at compile time, rather than causing strange issues at runtime. Bug: 1004855 Change-Id: Ib292f53a77d4731108a7aa862c6f531c3a041189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209298 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772387}
-
cfredric authored
Bug: 973801 Change-Id: I04853197445f0a2686a7d5703d4b80287719df54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194331Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#772386}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=anqing@chromium.org Bug: 1026641 Change-Id: I89a068370f65f68feb17379b74031c7f8011f289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216734 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#772385}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 1026641 Change-Id: I96280e6c82a78a76b838b6d15d92b5b7aab42708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217207 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772384}
-
Tom Anderson authored
This CL uses the special reader/writer added by [1] to check that it's working. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2209961 BUG=1066670 R=msisov CC=sky Change-Id: I09c83827145916366f283e2bac93ed03d5db113a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212976 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#772383}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=avi@chromium.org Bug: 1026641 Change-Id: I00577ff6e5b1883bbdb62f9e2dfb95e8f8758841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215914 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772382}
-
Sujie Zhu authored
fieldtrial_testing_config Flag AutofillEnableSurfacingServerCardNickname is introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2138154/. This change is corresponding to cl/252708499. Will launch to Desktop + Mobile. Bug: 1059087 Change-Id: Iadcbe4f232fbe31e53c9950dfd65085ed974c04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210091 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#772381}
-
gogerald authored
Screenshots: Incognito mode: https://drive.google.com/file/d/1Dt28k02QOq2aB0a2Oc3VVK10ScaSfwmF/view?usp=sharing Dark mode: https://drive.google.com/file/d/1ke4Aa8DG2SQ4X77CIsxODvacEAJB2P7Y/view?usp=sharing Normal mode: https://drive.google.com/file/d/1-L4G1POaYiYSIweRxRBFrpD1QDEmRI1x/view?usp=sharing Bug: 1083853 Change-Id: I6e00a511b72c384b217a10dcbdf0e0c3c83399e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208609 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#772380}
-
Sujie Zhu authored
Previously we use IsAsciiDigit(char) to check whether nickname is valid. In i18n languages, the language scripts/alphabet are encoded in Unicode. IsAsciiDigit will mistakenly treat some i18n language scripts as digits because Ascii is encoded in 7 bits and meant for English only, while UTF-8 is encoded in minimum 8 bits. The influence of previous implementation is for some of the i18n user, we won't show nickname even if the nickname is valid (same as control group user, won't affect user experience). We use IsAsciiDigit(char16) instead, to check whether nickname contains digits. Bug: 1082013 Change-Id: I08dc77047d46225aa2f4645554e0443a800a480d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216888 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Jon Mann authored
This change fixes a few places that caused loops of updating sync: * When sync is applying an update, we now record the network id in a map and check before uploading changes from the device. Previously there was only a bit in the metadata store which tracked this, but it's not necessarily updated in time. * When the Network Details page is open and an update is applied, avoid re-saving the network from js. * When applying an update that doesn't include fields that were modified by another user, this prevents sync from overwriting the existing values (and kicking off another update). This required adding a new option to the proto to leave DNS unspecified. Bug: 966270 Change-Id: I7a89c0e97b51fbcfd8dea81499fce075a18570eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209892 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772378}
-
David Black authored
In v1, the notification title is static "Time's up". In v2, the notification title is the string representation of time remaining. Bug: b:156641714 Change-Id: Iefd3d42ed4f8c81499971d313db3fe81cc73a741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216597Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#772377}
-
Jan Wilken Dörrie authored
This change adds implementations of the range-based non-modifying sequence operations to //base/util/ranges. Furthermore, it adds implementations of required helpers such as std::invoke, std::identity, std::ranges::begin, std::ranges::end, std::ranges::equal_to and std::ranges::less. Future CLs will add overloads for the remaining algorithms. Reference: https://eel.is/c++draft/alg.nonmodifying Bug: 1071094 Change-Id: I0cab296f3937de205583408638e9be2f79473768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944358Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772376}
-
Matt Menke authored
Bug: 1065927 Change-Id: If3b9b94c5886f05646d0f8887cc8955d2ae10437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208302Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#772375}
-
Tommy Nyquist authored
TBR=arbesser@google.com Bug: 1087042 Change-Id: I002fcf0cb005d9c31e4e16fc1fecf9321c4f1dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218714Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#772374}
-
Andrew Grieve authored
Also adds distributionUrl=, which my Android Studio told me is now necessary :/ Also enables warnings via gradle.properties. Without this, I just get a warning saying: "There was a warning, but to see it you need to enable warnings". Bug: None Change-Id: I7064ee3a82666866a56d2d69e04563fb7c7e44d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216323 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Joe Mason authored
Change-Id: I29b49b538872f7f618ff5b1e08cb30526de0f453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218754 Auto-Submit: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
dpapad authored
Specifically: - cr_fingerprint_progress_arc_tests.js - cr_icon_button_focus_tests.js - cr_icon_button_tests.js Bug: 1000989 Change-Id: I46baa47a8019b4434ea52e62a8bf89475fbdef08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217033 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#772371}
-
dpapad authored
Previously top-level properties like chrome.runtime.id or chrome.runtime.lastError where ignored by js_externs_generator.py and were not reflected in the generated JS externs files. Fixed: 1085641 Change-Id: I6a5719830f5c0945ca0b26c5c347bd3341b379c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213205 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#772370}
-
Elly Fong-Jones authored
This reverts commit 4da2944a. Reason for revert: Turns out the fence *was* there for a reason! https://bugs.chromium.org/p/chromium/issues/detail?id=1085578#c10 Original change's description: > Mac: Don't check for window switches in CommandDispatcher > > This code dates back from 2010 and doesn't accurately describe how full > screen works now. > > Bug: None > Change-Id: I25a1ef21845251c432e6512fb5d55791d696bded > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171440 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#763843} TBR=ellyjones@chromium.org,rsesek@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I297a6d5c6661453e6024b231fbcf34f6a5eb1692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218851Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#772369}
-
James Long authored
Added a new class that takes a JavaClassDependencyGraph as input and groups the classes into their packages, forming a less granular package-level dependency graph. Unit tests are included. To allow for this change, functionality was added to the Graph class to fetch a list of nodes and edges. Unit tests are included for this as well. Bug: 1081889 Change-Id: I6ff39a68945d7907afbbf6d58a6cb885fafcaba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213408 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#772368}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I473623338fee3277cb905b17151f80a6468ebb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213107Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/609c36d7e6ea..73cea9cfd9c1 2020-05-27 treehugger-gerrit@google.com Merge "Read boost frequencies" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I826e5acbba866e8a4ccd116e95e899480881dff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772366}
-
Sandeep Vijayasekar authored
Revert of https://chromium-review.googlesource.com/c/chromium/src/+/2145870 Bug: internal 154522981 Test: build cast Change-Id: I4821a920f40e468e28e556985108412199ea0fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218670Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@google.com> Auto-Submit: Sandeep Vijayasekar <sandv@google.com> Cr-Commit-Position: refs/heads/master@{#772365}
-
Dominic Mazzoni authored
The goal is that when we enable kEnableAccessibilityExposeHTMLElement, relatively few tests will be affected. In this tests, there was an assumption about nodes being an immediate child of the root element. Bug: 1063155 Change-Id: I4b6388e5529e1b39cf67881b4830192363106b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206338 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#772364}
-
Peter Wen authored
Ignore setText not being translated for test code. Tbr: Suppressing existing errors to fix build. Notry: true Bug: 1082743 Change-Id: I7de995b0d6cdc0bba867d9064d7daf245d7837bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218910Reviewed-by:
-
Tommy Nyquist authored
This reverts commit 9a7c97d5. Reason for revert: Now failing lint because of https://chromium.googlesource.com/chromium/src/+/7b39bed1b5c6d5adc3e470f0d936079cf15680b0 Original change's description: > Add nickname field to local card editor and new instrumentation tests. > > The field is flag protected and this is only a UI change, so setting the > nickname won't set the nickname in the database. Will follow up with a CL > that updates it in the database. > > Screencast: https://drive.google.com/file/d/1aIMedpnwlWtJ1YKNT0cpRCowuhDOnNRq/view?usp=sharing > (Googlers only) > > Bug: 1082013 > Change-Id: Ib26a67c858da4388563e4ba241604517a5e7fde8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213341 > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: sebsg <sebsg@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Siddharth Shah <siashah@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772310} TBR=twellington@chromium.org,sebsg@chromium.org,jsaul@google.com,siashah@chromium.org Change-Id: Ie04f8b35826b4cc9c92ec07156d5c893bcf3e970 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218722Reviewed-by:
-
Leonard Grey authored
This reverts commit 8f6be972. Reason for revert: [Sheriff] Failing on several bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/103319 https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/38321 Original change's description: > Add LayoutShiftTrackerSimTest.OOPIFSubframeWeighting test. > > > BUG=943668 > > Change-Id: I0157278fa1b7f8f5a0358e8811f21d4be1dd990c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208026 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772334} TBR=sullivan@chromium.org,skobes@chromium.org Change-Id: I27217d484c55a52e9aab52c95dbd053f44fb12b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218908Reviewed-by:
-
Joel Fernandes authored
The coresched prctl interface is subject to change based on upstream discussions. Add a TODO as a code comment. Signed-off-by:
Joel Fernandes <joelaf@google.com> Change-Id: I664d0b5815dc4d7fe3bed259474b76635aa992af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216799Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#772360}
-
liberato@chromium.org authored
Bug: 1072667 Change-Id: I4d7fa88313f452c4f1720ba235916f1c54829354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207480 Auto-Submit: Frank Liberato <liberato@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Brian Geffon authored
We shouldn't log errors for CrOS specific behavior when run on linux-chromeos. Bug: 1085453 Change-Id: Ibc0bf32a2fd6488eee224a9efd796a7114d51bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216378Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Mike Wittman authored
This is a reland of 01b9624c This is now safe to reland with the fix in https://crrev.com/772300. Original change's description: > [Sampling profiler] Provide unwinder in stack_unwinder DFM > > Implements the Android native/Java stack unwinder within the stack_unwinder > dynamic feature module. > > Adds visibility/assert_no_deps constraints to //base/BUILD.gn to avoid > leaking module implementation types into general Chrome code, which > would defeat the purpose of using the module to avoid Chrome binary size > increase. > > Adds required stub declarations/implementation for MemoryRegionsMap. > > Bug: 1083530, 1004855 > Change-Id: If9d31c4e1b9d214bb0baabe3afa8475ba7adef4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209297 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Auto-Submit: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771018} TBR=etiennep@chromium.org,kylechar@chromium.org Bug: 1083530, 1004855 Change-Id: I7c889d39cd7ae08c2dec9128a31742c2ff9525f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218669Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#772357}
-
