- 17 Apr, 2019 40 commits
-
-
Aaron Leventhal authored
For some reason this fixes the crash, although the other layout checks in NativeRoleIgnoringAria() seem to be ok. Bug: 945286 Change-Id: I2b2f9450a5a2e98f4a8c34169d86ef54aff74a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570820Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#651787}
-
Drew Stonebraker authored
Change the characters that get written to the chrome_versions.txt output file so that it can be read by the parser Omaha uses. Bug: 953059 Change-Id: I219dd2360cacf6d9bed2316478d86e733c4dcb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570699Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#651786}
-
Becky Zhou authored
+ Hold InfoBarContainer in activity context - Not instantiating InfoBarContainer until tab is attached - Close all infobars before destroy - Clear Java side InfoBar object when closing InfoBar - Add icon drawable tint + Fix a number of leaks - Tablet and top toolbar HomeButton holding on to HomepageManager Observer - ReaderModeManager delegate holding activity implicitly on native - BottomSheetController holding VrModeObserver - InputMethodManagerWrapperImpl holding activity Bug: 934577, 934909, 934908 Change-Id: I73ddff2549a921bfff37897bb7aff5622471c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540080 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#651785}
-
Esmael El-Moslimany authored
Bug: 736891 Change-Id: I9d53d847850288638a1fff51e348cfbcd3b64705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570540Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#651784}
-
Mohamed Amir Yosef authored
Many fixes have landed since this test was disabled. It's therefore worth giving it a try and enable it again. Bug: 889505 Change-Id: Iedf8ae64a002ea508f8304c67248c68d5e88cd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572339Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#651783}
-
Marijn Kruisselbrink authored
Change-Id: I39b60fb4607ee1e6b1987abf89c4f9e39a90d181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564586 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#651782}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58da6c5b..fd3e5e3a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I96320a2bf1f746f57475af0cee622c31ef527fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572223Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651781}
-
Thomas Tangl authored
Bug: 811351 Change-Id: I60104b8ec57aa86a8472bab631ca61c5d011d7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565989 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#651780}
-
Min Chen authored
Bug: 937907 Change-Id: I4341c58bc0f0dc22938d4e58711827b033ec1965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565627 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#651779}
-
Etienne Pierre-doray authored
Looks like it's now flaky on several Linux and Win10 bots as well. TBR=masonfreed@chromium.org Bug: 953725 Change-Id: I28513be624f25dd9a04c2f4864a545d2d6f5d946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570913Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#651778}
-
Timothy Loh authored
Bug: 950431 Change-Id: Ic7ddbefa4be3644bd088a2d19e1bdb698e60326a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571121 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#651777}
-
Tony de Luna authored
This cl moves sync consent tests to the normal chromium build target. Made fixes to the sync consent tests: * Added FakeGaia mixin to allow the call to ShowSigninScreenForTest to complete. * Updated the OOBE JS API call for updating language locale. * SyncConsentPolicyDisableTest now waits for user session to start because OOBE flow can finish before the Waiter started, causing the Waiter to wait forever. Moved the is_official_build_ flag in WizardController to static scope because a new WizardController instance is created as part of the login flow. This meant that setting is_official_build_ to true during the test would be overriden when the new WizardController instace is created. Added a helper function ForceOfficialBulidForTesting to WizardController that temporarily overrides is_official_build_ during the execution of a test. Removes some WizardController friend classes that only needed access to the private is_official_build_ flag. TBR=antrim@chromium.org Bug: 952388 Change-Id: I5bd87ef4a21b4a265bdde94656fc2380c770473a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570215 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#651776}
-
Etienne Pierre-doray authored
This is a reland of 328f5578 Issue was: When run_policy is changed during execution of GetWork() under lock, it is possible that the DCHECK GetNumAwakeWorkersLockRequired() > GetDesiredNumAwakeWorkersLockRequired() triggers. Fix: The DCHECK was a sanity check based on an assumption no longer true, so remove DCHECK. TestCanRunPolicyLoad was improve to always trigger the DCHECK when present. GetDesiredNumAwakeWorkersLockRequired() was also modified to always return at least the number of workers currently running a task. Fix: GetDesiredNumAwakeWorkersLockRequired returns at least num_running_tasks_. Original change's description: > Reland "[TaskScheduler]: Simplify sequence preemption logic." > > This is a reland of 5d4c05db > > Problem: PlatformNativeWorkerPool::RunNextSequenceImpl expects sequence > returned from GetWork() to be non-null and DCHECK. > Solution: Handle null sequences by skipping RunAndPopNextTask. > > Original change's description: > > [TaskScheduler]: Simplify sequence preemption logic. > > > > This CL removes preempted sequences from TaskTracker, > > removing need for CanScheduleSequenceObserver and > > simplifying shutdown. > > A CanRunPolicy enum is used instead, specifying whether > > or not tasks at a given priority can run. > > When CanRunPolicy is updated, wakeup workers needs > > to be done as appropriate. > > > > In addition, Shutdown was split in 2 phases start + complete > > to allow caller (TaskScheduler) to update CanRunPolicy after > > shutdown was started. > > > > This CL was recycled from: > > https://chromium-review.googlesource.com/c/chromium/src/+/1478007 > > I took ownership because simplifying Sequence lifecycle > > will simplify implementation of job API. > > > > TBR=gab@chromium.org > > > > Bug: 889029 > > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161 > > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648346} > > Bug: 889029, 950383 > Change-Id: I1f64517d312e65fb59ae235373b4f4d504da87dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557861 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649399} Bug: 889029, 950383 Change-Id: I306bf7119034fcd3b917946f1f561344374bb718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564791Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
-
Matt Mueller authored
This is significantly faster (about 80x in some quick testing). Also remove the now unused x509_util_mac IsSelfSigned function. Bug: 410574 Change-Id: I60cfc40d5f5a5dab419566836555cb4828148c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570768Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#651774}
-
Ehsan Karamad authored
The CL implements a new feature policy hidden behind the flag FeaturePolicyForSandbox. The policy is the feature policy counterpart to the sandbox flag 'allow-downloads-without-user-activation'. This policy is used to help migrate sandbox flags implementation on top of feature policies. PA: https://github.com/w3c/webappsec-feature-policy/issues/289 TBR=alexmos@chromium.org Bug: 812381 Change-Id: I234bb0486313ab350827315843db22525c2ceaac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538966Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#651773}
-
Reilly Grant authored
In Android Q calling UsbDevice.getSerialNumber() when the calling application does not have permission to access the device will throw a SecurityException. Bug: 952956 Change-Id: I2c335f39b528ea0e72eede46f98291d21bfe284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571005 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651772}
-
Bo Liu authored
Submit this after all bots have generated new reference images for these tests. Bug: 899399 Change-Id: Ib3a48a5955796e9e3638b11a6176bb8e935ebfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568387 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651771}
-
Nate Chapin authored
Bug: 914587 Change-Id: Ic851c6ad1d8e78af40f6bb8df3d310ed5c472e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570232Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#651770}
-
Ben Pastene authored
This will hopefully increase the chance of a test flake on the fyi bot so I can test out the failure reporting changes I'm making. Bug: 923426 Change-Id: Ibfda3b2af9f9240cfc72c5544ff56dfc2aa5c6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572259 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#651769}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/20a716319262..3b2c6bfd4353 git log 20a716319262..3b2c6bfd4353 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 spang@chromium.org Vulkan: Implement glImportMemoryFdEXT Created with: gclient setdep -r src/third_party/angle@3b2c6bfd4353 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I98284c36d5ea84dc173255081b7acb0ff1f6d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651768}
-
Huanzhong Huang authored
Reserve the space needed for an accessory view in each CBD items, so that text labels don't reach the far right end of a cell, and therefore cell selection doesn't result in text label width shrinkage. Bug: 935346 Change-Id: I6c13d82c3eb45555710447040de49550410650a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571411 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#651767}
-
Carlos Caballero authored
Currently WorkerThreads have a SequenceManager on top of the MessageLoop provided by base::Thread. This patch removes that duplication which was also causing a test to flake. There is really no need to use base::Thread, moreover it makes it hard hard to trigger shutdown and to make sure that initialization and destruction happen on the worker thread. So to have better control we use a base::SimpleThread instead. This patch has the small side effect that the thread name of WorkerThreads has now the tid as a suffix (imposed by the SimpleThread api). Bug: 934088 Change-Id: Ib771a5e2c756a0e8a02e6eed00a78da5d794e633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552812 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#651766}
-
Chris Hamilton authored
A policy message arriving on the UI thread may be bound to a contents that no longer exists, but in some cases the contents may still exist but have been renavigated. The LastNavigationId allows dropping policy messages that are only relevant to a particular navigation. This helps in migrating users of PSG/PSR/PSO away from that functionality. BUG=931407 Change-Id: I9182bd8fb558ff27d1a70917159d5eef4b99ccef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571008 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651765}
-
Jonathan Backer authored
This reverts commit a67d4d6f. Bug: 953476 Change-Id: I26daaa894110219d2f35573d4f0c520deade9245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572219Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651764}
-
Alan Wink authored
Bug: 935032 Change-Id: Ifebd7227120d90b9388fd9491b9a307a82a0991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571545Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Alan Wink <alanwink@chromium.org> Cr-Commit-Position: refs/heads/master@{#651763}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8e2440d06f5a..d1fff586eae3 git log 8e2440d06f5a..d1fff586eae3 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 amaiorano@google.com Fix 2D texture image functions not returning GL_INVALID_ENUM with target == GL_TEXTURE_3D Created with: gclient setdep -r src/third_party/swiftshader@d1fff586eae3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/116827965 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I2e5c4cbe6154e0df18fdbd175637c2c05832c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571527Reviewed-by:
-
Steven Bennetts authored
This also includes removal of unnecessary includes of dbus_thread_manager.h and improved DEPS restrictions. Bug: 951017 Change-Id: I5f75b3b01423a1a69e5929561bcc95b95a4e612c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560444 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The TODO reference a bug that is marked as fixed, so remove it assuming it is now obsolete (the bug was targetting M-42). Bug: 416823 Change-Id: I354df401da061e7ca188c99426f3d5891edbf9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569714Reviewed-by:
-
Jordan Demeulenaere authored
Screenshots: * https://screenshot.googleplex.com/dvVs0G3rN9N.png * https://screenshot.googleplex.com/QL1OL5toepz.png * https://screenshot.googleplex.com/F62S8zJT6JK.png Bug: 944056 Binary-Size: Adding assets for the Autofill Assistant feature which will be in a DFM for M75 Change-Id: Ia97102ca0cbb5fc55bd184fc57ee67a74b02ac96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552874 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#651759}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c1d1c4af. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" c1940432 "[WPT/common/security-features] Merge subresource path construction" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I066890bba89d18e4495445fe1145ed2fea7fa631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571487Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651758}
-
Mohamed Amir Yosef authored
Before this CL: There was a one global Boolean to signal if there are persisted FCM messages. But messages are replayed per subscription upon registration, so it's in efficient to keep one global flag. After this CL: This is replaced with a set of subscription ids that have persisted messages. Bug: 946486 Change-Id: I36836d224561568b84472786d0828e4dd40531fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569936 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#651757}
-
Ken Rockot authored
This reverts commit ef070420. Reason for revert: Circular refs leaking MessagePipeDispatcher instances. Also, abandoning the effort to remove associated interfaces for now: https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit#heading=h.csbpv04y875v Original change's description: > Reland "[mojo-core] Support pipe splicing" > > This is a reland of afff956d > > Fixes some trivial uninitialized value bugs only caught by MSAN after > landing. PS1 is the original CL, PS2 is the diff which fixes the bugs. > > Original change's description: > > [mojo-core] Support pipe splicing > > > > This change allows message pipes to be "spliced" into other message > > pipes, unifying their message queues while retaining their logical > > independence for routing of written messages. > > > > This is supported by adding an array of per-handle options and flags to > > MojoAppendMessageDataOptions. If a handle is marked with > > MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, > > sending that message will effectively cause the handle and its peer to > > be spliced into the sending pipe. > > > > See bug for design doc link. > > > > Bug: 941809 > > Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648579} > > Bug: 941809 > Change-Id: Ia66fa98810fae88023c71b50e5b6fd3862c4474e > TBR: oksamyt@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558190 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#648743} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941809,950454,951085,950983 Change-Id: I84ec6a14f0b1dccbb213ff9426c96af061c274a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570704Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#651756}
-
Avery Musbach authored
Before the present CL, the bounds of the dragged overview item are outset horizontally by 4% of the width, and vertically by 4% of the height. The outset in each dimension is on both sides, for a total of an 8% increase in size along that dimension. According to the specification, it should be 10%: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html Test: manual Bug: 953519 Change-Id: Iea690ebc851bcc6fb573fd66d91f26a7a4d92bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570692Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#651755}
-
Peter Kasting authored
These functions are deprecated. Where we can't map the existing functionality to algorithms, they're being replaced by range-based for, iterators, etc. In the cases in this CL, the underlying functionality maps to STL algorithms, so make use of them; this provides the most high-level description of the intent of the code, and in many cases can be simplified further in C++20 with ranges. See also https://sean-parent.stlab.cc/presentations/2013-09-11-cpp-seasoning/cpp-seasoning.pdf for arguments against loops (range-based or otherwise). Bug: 940135 Change-Id: Ic4ef8a9fd6840645180472828e91306414bb795b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565507Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0527c9db8148..805b09f92203 git log 0527c9db8148..805b09f92203 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 johnkslang@users.noreply.github.com Merge pull request #1753 from pixeljetstream/ckubischnv_dumpbuiltins Created with: gclient setdep -r src/third_party/glslang/src@805b09f92203 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I722e69057f6d83dd1998a878972d4bec1306289f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572179Reviewed-by:
-
Richard Knoll authored
This updates the relative time shown in non-native MD notifications as time goes by. Bug: 910089 Change-Id: Ie403c6b00c2f3b5508a5ed63d19d1b650787f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547518Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
jonross authored
A regression lead to viz::SkiaOutputDeviceVulkan::UpdateDrawSurface crashing. This has since been fixed (crbug.com/952231). This combined with falling back to GL Renderer was leading to the test only having flaky failures. We have recently added a testing flag to prevent this false positive: "--disable-vulkan-fallback-to-gl-for-testing" which this change adds to the tests. So that we reliably catch failures going forward. This change also re-enables AuraWindowVideoCaptureDeviceBrowserTest.ErrorsOutIfWindowHasGoneBeforeDeviceStart which was failing due to crbug.com/948249 which has since been fixed. This change also removes the test exceptions for vulkan_content_browsertests aside from TSAN and Intel HD 630, which are failing for other reasons TEST=vulkan_content_browsertests Bug: 940723, 930943 Change-Id: Id187c41718a91b4401db9ff2549d6556d1820c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568088 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Lily Chen authored
Force callers to specify a SameSite mode instead of relying on defaults which may be subject to change. Also removes blink::WebCanonicalCookie::kDefaultSameSiteMode. Bug: 953306 Change-Id: Iaea2224a28a169804048ad9f765e811374a9836f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567955Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#651750}
-
Gauthier Ambard authored
This CL adds a separator between the two toolbars and the content on the screen. Bug: 912963 Change-Id: I1a386c5ffb1cbe9cdbfd25000df7adcd5b00f4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571417 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#651749}
-
Mike Wittman authored
Update the expectation to match the wait_until_unloaded case. This should have been updated along with that case in http://crrev.com/645138 but was overlooked. Bug: 953714 Change-Id: I168f6690fdb32081930cae0c1ae57021219d471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572221 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651748}
-
