GitLab

The comments were not updated when the code changed, so they were
confusing.

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/138133015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248625 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves files that depend on the now-componentized data_type_controller.h
and data_type_manager.h into the sync_driver component. For the most part these
files are moved as-is. The only exception is sync_model_association_manager,
which had a DCHECK about being on BrowserThread::UI; this DCHECK is removed.

BUG=339726
TBR=joi

Review URL: https://codereview.chromium.org/133503011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248621 0039d316-1c4b-4281-b951-d872f2087c98

to ShelfID, ShelfItem and ShelfItems.


BUG=248353
TEST=None
R=jamescook@chromium.org,harrym@chromium.org

Review URL: https://codereview.chromium.org/152223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248619 0039d316-1c4b-4281-b951-d872f2087c98

For the error case:
- Hide the "You're now signed in to Chrome" title.
- Change "OK, got it!" to just "OK"

XIB changes:
- Connected the close (OK) button to the closeButton_ outlet, which was for some reason missing before.

Screenshots (disregard text of errors; samples were used):
- Mac: http://i.imgur.com/hPDAY8i.png
- Views: http://i.imgur.com/ZM9ktga.png
BUG=333988

Review URL: https://codereview.chromium.org/137563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248617 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a fix needed for Telemetry's --netsim option.

BUG=
TBR=slamm@chromium.org

Review URL: https://codereview.chromium.org/131453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248616 0039d316-1c4b-4281-b951-d872f2087c98

R=aedla@chromium.org
BUG=

Review URL: https://codereview.chromium.org/147533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248615 0039d316-1c4b-4281-b951-d872f2087c98

MemorySanitizer is confused by assembly code.

BUG=178409
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/139783016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248614 0039d316-1c4b-4281-b951-d872f2087c98

Update WebNode::getElementsByTagName() callers to use a WebNodeCollection
instead of a WebNodeList. The WebNode::getElementsByTagName() public API was
updated in Blink r166263 to return a WebNodeCollection instead of a
WebNodeList.

Callers need to be updated so that we can get rid of the current workaround
allowing a WebNodeList to be implicitly converted into a WebNodeCollection.

BUG=235008

Review URL: https://codereview.chromium.org/152133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248613 0039d316-1c4b-4281-b951-d872f2087c98

gpu::Mailbox by itself can hold only a texture id, but in common usage it comes
with texture target and syncpoint information for cross-context sharing.  To
reduce repetition of this pattern, gpu::MailboxHolder holds:

* a gpu::Mailbox
* a GL texture target
* a syncpoint index

Refactor other classes to use a gpu::MailboxHolder instead of separate
gpu::Mailbox and associated state.

Syncpoints are created with uint32 indices; make sure all uses of syncpoints
use the appropriate type.

BUG=None
TEST=local build, unittests on CrOS snow, desktop Linux
TBR=piman@chromium.org, enn@chromium.orge, cevans@chromium.org, scherkus@chromium.org

Review URL: https://codereview.chromium.org/132233041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248612 0039d316-1c4b-4281-b951-d872f2087c98

For reasons described in crbug.com/338016, I changed my mind on explicit
time tracking.  This is an attempt to clean up my mistake.

This new approach has the NudgeTracker keep track of the time when the
next retry GU is scheduled, and a flag that is set to true when we
should perform a retry GU at the next possible opportunity.  Before a
sync cycle, the NudgeTracker is provided with a TimeTicks::Now() value
and asked to update the flag accordingly.

This does a better job of ensuring the value of
NudgeTracker::IsRetryRequired() is consistent.  After this CL, we can
guarantee that its value will be the same before, during, and after the
sync cycle.  The previous implementation relied on a call to
TimeTicks::Now() in download.cc, so it did not have this property.

There is one tricky part to this patch.  We need to be careful that we
the call to RecordSuccessfulSyncCycle() after a sync cycle does not
overwrite pending retry state that may have been set by that sync
cycle's SyncSessionDelegate::OnReceivedRetryDelay() function.  To avoid
that problem, we store the value from that call in the SyncScheduler and
act on it only after we've updated the NudgeTracker's state when the
sync cycle is complete.

BUG=338016

Review URL: https://codereview.chromium.org/146113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248611 0039d316-1c4b-4281-b951-d872f2087c98

- the old profile button was too keen to update when the ProfileInfoCache
changed, and updated the incognito icon to the profile's avatar
- using the new avatar button, too many tabs overlapped the button
- leftover refactoring to do from https://codereview.chromium.org/117533002/

BUG=340246

Review URL: https://codereview.chromium.org/139343016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248610 0039d316-1c4b-4281-b951-d872f2087c98

With the addition of Linux support for rich notifications, we can turn on
Google Now for all desktop platforms.

BUG=164227
R=skare@chromium.org

Review URL: https://codereview.chromium.org/147273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309844

Review URL: https://codereview.chromium.org/147273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/145913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248606 0039d316-1c4b-4281-b951-d872f2087c98

Executable bits are wonky on Windows, so checking them doesn't get us anything
and incorrectly disallows uploading of, e.g., python scripts.

R=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/142973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248605 0039d316-1c4b-4281-b951-d872f2087c98

Now when NPAPI plugin is not present the host setup wizard detects
when the host is not installed and asks the user to install it.

BUG=339626

Review URL: https://codereview.chromium.org/132793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/150163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334379

Review URL: https://codereview.chromium.org/153083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248600 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue around field alignment when the dialog displays
scroll bars. Previous scroll would not only display the currently
active field, but also scroll the entire view 15 pixels to the side,
thus truncating the left edge. Since the scroll view is meant to scroll
only in y-direction, this simply forces the X coordinate to 0.

BUG=332678
R=estade@chromium.org

Review URL: https://codereview.chromium.org/141813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248599 0039d316-1c4b-4281-b951-d872f2087c98

The current height of the feedback page is causing the bottom of the page to get pushed off the boundary on certain screen sizes. The problem is now worse on other platforms due to the System Information link also being available there. Decrease some of the unnecessary padding on the feedback page to make sure it fits on the screens of machines with smaller displays.

R=xiyuan@chromium.org
BUG=334235

Review URL: https://codereview.chromium.org/151873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248598 0039d316-1c4b-4281-b951-d872f2087c98

I somehow forgot to change the style of this constant along with the
others way back when (in the original commit r233638).

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/133213012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=existing
R=darin@chromium.org, darin

Review URL: https://codereview.chromium.org/135683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248596 0039d316-1c4b-4281-b951-d872f2087c98

Also untangle clearView implementation from picture listener enabled.
Add some comments and removed some error logs.

BUG=

Review URL: https://codereview.chromium.org/136753015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248595 0039d316-1c4b-4281-b951-d872f2087c98

Previously, I had only checked that you can't write a message with a
handle to itself. I also need to check that you can't write the handle's
"peer" to the handle (which is actually worse).

R=darin@chromium.org

Review URL: https://codereview.chromium.org/145483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336793
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/149213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248593 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates the forwarding that PasswordManagerDelegateImpl was
previously doing to ContentPasswordManagerDriver. Instead,
PasswordManagerDelegate has a new GetDriver() method that returns the
PasswordManagerDriver that the core PasswordManager code should use. Tests are
updated to reflect this change.

BUG=335096

Review URL: https://codereview.chromium.org/152693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248592 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248591 0039d316-1c4b-4281-b951-d872f2087c98

Both 3.4 and 3.8 kernels for Exynos have supported setting the GSC alpha
component through V4L2_CID_ALPHA_COMPONENT for some time now.  Remove the
V4L2_CID_GLOBAL_ALPHA workaround path.

BUG=326590
TEST=local build, run on exynos

Review URL: https://codereview.chromium.org/147793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248590 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=166316:166323&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/150413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248589 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves ChromeOS specific logging from MetricsLog
to MetricsLogChromeOS.

BUG=339100

Review URL: https://codereview.chromium.org/146913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248588 0039d316-1c4b-4281-b951-d872f2087c98

- Handle devices without an "AndroidCAStore" KeyStore. Add a histogram to
  record when this happens.
- Remove resolved TODO.
- Unnecessary exception check (relevant function already CalledByNative, not
  CalledByNativeUnchecked)

BUG=116838
TEST=none

Review URL: https://codereview.chromium.org/144153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248587 0039d316-1c4b-4281-b951-d872f2087c98

Not all versions of Windows 7 and later ship with Media Foundation DLLs. Instead of crashing while attempting to delay load the DLL, preemptively load the library and fail gracefully if we're unable to do so.

BUG=339678

Review URL: https://codereview.chromium.org/151993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248586 0039d316-1c4b-4281-b951-d872f2087c98

Accept "into the public domain" as well as "in the public domain"
as indication of a public domain license.

NOTRY=true

Review URL: https://codereview.chromium.org/151883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248584 0039d316-1c4b-4281-b951-d872f2087c98

Add a PrivetDeviceResolver that resolves a device and parses its TXT record
based on the Privet protocol.

BUG=

Review URL: https://codereview.chromium.org/131503013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248583 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297132

Review URL: https://codereview.chromium.org/150783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248582 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
- Uses smaller assets for drawing the phantom window. This decreases the minimum size that a phantom window can be drawn at and still look good (i.e. the left and right corner assets do not overlap)
- Enforces a minimum size for the phantom window

BUG=335443
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/147103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248581 0039d316-1c4b-4281-b951-d872f2087c98

ProxyMessagePipeEndpoint::EnqueueMessage() needs to look at each handle
(i.e., dispatcher) and decide what to do.

This CL doesn't actually do anything yet exactly. I also need to check
(at a higher level) that we're not sending the peer handle over a given
handle, hence I'm splitting out this part now (since that work will
touch on the same things as this).

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/145483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320082
R=darin@chromium.org

Review URL: https://codereview.chromium.org/139613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248579 0039d316-1c4b-4281-b951-d872f2087c98

See https://bugzilla.mozilla.org/show_bug.cgi?id=966060

BUG=none

Review URL: https://codereview.chromium.org/152973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248578 0039d316-1c4b-4281-b951-d872f2087c98