- 16 Jan, 2020 40 commits
-
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (the tab-indexable elements are cycled through in order) when Quick View is displaying a audio file in its content panel. Tab past the content panel to skip over checking the focus on the content webview/audio: these can have multiple internal elements that can take the focus and our test should be independent of that. Bug: 907380 Change-Id: Ifd8b298865c05cbfcc318e63b0d701fb6ca8f7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004171Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Rachel Sugrono <rsugrono@google.com> Cr-Commit-Position: refs/heads/master@{#732260}
-
Alexandre Courbot authored
When the resolution changes, we recreate the image processor device entirely. However we used to do so while reusing the same V4L2Device instance, which is not supported and triggers a DCHECK() with Debug builds. This behavior is wrong anyway since we might want to use another image processor device with the new resolution. This also seems to be effective in fixing bug 1029396. BUG=chromium:1029396 TEST=video.DecodeAccel.h264_resolution_switch passes 100 times in a row on Hana. TEST=video.DecodeAccel.h264_resolution_switch passes on Hana without triggering DCHECK(). Change-Id: Ib506d9f038810a0683b806f8385746dce16ecd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002250 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732259}
-
Peter Boström authored
Fixes regression in r728281. The code started assuming that a BrowserActionsContainer always existed, this is not true for windows without a tab strip. Bug: chromium:1042419 Change-Id: Ia69257972ebe08d58a878722a42821730ebcc7b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003220 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#732258}
-
Dan Beam authored
CL generated with: $ git ls-files 'chrome/renderer/*.js' | xargs grep -l -P ' [!=]= (?!null)' | xargs perl -p -i -e 's/ ([!=])= (?!null)/ \1== /g' Bug: 720034 Change-Id: I64e170031fdd2087dd3adf50276228fbfaf6fd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003917 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732257}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6de271cd0349c33500203d3d4d87d2600932bbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003084Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732256}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1041419 Change-Id: Ied9d082ee57276d5b82983e6b42ee7914dea9eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998672 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732255}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ntfschr@chromium.org Bug: 1041419 Change-Id: I24f1a8ce0a32854fad3be2f645dd801f20e583ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998381 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732254}
-
Tom Anderson authored
The test should hopefully no longer be flaky after 0896c15f. R=atwilson Change-Id: I643298557d70d3b48163f7ba232ae5c31f0cb039 Bug: 701023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003613 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#732253}
-
Meredith Lane authored
This reverts commit 143d21fd. Reason for revert: Deterministically fails gfx_unittests on Mac 10.12 First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31106 Original change's description: > Remove ignorable codepoints for FontFallback > > Default ignorable codepoints should not be considered for > choosing a fallback font. > > see: > http://www.unicode.org/L2/L2002/02368-default-ignorable.pdf > """ > Default-ignorable codepoints are those that should be ignored > by default in rendering (unless explicitly supported). They have > no visible glyph or advance width in and of themselves, although > they may affect the display, positioning, or adornment of > adjacent or surrounding characters. > """ > > The API used to determine fallback fonts on Mac is > CTFontCreateForString(...) > 1) This API can returns .LastResort for an unknown text. > We observed this behavior with Emoji (e.g. regional flags). > see: > https://unicode.org/policies/lastresortfont_eula.html > > 2) The API is not able to match default ignorable codepoints > like ZWJ and NZWJ. GetFallbackFont(...) was failing when > an ignorable codepoints is present and the expensive > GetFallbackFonts(...) is used instead. > > > Bug: 1036652 > Change-Id: I12a81a0130b072f662547abd0d82f73c24a7b20d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995501 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732133} TBR=robliao@chromium.org,drott@chromium.org,etienneb@chromium.org Change-Id: I5c9fa4078a1519fc044536befd5d8a6ed0ea2604 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1036652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004168Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732252}
-
Matt Jones authored
Bug: 1041090 Change-Id: I7eb2c11717bfff33c98db123d511f8b867fc8961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003572 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732251}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=rbyers@chromium.org Bug: 1041419 Change-Id: Ibabc077d7f35f4e25d9c0c30964bc5cf9cf5be0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998790 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732250}
-
Kyle Horimoto authored
Now contains cr_components/chromeos and cr_elements/chromeos. Change-Id: I99b40bf8d81e7cb3a48c8f73ac06aca570dfc904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003148 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#732249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/737bab4e36f5..c885431d04db Created with: gclient setdep -r src-internal@c885431d04db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010717,chromium:1034098,chromium:1041468 Tbr: jbudorick@google.com Change-Id: I93a35f1c090388c87f86048cfafe89ac2b11c963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003927Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732248}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0c66bcd13a54..0ecc48ecb7a1 git log 0c66bcd13a54..0ecc48ecb7a1 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 natlee@microsoft.com Handle DeviceLost error Created with: gclient setdep -r src/third_party/dawn@0ecc48ecb7a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I76c2586baaf2abb36f44191679328e89d3516189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732247}
-
Dan Harrington authored
Change-Id: I61465c05b77282e229bf472a57f044c092fe4079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001121 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732246}
-
Sara Kato authored
Currently arc_a11y_helper_bridge converts mojom actions to android actions, however it's cleaner if this handling is done in arc_a11y_util. Bug: b/145316954 Test: refactoring Test: ArcAccessibilityHelperBridgeTest.* passes Change-Id: I48e1367a479bfc2d44664c2c4de6ce96eda44daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975478 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#732245}
-
Hiroki Sato authored
This change adds an extension API to set touch mode in ARC, which will be used in tast test. Bug: b:147116837 Test: tast run DUT arc.Accessibility* (crrev/c/1999865) Change-Id: I4bfdc11c5fec41e45207ceeffa0be0c985b172c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997436 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732244}
-
Alex Newcomer authored
Increase for a few more milestones, this is soon to be deprecated. Bug: 1037252 Change-Id: I06d316ebd227a2938fff54196c3d86ce5e7ad6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998459 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#732243}
-
Alexandre Courbot authored
This member is only used in one method, and its initialization is very simple: image processor if present, otherwise decoder. So perform this choice in the method where it is actually used instead of carrying this member for the whole life of the decoder and making sure it is updated properly, at the risk of introducing bugs. BUG=None TEST=Video playback working on Hana. Change-Id: I52e23fae9edb057ed618c2da0834f60ae88fccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002249 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732242}
-
Kent Tamura authored
This CL should have no behavior changes. Bug: 1040826 Change-Id: Iac5efeac96ddf437e3aa389c0669b0e19b131894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002268 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732241}
-
Rachel Sugrono authored
Rename test helper to follow the convention of other helper code that traverses into the shadow DOM. Bug: 907380 Change-Id: I7f6ee251a08995aa6b4052f7a87f4d6e3230414b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003154 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732240}
-
Michael Spang authored
This exception shouldn't be necessary after e93c224e ("Make exclude_unwind_tables only dependent on is_official_build") as Chromecast does set is_official_build for release builds. Bug: 1040148 Change-Id: Ifb0d9c2e7388de287594487aba7abc866e3ab18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993742 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732239}
-
Sadrul Habib Chowdhury authored
Notify the trackers when a begin-main-frame processing is complete, so that the tracker can verify (with DCHECKs) that it is notified of the events in a well-defined and expected sequence. At the moment, there are synthesized 'begin main frame' notifications to the trackers that prohibit the DCHECK()s to be added, but we will be turning those on in follow up CLs. BUG=1021963 Change-Id: I01e8bb2d869a1707b6a1b412fdab0cadfde12255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995461 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732238}
-
Avery Musbach authored
Bug: None Change-Id: I0b5c75f9134472428d7510a1370388c63dd518e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003926Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#732237}
-
Aliaksei Shmanai authored
New string field input_source_description would contain a description of current media input source. For example, if some device has two AUX inputs, this filed could contain 'Left AUX'. Bug: internal b/118644722 Change-Id: I8a75f9663d8a4b0553eaa0ed177c7fc1af1bef4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880274Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#732236}
-
Theresa Wellington authored
BUG=1042092 TBR=juncai@chromium.org Change-Id: I5ed0d8b0ce326b216fc9527faff72c008292b16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003302Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732235}
-
Maksym Onufriienko authored
Bug: 1033112 Change-Id: I3ca2f000362ae4bf879363d8ca60cc82266acf8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998581 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#732234}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aea3d43d0b6a..f7d73bb52028 git log aea3d43d0b6a..f7d73bb52028 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 wenbinzhang@google.com [Benchmarking] Add timeout for TakeScreenshot on Mac Created with: gclient setdep -r src/third_party/catapult@f7d73bb52028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036447 Tbr: wenbinzhang@google.com Change-Id: I8e09cb2b91af02bbd32df088282afd32dc923b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732233}
-
Francois Marier authored
Bug: 1042139 Change-Id: Iec292ab19216670c2c947218313ae21ac4273158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001855 Auto-Submit: Francois Marier <francois@brave.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732232}
-
Tom Anderson authored
This is a reland of 5f865cce Original change's description: > Ignore weak undefined symbols when calculating dpkg dependencies > > This is needed after [1] used weak undefined symbols to test feature > support in libgbm. The dependencies for the Chrome debian package are > unchanged before/after this change. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1988382 > > BUG=1031269 > R=thestig,thakis > CC=spang > > Change-Id: I760033d5883bf65a5a39316ea382766ae3754088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992340 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730271} Bug: 1031269 Change-Id: I1975969c780e5b7e2d9974526a8527a4f3d36143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001578 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#732231}
-
Prabir Pradhan authored
After certain UX concerns regarding exiting pointer capture have been addressed, the pointer-lock protocol can be enabled for ARC windows. This change makes it so that the kExoPointerCapture flag no longer affects ARC windows and only affect Crostini windows. See go/exo-pointer-lock for more information. Bug: b/114112168 Test: manual testing using ArcPointerCaptureTestApp Change-Id: I2f54e587c40bccbbf38e630dbfaff0896c321771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992188 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732230}
-
Aaron Colwell authored
Fixing an inconsistency in the partition selection in WebContentsImpl::CreateNewWindow(). The original code appeared to be conflating SiteInstance selection with partition_id selection. This was causing crashes when a new SiteInstance, created by the target_url in the noopener case, resulted in a site URL that had a different storage partition ID.(e.g. chrome-guest://blah). This change avoids the crashes by separating the 2 concerns. partition_id selection is now the same between noopener and normal paths. The special noopener SiteInstance behavior is now handled by not providing a SiteInstance in the CreateParams. This triggers the creation of a new SiteInstance, that does not share a BrowsingInstance with the original source SiteInstance. It also defers setting the site URL until we get the network response and are ready to commit. This provides the desired behavior and makes this case more consistent with other navigation scenarios. Bug: 965611 Change-Id: I054c2f793138a2b373bac6c61b0a85368f0adb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949285 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732229}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc93308cee32..772588160e90 git log cc93308cee32..772588160e90 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jalyn@microsoft.com Animations: Scale timeline when moving slider with keyboard 2020-01-15 hongchan@chromium.org Clean up after ESM migration of front_end/web_audio 2020-01-15 kahinds@microsoft.com Add screenreader support for Animation tool 2020-01-15 alchiem@microsoft.com Adding new performance histograms for performance tool launch 2020-01-15 alchiem@microsoft.com Adding new performance histograms for memory tool launch 2020-01-15 tvanderlippe@chromium.org Update README with format and check command Created with: gclient setdep -r src/third_party/devtools-frontend/src@772588160e90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1040646,chromium:1042102,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ice42d3fccbb78c0ffa8b69db68e7a527555eb37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732228}
-
Michael Thiessen authored
The InstalledAppProviderTest suite uses AsyncTask, which apparently requires a BrowserTaskEnvironment for the AsyncTask to actually run (sometimes it runs anyways - I don't know why). Bug: 1041909 Change-Id: Ida7a8ee8296ce489b560cec00e3b0ca2c4d7d982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003751 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732227}
-
Rakib M. Hasan authored
R=isamsonov@google.com TBR=robertma@chromium.org Bug: 986447 Change-Id: I2f0e1ea4cdfb7ec2fd207db283663ca9d71eaaf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002900Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#732226}
-
Lukasz Anforowicz authored
Fixed: 1042360 Change-Id: I5e0cc2859131d8524e72b46964b398242da6f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002943 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732225}
-
Meredith Lane authored
This reverts commit af5c4bc1. Reason for revert: Deterministically crashes MSAN and debug CrOS builds, first failure here: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17319 Original change's description: > Fix message_center::MessageView::OnSlideOut UAF > > Bug: 983009 > Change-Id: Ie285c4035bfc4c45e27e5f3fd6c34280d9f4c2d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001943 > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732131} TBR=peter@chromium.org,tengs@chromium.org,mpdenton@chromium.org Change-Id: Ib8a7cfeaa6c81fca58cee2cbff7102a20ca1a474 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003167Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732224}
-
Margaret Mary Kearney authored
Updating banner across Chrome apps docs for deprecation Change-Id: Ib29fc705ad37cc21c46eb7eb23daccf089a6d300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003112 Commit-Queue: Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Auto-Submit: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732223}
-
Felipe Salazar authored
Per @thomasanderson, the current minimum requirement is GLIBC 2.19. Bug: b/145962051, b/147656572 Change-Id: I1625753c6b0a2332015b78394740f0dba5a01519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003254Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Felipe Salazar <felipesalazar@chromium.org> Auto-Submit: Felipe Salazar <felipesalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732222}
-
James Darpinian authored
In https://crrev.com/c/1991969 I added a new, faster way to disable ARB_texture_rectangle support in ANGLE's shader translator. This change starts using it in Chrome, replacing the earlier change introduced in https://crrev.com/c/1842223 Bug: angleproject:3770 Change-Id: Ica718828581b49efc34230f9f53f28fdec77eb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992548 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732221}
-