- 26 Mar, 2019 40 commits
-
-
Mounir Lamouri authored
Bug: 924249 Change-Id: Id91994c87910d19884222a7060ecca28d0894bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1427599 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644568}
-
Esmael El-Moslimany authored
Bug: 945793 Change-Id: If766a68f71ce7d9d1068cc30b12a2c1191a966af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540066Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#644567}
-
Min Qin authored
For resumed download, we should extend the expiration date. Or otherwise, large downloads may not complete on slow networks BUG=938978 Change-Id: Ib57c5915a4caa1305e7b9ba6ec7c2abc1f30f3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538453Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644566}
-
Xiyuan Xia authored
- Update DesktopFocusRules so that only toplevel window is allowed to be activated in minimized state. Otherwise, a child window could be activated and cause DesktopNativeWidgetAura not getting activation change which in turn causes more problems down the road. - Fix DesktopNativeWidgetAura so that RestoreFocusedView happens for a minimized widget Bug: 942787 Change-Id: I0e3d35f342fca16cc78e451d6bf7fe32ac2dc337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536554 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#644565}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b12fa2c0ae1..c8bd9e358dfd git log 1b12fa2c0ae1..c8bd9e358dfd --date=short --no-merges --format='%ad %ae %s' 2019-03-26 benjhayden@chromium.org Support bug_id=* in Anomaly.QueryAsync() 2019-03-26 benjhayden@chromium.org Support count_limit in /api/alerts Created with: gclient setdep -r src/third_party/catapult@c8bd9e358dfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193 TBR=sadrul@chromium.org Change-Id: I2cd8460dbca2d95dce85aeb2ca73b9444ef6680f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539075Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644564}
-
Nikunj Bhagat authored
Bug: 945174 Change-Id: Ia1d99f70eb43f3ffb6545b18a3c922d638096dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540315Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#644563}
-
Yao Xiao authored
for the new scope This CL expands the intervention scope from "download happening in sandboxed iframe" to "download initiated from OR happening in sandboxed iframe", as we feel that makes more sense. This only affects the navigation path; for <a download>, the two frames are trivially the same. Moved the existing browser tests from AdsPageLoadMetricsObserverBrowserTest to a new component DownloadFramePolicyBrowserTest. Rewrote the tests making it easier to understand. The mapping from the original tests to the new tests: AdsPageLoadMetricsObserverResourceBrowserTest.SubframeNavigationDownloadBlockedByLoadPolicy <==> (identical) DownloadFramePolicyBrowserTest.SubframeNavigationDownloadBlockedByLoadPolicy DownloadInSubframeBrowserTest.Download/* <==> (splitted into 2) SubframeSameFrameDownloadBrowserTest_Sandbox.Download/* SubframeSameFrameDownloadBrowserTest_AdFrame.Download/* DownloadInMainFrameBrowserTest.Download/* <==> (identical) TopFrameSameFrameDownloadBrowserTest.Download/* RemoteFrameNavigationBrowserTest.DownloadsBlockedInSandbox <==> (expanded the scope) OtherFrameNavigationDownloadBrowserTest_Sandbox.Download/* Bug: 539938 Change-Id: I75d65f28a40cf11cc0407cfd61d6e6f15a3c8e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529514 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644562}
-
Avery Musbach authored
According to the specification, when you drag a window to snap it, the preview area (referred to as "Indicator") should fade out, and meanwhile its inset should animate to zero: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop Also, it seems reasonable to expect that the highlights should fade out if you drag a window from the top and then back to the top, or if you drag a window from the top and drop it into overview. The animations have already been implemented in SplitViewDragIndicators, but in most cases, the SplitViewDragIndicators object goes out of scope and then you do not see the animations. See the videos linked below for details. The present CL gives animations a little extra time after the SplitViewDragIndicators object is destroyed. BEFORE: https://photos.app.goo.gl/81kc7xbxQgU67CvJA https://photos.app.goo.gl/evrzpBBoXuAqZadc8 https://photos.app.goo.gl/cVqdxzVRdBzSYgNQ8 https://photos.app.goo.gl/YMtUEPmYPBDpVkeZ8 https://photos.app.goo.gl/aBsW1kYoLgvvNd4N8 AFTER: https://photos.app.goo.gl/V7XG4TX7nmF98dnv5 https://photos.app.goo.gl/oXWbDEhtij6FGwx5A https://photos.app.goo.gl/yUWToSHEH2u5k3kY7 https://photos.app.goo.gl/5yTNQ2U4CkH4AG2aA https://photos.app.goo.gl/p1fW6n9edrod2SbeA Test: manual Bug: 934977 Change-Id: I5ac3c6982f620dd90befe62849b4c60e5c7762bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536463 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#644561}
-
Evan Stade authored
Chrome doesn't recover from this error, so crash rather than leaving the client broken. Bug: 943238 Change-Id: I4e61310a2367354eba2d06b8b0f263aac66cce94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536138 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0b7cfc0b483..bcf82c47e836 Created with: gclient setdep -r src-internal@bcf82c47e836 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: I0f0eaa885d1650969bb73bbc52bb0c5ad47e36bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540049Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644559}
-
Sunny Sachanandani authored
Surface aggregator perftests were using the same embed token for each surface which triggers surface invariants violation DCHECKs. Bug: None Change-Id: I716feac2f134e8b199b071fb85219c50b93f1e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540140 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#644558}
-
Rakib M. Hasan authored
The test name prefix will be used to shorten the tests name. It will also be added as a field to the JSON results. Bug: chromium:698902 Change-Id: I3a8be18eb583cc5cfadbf61f29d366a7b21c9527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539887 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644557}
-
jdoerrie authored
Bug: 945560 Change-Id: I4d07b3e084fae7eb819bcf377f0b5231d8ae68e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539841 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644556}
-
Kevin Ellis authored
This patch adds support for multiple queues for async mutation of worklet animations. Active tree mutations that have been previously queued can get replaced by later mutation requests. Only one pending tree mutation can be performed at any time, so each much run to completion before the next is queued. Next steps: * Track active and pending version of local time separately. * Update local time for the active tree on activation of the pending tree. * Trigger animate layers after pending tree activation if potentially stale. Bug: 937975 Change-Id: I1c1c39bd65325a5323814d7718c2fab6c8683a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535747Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#644555}
-
Pavel Feldman authored
Change-Id: I10039ff0c4786b44fc73cc30b5758c55a6b071b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540299 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644554}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72cc2eaafdec..4864e0cd1960 git log 72cc2eaafdec..4864e0cd1960 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 syoussefi@chromium.org Fix OOM in TextureUpload perf test 2019-03-26 syoussefi@chromium.org Disable GPU perf tracking on D3D 2019-03-26 syoussefi@chromium.org Add instructions for use with RenderDoc + Android Created with: gclient setdep -r src/third_party/angle@4864e0cd1960 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:945415,chromium:945415 TBR=jonahr@chromium.org Change-Id: If4c6ed0c94a715faee7f4a8574cfde6a7e86f6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538748Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cadd2cc7ad7f..0ce04fb00267 git log cadd2cc7ad7f..0ce04fb00267 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 taylori@google.com Merge "Access atrace HAL to get available categories" 2019-03-26 treehugger-gerrit@google.com Merge "TracePacket.previous_packet_dropped: clarify proto comment" Created with: gclient setdep -r src/third_party/perfetto@0ce04fb00267 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id02f39d275fb942c05fb258971d54d1765e24032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540051Reviewed-by:
-
Maksim Sisov authored
The previous limitation is artificial and blocks Wayland from correct behaviour. The presentation and swap completion callbacks come completely independently in case of Wayland, and blocking swap completion callback until presentation callback come adds an artificial delay to the display compositor as long as it's not known when the pixel will be turned to light. Thus, use local swap ids to allow the following order Swap[0] Swap-Ack[0] Swap[1] PresentationCallback[0] Swap-Ack[1] PresentationCallback[1] Right now, it crashes because Swap[1] sets allow_running_presentation_callback_ to false and the feedback for the Swap[0] cannot go through. To ensure that the presentation callback does not come earlier than the swap-ack callback, implement a queue with local swap ids to ensure 1) correct order of swap and swap-ack and ensure the presentation callbacks do not run earlier than their preceeding swap requests. Bug: 943096 Change-Id: I0c399c6031991fd317484a8448228fe27ec69ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533873Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#644551}
-
Ted Choc authored
TBR=amaralp@chromium.org BUG=946157 Change-Id: Id4b9433a9186055073b9f3f93b95e30238172ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538873Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644550}
-
James Darpinian authored
This test currently fails on all platforms. We were just missing a failure expectation for Android. Bug: 945970 Change-Id: I9266aca2423ac1ef8cc3d9c47b77dc6ad479087b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534871 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This will prevent the network service from creating a NetworkChangeNotifier if it's started up in unit tests, which means we won't be leaking the NetworkChangeNotifier anymore. Bug: 938126, 901092 Change-Id: Ib20146981957a79584e005fa23662a996447f300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533163 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#644548}
-
Caleb Rouleau authored
I think these should have been deleted by https://chromium-review.googlesource.com/1213317 Bug: 945453 Change-Id: I5a1fdef8704082652ba93f459667a9828743c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538704Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#644547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b23aee3431c0..ce9a7af967cb git log b23aee3431c0..ce9a7af967cb --date=short --no-merges --format='%ad %ae %s' 2019-03-26 jvanverth@google.com Fix BGRA GL texture format on iOS 2019-03-26 michaelludwig@google.com Remove old experimental SkiaRenderer APIs 2019-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 213a8ce6d5c2..cc6473f7d80d (4 commits) 2019-03-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 da37e7f6759d..a47e2a23ab4c (2 commits) Created with: gclient setdep -r src/third_party/skia@ce9a7af967cb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ib2883c15dc8518e0b0bab80fc4a80b129c7a2dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539072Reviewed-by:
-
rbpotter authored
Print Preview's phase 2 layout changes will be added behind a flag. Add this flag. If the flag is enabled, set the maximum dialog size on all platforms to 1000x660, instead of only doing this on Mac. No behavior changes expected if the flag is not enabled, or if using Mac OS where the dialog size is already limited. Bug: 945619 Change-Id: Ifcfb716842dbf9539032760d97a456fee2f4c60a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538687Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644545}
-
Dana Fried authored
BrowserView was calling BrowserFrame::FrameTypeChanged() whenever the native theme changed. While Chrome theme changes can indeed cause frame changes, native theme changes should largely be color-based and should not require re-creation of the frame and re-composition of the entire window. This was causing flicker, which was especially pronounced on older machines and computers running Windows 8.x. See attached bug for details. Bug: 945138 Change-Id: I002a6535de507866b781643ce9afb81002c6946c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538984 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644544}
-
Vladimir Levin authored
This patch adds a simple values changed type to PaintPropertyChangeType and uses it to mark simple [0, 1) opacity changes with no compositor animations as such. R=pdr@chromium.org, wangxianzhu@chromium.org Bug: 938563 Change-Id: I9539baa76e128fc8cec0c592e5b32dc79594f987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537748 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644543}
-
Carlos Knippschild authored
This is the first step in eliminating mojo::DataPipe. Marking it as deprecated with a comment and a DLOG will hopefully stop it from being used in new code. Bug: 944990 Change-Id: I28d7d252a84c2c5352f6fee0fd9f9b74c81b80a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538740Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#644542}
-
Xianzhu Wang authored
This avoids empty display items for line breaks without selection. Bug: 942180 Change-Id: I0b0d30488d31b4dfcd10c40be0c564d4bd7c128b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536540 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#644541}
-
Jeffrey Cohen authored
Added a bridge to forward all Send Tab To Self Model Observer methods into Objective-C for consumption by the ios client. Bug: 944600 Change-Id: Ic1635f05e44b2ac365c3e08871bcf7d03015f417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535223 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#644540}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/069b546ca7bf..db121ec5abd6 git log 069b546ca7bf..db121ec5abd6 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 thestig@chromium.org Simplify CXFA_NodeHelper::GetParent() and callers. Created with: gclient setdep -r src/third_party/pdfium@db121ec5abd6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I88844bc9d7cdaf15741c4e2580f308083154002e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540050Reviewed-by:
-
Sammie Quon authored
Shield widget is getting removed. This is step one by moving the cannot snap window out into its own separate widget owned by overview_session. Since there is only ever one shown, it doesn't need to be owned by overviewGrid. Test: ash_unittests OverviewSessionTest.* Bug: 942759 Change-Id: I5c9e40763a35d27f2e383effada0f4f6d8791320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535131Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#644538}
-
Nate Chapin authored
Bug: 914587 Change-Id: I366cbd78cd80b3814865ed6d5565d11d28415fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520353 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
This is a reland of 640f197a Original change's description: > Reland: Various refactoring in TabStripModel tests. > > This patch refactors tab_strip_model_unittest.cc and some associated > files in several ways: > * Removes ChromeRenderViewHostTestHarness as a superclass of > TabStripModelTest, which includes some heavyweight dependencies that > are unused. This speeds up the suite by about 20% (~6500 ms runtime > vs. ~8000ms before this patch). > * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to > return false, and deletes subclasses that exist solely to override > that method (all of them, except TabStripDummyDelegate, which is > renamed to UnloadListenerTabStripModelDelegate). > * Moved several helper classes to be defined immediately before the > test that uses them. > * Deletes member variables from MockTabStripModelObserver, which are > unused. > * Fixes lint errors and cleans up unused includes. > > Change-Id: Ibb93ff41a21aab4c0b9b9f075df315381959c35c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538575 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644437} TBR=erikchen@chromium.org,fdoray@chromium.org Change-Id: I1ed5fbe5cafab20271be5148596f6fed9e493b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540261Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644536}
-
Guohui Deng authored
This is to provide option for devices where more than one Kind of MediaPipelineBackend can be created. Caller of CastMediaShlib::CreateMediaPipelineBackend can specify that the support forPassthrough audio is desired Bug: internal b/110233576 Test: Internal CQ. Change-Id: If0548f08a97bb68619411e4471b1ee8e7c359f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524876 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644535}
-
Miguel Casas authored
This CL replaces mechanically: media/mojo/clients/mojo_jpeg_decode_accelerator* --> mjpeg media/mojo/services/mojo_jpeg_decode_accelerator_service* --> mjpeg and the classes inside s/MojoJpegDecodeAccelerator/MojoMjpegDecodeAccelerator/ s/MojoJpegDecodeAcceleratorService/MojoMjpegDecodeAcceleratorService/ TBR=sadrul@ for the mechanical substitution in gpu_service_impl.cc Bug: 932860 Change-Id: I3f6e43132aabd8ea2880cd584e2ced45ec16d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540302 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#644534}
-
Robert Liao authored
This is a run of clang-tidy with the existing .clang-tidy config on //ui/views. BUG=940732 TBR=sky@chromium.org Change-Id: Ia2a94691586544ec7e01156780510b09eb0d1d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540277 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#644533}
-
Staphany Park authored
Bug: 918293 Change-Id: I8e8a7e9e5ead7eca1c6712d8464ae1d63049b96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538977Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#644532}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. Patch is migrating FONT_FAMILY and THEME enums to @IntDef generated by java_cpp_enum.py 2. COUNT inside is renamed to NUM_ENTRIES 3. enums in C++ code have prefixes in names (because of NUM_ENTRIES) BUG=919666 Change-Id: Ie00ea41c0fdbb702192463f63a752cc43bae92c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517112 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644531}
-
Allen Bauer authored
Bug: 945847 Change-Id: I8891b4877fb8cf962e2afa96dafc1e62ceb1618a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539786 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Ted Choc authored
The bots have been updated to 5.1.1, which is LOLLIPOP_MR1. This just disables the test for anything pre-marshmallow. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/21211 ../../content/browser/media/media_browsertest.cc:55: Failure Expected equality of these values: expected_title Which is: "ENDED" final_title Which is: "error" Stack trace: [WARNING:discardable_shared_memory_manager.cc(410)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [ FAILED ] MSE_ExternalClearKey/EncryptedMediaTest.FrameSizeChangeVideo/0, where GetParam() = (0x9d970a3b pointing to "org.chromium.externalclearkey", 4-byte object <01-00 00-00>) (5931 ms) [----------] 1 test from MSE_ExternalClearKey/EncryptedMediaTest (5937 ms total) TBR=liberato@chromium.org BUG=778245 Change-Id: I6816cbabedd6c6a60b139e494b9dae35164f07b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540304Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644529}
-
