1. 26 Apr, 2009 3 commits
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gns@gnome.org> · ea9b5424
      kov@webkit.org authored
              Go back to disabling accessibility tests as a whole, since we have
              no real way of checking them, and no accessibilityController
              implementation.
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42874 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ea9b5424
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gns@gnome.org> · da17041d
      kov@webkit.org authored
              Disable tests that need eventSender, not yet implemented in our
              DumpRenderTree.
      
              * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42873 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      da17041d
    • simon.fraser@apple.com's avatar
      2009-04-24 Simon Fraser <simon.fraser@apple.com> · 0075bef8
      simon.fraser@apple.com authored
              Reviewed by Darin Adler
      
              https://bugs.webkit.org/show_bug.cgi?id=25390
      
              Fix point mapping and hit testing through transforms and perspective
              with ENABLE_3D_RENDERING. Previously the code did the more efficient
              move(), rather than getTransformFromContainer(), when the object had
              no transform. However, this skipped the application of perspective
              when the immediate child of the perspective element had no transform
              itself.
      
              Test: transforms/3d/point-mapping/3d-point-mapping-3.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::mapLocalToContainer):
              (WebCore::RenderBox::mapAbsoluteToLocalPoint):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createLocalTransformState):
              Call shouldUseTransformFromContainer() to determine if we need to
              go through the more expensive getTransformFromContainer() code
              path.
      
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shouldUseTransformFromContainer):
              New method that indicates whether we need use getTransformFromContainer()
              when mapping points through renderers, and hit testing.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42872 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0075bef8
  2. 25 Apr, 2009 17 commits
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · 42237ef8
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              Some *obvious* style cleanup in my last patch.
      
              * History/WebBackForwardList.mm:
              (bumperCarBackForwardHackNeeded):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42871 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      42237ef8
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · ff1399db
      beidson@apple.com authored
              Reviewed by Oliver Hunt
      
              <rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)
      
              BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
              tried to go to it.  In some cases it would be dealloc'ed first.
              When WebHistoryItems were pure Objective-C they probably got away with this more often.
              With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.
      
              * History/WebBackForwardList.mm:
              (bumperCarBackForwardHackNeeded):
              (-[WebBackForwardList backListWithLimit:]):  If this is BumperCar, hang on to the
                NSArray of WebHistoryItems until the next time this method is called.
              (-[WebBackForwardList forwardListWithLimit:]):  Ditto.
      
              * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42870 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff1399db
    • adele@apple.com's avatar
      WebCore: · 82ae4469
      adele@apple.com authored
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              Test: editing/deleting/delete-br-013.html
      
              * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
               Only preserve an empty paragraph's style when moving paragraphs around if the selection is still 
               in an empty paragraph after the move occurs.  This was causing the empty paragraph's style to overwrite
               the previous paragraph's style during a delete of an empty paragraph.
      
      LayoutTests:
      
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              * editing/deleting/delete-br-013.html: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.png: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42869 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82ae4469
    • eric.carlson@apple.com's avatar
      2009-04-25 Eric Carlson <eric.carlson@apple.com> · 6fd0c25e
      eric.carlson@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't 
              properly display non-linear media
      
              If a media engine claims it can support the MIME type, WebCore now creates a <video>
              element for document mode media files instead of an <embed> element. Because WebCore's 
              QuickTime backed media players do not support every kind of media the QuickTime plug-in
              supports, and because it is not always possible to tell what type of media is in a file 
              without opening and parsing it, some types of media that used to be displayed properly
              by a plug-in are no longer supported properly. To fix this, if the media engine
              sees that it can not completely support a media file it now informs the media 
              document, which replaces the <video> element with an <embed>.
              
              r42301 landed support for OSX. This patch modifies those changes slighly and adds support
              for Windows.
      
              * loader/MediaDocument.cpp:
              (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer.
              (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> 
              element immediately.
              (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed.
              Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
              * loader/MediaDocument.h:
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks.
              (WebCore::MediaPlayerPrivate::rateChanged): Ditto.
              (WebCore::MediaPlayerPrivate::timeChanged): Ditto.
              (WebCore::MediaPlayerPrivate::didEnd): Ditto.
              (WebCore::MediaPlayerPrivate::repaint): Ditto.
              (WebCore::MediaPlayerPrivate::paint): Ditto.
              (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
      
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks.
              (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported
              media type(s) or if it fails completely.
              (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the
              media player client we won't play this movie correctly.
              (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks.
              (WebCore::MediaPlayerPrivate::setSize): Ditto.
              (WebCore::MediaPlayerPrivate::setVisible): Ditto.
              (WebCore::MediaPlayerPrivate::paint): Ditto.
              (WebCore::MediaPlayerPrivate::movieEnded): Ditto.
              (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto.
              (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto.
              (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
      
              * platform/graphics/win/QTMovieWin.cpp:
              (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state
              change callback.
              (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled.
              (QTMovieWin::QTMovieWin): Initialize m_disabled.
              (QTMovieWin::disableUnsupportedTracks): Return total number of tracks.
              (QTMovieWin::setDisabled): New, set m_disabled flag.
              * platform/graphics/win/QTMovieWin.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42868 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6fd0c25e
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 17952444
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=24786
              WebKitDownload sometimes suggests peculiar filenames
      
              Refactor the emission of the download-requested signal so that we
              have less code duplication.
      
              * WebCoreSupport/ContextMenuClientGtk.cpp:
              (WebKit::ContextMenuClient::downloadURL):
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::startDownload):
              * webkit/webkitprivate.h:
              * webkit/webkitwebview.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42867 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      17952444
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · fd2d51dc
      jmalonzo@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Error reporting
              https://bugs.webkit.org/show_bug.cgi?id=18344
      
              Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
              errors and G_IO_ERROR for gio errors.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::finishedCallback):
              (WebCore::ResourceHandle::startHttp):
              (WebCore::ResourceHandle::start):
              (WebCore::readCallback):
              (WebCore::openCallback):
              (WebCore::queryInfoCallback):
              (WebCore::ResourceHandle::startGio):
      
      2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
      
              Reviewed by Xan Lopez.
      
              [GTK] Error reporting
              https://bugs.webkit.org/show_bug.cgi?id=18344
      
              Update FrameLoad errors to use WebKitErrors.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::cancelledError):
              (WebKit::FrameLoaderClient::blockedError):
              (WebKit::FrameLoaderClient::cannotShowURLError):
              (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
              (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
              (WebKit::FrameLoaderClient::fileDoesNotExistError):
              (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
              (WebKit::FrameLoaderClient::shouldFallBack):
              * webkit/webkiterror.h: Added.
              * webkit/webkiterror.cpp: Added.
      
      2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
      
              Reviewed by Xan Lopez.
      
              [GTK] Error reporting
              https://bugs.webkit.org/show_bug.cgi?id=18344
      
              Add webkiterror to the build.
      
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42866 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fd2d51dc
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · 6154a4d4
      jmalonzo@webkit.org authored
               Reviewed by Xan Lopez.
      
               [GTK] Error reporting
               https://bugs.webkit.org/show_bug.cgi?id=18344
      
               Add the default error page for installation.
      
               * GNUmakefile.am:
      
      2009-04-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
      
               Reviewed by Xan Lopez.
      
               Display a default error page for load errors.
      
               * WebCoreSupport/FrameLoaderClientGtk.cpp:
               (WebKit::FrameLoaderClient::dispatchDidFailLoad):
               * resources/error.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42865 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6154a4d4
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · 5757029f
      jmalonzo@webkit.org authored
               Reviewed by Xan Lopez.
      
               [GTK] Error reporting
               https://bugs.webkit.org/show_bug.cgi?id=18344
      
               Add a WebKitWebFrame API to load alternate content for unreachable URLs.
               Also add a new signal "load-error" for handling load errors.
      
               * WebCoreSupport/FrameLoaderClientGtk.cpp:
               (WebKit::FrameLoaderClient::postProgressFinishedNotification):
               (WebKit::FrameLoaderClient::dispatchDidFailLoading):
               (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
               (WebKit::FrameLoaderClient::dispatchDidFailLoad):
               * webkit/webkitwebframe.cpp:
               * webkit/webkitwebframe.h:
               * webkit/webkitwebview.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42864 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5757029f
    • oliver@apple.com's avatar
      Build fix. · ddc4a7b5
      oliver@apple.com authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42863 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ddc4a7b5
    • jmalonzo@webkit.org's avatar
      2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org> · e8829099
      jmalonzo@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Gtk build fix - check if we have MADV_FREE before using it.
      
              * interpreter/RegisterFile.cpp:
              (JSC::RegisterFile::releaseExcessCapacity):
              * wtf/Platform.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42862 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e8829099
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · dacfe7ad
      kov@webkit.org authored
              Reviewed by Mark Rowe.
      
              Only set the new URL once for the request. Doing it a second time
              after the call to willSendRequest was causing crashes when
              redirected requests got cancelled.
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::restartedCallback):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42861 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dacfe7ad
    • kevino@webkit.org's avatar
      wx build fix. Switching JSCore from a static lib to a dynamic lib to match the... · f6a3a134
      kevino@webkit.org authored
      wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42860 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f6a3a134
    • kevino@webkit.org's avatar
      wx build fix. Adding ScriptEventListener.cpp. · 3cdb1253
      kevino@webkit.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42859 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3cdb1253
    • jmalonzo@webkit.org's avatar
      2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 9008d83f
      jmalonzo@webkit.org authored
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25337
              Move ThreadingQt.cpp under the qt directory.
      
              * JavaScriptCore.pri:
              * wtf/ThreadingQt.cpp: Removed.
              * wtf/qt/ThreadingQt.cpp: Copied from JavaScriptCore/wtf/ThreadingQt.cpp.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42858 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9008d83f
    • jmalonzo@webkit.org's avatar
      2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · a05ed31a
      jmalonzo@webkit.org authored
              Rubber-stamped by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=25338
              Move ThreadingGtk.cpp under the gtk directory.
      
              * GNUmakefile.am:
              * wtf/ThreadingGtk.cpp: Removed.
              * wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42857 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a05ed31a
    • jmalonzo@webkit.org's avatar
      2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org> · b4f87842
      jmalonzo@webkit.org authored
              Rubber-stamped by Gustavo Noronha.
      
              Fix braces to comply with style guidelines.
      
              * WebCoreSupport/PasteboardHelperGtk.cpp:
              (WebKit::PasteboardHelperGtk::getClipboard):
              (WebKit::PasteboardHelperGtk::getCopyTargetList):
              (WebKit::PasteboardHelperGtk::getPasteTargetList):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42856 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b4f87842
    • jmalonzo@webkit.org's avatar
      2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net> · 73f2badf
      jmalonzo@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=17267
              [GTK] Primary selection/clipboard support
      
              Copy the link location to the primary selection as well as the
              clipboard selection when using the "copy link selection" context
              menu entry.
      
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::Pasteboard::writeURL):
              * platform/gtk/PasteboardHelper.h:
      
      2009-04-24  Sergio García-Cuevas  <sergio_gcg@telefonica.net>
      
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=17267
              [GTK] Primary selection/clipboard support
      
              Add a method for getting the primary selection.
      
              * WebCoreSupport/PasteboardHelperGtk.cpp:
              (WebKit::PasteboardHelperGtk::getPrimary):
              * WebCoreSupport/PasteboardHelperGtk.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42855 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      73f2badf
  3. 24 Apr, 2009 20 commits
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 8b0fbc92
      eric@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=25383
              Changing SVG size via JS does not update CSS width/height
      
              Add an ugly hack to fix CSS width/height updates from JS.
      
              We can't easily call setAttribute when width/height changes
              as that would cause infinite recursion (as we'd try to set
              the animation storage from the attributes)
      
              For now, when we get notification that JS changed width/height
              we copy what parseMappedAttribute does and update the CSS values as well.
      
              A better fix for this would be:
              https://bugs.webkit.org/show_bug.cgi?id=25383
      
              * svg/SVGSVGElement.cpp:
              (WebCore::updateCSSForAttribute):
              (WebCore::SVGSVGElement::svgAttributeChanged):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42854 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8b0fbc92
    • barraclough@apple.com's avatar
      2009-04-24 Gavin Barraclough <barraclough@apple.com> · 6f1a55b4
      barraclough@apple.com authored
              Reviewed by Sam "Wesley" Weinig.
      
              Improve performance to YARR interpreter.
              (From about 3x slower than PCRE on regex-dna to about 30% slower).
      
              * yarr/RegexCompiler.cpp:
              (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
              * yarr/RegexInterpreter.cpp:
              (JSC::Yarr::Interpreter::checkCharacter):
              (JSC::Yarr::Interpreter::checkCasedCharacter):
              (JSC::Yarr::Interpreter::backtrackPatternCharacter):
              (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
              (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
              (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
              (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
              (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
              (JSC::Yarr::Interpreter::matchDisjunction):
              (JSC::Yarr::Interpreter::interpret):
              (JSC::Yarr::ByteCompiler::atomPatternCharacter):
              (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
              (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
              (JSC::Yarr::ByteCompiler::closeAlternative):
              (JSC::Yarr::ByteCompiler::closeBodyAlternative):
              (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
              (JSC::Yarr::ByteCompiler::regexBegin):
              (JSC::Yarr::ByteCompiler::regexEnd):
              (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
              (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
              (JSC::Yarr::ByteCompiler::emitDisjunction):
              * yarr/RegexInterpreter.h:
              (JSC::Yarr::ByteTerm::):
              (JSC::Yarr::ByteTerm::ByteTerm):
              (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
              (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
              (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
              (JSC::Yarr::ByteTerm::AlternativeBegin):
              (JSC::Yarr::ByteTerm::AlternativeDisjunction):
              (JSC::Yarr::ByteTerm::AlternativeEnd):
              (JSC::Yarr::ByteTerm::SubpatternBegin):
              (JSC::Yarr::ByteTerm::SubpatternEnd):
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
              * yarr/RegexPattern.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42853 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6f1a55b4
    • kmccullough@apple.com's avatar
      2009-04-24 Kevin McCullough <kmccullough@apple.com> · 2e9e48bc
      kmccullough@apple.com authored
              Reviewed by Dan Bernstein.
      
              We should not show the deletion UI for blockquotes in mail but they do 
              show now that we only check for one visible border.
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42852 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2e9e48bc
    • mrowe@apple.com's avatar
      2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com> · cf45a5a7
      mrowe@apple.com authored
              Rubber-stamped by Mark Rowe.
      
              * wtf/CurrentTime.h: Fix a typo in a comment.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42851 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf45a5a7
    • mitz@apple.com's avatar
      - address Hyatt's review comments on the last patch · 6a6f954a
      mitz@apple.com authored
              * rendering/RenderLayer.cpp:
              (WebCore::performOverlapTests):
              (WebCore::RenderLayer::paintLayer):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42850 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6a6f954a
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 420cbcfa
      mitz@apple.com authored
              - fix https://bugs.webkit.org/show_bug.cgi?id=5909
                <rdar://problem/5863349> overlapping element leaves trail when
                scrolling iframe
      
              * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::reset): Initialize m_isOverlapped.
              (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
              (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
              so overlapping is taken into account.
              (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
              enables or disables copy-on-scroll accordingly.
      
              * page/FrameView.h:
              Added setIsOverlapped() and m_isOverlapped.
      
              * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
              an OverlapTestRequestClient can make a request to test if any subsequently-
              painted layers overlap a rect. The test result is delivered to the
              requestClient via setOverlapTestResult().
              (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
              paintLayer(). When done painting, inform any remaining requestClients that
              they are not overlapped.
      
              (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
              pass it down to child and reflection layers. Inform requestClients if this
              layer overlaps their requested rects.
      
              * rendering/RenderLayer.h:
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
              OverlapTestRequestMap member.
      
              * rendering/RenderReplica.cpp:
              (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
              to paintLayer().
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
              with the frame.
              (WebCore::RenderWidget::setOverlapTestResult): Call
              FrameView::setIsOverlapped() with the result of the overlap test.
      
              * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      420cbcfa
    • simon.fraser@apple.com's avatar
      2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com> · e5c0cdde
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser
      
              https://bugs.webkit.org/show_bug.cgi?id=25380
      
              Fixed a race condition on the first 'played' attribute test start.
      
              Previously we were starting nearly right away to play, and probably
              before receiving the 'canplay' event. Now we ensure we'll wait for
              that 'canplay' event before attempting to play.
      
              * media/video-played-expected.txt: Updated
              * media/video-played.html:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42848 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e5c0cdde
    • ggaren@apple.com's avatar
      2009-04-24 Geoffrey Garen <ggaren@apple.com> · bbb0a673
      ggaren@apple.com authored
              Rubber stamped by Eric Seidel.
              
              Updated test to turn the buildbot green after Eric's last check-in.
      
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42847 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bbb0a673
    • hyatt@apple.com's avatar
      2009-04-24 David Hyatt <hyatt@apple.com> · ca528bf3
      hyatt@apple.com authored
              Reviewed by Simon Fraser, Dan Bernstein.
      
              Speed up the PLT by devirtualizing the height() function on InlineBox.  virtualizing it in order to make the height() computation dynamic caused
              a ~0.5% slowdown.  This patch does the following to get the speed back:
              
              (a) Devirtualizes isText and forces inline box creators to set the bit as needed.  This actually resulted in simplified code, since ListMarkerBox could
              then be removed.
              (b) Reduces the height() call count.  In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
              member variable access.  The call sites have been patched to cut down on extra height() calls now that it is more expensive.
              (c) Devirtualize height() except on SVG boxes.  For all non-SVG, the height() function on InlineBox handles the computation.  For SVG boxes, a new bit has
              been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::height):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::InlineBox):
              (WebCore::InlineBox::isSVG):
              (WebCore::InlineBox::setIsSVG):
              (WebCore::InlineBox::isText):
              (WebCore::InlineBox::setIsText):
              (WebCore::InlineBox::svgBoxHeight):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesVertically):
              (WebCore::InlineFlowBox::paintBoxDecorations):
              (WebCore::InlineFlowBox::paintMask):
              * rendering/InlineFlowBox.h:
              * rendering/InlineTextBox.cpp:
              * rendering/InlineTextBox.h:
              * rendering/ListMarkerBox.cpp: Removed.
              * rendering/ListMarkerBox.h: Removed.
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::createInlineBox):
              * rendering/RenderSVGInline.cpp:
              (WebCore::RenderSVGInline::createFlowBox):
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::createTextBox):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::createRootBox):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::createInlineTextBox):
              * rendering/RootInlineBox.cpp:
              * rendering/RootInlineBox.h:
              * rendering/SVGInlineFlowBox.h:
              (WebCore::SVGInlineFlowBox::svgBoxHeight):
              * rendering/SVGInlineTextBox.h:
              (WebCore::SVGInlineTextBox::svgBoxHeight):
              * rendering/SVGRootInlineBox.h:
              (WebCore::SVGRootInlineBox::svgBoxHeight):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42846 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ca528bf3
    • eric@webkit.org's avatar
      Reviewed by Adam Roben. · 49c8a1ba
      eric@webkit.org authored
              Add PrettyPatch support to run-webkit-tests
      
              * Scripts/run-webkit-tests:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42845 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      49c8a1ba
    • oliver@apple.com's avatar
      Build fix · 7d11de0c
      oliver@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@42844 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7d11de0c
    • dglazkov@chromium.org's avatar
      2009-04-24 Dimitri Glazkov <dglazkov@chromium.org> · 9dbbce43
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25370
              Introduce ScriptEventListener to refactor away direct references to
              JSLazyEventListener in WebCore code.
      
              * GNUmakefile.am: Added ScriptEventListener to project.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
              * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
                  to ScriptEventListener.
              * bindings/js/JSLazyEventListener.h: Ditto.
              * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
              * bindings/js/ScriptEventListener.cpp: Added.
              * bindings/js/ScriptEventListener.h: Added.
              * bindings/v8/ScriptEventListener.cpp: Added.
              * bindings/v8/ScriptEventListener.h: Added.
              * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
              * html/HTMLBodyElement.cpp: Ditto.
              * html/HTMLButtonElement.cpp: Ditto.
              * html/HTMLElement.cpp: Ditto.
              * html/HTMLFormElement.cpp: Ditto.
              * html/HTMLFrameElementBase.cpp: Ditto.
              * html/HTMLFrameSetElement.cpp: Ditto.
              * html/HTMLImageElement.cpp: Ditto.
              * html/HTMLInputElement.cpp: Ditto.
              * html/HTMLObjectElement.cpp: Ditto.
              * html/HTMLScriptElement.cpp: Ditto.
              * html/HTMLSelectElement.cpp: Ditto.
              * html/HTMLTextAreaElement.cpp: Ditto.
              * svg/SVGElement.cpp: Ditto.
              * svg/SVGSVGElement.cpp: Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42843 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9dbbce43
    • oliver@apple.com's avatar
      <rdar://problem/6050421> JavaScript register file should remap to release... · 0b189b32
      oliver@apple.com authored
      <rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion
      
      Reviewed by Geoff Garen
      
      We now track the maximum extent of the RegisterFile, and when we reach the final
      return from JS (so the stack portion of the registerfile becomes empty) we see
      if that extent is greater than maxExcessCapacity.  If it is we use madvise or
      VirtualFree to release the physical pages that were backing the excess.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42842 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0b189b32
    • darin@apple.com's avatar
      2009-04-24 Darin Adler <darin@apple.com> · 25850f6c
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
              https://bugs.webkit.org/show_bug.cgi?id=25355
              rdar://problem/6823543
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadItem): Added a null check.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42841 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25850f6c
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 3add8337
      eric@webkit.org authored
              Fix RenderSVGImage to dump with full bounds and style information.
              https://bugs.webkit.org/show_bug.cgi?id=25377
      
              No functional changes, we're just now including more info in render tree dumps.
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSVGImage):
              * rendering/RenderSVGImage.h:
              (WebCore::RenderSVGImage::isSVGImage):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::operator<<):
              (WebCore::write):
              * rendering/SVGRenderTreeAsText.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42840 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3add8337
    • andersca@apple.com's avatar
      2009-04-24 Anders Carlsson <andersca@apple.com> · 1142aba0
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Fix <rdar://problem/6761635>.
              
              Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
              we're waiting for a reply.
              
              * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
              (WebKit::NetscapePluginInstanceProxy::destroy):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42839 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1142aba0
    • levin@chromium.org's avatar
      2009-04-24 David Levin <levin@chromium.org> · f8d4117e
      levin@chromium.org authored
              Reviewed by NOBODY (chromium build fix).
      
              Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).
      
              * bindings/v8/V8AbstractEventListener.cpp:
              (WebCore::V8AbstractEventListener::V8AbstractEventListener):
              (WebCore::V8AbstractEventListener::invokeEventHandler):
              * bindings/v8/V8AbstractEventListener.h:
              * bindings/v8/V8EventListenerList.cpp:
              (WebCore::V8EventListenerList::add):
              (WebCore::V8EventListenerList::remove):
              (WebCore::V8EventListenerList::clear):
              * bindings/v8/V8LazyEventListener.h:
              (WebCore::V8LazyEventListener::virtualisAttribute):
              * bindings/v8/custom/V8CustomEventListener.cpp:
              (WebCore::V8EventListener::V8EventListener):
              * bindings/v8/custom/V8CustomEventListener.h:
              (WebCore::V8EventListener::create):
              (WebCore::V8EventListener::virtualisAttribute):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42838 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f8d4117e
    • xan@webkit.org's avatar
      2009-04-24 Johan Bilien <jobi@via.ecp.fr> · 1df59845
      xan@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=25373
              Popup menu has the wrong size when popped up near the edge
              of the screen
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_forward_context_menu_event): Let GTK place
              the popup menu instead of trying to do better and failing
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42837 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1df59845
    • simon.fraser@apple.com's avatar
      2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com> · e6f34b7d
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser
      
              <rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit
      
              Use better mp4 test file for media tests. The original mp4 file had an unusual
              edit (non-zero start time) which is not supported by all media engines. The new
              movie should also give more useful pixel test results.
      
              * media/content/test.mp4: Update the movie.
              * media/progress-event-total-expected.txt: Update test results to match movie duration and
              content changes.
              * media/progress-event-total.html: Ditto.
              * media/video-currentTime-set-expected.txt: Ditto.
              * media/video-loop-expected.txt: Ditto.
              * platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
              * platform/mac/media/video-aspect-ratio-expected.png: Ditto.
              * platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
              * platform/mac/media/video-controls-rendering-expected.png: Ditto.
              * platform/mac/media/video-display-toggle-expected.checksum: Ditto.
              * platform/mac/media/video-display-toggle-expected.png: Ditto.
              * platform/mac/media/video-empty-source-expected.checksum: Ditto.
              * platform/mac/media/video-layer-crash-expected.checksum: Ditto.
              * platform/mac/media/video-layer-crash-expected.png: Ditto.
              * platform/mac/media/video-transformed-expected.checksum: Ditto.
              * platform/mac/media/video-transformed-expected.png: Ditto.
              * platform/mac/media/video-zoom-expected.checksum: Ditto.
              * platform/mac/media/video-zoom-expected.png: Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42836 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6f34b7d
    • sfalken@apple.com's avatar
      Fix nightly for Windows x64 users. · af835c2f
      sfalken@apple.com authored
              Installed browser location is written to a slightly different registry key in that case.
              
              * FindSafari/FindSafari.cpp:
              (getInstalledWebKitDirectory):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@42835 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af835c2f