Commits · eaa12c7bbc8a2697d71676629b3f2bb06150741c · eriksson monteiro / tangled

04 Sep, 2014 40 commits

Fix crash on chrome://sync-internals when sync is disabled. · eaa12c7b

ahest authored Sep 04, 2014

BUG=

Review URL: https://codereview.chromium.org/537893002

Cr-Commit-Position: refs/heads/master@{#293330}

eaa12c7b

Update V8 to version 3.29.41 (based on bleeding_edge revision r23674). · 347e5643

machenbach authored Sep 04, 2014

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/545443002

Cr-Commit-Position: refs/heads/master@{#293329}

347e5643

Video Player: fix misc bugs · f1305fc0

yoshiki authored Sep 04, 2014

- Add null-checks
- Return an empty mime/thumbnailUrl instead of error if request is succeeded (media_manager.js)
- Make savedVolume_ consistent (media_controls.js)

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/537863002

Cr-Commit-Position: refs/heads/master@{#293328}

f1305fc0

Modify test case to support streaming operation in sandbox file system. · 0df38665

iseki authored Sep 04, 2014

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/522543002

Cr-Commit-Position: refs/heads/master@{#293327}

0df38665

This is a reland of ServiceWorkerCache::Keys. · bb2bb40a

jkarlin authored Sep 04, 2014

Reland of https://codereview.chromium.org/477973002/

There was a memory leak.  EndEnumeration wasn't called on the iterator.

Fixed and tested with ASAN.

The leak was detected because SimpleCache doesn't clean up its enumerators on deletion, but it should.  See https://code.google.com/p/chromium/issues/detail?id=410276

BUG=392621

Review URL: https://codereview.chromium.org/528233003

Cr-Commit-Position: refs/heads/master@{#293326}

bb2bb40a

Use video-only test clips for media_perftests video benchmarks. · 52e5986b

Andrew Scherkus authored Sep 04, 2014

During development I noticed that the clips we were using contained
audio, which would mean changes to audio-only code were impacting these
benchmarks.

This will cause our tests to use a new baseline, but that's OK.

R=rileya@chromium.org

Review URL: https://codereview.chromium.org/543703003

Cr-Commit-Position: refs/heads/master@{#293325}

52e5986b

USB interrupt and bulk transfer tests using an echo gadget. · ee658b74

reillyg authored Sep 04, 2014

Add tests for interrupt and bulk USB transfers using a gadget device
that echos packets back to the host. This change depends on the removal
of the //content dependency in usb_service so that it no longer depends
explicitly on BrowserThread::FILE for I/O operations.

BUG=

Review URL: https://codereview.chromium.org/516003002

Cr-Commit-Position: refs/heads/master@{#293324}

ee658b74

Added mailing list for device alerts. · 20533738

zty authored Sep 04, 2014

R=friedman@chromium.org, navabi@chromium.org

Review URL: https://codereview.chromium.org/521823003

Cr-Commit-Position: refs/heads/master@{#293323}

20533738

Add WindowManager to about:gpu page on Linux/X11 · 2e8962b0

zmo authored Sep 04, 2014

BUG=410560
TEST=about:gpu page
R=piman@chromium.org,davemoore@chromium.org,sadrul@chromium.org,derat@chromium.org

Review URL: https://codereview.chromium.org/540643002

Cr-Commit-Position: refs/heads/master@{#293322}

2e8962b0

Disable build/android/buildbot/tests in presubmit · 5d7197f5

cjhopman authored Sep 04, 2014

These tests are deleting out/Debug when run.

TBR=navabi
NOTRY=true
BUG=410936

Review URL: https://codereview.chromium.org/542803002

Cr-Commit-Position: refs/heads/master@{#293321}

5d7197f5

Disable the Mac "Access Address Book" Autofill popup. · 1e021cbc

Evan Stade authored Sep 04, 2014

The intent of this patch is to create something small and harmless for merging to M38. The prompt will be reenabled as soon as the logic for showing it is updated.

BUG=408695
R=erikchen@chromium.org

Review URL: https://codereview.chromium.org/535243002

Cr-Commit-Position: refs/heads/master@{#293320}

1e021cbc

Clear GCMProfileService::account_id_ in when signing out · 2f90d82b

jianli authored Sep 04, 2014

This fixed the bug that signing out and then signing in again does not
restart GCM.

BUG=393043
TEST=new test added

Review URL: https://codereview.chromium.org/535393002

Cr-Commit-Position: refs/heads/master@{#293319}

2f90d82b

Skia roll 0c88d82:a17aac8 with fixed build exclusions. · 1bd9a310

mtklein authored Sep 04, 2014

Apparently it's fatal for GN to try to remove something that doesn't exist,
but not for GYP... the GYP list is way out of date.

SkTaskGroup{.cpp,.h} are not currently listed in utils.gypi,
so there's no need to remove them.

https://skia.googlesource.com/skia/+log/0c88d8233ba3a8baa9b4dd6ef515def6b3749980..a17aac8bd4c755c3a24befc7fd297969c0bb0861

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg

Bots seem to be failing before and after this CL.
NOTRY=true

BUG=

Review URL: https://codereview.chromium.org/537363002

Cr-Commit-Position: refs/heads/master@{#293318}

1bd9a310

Revert of Revert of Blink roll 9d34a87:9a051c52 · 31fccd7d

Erik Arvidsson authored Sep 04, 2014

Revert of Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/540023002/)

Reason for revert:
breaking all gpu bots

see https://code.google.com/p/chromium/issues/detail?id=410885

Original issue's description:
> Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/539713002/)
>
> Reason for revert:
> Breaks telemetry_perf_unittests on Mac.
> Likely culprit is http://src.chromium.org/viewvc/blink?revision=181336&view=revision
>
>   ASSERTION FAILED: (HashTableKeyChecker<HashTranslator, KeyTraits, HashFunctions::safeToCompareToEmptyOrDeleted>::checkKey(key))
>   ../../third_party/WebKit/Source/wtf/HashTable.h(645) : const ValueType *WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup(T) const [Key = blink::FontPlatformData, Value = WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, Extractor = WTF::KeyValuePairKeyExtractor, HashFunctions = blink::FontDataCacheKeyHash, Traits = WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, KeyTraits = blink::FontDataCacheKeyTraits, Allocator = WTF::DefaultAllocator, HashTranslator = WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, T = blink::FontPlatformData]
>   1   0x5045c9b7 WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > const* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData) const
>   2   0x5045c8fc WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData)
>   3   0x5045fed9 WTF::HashTableIterator<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator> WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData const&)
>   4   0x5045fe51 WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
>   5   0x504556e8 WTF::HashMap<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int>, blink::FontDataCacheKeyHash, blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
>   6   0x50454b28 blink::FontDataCache::get(blink::FontPlatformData const*, blink::ShouldRetain)
>   7   0x50446962 blink::FontCache::fontDataFromFontPlatformData(blink::FontPlatformData const*, blink::ShouldRetain)
>   8   0x504467f1 blink::FontCache::getFontData(blink::FontDescription const&, WTF::AtomicString const&, bool, blink::ShouldRetain)
>   9   0x5046298f blink::FontFallbackList::getFontData(blink::FontDescription const&, int&) const
>   10  0x504620c9 blink::FontFallbackList::fontDataAt(blink::FontDescription const&, unsigned int) const
>   11  0x50461d9d blink::FontFallbackList::determinePitch(blink::FontDescription const&) const
>   12  0x4384da35 blink::FontFallbackList::isFixedPitch(blink::FontDescription const&) const
>   13  0x4384d6b9 blink::Font::isFixedPitch() const
>   14  0x43841394 blink::RenderText::widthFromCache(blink::Font const&, int, int, float, blink::TextDirection, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>*, blink::GlyphOverflow*) const
>   15  0x4383c04d blink::RenderText::computePreferredLogicalWidths(float, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>&, blink::GlyphOverflow&)
>   16  0x4383ad0c blink::RenderText::computePreferredLogicalWidths(float)
>   17  0x4383a603 blink::RenderText::trimmedPrefWidths(float, float&, bool&, float&, bool&, bool&, bool&, float&, float&, float&, float&, bool&, blink::TextDirection)
>   18  0x4365b7ab blink::RenderBlockFlow::computeInlinePreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&)
>   19  0x435f3d3c blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
>   20  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
>   21  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
>   22  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
>   23  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
>   24  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
>   25  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
>   26  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
>   27  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
>   28  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
>   29  0x438059b1 blink::RenderTableCell::computePreferredLogicalWidths()
>   30  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
>   31  0x435766c8 blink::AutoTableLayout::recalcColumn(unsigned int)
>
> Original issue's description:
> > Blink roll 9d34a87:9a051c52
> >
> > https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf
> > TBR=tkent@chromium.org,arv@chromium.org
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/203622e5b22fd772320684b7f8a1aa1fa4afc25b
>
> TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3c503fbc25dc383874c83b1fc2c6a72fdfbf4bfc

TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org,dslomov@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/544733002

Cr-Commit-Position: refs/heads/master@{#293317}

31fccd7d

Revert of [Telemetry] Re-enable page_cycler.typical_25 on windows. (patchset... · f13aac1d

tonyg authored Sep 04, 2014

Revert of [Telemetry] Re-enable page_cycler.typical_25 on windows. (patchset #1 id:1 of https://codereview.chromium.org/534313002/)

Reason for revert:
Still failing

Original issue's description:
> [Telemetry] Re-enable page_cycler.typical_25 on windows.
>
> The underlying issue has been fixed.
>
> BUG=273986
> TBR=andrewhayden@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f6d8edcc3dd0fb90b43ffb2524eecdf8983a38cd

TBR=andrewhayden@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=273986

Review URL: https://codereview.chromium.org/537093003

Cr-Commit-Position: refs/heads/master@{#293316}

f13aac1d

Disable a flaky test under MemorySanitizer. · 250468db

earthdok authored Sep 04, 2014

BUG=410891
TEST=compile
NOTRY=true
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/544703002

Cr-Commit-Position: refs/heads/master@{#293315}

250468db

Add LatencyInfo support for Surfaces. · 1b92b44c

jbauman authored Sep 04, 2014

BUG=

Review URL: https://codereview.chromium.org/539783002

Cr-Commit-Position: refs/heads/master@{#293314}

1b92b44c

Use GpuBrowserCompositorOutputSurface with Surfaces. · 9a9327ca

jbauman authored Sep 04, 2014

This is needed for vsync message filtering and latencyinfo

BUG=

Review URL: https://codereview.chromium.org/511423002

Cr-Commit-Position: refs/heads/master@{#293313}

9a9327ca

Build fixes for GN mac build. · fd3e9370

brettw authored Sep 04, 2014

TBR=jamesr

Review URL: https://codereview.chromium.org/538633003

Cr-Commit-Position: refs/heads/master@{#293312}

fd3e9370

Group GN/gyp flag comparison output by file · 0e597a71

scottmg authored Sep 04, 2014

Looks like this now: https://gist.github.com/sgraham/1996522958b09077fd92

(vs. very redundant for each file before)

R=awong@chromium.org
TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/533413002

Cr-Commit-Position: refs/heads/master@{#293311}

0e597a71

Enable the PrintingEnabled policy on Android from M39 · aa52ced2

avayvod authored Sep 04, 2014

The template change to enable the printing policy for Android.

BUG=404807
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/545543002

Cr-Commit-Position: refs/heads/master@{#293310}

aa52ced2

Mark the root GN build target as test only. · b80a148e

brettw authored Sep 04, 2014

This will allow us to mark other things as tests as well.

Review URL: https://codereview.chromium.org/536203002

Cr-Commit-Position: refs/heads/master@{#293309}

b80a148e

[GCM] Adding GCMAccountMapper to link signed in profile to accounts. · c1047318

fgorski authored Sep 04, 2014

* Addes GCMAccountMapper with tests for adding and removing accoounts.

BUG=374969

Review URL: https://codereview.chromium.org/491443004

Cr-Commit-Position: refs/heads/master@{#293308}

c1047318

Bisect config params should alway be empty. · 6017d60f

prasadv authored Sep 04, 2014

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/537413002

Cr-Commit-Position: refs/heads/master@{#293307}

6017d60f

Only enumerate known WinUSB devices using chrome.usb, to avoid errors · 073b9b87

juanlang authored Sep 04, 2014

attempting to open HID devices using libusb.

BUG=410623

Review URL: https://codereview.chromium.org/540693002

Cr-Commit-Position: refs/heads/master@{#293306}

073b9b87

MSan: move the test specs from chromium.fyi to chromium.memory.fyi. · f95a312b

earthdok authored Sep 04, 2014

BUG=178409
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/539623002

Cr-Commit-Position: refs/heads/master@{#293305}

f95a312b

NaCl: Remove SRPC-based manifest tests. · 0dba8de0

Justin TerAvest authored Sep 04, 2014

irt_open_resource() is being refactored to stop using SRPC.
Testing should happen via the IRT instead of using the SRPC interfaces directly.

This change removes these tests entirely since an upcoming change will make
this SRPC interface unusable, except by PNaCl translator processes:
  https://codereview.chromium.org/418423002/

BUG=394130
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/535223002

Cr-Commit-Position: refs/heads/master@{#293304}

0dba8de0

[chromium] Remove XMLViewer.js/css post blink-in-js migration of XML tree viewer. · 9985c16e

vivek.vg authored Sep 04, 2014

CL, https://codereview.chromium.org/479753003, migrated the usage of XML tree viewer to
be implemented in blink-in-js. Post the migration, the files XMLViewer.js/css are no longer
used by any native code directly and hence should be removed.

Subsequent blink side CL would remove these files from the repository permanently.

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/540493002

Cr-Commit-Position: refs/heads/master@{#293303}

9985c16e

Add data-path restriction to tutorial, part 2. · 445060e4

jmedley authored Sep 04, 2014

BUG=none
R= jf@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/531183002

Cr-Commit-Position: refs/heads/master@{#293302}

445060e4

NaCl: Update revision in DEPS, r13679 -> r13687 · 2b25daca

dschuff authored Sep 04, 2014

This pulls in the following Native Client changes:

r13680: (bradnelson) Add back in android_tools, but in the right location.
r13682: (dyen) Added irt extension support for supplying the nacl_irt_memory interface.
r13683: (bradnelson) Disabling flaky test under asan.
r13684: (hans) service_runtime_x86_64.gyp: pass /nologo to ml64.exe
r13685: (mseaborn) Use uint32_t for untrusted pointer args: mmap() and munmap() syscalls
r13686: (jfb) LLVM 3.5 merge: add missing dependencies to PNaCl build
r13687: (dschuff) Build x86-32 IRT with PNaCl

R=mseaborn@chromium.org,bradnelson@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/537003002

Cr-Commit-Position: refs/heads/master@{#293301}

2b25daca

Revert "Certificate Transparency: Code for unpacking EV cert hashes whitelist" · 87bf0f71

Dmitry Lomov authored Sep 04, 2014

This reverts commit 743f614e.
It breaks X509CertificateTest.SHA256FingerprintsCorrectly on Vista.

BUG=339128
TBR=eranm@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/542673002

Cr-Commit-Position: refs/heads/master@{#293300}

87bf0f71

RenderTextHarfBuzz: Break runs at parentheses so they aren't affected by font fallbacks · f8d6f659

Cem Kocagil authored Sep 04, 2014

BUG=396776
R=msw@chromium.org, msw

Review URL: https://codereview.chromium.org/522343002

Cr-Commit-Position: refs/heads/master@{#293299}

f8d6f659

Add the base class for decoder buffers used in cast media. · c434502c

damienv authored Sep 04, 2014

Creates a decoder buffer base class that exposes only the properties
of a decoder buffer. This makes it possible to hide how a buffer
is created and how it is organized in memory, this is left
as an implementation detail of derived classes.

BUG=408189

Review URL: https://codereview.chromium.org/535563002

Cr-Commit-Position: refs/heads/master@{#293298}

c434502c

NaCl: Detect plugin crashes via EOF on Chromium IPC. · f3e9e0cb

Justin TerAvest authored Sep 04, 2014

This change uses the OnChannelError() callback in TrustedPluginChannel to
detect that the channel between the renderer and NaCl processes has closed.
Previously, closure of the SRPC channel between those two processes was used to
indicate a plugin crash.

I wasn't sure at first that OnChannelError() would be called, but it appears to
be called reliably in the testing that I've done.

This change removes a call to ReportCrash() in ServiceRuntime::ReapLogs() since
ReportCrash() has become a no-op.

This change reenables the NaClBrowserTest*.Crash tests on Linux to ensure that
there's good coverage-- they seem to pass.

TEST=NaClBrowserTest*.Crash
BUG=366334,401105
R=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/512323002

Cr-Commit-Position: refs/heads/master@{#293297}

f3e9e0cb

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #4... · c6df1044

lushnikov authored Sep 04, 2014

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #4 id:60001 of https://codereview.chromium.org/504823003/)

Reason for revert:
This patch broke icons in Developer Tools: crbug.com/410847

Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out.  Performance and
> correctness problems are both possible.  Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over.  This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=408985,409110
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan
>
> Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58

TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,fmalita@chromium.org,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408985,409110

Review URL: https://codereview.chromium.org/544643002

Cr-Commit-Position: refs/heads/master@{#293296}

c6df1044

Enable Certificate Transparency in the OpenSSL port. · eb5f8ef3

davidben authored Sep 04, 2014

Also add tests that assert OCSP responses and SCT extensions are returned in
the expected format.

BUG=408687
TEST=open https://embed.ct.digicert.com/ in Chrome for Android and
     tap the lock icon. Popup should say "The identity of this
     [...] and is publicly auditable."

Review URL: https://codereview.chromium.org/517083002

Cr-Commit-Position: refs/heads/master@{#293295}

eb5f8ef3

find_sdk.py: pylint clean · 9520d408

ukai authored Sep 04, 2014

W0105: 16,-1: String statement has no effect
C0323: 45,4:main: Operator not followed by a space
    print >>sys.stderr, out
           ^

BUG=

Review URL: https://codereview.chromium.org/539843002

Cr-Commit-Position: refs/heads/master@{#293294}

9520d408

Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of... · 42539711

dslomov authored Sep 04, 2014

Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/539713002/)

Reason for revert:
Breaks telemetry_perf_unittests on Mac.
Likely culprit is http://src.chromium.org/viewvc/blink?revision=181336&view=revision

	ASSERTION FAILED: (HashTableKeyChecker<HashTranslator, KeyTraits, HashFunctions::safeToCompareToEmptyOrDeleted>::checkKey(key))
	../../third_party/WebKit/Source/wtf/HashTable.h(645) : const ValueType *WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup(T) const [Key = blink::FontPlatformData, Value = WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, Extractor = WTF::KeyValuePairKeyExtractor, HashFunctions = blink::FontDataCacheKeyHash, Traits = WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, KeyTraits = blink::FontDataCacheKeyTraits, Allocator = WTF::DefaultAllocator, HashTranslator = WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, T = blink::FontPlatformData]
	1   0x5045c9b7 WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > const* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData) const
	2   0x5045c8fc WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData)
	3   0x5045fed9 WTF::HashTableIterator<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator> WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData const&)
	4   0x5045fe51 WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
	5   0x504556e8 WTF::HashMap<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int>, blink::FontDataCacheKeyHash, blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
	6   0x50454b28 blink::FontDataCache::get(blink::FontPlatformData const*, blink::ShouldRetain)
	7   0x50446962 blink::FontCache::fontDataFromFontPlatformData(blink::FontPlatformData const*, blink::ShouldRetain)
	8   0x504467f1 blink::FontCache::getFontData(blink::FontDescription const&, WTF::AtomicString const&, bool, blink::ShouldRetain)
	9   0x5046298f blink::FontFallbackList::getFontData(blink::FontDescription const&, int&) const
	10  0x504620c9 blink::FontFallbackList::fontDataAt(blink::FontDescription const&, unsigned int) const
	11  0x50461d9d blink::FontFallbackList::determinePitch(blink::FontDescription const&) const
	12  0x4384da35 blink::FontFallbackList::isFixedPitch(blink::FontDescription const&) const
	13  0x4384d6b9 blink::Font::isFixedPitch() const
	14  0x43841394 blink::RenderText::widthFromCache(blink::Font const&, int, int, float, blink::TextDirection, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>*, blink::GlyphOverflow*) const
	15  0x4383c04d blink::RenderText::computePreferredLogicalWidths(float, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>&, blink::GlyphOverflow&)
	16  0x4383ad0c blink::RenderText::computePreferredLogicalWidths(float)
	17  0x4383a603 blink::RenderText::trimmedPrefWidths(float, float&, bool&, float&, bool&, bool&, bool&, float&, float&, float&, float&, bool&, blink::TextDirection)
	18  0x4365b7ab blink::RenderBlockFlow::computeInlinePreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&)
	19  0x435f3d3c blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	20  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	21  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	22  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	23  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	24  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	25  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	26  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	27  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	28  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	29  0x438059b1 blink::RenderTableCell::computePreferredLogicalWidths()
	30  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	31  0x435766c8 blink::AutoTableLayout::recalcColumn(unsigned int)

Original issue's description:
> Blink roll 9d34a87:9a051c52
>
> https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf
> TBR=tkent@chromium.org,arv@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/203622e5b22fd772320684b7f8a1aa1fa4afc25b

TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/540023002

Cr-Commit-Position: refs/heads/master@{#293293}

42539711

Roll src/third_party/libjpeg_turbo from 2ed5319ce40b to 3963fbcd6c16 · 89b2f5cc

torne authored Sep 04, 2014

Just a trivial update to README.chromium.

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+log/2ed5319ce40b..3963fbcd6c16

NOTRY=true
R=mnaganov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/537973002

Cr-Commit-Position: refs/heads/master@{#293292}

89b2f5cc

[Android] JNI bridges for querying top level bookmark folders. · 78cb62e9

kkimlabs authored Sep 04, 2014

The new enhanced bookmark UI redefines what top folders are:
- Sub-folders of mobile node and others node.
- Desktop node.
- Managed bookmark node.
- Partner bookmark node.

So we need JNI bridge functions to query them.

BUG=386785

Review URL: https://codereview.chromium.org/516323003

Cr-Commit-Position: refs/heads/master@{#293291}

78cb62e9