GitLab

InitializeSession. This seems to be able to happen if too much time
elapses between the call to the constructor and the call to InitializeSession.

This fixes the fix from https://codereview.chromium.org/560913002

BUG=399147

Review URL: https://codereview.chromium.org/579533003

Cr-Commit-Position: refs/heads/master@{#295601}

These files were being removed twice from the sources.

TBR=viettrungluu

Review URL: https://codereview.chromium.org/568153006

Cr-Commit-Position: refs/heads/master@{#295600}

Currently, when distillation fails, the TaskTracker signals that a
source has finished. It then checks if all sources are done (and if not,
it will wait to call the callback). The check for sources done though
assumes that if distiller_ is non-null, then distillation is still in
progress. So, we should be deleting/releasing distiller_ when it
finished (and before signalling that the source is finished).

This also updates the standalone content extractor to fail if extraction
of some url fails.

Review URL: https://codereview.chromium.org/575883002

Cr-Commit-Position: refs/heads/master@{#295599}

This CL was reverted due to test failures. Under inspection, the test proved to
already be flaky. The test has been disabled. See http://crbug.com/415422 for
more details.

--------------Original CL Description-----------------

The menu item "Enter Presentation Mode" has different effects in 10.6 and
10.7+. In 10.6, the menu item invokes Immersive Fullscreen. In 10.7+, the menu
item invokes AppKit Fullscreen. Similar logic applies to fullscreen invoked by
an extension.

I accidentally changed this logic during the fullscreen refactor by removing
the 10.6 vs 10.7+ conditional. This CL adds back the conditional. I also
updated the code to explicitly indicate the mechanism that is invoking
fullscreen to prevent similar future mistakes.

Original CL: https://codereview.chromium.org/575653003/

BUG=NONE
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/576393002

Cr-Commit-Position: refs/heads/master@{#295598}

This patch moves OcclusionTracker::UnoccludedContentRect to Occlusion.
This reduces OcclusionTracker API and makes it consistent with
IsOccluded call.

Follow-up work here will remove occlusion_tracker from these functions
where possible and replace it with const Occlusion& occlusion.

R=danakj
BUG=410932

Review URL: https://codereview.chromium.org/576173003

Cr-Commit-Position: refs/heads/master@{#295597}

Layout test do not use compositor thread, so WebMediaPlayerAndroid ends
up using a null message loop.

BUG=412578

Review URL: https://codereview.chromium.org/586493002

Cr-Commit-Position: refs/heads/master@{#295596}

java_cpp_enum.gypi was creating all enums in the same root folder and
then adding that folder to its dependents generated_src_dirs. This has
two issues: first, incremental builds will include stale files when
things are moved/renamed/etc. second, all libraries that depend on such
an enum target will actually compile and include all the enum targets
(and in fact may even include different versions of one enum in
 different libraries).

This change just makes each such target use its own unique directory
(this will still have the stale enum issue when renaming an enum if the
 target name doesn't change, but that is very rare).

The GN version already used unique directories.

TBR=mkosiba

Review URL: https://codereview.chromium.org/578363002

Cr-Commit-Position: refs/heads/master@{#295595}

Apparently (?) unnecessary, and it sometimes hangs in that call.

This doesn't seem to help the 16s timeout (per tryjobs here), but
doesn't seem to hurt either, and I can run on a local VM this way
at least.

BUG=411147

Review URL: https://codereview.chromium.org/583443005

Cr-Commit-Position: refs/heads/master@{#295594}

StartupTimeBomb in 10 minutes.

Give more time for startup tasks to finish.

R=sky@chromium.org
BUG=396356

Review URL: https://codereview.chromium.org/581163003

Cr-Commit-Position: refs/heads/master@{#295593}

Revert of GCM: D-Bus methods for wake-on-packet (patchset #15 id:280001 of https://codereview.chromium.org/409883006/)

Reason for revert:
See issue https://code.google.com/p/chromium/issues/detail?id=415281

I bissected chrome to this patch and figured that this is causing chrome to crash.

Sorry.

Original issue's description:
> GCM: D-Bus methods for wake-on-packet
>
> Program the NIC to wake-on-packet for packets arriving from
> the GCM server.  Chrome notifies the connection manager (shill)
> by calling D-Bus methods.  The return status indicates if the
> operation succeeded or not (depending on hardware support and
> the type of connection).
>
> Keywords: wowlan, wake-on-lan, wake-on-wlan
>
> BUG=360295
> TEST=verified dbus methods are called, and packets are sent on the
> TEST=connection passed to the methods.  Also verified that shill
> TEST=programs the NIC correctly, and packets wake up the device.
>
> Committed: https://crrev.com/88a95a70fa94bb578b371490d0f9868584b7096e
> Cr-Commit-Position: refs/heads/master@{#294936}

TBR=derat@chromium.org,fgorski@chromium.org,stevenjb@chromium.org,zea@chromium.org,scheib@chromium.org,yoz@chromium.org,semenzato@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360295

Review URL: https://codereview.chromium.org/584753002

Cr-Commit-Position: refs/heads/master@{#295592}

BUG=412126

Review URL: https://codereview.chromium.org/565803002

Cr-Commit-Position: refs/heads/master@{#295591}

BUG=

Review URL: https://codereview.chromium.org/584643002

Cr-Commit-Position: refs/heads/master@{#295590}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=erg@chromium.org

Review URL: https://codereview.chromium.org/585673002

Cr-Commit-Position: refs/heads/master@{#295589}

Logical OR was used instead of bitwise OR.

BUG=415437

Review URL: https://codereview.chromium.org/585653003

Cr-Commit-Position: refs/heads/master@{#295588}

Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when extensions are disabled.

Review URL: https://codereview.chromium.org/559523004

Cr-Commit-Position: refs/heads/master@{#295587}

BUG=388987

Review URL: https://codereview.chromium.org/577123003

Cr-Commit-Position: refs/heads/master@{#295586}

During loop, player should not be in a paused state
This change fix that behavior

Layout test:https://codereview.chromium.org/585563003/

BUG=415651

Review URL: https://codereview.chromium.org/580093005

Cr-Commit-Position: refs/heads/master@{#295585}

This usage was mapped to XF86XK_Tools and remapped to VKEY_F13 on
chrome, which is used for LOCK (logout) causing confusion for some
users. This usage is supported on Windows and Android to launch the
default media player, therefore it is now mapped to
VKEY_MEDIA_LAUNCH_MEDIA_SELECT.

R=garykac@chromium.org, wez@chromium.org, adlr@chromium.org

BUG=398345

Review URL: https://codereview.chromium.org/442333002

Cr-Commit-Position: refs/heads/master@{#295584}

* Factor out code that can be used for both chrome/app_shell version from athena/extensions/chrome
* Create AppsClient/AppsDelegate for app_shell version.
* Removed CreateAppsClient as it's no longer necessary.

AthenaNativeAppWindow needs more work in order to work properly on athena. I'll address them in separate bug/CLs.

BUG=410448,410448
TBR=ben@chromium.org

Note: This CL depends on https://codereview.chromium.org/576863003/

Review URL: https://codereview.chromium.org/563083003

Cr-Commit-Position: refs/heads/master@{#295583}

R=rjshade@chromium.org, rch@chromium.org, asvitkine@chromium.org, rvargas@chromium.org

Review URL: https://codereview.chromium.org/427313002

Cr-Commit-Position: refs/heads/master@{#295582}

Debug bots became flaky with the notification turned on (crash in the
V8 idle handler). Disabling by default.

NOTRY=True
TBR=zmo@chromium.org,jochen@chromium.org
BUG=414815

Review URL: https://codereview.chromium.org/586523002

Cr-Commit-Position: refs/heads/master@{#295581}

More specifically, add Cmd+A and Cmd+V for making entering the password less sucky.

BUG=394575
TEST=Start Chrome with --enable-new-profile-management. Sign in a profile,
and from the avatar bubble, click on "Lock. In the User Manager that
shows up, Chrome shortcuts like Cmd+N and Cmd+T shouldn't work, but in
the password field of the locked pod things like Cmd+A and Cmd+V should.

Review URL: https://codereview.chromium.org/553133002

Cr-Commit-Position: refs/heads/master@{#295580}

* Add skeleton client-side and service-side MediaRenderer pieces with basic plumbing and connections but no real logic.
* model a media::DemuxerStream in a mojom to clean up MediaRenderer interface and line-up with RendererImpl expectations.
* add DecoderConfig plumbing support
* add a basic unittest verifying things do actually hook up
* consolidate around 'media_mojo_' naming in media.gyp and add media_mojo target to build all this stuff.

BUG=410451

Review URL: https://codereview.chromium.org/551963004

Cr-Commit-Position: refs/heads/master@{#295579}

increase

BUG=408257

Review URL: https://codereview.chromium.org/510943003

Cr-Commit-Position: refs/heads/master@{#295578}

BUG=415742
TBR=danbeam@chromium.org

Review URL: https://codereview.chromium.org/582233002

Cr-Commit-Position: refs/heads/master@{#295577}

BUG=415705

Review URL: https://codereview.chromium.org/582143002

Cr-Commit-Position: refs/heads/master@{#295576}

The following supressions are no longer needed:
bug_101151
bug_101159
bug_101345
bug_101347
bug_101751
bug_101781

BUG=101151,101159,101345,101347,101751,101781
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562593004

Cr-Commit-Position: refs/heads/master@{#295575}

This is a partial revert of some of the logic that was
removed by http://crrev.com/262526, but updated with
new logic to only do it when there is a version change
and we didn't generate an initial stability log. Plus,
the list of prefs that are reset is trimmed to only
the ones that need to be (per my auditing of the code).

BUG=409117

Review URL: https://codereview.chromium.org/580093004

Cr-Commit-Position: refs/heads/master@{#295574}

- Don't show access Address Book prompt if user has any Autofill state.
- Eliminate flickering of the access Address Book prompt.

BUG=414359

Review URL: https://codereview.chromium.org/575283003

Cr-Commit-Position: refs/heads/master@{#295573}

Add a global on/off switch for content settings and expose a toggle on the Website Settings options page.

TBR=miguelg@chromium.org
BUG=372607

Review URL: https://codereview.chromium.org/542253003

Cr-Commit-Position: refs/heads/master@{#295572}

The following supressions are no longer needed:
bug_106183a
bug_106183b
bug_106183c
bug_106402
bug_106552

BUG=106183,106402,106552
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/576033002

Cr-Commit-Position: refs/heads/master@{#295571}

The following supressions are no longer needed:
bug_100043
bug_100133
bug_100330
bug_100647
bug_100777
bug_100916

BUG=100043,100133,100330,100647,100777,100916
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/561883005

Cr-Commit-Position: refs/heads/master@{#295570}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c3a905f..2dc4bc6

TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/579403002

Cr-Commit-Position: refs/heads/master@{#295569}

Revert of Third attempt to land change to remove NativeViewportService and (patchset #2 id:20001 of https://codereview.chromium.org/578353002/)

Reason for revert:
all these tests are timing out on Win7 Tests (dbg)(4):mojo_view_manager_unittests -
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(4)/builds/28279

ViewManagerTest.CantAccessChildrenOfEmbeddedView
ViewManagerTest.SecondEmbedRoot_Service
ViewManagerTest.EmbedWithSameViewId2
ViewManagerTest.EmbedWithSameViewId
ViewManagerTest.ViewsRemovedWhenEmbedding
ViewManagerTest.CantGetViewTreeOfOtherRoots
ViewManagerTest.SetViewVisibilityNotifications
ViewManagerTest.CreateView
ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown
ViewManagerTest.GetViewTree
ViewManagerTest.ViewHierarchyChangedViews
ViewManagerTest.ReuseDeletedViewId
ViewManagerTest.AddViewWithNoChange
ViewManagerTest.ReorderView
ViewManagerTest.SetViewVisibility
ViewManagerTest.CantModifyChildrenOfEmbeddedView
ViewManagerTest.OnViewInput
ViewManagerTest.CantMoveViewsFromOtherRoot
ViewManagerTest.TwoClientsGetDifferentConnectionIds
ViewManagerTest.SetViewBounds

Original issue's description:
> Third attempt to land change to remove NativeViewportService and
> ViewManager from mojo_shell.
>
> Original cl was https://codereview.chromium.org/477923004/
>
> BUG=
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/9b5afe9fda3e59c856cbfc43367c2719df676af0
> Cr-Commit-Position: refs/heads/master@{#295537}

TBR=davemoore@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/577403002

Cr-Commit-Position: refs/heads/master@{#295568}

Change #294679 was lost in #294932

BUG=None

Review URL: https://codereview.chromium.org/583753002

Cr-Commit-Position: refs/heads/master@{#295567}

The test is flaky.

BUG=415422

Review URL: https://codereview.chromium.org/586443002

Cr-Commit-Position: refs/heads/master@{#295566}

Review URL: https://codereview.chromium.org/578203003

Cr-Commit-Position: refs/heads/master@{#295565}

http://llvm.org/PR20354 was fixed and rolled into Chromium in
the latest Clang roll.

BUG=none

Review URL: https://codereview.chromium.org/582583003

Cr-Commit-Position: refs/heads/master@{#295564}

This flags has the same effect as being part of the enabled
group of the DataCompressionProxyAlternativeConfiguration
field trial.

BUG=415185

Review URL: https://codereview.chromium.org/578883004

Cr-Commit-Position: refs/heads/master@{#295563}

Makes some Skia flags be matched properly.

e.g.

  '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
vs
  -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"

Diffs 393202 -> 374424.

It does make the script quite a bit slower unfortunately, I guess the
regular split is native C.

BUG=335824

Review URL: https://codereview.chromium.org/580213003

Cr-Commit-Position: refs/heads/master@{#295562}