GitLab

Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the GURL that was passed to URLRequest(const GURL&) is invalid.

BUG=http://crbug.com/21423

Review URL: http://codereview.chromium.org/192057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25903 0039d316-1c4b-4281-b951-d872f2087c98

Force preferences to save immediately when a theme is set, so that a browser crash does not corrupt the theme.

BUG= http://crbug.com/21488
TEST= Install a theme.  Force browser crash, and reopen. Note that theme images are not corrupted.

Review URL: http://codereview.chromium.org/200080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25902 0039d316-1c4b-4281-b951-d872f2087c98

Add a bogus Chrome/0.0.0.0 in case we fail to read file version info for
chrome.dll.  This should help anyone who is bringing up a new port know
that they need to make the file version info stuff work.

R=pkasting
BUG=4111
TEST=none

Review URL: http://codereview.chromium.org/193074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25901 0039d316-1c4b-4281-b951-d872f2087c98

These weren't referenced anywhere; we don't rely
on openssl.  They were just cruft.

BUG=none
TEST=builds fine without these files

Review URL: http://codereview.chromium.org/201082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25899 0039d316-1c4b-4281-b951-d872f2087c98

Fix some tests that were manually getting sourcedir from DIR_EXE instead of using DIR_SOURCE_ROOT.

BUG=none
TEST=rm -r out, ln -s /somedir/out out, run tests

Review URL: http://codereview.chromium.org/192064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25898 0039d316-1c4b-4281-b951-d872f2087c98

the same cleanup code as browser_window_gtk.

Also fix a leak of the gtk widgets when the accelerator was
not used for the task manager.  If the user closed by using the
window manager destroy, then we never called gtk_widget_destroy
on the window and leaked the widgets.

Review URL: http://codereview.chromium.org/202035


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25897 0039d316-1c4b-4281-b951-d872f2087c98

* enable MessageBoxView
convert wstring to string16 when necessary using WideToUTF16Hack, which is no-op on Windows.
* updated checkbox to get state update working
state handing is a bit hacky, esp. b/c gtk sends signal even when the state is changed via API.
If there is better way, please let me know.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/201079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25896 0039d316-1c4b-4281-b951-d872f2087c98

For now, as with other extension errors, these are not i18n'd.

The blacklist loading error is though because it is most like
an error to be shown to end users.

BUG=16932
TEST=none

Review URL: http://codereview.chromium.org/173357

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25895 0039d316-1c4b-4281-b951-d872f2087c98

Allow windows with a single tab to be merged into other windows with drag and drop. When there is a single window with a single tab, we treat it like a window move.
BUG=15108
TEST=dragging out windows and merging them back in, dragging windows around to move them. Test windows of different types (incognito) as well.
Review URL: http://codereview.chromium.org/199079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25894 0039d316-1c4b-4281-b951-d872f2087c98

using them for anything.

Review URL: http://codereview.chromium.org/192068


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25893 0039d316-1c4b-4281-b951-d872f2087c98

This needs to wait on a master.cfg update to make f_webkit_dbg_linux_builder build 'test_shell'.

TBR:mark


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25891 0039d316-1c4b-4281-b951-d872f2087c98

since r25855 V8 update.

BUG=21501
TEST=bot color
Review URL: http://codereview.chromium.org/195055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25889 0039d316-1c4b-4281-b951-d872f2087c98

With this change, Strict Transport Security is active by default and
doesn't need the --force-https flag any more.

http://codereview.chromium.org/193067


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25888 0039d316-1c4b-4281-b951-d872f2087c98

Content script code seemed old; updated to what worked for me.
Manifest code had an extraneous comma that caused an error.

TBR=aa,rafaelw

Review URL: http://codereview.chromium.org/196079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25887 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the missing requirement that test_shell was previously satisifying for test_shell_tests.

Review URL: http://codereview.chromium.org/201067


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25885 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/192061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25884 0039d316-1c4b-4281-b951-d872f2087c98

linked with g++ instead of gcc.
BUG=none
TEST=build without warnings
Review URL: http://codereview.chromium.org/202046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25883 0039d316-1c4b-4281-b951-d872f2087c98

TBR=aa,rafaelw

Review URL: http://codereview.chromium.org/202047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25882 0039d316-1c4b-4281-b951-d872f2087c98

Improves a code block in in_process_browser_test, avoids the use of FilePath::FromWStringHack and the use of a deprecated function.

Patch by tfarina.

BUG=None
TEST=run browser_tests.exe 

Review URL: http://codereview.chromium.org/192035


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25881 0039d316-1c4b-4281-b951-d872f2087c98

Only difference is explicitly calling a FreePerDisplaySurfaces() function from
~GtkThemeProvider() because vtables are set to base class during destructor
calling.

BUG=http://crbug.com/10499
Original Review URL: http://codereview.chromium.org/197046

Review URL: http://codereview.chromium.org/199077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/200045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25879 0039d316-1c4b-4281-b951-d872f2087c98

required changes.

This way future merging would be much easier.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/201034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25878 0039d316-1c4b-4281-b951-d872f2087c98

Linux: set the process title (that shows in "ps" etc.) of renderers correctly when using the zygote.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/196009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25877 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit suppression count report patch, but this time don't crash if that section of the xml file is missing/empty

Review URL: http://codereview.chromium.org/203018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25876 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=19361

Review URL: http://codereview.chromium.org/199076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21383
TEST=covered by current unit tests.


Review URL: http://codereview.chromium.org/201065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25873 0039d316-1c4b-4281-b951-d872f2087c98

The difference between repaint areas is due to the difference in repaint logic.
Safari/Mac port uses NSView's native 
rectangle collection/unification, and we just unify all into one damage rect.

R=jparent
BUG=8630
TEST=none

Review URL: http://codereview.chromium.org/193070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25872 0039d316-1c4b-4281-b951-d872f2087c98

Add exe servers to the list of binaries that may be packaged with the mini_installer. Does not cause them to be registered.

Review URL: http://codereview.chromium.org/202044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25871 0039d316-1c4b-4281-b951-d872f2087c98

Adding a --do-not-create-shortcuts command line switch to the installer to prevent it from trying to create Chrome desktop shortcuts.

Review URL: http://codereview.chromium.org/196068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25870 0039d316-1c4b-4281-b951-d872f2087c98

We run diff-index to see if there are any changes we need to pull in,
but we don't need it to print all of those changes.

Review URL: http://codereview.chromium.org/202045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20653
TEST=Mac Valgrind UI bots

Review URL: http://codereview.chromium.org/199062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25868 0039d316-1c4b-4281-b951-d872f2087c98

Supressing the referrer header in the automation url request job when going from a secure to non-secure URL.

Also calling OnSSLCertificateError in case of certificate errors.

TEST=Run automation tests.
BUG=none

Review URL: http://codereview.chromium.org/195054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25867 0039d316-1c4b-4281-b951-d872f2087c98

This fix the build.

TBR=phajdan

Review URL: http://codereview.chromium.org/201081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25866 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/202033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25864 0039d316-1c4b-4281-b951-d872f2087c98

interactive UI tests, so the interactive UI tests can be run isolated.

BUG=None
TEST=Run the the interactive ui tests with the new launcher:
     test_launcher --lib=interactive_ui_tests_dll

Review URL: http://codereview.chromium.org/197045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25863 0039d316-1c4b-4281-b951-d872f2087c98

as the default action.  Buttons with destructive actions should never be
the default.

This removes the return key equivalent from the Clear Browsing Data button.
It also adds an escape key equivalent to the Cancel button, so that it will
blink appropriately in response to both escape and command-period.

BUG=21461
TEST=Look and try as above
Review URL: http://codereview.chromium.org/194068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25862 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/21290
TEST= Install a theme without an NTP image (greyscale).  Look at NTP with bookmarkbar attached and detached.  See no white box at bottom of NTP.

Review URL: http://codereview.chromium.org/194066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25861 0039d316-1c4b-4281-b951-d872f2087c98

This is an optimization, and also helps stability. Fixes an intermittent DCHECK
I was hitting while working on unrelated parts of code.

TEST=There are DCHECKs that make sure the new code is valid.
BUG=none

Review URL: http://codereview.chromium.org/200069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15494
TEST=none

Review URL: http://codereview.chromium.org/203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25859 0039d316-1c4b-4281-b951-d872f2087c98