GitLab

Currently the intents to be handled in the foreground instance of
CustomTabActivity are delivered via a static reference in
BrowserSessionContentUtils, instead of delivering the intent via
ordinary Android mechanisms. This means, in particular, that intent
flags are lost in the process.

This poses a problem for "Single activity" TWA apps, specifically for
their ability to forward new incoming View intents to the running TWA.
We'd like this forwarding to be possible, and to work "out of the box"
with LauncherActivity.

Currently it works as follows. LauncherActivity starts a TWA, and keeps
running in background - this allows to customize it so that it would
continue communicating with TWA via CustomTabConnection. If a new
View intent comes in, it starts a new instance of LauncherActivity,
which in turn creates ChromeLauncherActivity, so the stack is:

LauncherActivity | CTA | LauncherActivity | ChromeLauncherActivity

ChromeLauncherActivity calls CTA via a static method, and kills itself,
which leaves the second LauncherActivity running. Setting SINGLE_TOP and
CLEAR_TOP intent flags on the client won't help, because these flags won't
reach CTA.

In this CL I make ChromeLauncherActivity launch CTA with SINGLE_TOP and
CLEAR_TOP if there is a foreground CTA with matching session. Otherwise,
the intent handling is kept the way it was, with all the logic untouched.

The fallback solution, in the case this one won't work out, is to just
call  finish() in LauncherActivity once it has launched a TWA. This would
mean it won't be able to both do the intent routing and keep communicating
via CustomTabConnection (and probably no client implementation would be
able to), which isn't good, but might not be a blocker for MVP release.

Companion CL: http://crrev.com/c/1349363

Bug: 907796
Change-Id: I8a2396b325baae2974d6b0dfb73c2ed2fb0519eb
Reviewed-on: https://chromium-review.googlesource.com/c/1349653
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611375}

This CL changes URLRequestFileJob to not suspend file url requests when the
system suspends. There is no reason to suspend requests which don't require
network activity.

This helps solves bugs where extension event listeners are not registered as
the request for extension background scripts are aborted on system suspend.

BUG=898494

Change-Id: I3ce676fc6dc204c8c58d282d5ed0e81f97b5cc2c
Reviewed-on: https://chromium-review.googlesource.com/c/1351730
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611374}

There should be no behaviour change.

Bug: 635619
Change-Id: I0e885c53a27c07a85e64371f3e6edfcbd17d01f8
Reviewed-on: https://chromium-review.googlesource.com/c/1352442Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611373}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d543f7dfed9b..dab634da93d3


git log d543f7dfed9b..dab634da93d3 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 zoddicus@users.noreply.github.com Ensure that function parameter's type is not void (#2118)
2018-11-27 zoddicus@users.noreply.github.com Restrict capabilities to WebGPU spec (#2113)
2018-11-27 40001162+alelenv@users.noreply.github.com Add precise check for allowing use of gl_InstanceID for specific vulkan raytracing stages . (#2096)
2018-11-27 stevenperron@google.com Add validation for OpArrayLength. (#2117)
2018-11-26 afdx@google.com New spirv-reduce reduction pass: operand to dominating id. (#2099)
2018-11-26 33432579+alan-baker@users.noreply.github.com Prevent diagnostic memory leak (#2110)
2018-11-26 stevenperron@google.com Change HexFloat to work with gcc8. (#2109)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@dab634da93d3

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id4dac84b9b212adee52a8f81fca7df90f308357c
Reviewed-on: https://chromium-review.googlesource.com/c/1352243Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611372}

R=dpranke, jbudorick

Bug: 902468
Change-Id: Id7e4909528758fd24a22e00696e905346a06b950
Reviewed-on: https://chromium-review.googlesource.com/c/1352267Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611371}

Channel count in the IDL is a 32 bit integer. Ensure we use that
and not a 64 bit integer in C++.

BUG=879657

Change-Id: I6415d2d0965f8b4dbd2aa79d831ef8dfc1f49038
Reviewed-on: https://chromium-review.googlesource.com/c/1348969Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611370}

This change breaks up the UNKNOWN_FAILURE bucket into more detailed
values so that we can better determine where errors are happening.

Bug: chromium:902923
Change-Id: I814466b081ce5ad0371fff7cd843ed8dd9e9c2e5
Reviewed-on: https://chromium-review.googlesource.com/c/1340976
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611369}

This test was disabled due to flakiness on Windows7 sp1.

BUG=644614

Change-Id: Id48da1b956c38681d1aa16d0a8de95155fc875a2
Reviewed-on: https://chromium-review.googlesource.com/c/1345416Reviewed-by: Qiang Chen <qiangchen@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611368}

Bug: None
Change-Id: Ib74322b81e40283ab84160a3f3375d98b6d5376a
Reviewed-on: https://chromium-review.googlesource.com/c/1348952Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611367}

The feature is enabled by default.  The feature flag is:
SupervisedUserDeprecationNotice.

Bug: 899017
Change-Id: Ibe8257043fae62e6bad7f98c3ec936803f75afed
Reviewed-on: https://chromium-review.googlesource.com/c/1344871Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611366}

It is shown when the response contained api error.
This prevents user from deleting those cards when migration
failure is probably due to server error.

Uploaded screenshot in bug comment#18

Bug: 897998
Change-Id: I828c6560f39e5383c25822631ed15fbc47e05222
Reviewed-on: https://chromium-review.googlesource.com/c/1332410
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611365}

Since HTTPS Server Previews will also send pingbacks, and we don't want
a lot of copied code, this factors all DRP pingback logic out into a
shareable base class. The histogram recording stays in the DRP Observer.

Also factors out a test_utils class for testing pingbacks.

This CL has no behavorial changes to pingbacks themselves. However, in
the next CL, the OnCommit logic will move from the base class to the
derived classes.

Bug: 864665
Change-Id: I569bc58331b45b71ae702149e43a2630d523e6dc
Reviewed-on: https://chromium-review.googlesource.com/c/1351497
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611364}

Analogous to similar methods in Point and Size.

These are used to simplify layout computation in a follow-up CL.

Change-Id: If509de376cd1395f1d85aa5abe1121662e94629c
Reviewed-on: https://chromium-review.googlesource.com/c/1351081
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611363}

Bug: 906202
Change-Id: I8607465f4657eb5c7c96e1ad85a51f4e8206cbfc
Reviewed-on: https://chromium-review.googlesource.com/c/1340532Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611362}

Bug: 908812
Change-Id: Ide5ecaee607468d953cfec54c1c465bd2ed8f96e
Reviewed-on: https://chromium-review.googlesource.com/c/1351945
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611361}

I stopped working on Chrome for 1.5y and didn't check my @chromium.org
email too often. I want to speed folks up that need help reviewing.

This is essentially revert of crrev.com/7a2607b8 (but we've removed a lot
of old code so I couldn't apply revert cleanly!).

R=dpapad@chromium.org
TBR=michaelpg@chromium.org
CC=​​groby@chromium.org
BUG=leaving chrome

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia6ecf786537fe11ac4808b2a38fe5494cb0d1365
Reviewed-on: https://chromium-review.googlesource.com/c/1309321Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611360}

What's been addressed:
add private/type annotation for navigationListener_ in activity_log.js

use logical css properties (margin/padding) for RTL support

remove trivial/default resolve function bodies in service.js

remove unnecessary type annotation (primitive type) in manager.js:100

add arrow icon to "View activity log" link from details page

remove excessive padding on the bottom of the activity log page,causing
scrolling to occur despite the page not having much content

Change-Id: I97bd2a77166ff212fe2204130c5c1783244053e6
Reviewed-on: https://chromium-review.googlesource.com/c/1345075Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611359}

Fix the issue by:
* Use the default color matrix for paint canvas.
* For SW, we use correct gl format and type to upload pixel data
  to texture with SubTexImage2D().


Bug: 907894
Change-Id: I81f2002a6dba7e048183634e6eb3f31fea69aee6
Reviewed-on: https://chromium-review.googlesource.com/c/1352450
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611358}

This approach adds 2 extra process hops before the request, and once
the headers are received to allow modification of headers that are set
and used within //net. A new "extraHeaders" value is added to the
opt_extraInfoSpec enum of onBeforeSendHeaders/onSendHeaders/
onHeadersReceived, which will trigger this behavior. The process hops
will only be done if there is a listener with the "extraHeaders" option
that matches the request registered when the request starts.

To do the header modification, a TrustedURLLoaderHeaderClient can be
set on URLLoaderFactoryParams which will be called from the network
delegate at the required times if the kURLLoadOptionUseHeaderClient
option is set on the request. This interface has methods to modify
the request and response headers, which will pause the request until
the callback is called with the result of the header modification.
These methods expose the sensitive "set-cookie" response header
(which is normally stripped when response headers are serialized for
IPC) by serializing the full headers to a string before sending. This
is safe because only the browser process is able to set the header
client on the URLLoaderFactoryParams that will have access to this
header. The TrustedURLLoaderHeaderClient pipe should never be passed
to an untrusted process.

Bug: 827582
Change-Id: If31ac82d91de1fd2c745a2f05ebbb14130713b3e
Reviewed-on: https://chromium-review.googlesource.com/c/1338165Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611357}

These metrics all measure the "effective success rate" of various
sub-tasks of creating a connection. In this context, the effective rate
includes retries, meaning that a failure followed by a successful retry
is counted as one "success" metric.

Metrics added in this CL:
  * Start scan ==> GATT connection
  * Start scan ==> Authentication
  * GATT connection ==> Authentication

Bug: 870139
Change-Id: Ic8796cf7501d9a1ecf3fb08ec788e1f0a487488e
Reviewed-on: https://chromium-review.googlesource.com/c/1344999
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611356}

Previously, this action would only allow setting the text of input fields. Now, it also supports pressing Enter or any other available key on the keyboard.

Bug: 806868
Change-Id: If1617d444790575c14f8f822df8b20938d592863
Reviewed-on: https://chromium-review.googlesource.com/c/1350609
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611355}

There are several uses of |privates| in the guest view js that are used
as if it were a means of making properties inaccessible from outside a
class (like what private does in C++). |privates| only hides
properties from outside the extension system implementation.

We remove uses of |privates| where the receiver is already inaccessible
from outside the extension system implementation.

Bug: 900940
Change-Id: Ib583aefe9daa22e095d387ffab430429870796fc
Reviewed-on: https://chromium-review.googlesource.com/c/1336052Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611354}

When a page requests permissions, a prompt will show on the desktop
display. This change allows a notification to show in-headset so the
user knows to look at the prompt on the desktop display.

BUG=819448

Change-Id: I55801326c41b1b152da5ee80ed7ef62107184de8
Reviewed-on: https://chromium-review.googlesource.com/c/1332690
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611353}

Also changes what happens when the drag ends during a nested move loop.  It
now exits the move loop (which triggers a drag end) instead of immediately
ending the drag.

This is the first step in a larger refactoring for TabDragController:
go/tabdragcontroller-untangling

Change-Id: I6cabc5237a604320c934bb8b5d4bbc9ff6d231f0
Reviewed-on: https://chromium-review.googlesource.com/c/1285085
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611352}

https://pdfium.googlesource.com/pdfium.git/+log/b4c95fe2ded4..adb9e705092b


git log b4c95fe2ded4..adb9e705092b --date=short --no-merges --format='%ad %ae %s'
2018-11-27 tsepez@chromium.org Add Widestring::{To,From,Is}ASCII()


Created with:
  gclient setdep -r src/third_party/pdfium@adb9e705092b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iac2e589d589766a109f33f92547f6e36dc6cd953
Reviewed-on: https://chromium-review.googlesource.com/c/1352246Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611351}

This CL lands server change 221616382 by bnc.

BUG=488484

Change-Id: I2f8d913b85d57a565da11572e8dc87b6c3a6495b
Reviewed-on: https://chromium-review.googlesource.com/c/1341092Reviewed-by: Dianna Hu <diannahu@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611350}

Test parsing and computed value for
https://drafts.csswg.org/css-position/

- bottom left right top
- position
- z-index
- inset-after inset-before inset-end inset-start (not currently implemented)

Change-Id: I586271fe584fadb19e5683a2781c32142fd9001a
Reviewed-on: https://chromium-review.googlesource.com/c/1350409Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611349}

Prior to the conversion to MVC, there was de-duping logic:
https://chromium.googlesource.com/chromium/src/+/d9d67649e98707fbf2622e964bf1bf8f8f548a46/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java#1728

In the MVC conversion, this was dropped because the view
de-dupping was enhanced, but that discounted the fact that
notifyDataSetChanged always triggers a relayout on the
ListView even if the data is the same and would be no-op'd
when updating the individual views.

This ensures that we are not triggering unnecessary layouts
as we get duplicate omnibox suggestions.

With naive logging, I was seeing that each keystroke was
getting at least one set of duplicate suggestions received,
so this should save many layouts during the course of typing.

BUG=905742

Change-Id: I8ec9e5794c4e43687c7a30fc944976c6d63cbce9
Reviewed-on: https://chromium-review.googlesource.com/c/1352188
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611348}

Does not remove/change any code except for the simple decision logic that's using the feature.

Bug: 870836
Change-Id: If6f0bc54954cc1d95c6be4f4a1426e51327cefad
Reviewed-on: https://chromium-review.googlesource.com/c/1350909Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611347}

A WebAPK is valid if all the requirements below are true:
Requirement#1: The APK is correctly signed (WebApkValidator#isValidWebApk())
Requirement#2: The APK handles the URL in the intent (WebApkValidator#canWebApkHandleUrl())
Requirement#3: The APK has <meta-data> in a format that Chrome can read.
  (WebApkInfo#create() returns non-null)

This CL changes the logic in WebappLauncherActivity to make Requirement#3 clearer. This CL:
- Introduces WebappInfo#isForWebApk() and makes WebappLauncherActivity use this instead
  of the return value of WebappLauncherActivity#isValidWebApk() which did not check
  Requirement #3.
- Changes WebApkValidator#canWebApkHandleUrl() to no longer check whether the passed in
  APK package is a valid WebAPK. This reduces the number of extras read directly in
  WebappLauncherActivity (outside of WebApkInfo#create/WebappInfo#create)

BUG=901954

Change-Id: I51ef612c641d9d7c2e9535db33f0baee17694edb
Reviewed-on: https://chromium-review.googlesource.com/c/1351456
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611346}

 - remove drive_sync_handler_unittest.html
 - add BUILD rules to auto-generate and compile this unit test
 - BUILD: progress center does depends on cr.EventTarget
 - BUILD: drive sync handler does depend on AsyncUtil.Queue
 - define and use a mockChrome, and install it during tests
 - fix Closure compile errors

Bug: 907964
Change-Id: I464f4fb43e2ab145f1a6c85b53f8292a8a2c69fc
Reviewed-on: https://chromium-review.googlesource.com/c/1352113
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611345}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b1a6401f31b..af1cdca8c140


Created with:
  gclient setdep -r src-internal@af1cdca8c140

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:904780,chromium:767130
TBR=mmoss@chromium.org

Change-Id: Ia8900c03cbe783391f05b9bdf387a46221f1cc10
Reviewed-on: https://chromium-review.googlesource.com/c/1352237Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611344}

The |argument_filter_predicate_| is not set in the GPU process.
The CHECK is triggered in the GPU process when flushing the buffer.

void TraceLog::FinishFlush(int generation, bool discard_events) {
  [...]
    if (trace_options() & kInternalEnableArgumentFilter) {
      CHECK(!argument_filter_predicate_.is_null());
      argument_filter_predicate = argument_filter_predicate_;
    }

7923:197923:1121/151153.522324:FATAL:trace_log.cc(997)] Check failed: !argument_filter_predicate_.is_null().


We tried with a CHECK to catch this case early in
base::trace_event::TraceLog::SetEnabled(...).
Which make the test fail here:

[202280:202280:1121/152013.218605:FATAL:trace_log.cc(587)] Check failed: !trace_config.IsArgumentFilterEnabled() || !argument_filter_predicate_.is_null().

The current solution is to provide a default safe predicate filter in this case.

R=oysteine@chromium.org

Bug: 642991
Change-Id: Id52357299d170e66596081b8a020a42f9589754e
Reviewed-on: https://chromium-review.googlesource.com/c/1348633
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611343}

This will lessen the code review noise in an upcoming commit.

Change-Id: I4e933def4b6a10f45ce7545ce990c646a04a7aa4
Reviewed-on: https://chromium-review.googlesource.com/c/1349512Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611342}

When offering save of expired credit cards with the expiration date fix flow,
disables showing the outdated expiration date initially imported (because it
will be changed to whatever the user enters in the fix flow anyway.)

Bug: 899057
Change-Id: I79c1861046768f0f5470e4c73834784472f29f91
Reviewed-on: https://chromium-review.googlesource.com/c/1350880
Commit-Queue: Hao Zhang <hozhng@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#611341}

This relands commit f481306a. The CL
got reverted because BrowserMainLoopTest.CreateThreadsInSingleProcess
is falling on Windows. In this CL, we remove the call of
BrowserMainLoop#InitilaizeMojo() which isn't necessary for the test.

Beside, also re-enable two tests which were disabled when the reverting
CL landed:
 * RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler

The original cl description is:
This CL instantiates the ServiceManagerContext before creating
the BrowserMainRunner. It splits the startup path into two,
with/without starting the full browser. The changes are implemented
behind a flag "allow-start-service-manager-only".

Bug: 846846,902311
Change-Id: I6e3f6518e414e1298e57b55bd188879461d8f342
Reviewed-on: https://chromium-review.googlesource.com/c/1327413
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611340}

Bug: 889029
Change-Id: Ib8e3967d73a0844ba0d0a9ddb318168e0de1594d
Reviewed-on: https://chromium-review.googlesource.com/c/1349459
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611339}

Move to 4 targets:
common_lib, ui_lib, test_lib, app_framework

Based on the EG2 xcodeproject on github.

Also rolled EG2 to a more recent commit hash.

Bug: 906201
Change-Id: Ifee6d4de17d8df930ac4760714ee32b0cab89cb5
Reviewed-on: https://chromium-review.googlesource.com/c/1340531Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611338}

This is a reland of 409ceb85

Original change's description:
> GWP-ASan: Add crash handler hook.
>
> After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad
> UserStreamDataSource) is responsible for looking at the crash and
> 1) determining if the exception was related to GWP-ASan, and 2) adding
> additional debug information to the minidump if so.
>
> The crash handler hook determines if the exception was related to
> GWP-ASan by finding the AllocatorState address (using a crash key),
> reading the allocator state and seeing if the exception occurred in the
> bounds of the allocator region. If it did, we extract debug information
> about that allocation and report it in the minidump.
>
> CQ-DEPEND=CL:1339246
>
> Bug: 896019
> Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a
> Reviewed-on: https://chromium-review.googlesource.com/c/1330283
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611033}

TBR=bcwhite@chromium.org

Bug: 896019
Change-Id: Ibc35c33ccc816cd2436412e2c6f399908161e7e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351935
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611337}

This change moves the error toast to the dialog when mounting an SMB
share.

Previously the flow was:

- Click add mount
- Dialog closes to SMB Shares parent page
- Error/success string is displayed on parent page

Now the flow will be:
- Click add mount
- Dialog stays open but add button becomes disabled
- Error/success string is displayed on dialog itself

An added advantage of this change is that it improves user experience
as it is easier for users to debug error cases when the dialog is still
open and they can still see the information they entered.

Bug: chromium:887135
Test: browser_tests --gtest_filter=CrSettingsSmb*
Change-Id: I6f68cd71a0002372a45975b3d8602809b36a6754
Reviewed-on: https://chromium-review.googlesource.com/c/1316664
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611336}