GitLab

BUG=379170
TBR=asargent

Review URL: https://codereview.chromium.org/318483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274606 0039d316-1c4b-4281-b951-d872f2087c98

The GUID property is used to pick user settings, policies and active settings for the same network. Thus it's more an identifier than a property and should not be exposed with additional meta information as it is the case for other properties.

BUG=372337

Review URL: https://codereview.chromium.org/291553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379812
TEST=GestureRecognizerTest.LatencyPassedFromTouchEvent

Review URL: https://codereview.chromium.org/309823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274602 0039d316-1c4b-4281-b951-d872f2087c98

The DesktopMediaListAsh uses the AuraWindow's title as the description
for the desktop source (window or screen.) To ensure that the display's
description appears we need to set the root window's title to the
display's name. This display name matches the name shown in the display
configuration UI.

BUG=372444
TEST=In a multiple display environment trigger the picker and observe
that the displays' names are included and match those in the display
settings UI.

Review URL: https://codereview.chromium.org/314733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274599 0039d316-1c4b-4281-b951-d872f2087c98

This wrapper isn't providing much benefit; we may as well tear it out. This
also removes the LengthComputable enum.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/316653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274598 0039d316-1c4b-4281-b951-d872f2087c98

- We don't have to use DefaultActivationController because
  wm::FocusController provides activation controls.
- FocusController should be registered as a pre-target handler
  to change the focus on mouse click.
- InitializeInputMethodForTesting seems unnecessary. Text input
  is working well while no actual input methods are available.

BUG=None
R=jamescook@chromium.org, oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/310463010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274596 0039d316-1c4b-4281-b951-d872f2087c98

Certificate verification still won't be functional and VERIFY_FAILED will
NOTREACHED() on a debug build, but this is probably better-behaved than a
NullPointerException, and we try to handle other initialization failures.

BUG=376660

Review URL: https://codereview.chromium.org/316613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274595 0039d316-1c4b-4281-b951-d872f2087c98

Update the textinput_helper.js text helper to support subpixel
precision for element coordinates.

R=nona@chromium.org

Review URL: https://codereview.chromium.org/309303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362887

Review URL: https://codereview.chromium.org/290143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274593 0039d316-1c4b-4281-b951-d872f2087c98

Removes TODOs, adds some more important details and an example to the documentation.
Makes the documentation appear on the official developer.chrome.com page.

BUG=364435

Review URL: https://codereview.chromium.org/312503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274591 0039d316-1c4b-4281-b951-d872f2087c98

Adds whitelisted non-extension-based input methods if no component extensions are at present (e.g. linux_chromeos).
And also clean up some useless code.

BUG=364712
TEST=Verified it works on linux_chromeos and no regression on Pixel device.

Review URL: https://codereview.chromium.org/306053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274589 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This broke NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to pass on the right trybot before landing. I'm not sure why it broke yet.

Original issue's description:
> Pepper: Refactor OpenManifestEntry.
> 
> This change pulls out more OpenManifestEntry code from service_runtime, making
> PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
> logic out of the trusted plugin.
> 
> BUG=239656
> R=dmichael@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530

TBR=dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239656

Review URL: https://codereview.chromium.org/318463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274588 0039d316-1c4b-4281-b951-d872f2087c98

The navigation transition needs the transition page to render transparently over top the current tab, so we need to expose this call to java.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5
BUG=370696

Review URL: https://codereview.chromium.org/284413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274587 0039d316-1c4b-4281-b951-d872f2087c98

Request interceptors are the new way to handle intercepting URL
requests, to be used by ServiceWorkers and AppCache.  This CL
hooks them up to the URLRequestContext in AndroidWebview.

BUG=350286

Review URL: https://codereview.chromium.org/294023015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274586 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378785
NOTRY=true

Review URL: https://codereview.chromium.org/305393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/317443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274583 0039d316-1c4b-4281-b951-d872f2087c98

Also, changes a condition to a switch to
make compiler warn if a new enum value is
added.

BUG=none

Review URL: https://codereview.chromium.org/310483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274582 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274581 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
CID=115568

Review URL: https://codereview.chromium.org/302003014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274580 0039d316-1c4b-4281-b951-d872f2087c98

r168: Have grit survive a Windows registry with Unicode keys.
Review: https://codereview.chromium.org/253443002

R=thakis@chromium.org
BUG=365188

Review URL: https://codereview.chromium.org/310773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274579 0039d316-1c4b-4281-b951-d872f2087c98

They found that they had subdomains that weren't ready.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274576 0039d316-1c4b-4281-b951-d872f2087c98

Steps to reproduce:
1. Type some keys in |mUrlTextView| to show some suggestions.
2. Press "Go" button.

What heppended:
The url loading starts but the suggestions does not disappear.

BUG=none

Review URL: https://codereview.chromium.org/312673007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274575 0039d316-1c4b-4281-b951-d872f2087c98

This is another attempt to try to figure out where we are really
hanging when this test hangs on the Win7 WebRTC bot.

no-try to bypass flaky win_rel bot.

TBR=grunell@chromium.org
BUG=373252
NOTRY=true

Review URL: https://codereview.chromium.org/309273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274574 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378414
TEST=several unittests

Review URL: https://codereview.chromium.org/309793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274570 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175314:175351&mode=html

TBR=jchaffraix@chromium.org
NOTRY=true (don't trust the Android try-bot to be correct, will stick around)
BUG=

Review URL: https://codereview.chromium.org/315603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274569 0039d316-1c4b-4281-b951-d872f2087c98

Update native modifier state to reflect the rewritten ui::Event state before the X11 mouse code uses it.

Also splits code for the various ui::Event subclasses out of RewriteEvent() for clarity.

BUG=372485
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/280413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274568 0039d316-1c4b-4281-b951-d872f2087c98

This broke various builds (http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/54738/steps/runhooks/logs/stdio for example) since chrome_renderer.gypi (and maybe other files) still have refernces to the old location of these resources.

> Move some extensions renderer resources to extensions_renderer_resources.grd.
> 
> This breaks the remaining dependency from src/extensions to chrome resources files.
> 
> BUG=368334
> 
> Review URL: https://codereview.chromium.org/307833002

TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/309413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None 
CID=115769

Review URL: https://codereview.chromium.org/309113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274564 0039d316-1c4b-4281-b951-d872f2087c98

Populates the count of entities per type in about:sync.

Includes C++ code to count and emit the set of deleted and non-deleted
counts, though for space reasons only the non-deleted count is displayed
on the about:sync page.

This calculation is somewhat expensive.  It could be made cheaper by
having an index in the Directory to keep track of which entities belong
to which type, but that doesn't exist at the moment.  For now, we just
avoid calculating these counts unless the about:sync page is open.

BUG=349301

Review URL: https://codereview.chromium.org/302283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331453,380238
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/309403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274562 0039d316-1c4b-4281-b951-d872f2087c98

Apparently libtool on Mac doesn't understand the "@" syntax.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/309113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274561 0039d316-1c4b-4281-b951-d872f2087c98

* Remove null check
* Simplify NestedAcceleratorDelegate interface.

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/312483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274560 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/291933002 solved
these suppressions.

BUG=364675,158510

Review URL: https://codereview.chromium.org/308713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274559 0039d316-1c4b-4281-b951-d872f2087c98

This breaks the remaining dependency from src/extensions to chrome resources files.

BUG=368334

Review URL: https://codereview.chromium.org/307833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274558 0039d316-1c4b-4281-b951-d872f2087c98

Currently, subprocess_mu_ is held the entire time the ld subprocess is
starting. This blocks a larger refactor that I'd like to make as part of nexe
loading.

I'd like to change ServiceRuntime::LoadModule() to be asynchronous to simplify
threading behavior on the plugin side when loading nexe modules. However, this
requires that many methods are made asynchronous, including
Plugin::LoadHelperNaClModule().

PnaclTranslateThread will need to use a pattern similar to WaitForSelLdrStart()
to resume execution on a background thread. However, I don't like the idea of
introducing another mutex and condvar to deal with while holding
subprocess_mu_.

This change narrows the time that subprocess_mu_ is held to make that refactor
possible. This follows a similar change made for the llc subprocess.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/308193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274557 0039d316-1c4b-4281-b951-d872f2087c98

Broke BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp on Linux Clang (dbg) and other bots: 
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Clang%20%28dbg%29&number=60356 

[ RUN ] BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp 
[26813:26813:0603/095344:697268828:FATAL:render_process_host_impl.cc(501)] Check failed: is_self_deleted_. RenderProcessHostImpl is destroyed by something other than itself 
#0 0x7fb30098e8de base::debug::StackTrace::StackTrace() 
#1 0x7fb300a21b85 logging::LogMessage::~LogMessage() 
#2 0x7fb308595006 content::RenderProcessHostImpl::~RenderProcessHostImpl() 
#3 0x7fb3085955a9 content::RenderProcessHostImpl::~RenderProcessHostImpl() 
#4 0x000000eef1df (anonymous namespace)::BookmarkAppHelperExtensionServiceTest::TearDown() 
#5 0x0000039dd3c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() 
#6 0x0000039ca68e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() 
#7 0x0000039c159a testing::Test::Run() 
#8 0x0000039c1c6b testing::TestInfo::Run() 
#9 0x0000039c225a testing::TestCase::Run() 
#10 0x0000039c6868 testing::internal::UnitTestImpl::RunAllTests() 
#11 0x0000039d60d3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() 
#12 0x0000039cc26e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() 
#13 0x0000039c64f4 testing::UnitTest::Run() 
#14 0x00000594af51 RUN_ALL_TESTS() 
#15 0x000005949ff7 base::TestSuite::Run() 
#16 0x00000595dc4d content::UnitTestTestSuite::Run() 
#17 0x000003a80772 base::internal::RunnableAdapter\u003C>::Run() 
#18 0x000003a806dc base::internal::InvokeHelper\u003C>::MakeItSo() 
#19 0x000003a8068a base::internal::Invoker\u003C>::Run() 
#20 0x000002b6f0de base::Callback\u003C>::Run() 
#21 0x00000594404e base::(anonymous namespace)::LaunchUnitTestsInternal() 
#22 0x000005943d40 base::LaunchUnitTests() 
#23 0x000003a80450 main 
#24 0x7fb2f7c6076d __libc_start_main 
#25 0x000000710379 \u003Cunknown> 

> Add generateAppForLink function in chrome.management
> 
> This function takes a url and a title as input, generates and
> returns a bookmark app.
> 
> R=benwells@chromium.org,kalman@chromium.org,calamity@chromium.org
> BUG=370350
> 
> Review URL: https://codereview.chromium.org/266353006

TBR=wjywbs@gmail.com

Review URL: https://codereview.chromium.org/313633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379128

Review URL: https://codereview.chromium.org/315493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274553 0039d316-1c4b-4281-b951-d872f2087c98

This function takes a url and a title as input, generates and
returns a bookmark app.

R=benwells@chromium.org,kalman@chromium.org,calamity@chromium.org
BUG=370350

Review URL: https://codereview.chromium.org/266353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274549 0039d316-1c4b-4281-b951-d872f2087c98