- 04 Feb, 2020 17 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a968e640c5c..aae8a22141d0 Created with: gclient setdep -r src-internal@aae8a22141d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1026060,chromium:1047530 Tbr: jbudorick@google.com Change-Id: I6aa774e7541012c1a8f00a88bd2627ef99579333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036783Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738011}
-
Sammie Quon authored
Inkdrop highlights are normal created by painting a texture using a layer delegate into a certain shape. In most cases, this shape matches the shape provided by the ink drop mask/clip, so a solid color layer would achieve the same results, and is cheaper. Test: manual Bug: 1042303 Change-Id: I1919a0a4ab651581fa4001e9b6086f9be13c2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036112 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#738010}
-
Ben Pastene authored
Most bots' xcode were upgraded to 11c29 in crrev.com/c/2028249. However, we tell swarming to persist only the xcode located in 11a1027, so the new xcode located in 11c29 isn't getting persisted. Consequently every build does a fresh download of xcode, which leads to a 20+ min download time: https://luci-milo.appspot.com/p/chromium/builders/try/ios-simulator/473405 This should fix that. Bug: 1048301, 1041618 Change-Id: Ie610497b6c40edb66021fa7fe55676cbf96fb8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036443 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738009}
-
Lukasz Anforowicz authored
This CL removes 1) ChromeExtensionsRendererClient::ShouldFork (and as a consequence the ContentRendererClient::ShouldFork) as well as 2) the file-based ShouldFork considerations from RenderFrameImpl::BeginNavigation. Looking at git history, this CL is a combination of: - a reland of r700364+r705362 (~revert of the revert from r719751) - a partial reland of r705329 (~revert of the revert from r731108) The reland should be okay now, given that https://crbug.com/1027719 and https://crbug.com/1042271 have been addressed. Bug: 883549 Tbr: Egor Pasko <pasko@chromium.org> Tbr: Tarun Bansal <tbansal@chromium.org> Tbr: Devlin <rdevlin.cronin@chromium.org> Tbr: Alex Moshchuk <alexmos@chromium.org> Change-Id: Ib0bb7175eae2cb4d95c073264155f1f7d154769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949448 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#738008}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. Multidevice features aren't tied to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. no errors in chrome://proximity-auth SplitSettingsSync, no errors in chrome://proximity-auth Bug: 1042400 Test: Multidevice setup works for new account with SplitSettingsSync, Test: Multidevice settings work for existing account with Test: updated chromeos_unittests Change-Id: I53171f3ba6a308c1af0da7a1092254e06f679bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036786Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#738007}
-
Becca Hughes authored
Fix crash in WebUI caused by mojo. Fixes: 1048314 Change-Id: I642dfd7a427ff32f09c889540fdd3cea62100ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036653Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#738006}
-
Matt Mueller authored
Bug: 1040681 Change-Id: Iaadc7d1b99668c8287eab5a181838f744f767e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036271 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#738005}
-
Gyuyoung Kim authored
This CL migrate the legacy ResetDone IPC message to the new Mojo in BlinkTestClient interface. This CL adds a |is_secondary_window_| flag to WebTestRenderFrameObserver to avoid calling ResetDone twice when a secondary window exists. Then, it's passed to BlinkTestRunner::DidCommitNavigationInMainFrame to avoid calling ResetDone twice. Because twice calls of ResetDone can cause a crash during the web test. Bug: 1039247 Change-Id: Ia992616449ec54d1e28d2a6804f907cfac404cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009595Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#738004}
-
Jamie Walch authored
The DesktopCapturer implementation used by ClientSession on Windows uses read-only shared memory, and so the mouse cursor composition needs to be done by the DesktopSessionAgent instead. This CL refactors that logic so that it can be used in both places, cleans up some raw pointer ugliness, and adds support for compositing the mouse cursor on Windows when pointer lock is active. Bug: 1047908 Change-Id: Ic21a750379a8f144227d662cce200cdc95ce3967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034104 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#738003}
-
Stephen McGruer authored
Test was updated upstream, and Chrome should now pass. Bug: None Change-Id: I298a452a93bb6e8280edcc570058478e719a93de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035300 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#738002}
-
Fritz Koenig authored
This reverts commit 4efc495c. Reason for revert: Driver was fixed so this is no longer an issue. Original change's description: > webgl: gpu workaround to turn off MSAA > > PowerVR.*GX6250 gpu is producing artifacts when > rendering with a context that has antialias set true. > > Bug: 1038671, b:148280161 > Change-Id: I79081f342bac2531e9d6d43a57939e3c5f8fc0e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019939 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Auto-Submit: Fritz Koenig <frkoenig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735217} TBR=frkoenig@chromium.org,kbr@chromium.org,haraken@chromium.org Bug: 1038671, b:148280161 Change-Id: I2e3ace6578fc90b26b5f180f388a6c80f56a0f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036400 Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738001}
-
Patrick Monette authored
The PerformanceManagerTabHelper reflects WebContents and their frame trees into the PerformanceManager graph. This CL gives the graph visibility for the WebContents created by ChromeWebDialogView. Bug: 1046881 Change-Id: I0b60996a1883a3be5f85f505576e1618ad347061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036479Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#738000}
-
Mingjing Zhang authored
This CL breaks CompositorLatency.*.StartDrawToSwapEnd into CompositorLatency.*.StartDrawToSwapStart and CompositorLatency.*. SwapStartToSwapEnd for better consumption of the metrics. Bug: 1027014 Change-Id: Id0428933ea76910d6dfc7e37150c878bfd678dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020524Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737999}
-
Kenichi Ishibashi authored
Before this CL, WriteToDiskCacheAsync() synchronously returned ServiceWorkerDatabase::ResourceRecord even its internal operations were asynchornously done. This behavior is undesirable because we want to make resource ID assignment async but creating ResourceRecord requires a new ID. This CL make WriteToDiskCacheAsync() return ResourceRecord asynchornously. A subsequent CL will remove |resource_id| argument from the function and assign an ID inside the function. Bug: 1046335 Change-Id: Id44e39db0b5912235c19d31198763036e922cbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029561 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737998}
-
James Cook authored
A change for supervised users added a JS-to-C++ validation step when closing the dialog, but the tests were not always waiting for the appropriate browser proxy calls. Bug: 1043598 Change-Id: I1f6ec812526a4e8f08427ce1b5605ea5c4340ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036358Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737997}
-
Darwin Huang authored
Remove ClipboardPromise::system_clipboard(), which was added in https://crrev.com/c/1877532, but doesn't seem to be called at all. Refactoring change, with no functional changes intended. Change-Id: Ie63574cb279e3df1c05b3446202085b72e1a455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033976 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737996}
-
Avi Drissman authored
Bug: 1022821 Change-Id: Id8871a38ea429db3efb1a1f7305eb9e3072f9efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036357 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#737995}
-
- 03 Feb, 2020 23 commits
-
-
Noel Gordon authored
The <dialog> element added in CL:2033012 is too dark. We should restyle its CSS ::backdrop property in quick-view.css to lighten it up dialog#delete-confirm-dialog::backdrop { ... } Add TODO item for that task. Tbr: alex Bug: 803259 Change-Id: Id8f2408f6d9d6cc02f612e1794a52e54dcd2351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035493 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737994}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/664c5603593f..5bbc191e0e57 git log 664c5603593f..5bbc191e0e57 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 janscheffler@chromium.org Add reset columns to DataGrid Created with: gclient setdep -r src/third_party/devtools-frontend/src@5bbc191e0e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043803 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I217aba7a35c040a59c8e0af1ae8ec30d3f5540df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737993}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: Ifdde0f9e242a3b521e308285b436f657dbf057bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036444Reviewed-by:
-
nancy authored
Based on the requirement: https://docs.google.com/presentation/d/16He3heqXY5E6IN-OhYcuVe7TGVvZk9kRkWJZvcCP830/edit#slide=id.g638c2bca07_0_38 Paused apps shouldn’t show up in suggested chips. BUG=1011235 Change-Id: I124861da4d888a82060607ade798f9b446eed4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033063 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737991}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4044.0-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2e7ee3cadb3af7f3b2de4b6e3daffc32df838fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036785Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580123479-benchmark-81.0.4044.0-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.4-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ib8dce85df1217433b571c922d437e2dc207fe8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036782Reviewed-by:
-
nancy authored
TODO: Add the close item for the new Web apps publisher. BUG=1038487 Change-Id: Ie3063c6cc5bd4bee2f51c0117b832cc8411b06db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032460Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
nancy authored
BUG=1016159 Change-Id: I9e80e8f759cc2f96dd15b5a2f5c06eafac92fd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032758Reviewed-by:
-
Donn Denman authored
Fixes the asset for the rounded corners on the top of the Bar of the Overlay panel when in Dark Mode on an mdpi device. The wrong asset was originally uploaded -- white instead of dark. This asset was crushed with optimize-png-files.sh but still ended up substantially larger maybe due to the non-white color that's dominant. BUG=1000792 Change-Id: I60faa1f33c019d2a9f473444a5be11d3eb09fae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036732 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#737986}
-
nancy authored
BUG=1038487 Change-Id: Ib7aa3b9795dc037577086e9d4199b24cdb805a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032698Reviewed-by:
-
Mustafa Emre Acer authored
crrev.com/c/2031936 added javascript_dialogs_android_strings.grd but it's not listed in the expectations. This CL adds it. Bug: 1025256 Change-Id: I8e940e0d4d7759bef2e1a40c50a149dd7ebb4adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033340Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#737984}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ce875a55578..ebf2bec1675c git log 6ce875a55578..ebf2bec1675c --date=short --first-parent --format='%ad %ae %s' 2020-02-03 jbudorick@chromium.org devil: reduce logging verbosity in device_utils and cmd_helper. Created with: gclient setdep -r src/third_party/catapult@ebf2bec1675c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I6e3394cace241108e27ffdc6d0459946e8c0c2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036771Reviewed-by:
-
Regan Hsu authored
This CL copies strings used by the OS Search page from browser settings to OS settings, and removes strings unused the browser settings. Bug: 967888 Change-Id: I2a326c91a2aa19b1d83fae11a598029bc6e67a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031166 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
rbpotter authored
- Bundle the autogenerated Polymer 3 settings resources into a new settings.rollup.js file - Include this file in optimized builds - Run Polymer 3 settings browser_tests in optimized builds This will prevent developers from accidentally breaking debug builders that are not run by default in the CQ. Bug: 1026426 Change-Id: I42122e1a4fa2dbc5bfb20dd0586a961e8cbec745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032187 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. Google Drive isn't tied to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400 Test: logging shows access tokens still fetched Change-Id: Ic5b95e0fe7484e373550fa93b87aa9b782aeae05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036380Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737980}
-
Hesen Zhang authored
Bug: 1013685 Change-Id: I2b8fcccb5684d43cfd05d05e618cec16fd21d8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025978 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737979}
-
Avi Drissman authored
It's possible that there's a newer Chrome already installed on the target Mac. In that case, the installer will skip the Chrome app installation, and the postinstall script won't know what brand code to write. Therefore, bake the brand code into the postinstall script. Bug: 1048228 Change-Id: I57857bf5f43804fa4cfb3a552cb3a131e9ee94fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036255Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737978}
-
Regan Hsu authored
* Remove AddWebContentStrings from Browser settings * Move AddWebContentStrings to AddAppearanceStrings * Delete unused IDS_SETTINGS_WEB_CONTENT, IDS_SETTINGS_LOREM_IPSUM, IDS_SETTINGS_LOADING * Move strings in AddWebContentStrings that are shared between different components to AddCommonStrings * Copy strings used by OS settings to OS settings string provider Bug: 967888 Change-Id: I4ff81ab4d6e363e8771748c48ac9802e6b8bc719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013862 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
The different Cursor and CursorInfo objects may hold a custom image and hotspot when their type is ui::CursorType::kCustom. This CL makes changes in several places to ignore those values for non-custom cursors. Bug: 1040499 Change-Id: I504ef36f45bd771c80a2f8b81b828e16eeca0074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035412Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#737976}
-
Takuto Ikuta authored
This was added in crrev.com/b274e87c But I think we can use BQ to do this kind of analysis now. Bug: 984869 Change-Id: Ic4feb37897a6b6fdcac36039aba8d24ae7b3a987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032557 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Tom Anderson authored
R=sky Bug: None Change-Id: I680cafd25935e59a280e3b2baac754d3d5f13a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036553 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Removed the overridden color definition in the Preview Tab progress bar. By default, the given style sets the color right both in light and dark mode. Bug: 1047887 Change-Id: I9a5473f9e1f3bf58c83c1f264a4e2ea697b44a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032657Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737973}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6da434932c2e..8f2b5ba75973 git log 6da434932c2e..8f2b5ba75973 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 treehugger-gerrit@google.com Merge "traced_probes: supply shmem size hints when connecting" 2020-02-03 treehugger-gerrit@google.com Merge "Re-enable service worker" Created with: gclient setdep -r src/third_party/perfetto@8f2b5ba75973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id41c9a56f5c4cea586d0e16aa7e97808a8e669e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036349Reviewed-by:
-
