- 27 Nov, 2019 40 commits
-
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves BFCache glue code and relevant functions/members from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Notable points of this change are as follows: - RenderFrameHostImpl manages raw pointers to ServiceWorkerContainerHost instead of raw pointers to ServiceWorkerProviderHost. - ServiceWorkerVersion also manages raw pointers to ServiceWorkerContainerHost instead of raw pointers to ServiceWorkerProviderHost as controllees. - This CL doesn't change ownership of ServiceWorkerProviderHost and ServiceWorkerContainerHost yet. ServiceWorkerContextCore owns ServiceWorkerProviderHost, which in turn owns ServiceWorkerContainerHost. See the design doc for the end state of the object ownership. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I955bbf6dafbb2258238b33b25d6b074d86b26f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935580 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719522}
-
Yoshiki Iguchi authored
This reverts commit b622130a. Reason for revert: This CL causes the crash. See crbug.com/1028848 BUG=1028848 Original change's description: > Ash Tray: Fix quick settings not closing after clicking on a notification. > > BUG=1024100 > > Change-Id: Ib30e43689842069e4647f7f455a919c62a3c7844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928042 > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717775} TBR=amehfooz@chromium.org,tengs@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024100 Change-Id: I52bf4673a0b7f3142690e80c7bf944f0fd0a2a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939135Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719521}
-
Navid Zolghadr authored
Change-Id: Ib59636f289e7bf0ef90a9e1120b729c04ef98ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939247Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719520}
-
Kent Tamura authored
This CL changes the types of |FormDataElement:: expected_file_modification_time_| and |WebHTTPBody::Element:: modification_time| from double (seconds from Unix Epoch) to base::Optional<base::Time>. This CL has no behavior changes. Bug: 988343 Change-Id: I28c5819615a1de6d2b5cd28203df38fe49f5bff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719519}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/translate This CL was uploaded by git cl split. TBR=napper@chromium.org Bug: 1018667 Change-Id: I33c15aa765e5e18e7e893beb4a5739f8eeef4362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917509 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719518}
-
Yutaka Hirano authored
They depend on dom/html which is slow. Also remove entries from TestExpectations because they are covered either by - the long timeout introduced here, or - MSAN related expectations (see https://crbug.com/856601) Bug: 1026151, 990900, 856601 Change-Id: I094590d485c318fef5ab4c2e213a621211a6a3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936444 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719517}
-
Jeremie Boulic authored
Update file_manager manifest to be able to accept path parameters when trying to launch the files app on specific directories. Bug: 1028038 Change-Id: I48b4084699edeb2ba39456e2ac1b14a60ee0ea9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936437Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/415874734c70..39e2ad23d608 Created with: gclient setdep -r src-internal@39e2ad23d608 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5679041e7bc61620c3f72f48320d56793873f305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719515}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c373dfd84194..f848256008f5 git log c373dfd84194..f848256008f5 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 syoussefi@chromium.org Don't use too many color attachments in clear test Created with: gclient setdep -r src/third_party/angle@f848256008f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ica2a8dca708d3fd45a0086be28009737b5c7cc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719514}
-
Makoto Shimazu authored
If a page is guarded by Cross-Origin-Embedder-Policy: require-corp, a fetch event initiated by a page can bypass the `require-corp` policy if a service worker controlling the page is COEP: none. This CL is to validate the COEP value for the page before returning a response to the client. In a previous CL, COEP for clients became available in SWGlobalScope. This retrieves the value and passes it to FetchResponseWithObserver. Once a response is provided to the observer, Cross-Origin-Resource-Policy will be checked if COEP is `require-corp`. Note that this CL makes a util for CORP in services/network public as we'd like to unify the logic to check the CORP header. Some of the other files are needed to follow the change because of an issue around linking. Bug: 999049 Change-Id: Ib5754b5f7ce32966c24aabe89892a5637e6f7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928351 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#719513}
-
Noel Gordon authored
- use keyboard arrow-right key to expand the nested folders - speed: a smaller number of entries (still repros the bug) - make comments consistent across the test fixtures - add files-ng TODO Bug: 1025581 Fixed: 1025581 Change-Id: Ia239b2ce194322df4894902f2a6522bc99f92be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937957Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719512}
-
David Black authored
There are three types of clicks which may originate from the rich version of the proactive suggestions entry point: 1. Click to open all proactive suggestions inline in Assistant UI. 2. Click to teleport directly to a single proactive suggestion. 3. Click to close the proactive suggestions entry point. To handle these cases, two new deeplink action types were added: 1. entryPointClick 2. entryPointClose The latter will always cause the proactive suggestions entry point to be closed. The former will either open Assistant UI to show the entire set of proactive suggestions inline or it will teleport the user directly to a single proactive suggestion. This is accomplished by handling an optional |href| parameter. A new histogram is also added in this CL to track the new possible outcome of showing the proactive suggestions entry point. Bug: b:145056104 Change-Id: I5faf89ba014ed32f17dd3c877ceba0e5371c1fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935447 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719511}
-
Hitoshi Yoshida authored
This CL assumes to have using BaseClass = ParentClass; in the class definition. Bug: 839389 Change-Id: Iabdaadd990811f46332f79eed113907f00a801a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935573 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719510}
-
David Schinazi authored
Callers are already required to add a semicolon in debug builds, so this extra one could cause the -Wextra-semi-stmt compiler warning if we enable it. It would be safer to remove it. Change-Id: I6ac395ed5524ff277edbfcd7d23a5e37b61534fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938827 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719509}
-
Anand K. Mistry authored
The difference in naming was causing the wrong icon URL to be returned in launcher search results, causing the icon load to fail. Bug: 753902 Change-Id: I3d058752b08a7d12e1d7e5cc4873eebdac42b349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935969Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Alan Cutter authored
This updates the WebAppManifestUpdateResult enum value kAppDataInvalid to be more accurately named kAppNotEligible as it is triggered by the app failing install promotability checks. Bug: 926083 Change-Id: I3822a9a3c5d5acffb3a5ebcb8fba6ffa2f7ff760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937954 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#719507}
-
rbpotter authored
Moving most chrome.send calls into the BrowserService, to better match the history page to the browser proxy pattern. Currently not moving calls in history.js, since the intent appears to be for those calls to be made before the history page fully loads. Bug: 1022212 Change-Id: Ief20d57a6d710121803a2c0ee2be26e96b9ce675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928036 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a5941edd0cf..b00449ac4016 git log 9a5941edd0cf..b00449ac4016 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tandrii@google.com Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293. Created with: gclient setdep -r src/third_party/depot_tools@b00449ac4016 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028420 Tbr: agable@chromium.org Change-Id: Ibca5e87d9b12098f66ddcf693a0208496dd995aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938439Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLQuoteElement> and DynamicTo<HTMLQuoteElement> as new downcast helper 2. Use IsA<HTMLQuoteElement>(element) in place of IsHTMLQuoteElement(element) Bug: 891908 Change-Id: Ie3908bdfd769857c8bc6332a5fbd794bc13b6884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930544Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719504}
-
Chris Hall authored
R=meredithl TBR=pmarko,sky,sadrul,iapres@microsoft.com,rohitrao Change-Id: Ie7dfba207a9d78b8b701e59c81eb7bf95862c14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928596 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#719503}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<HTMLFormElement>(element) in place of IsHTMLFormElement(element) Bug: 891908 Change-Id: I0c68abf504edaaa652b37b375f334739ef1b248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930767Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719502}
-
Adam Rice authored
Since quic-transport: is now on the list of "special" urls, it is no longer necessary to convert it to https to perform checks. BUG=1011392 Change-Id: I357a5a74cb596da473805534c432e25c404c1434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923873 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Chris Hall authored
R=meredithl TBR=ccameron Change-Id: I10c262ced0b2b7a21b2ba2ff1f40bbe14fbc1236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918901 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
-
Yuzu Saijo authored
This CL implements eviction when ServiceWorker postMessage is called on a bfcached client. A client cannot be retrieved after it gets into bfcache using APIs like clients.matchAll() and client.get(), but the client handle which is already saved is valid and postMessage can be triggered from there. In this case, the client in bfcache should be evicted. Design doc: https://docs.google.com/document/d/1GynjukIwZdoA9lJyYUzUL3bejS5CXbWLw4eEts5ZKaI/ Bug: 1010419 Change-Id: I0355a33226c497900433015b9d6ac54deabc6672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928271Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#719499}
-
Xiaocheng Hu authored
FontFallbackIterator is only used in HarfBuzzShaper::ShapeSegment() as a temporary variable. Hence, this patch changes FontFallbackIterator to stack-allocated to improve code readability. Change-Id: I7c13f4156baed64c74e391e97b6d67663644b157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931406 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#719498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b0ec3de5. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" 9cf13e80 "Cookie Store: Rework the SW change events API." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I06ee96a0fc27f7b289aafff937f41330a0f1cd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936764Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719497}
-
Yuki Shiino authored
Adds a trivial optimization to expr_and and expr_or functions. Bug: 839389 Change-Id: If610d75d988b159fb713f23f145c4274a7c9f27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935644 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#719496}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9d71508e42b..ddbe56c4721c git log f9d71508e42b..ddbe56c4721c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 dberris@chromium.org Fix the bundling step to only consider HTML files Created with: gclient setdep -r src/third_party/catapult@ddbe56c4721c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986772 Tbr: skyostil@google.com Change-Id: I7b17f57876e9a1665ce77ee032c9e0e1f2bbe216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938608Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/09fcacb87950..fff69a79f984 git log 09fcacb87950..fff69a79f984 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 caseq@chromium.org Reland "Update roll & type check scripts with new browser_protocol.pdl location" Created with: gclient setdep -r src/third_party/devtools-frontend/src@fff69a79f984 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibbabf4893d927bcdc7a95d7ceb0f98e1b00c4f6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938430Reviewed-by:
-
Darren Shen authored
We add a new private API for Chrome OS component extensions to report JavaScript errors to Crash. The API mirrors the window.onerror API. Design doc: https://docs.google.com/document/d/1XqN_wO1_UfVRTfhDf6yzHCyBwq_TcSw8ILDOOY_h3w4/edit?usp=sharing Bug: 986178 Change-Id: I8e11553fd7d1c07c712c7a87a68f1c0ccace54f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732329 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719493}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I53041e8d9ead763e4929d9bf59ee359cd5d02863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938708Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719492}
-
Michael Montvelishsky authored
Change-Id: I1d6967b592fbdbaa682ba85c572e4a6d0576eeec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937585 Commit-Queue: Michael Montvelishsky <mont@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#719491}
-
Yuri Wiitala authored
Includes trivial changes to ChromeTlsConnectionFactory, after Open Screen API changes. https://chromium.googlesource.com/openscreen/+log/8e6db3b055ba..fddca10f23f5 $ git log 8e6db3b05..fddca10f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-26 miu Remove dependencies on openssl from platform/api. 2019-11-26 mfoltz [Open Screen] Move osp/ code into openscreen::osp namespace. 2019-11-26 btolsch Add virtual connection routing 2019-11-22 miu Replace OSP_DCHECK→assert to remove many platform/base deps on util/. 2019-11-23 miu Remove RepeatingFunction, use Alarm instead. 2019-11-25 miu Network interfaces platform API: Separate structs from API. 2019-11-21 rwkeane mDNS: Add Comparison Operators 2019-11-22 miu Move streaming/cast/* to cast/streaming/* and cast/standalone_receiver/* 2019-11-21 fdegans Fix a build issue for platforms with different host and target toolchains. 2019-11-20 rwkeane mDNS: Fix mDNS Receiver Bug 2019-11-20 miu Move platform/api/internal/logging_macros.h → util/logging.h Created with: roll-dep src/third_party/openscreen/src TBR=mfoltz@chromium.org Change-Id: I5348d0dd196790c25d3576734df66869d6d77799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938455Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719490}
-
Michael Spang authored
This patch is corrupt: patch: **** malformed patch at line 54: return PR_FALSE; Bug: 1027853 Change-Id: I8cee1172c2dbd5abe28f65c648df343a0c91d882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937464Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719489}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/341d41ba593d..9a5941edd0cf git log 341d41ba593d..9a5941edd0cf --date=short --first-parent --format='%ad %ae %s' 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@9a5941edd0cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I98bcb6941b2c919c41fc0625edf8be5fddcc49db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938436Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca6bba47d07..415874734c70 Created with: gclient setdep -r src-internal@415874734c70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5323c4ee075690977252045376f256f7ed532a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938437Reviewed-by:
-
tby authored
We have a lot of dead code behind unused feature flags from past experiments in the search ranking codebase, so I'm going to do some clean up CLs. This one removes the utility code for expanding omnibox result subtypes, used for the original cat model. Bug: 1028447 Change-Id: I2f88c68e08505edbc559b7bae63310c2b850c8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935629Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#719486}
-
Changwan Ryu authored
Adding a simple script to run simpleperf for WebView. Unfortunately for WebView, there is no easy way to symbolize the native stack output. This is a somewhat quick and dirty workaround to use stack script to do the post-processing on the original report HTML file that simpleperf produces. Bug: 1015236 Change-Id: Ica49b8af3af809162d2f895663c37f913c646028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929765Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719485}
-
Demetrios Papadopoulos authored
Move Settings subpages currently residing in the main module to the lazy module. This change further reduces the amount of code (both JS and HTML) that is part of the main module. Previously it was assumed that only elements in the "Advanced" section resided under the lazy_load.html module. With this change, subpages that are part of the basic module are also moved to lazy_load.html. The change in main_page_behavior.js is necessary to ensure that subpages are force loaded before we attempt to display them. Numbers from Linux build (before -> after): vulcanized.html 298K -> 239K, -59K, -19.8% crisper.js 346K -> 285K, -61K, -17.6% lazy_load.vulcanized.html 149K -> 207K, +58K, +38.9% lazy_load.crisper.js 179K -> 240K, +61K, +34.1% In this CL intentionally not touching any ChromeOS specific subpages (will address in follow up CL). Bug: 1026064 Change-Id: I3b1ef541ce9d6e3a267e0b2434154c632b0b1a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922295 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719484}
-
Fergal Daly authored
All other sensors remain blocklisted. Bug: 1024716 Change-Id: I3548648fb85b71ceb2d4b5808c63fbf9be5a7402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915643 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#719483}
-
