GitLab

When TabModelBase is destroyed, Tabs and Observers List should
be cleared to free any holding tabs and observers respectively.

BUG=None.

Review URL: https://codereview.chromium.org/511903002

Cr-Commit-Position: refs/heads/master@{#292326}

BUG=406227

Review URL: https://codereview.chromium.org/510563004

Cr-Commit-Position: refs/heads/master@{#292325}

BUG=370433
TEST=None
R=sky@chromium.org
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/490123003

Cr-Commit-Position: refs/heads/master@{#292324}

We get the touch ellipse geometry from the major/minor/orientation axis
of the MT protocol. Use those intead of attempting to derive it from
pressure.

BUG=381898
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true

Review URL: https://codereview.chromium.org/509713002

Cr-Commit-Position: refs/heads/master@{#292323}

Revert of Replace NPObject usage in ppapi with gin (patchset #26 of https://codereview.chromium.org/459553003/)

Reason for revert:
Crash in telemetry tests http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/6615

Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3

TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=351636

Review URL: https://codereview.chromium.org/512983004

Cr-Commit-Position: refs/heads/master@{#292322}

Move the gesture event targeting logic from
RootView::DispatchGestureEvent() into ViewTargeter's
overrides of FindTargetForEvent() and
FindNextBestTarget().

BUG=404224
TEST=ViewTargeterTest.ViewTargeterForGestureEvents

Review URL: https://codereview.chromium.org/481433006

Cr-Commit-Position: refs/heads/master@{#292321}

This CL removes the custom layout from SearchBoxView and uses a BoxLayout
instead. This slightly changes the layout of the app list search box.

BUG=406983

Review URL: https://codereview.chromium.org/463403003

Cr-Commit-Position: refs/heads/master@{#292320}

NOTRY=true

Review URL: https://codereview.chromium.org/510163002

Cr-Commit-Position: refs/heads/master@{#292319}

Remove some unnecessary includes, typedefs, and forward declarations.

BUG=none

Review URL: https://codereview.chromium.org/490923006

Cr-Commit-Position: refs/heads/master@{#292318}

height of top infobar arrow doesn't changed through animation when the status
of bookmark bar changes from show to hide/detach.

Set the view of info bar to be auto resizable and change the height of top infobar
arrow when the its frame is changed.

BUG=382141
TEST= ./browser_tests --
gtest_filter="BrowserWindowControllerTest.InfoBarTipStrechedWhenBookmarkBar
StatusChanged", manually tested.

Review URL: https://codereview.chromium.org/435863002

Cr-Commit-Position: refs/heads/master@{#292317}

Depend on the correct target

BUG=388515

Review URL: https://codereview.chromium.org/514603002

Cr-Commit-Position: refs/heads/master@{#292316}

gles2_thunks.cc, gles2_impl_thunks.cc, etc define symbols that should be
exported from loadable modules.  If these files are linked into a static
library and that static library is then linked into a loadable module,
the linker may or may not pull in the object files for the thunks
depending on if any symbols from that object file are referenced by
some other object file in the component.

This puts the thunks into a gypi that can be included directly into a
loadable module so the object files containing the thunks are on the
link line directly and make it into the final library.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/509123003

Cr-Commit-Position: refs/heads/master@{#292315}

Implement HandleContextMenu in ExtensionOptionsGuest so that the right
click context menu within guest views are properly positioned next to
the pointer.

BUG=406885

Review URL: https://codereview.chromium.org/510993002

Cr-Commit-Position: refs/heads/master@{#292314}

Create a component necessary for showing PDF in a content-based client. Much of
the relevant code currently lives in //chrome/, and is usable by chrome. Moving
this code into a separate component in //components/pdf/ allows it to be easily
used by other content-clients (e.g. app-shell, athena, etc.). This patch moves
PPB_PDF_Impl (implementation for the PPB_PDF interface in ppapi) and the
relevant IPC messages in the pdf component.

A short summary of the changes in this patch:
. Move ppb_pdf_impl.cc|h into //components/pdf from //chrome/renderer/pepper
. Put this code in the 'pdf' namespace. This code lives in 'pdf_renderer'
  target. 'chrome_renderer' depends on this target.
. Move the following IPC messages from render_messages.h to pdf_messages.h:
  - PDFUpdateContentRestrictions
  - PDFHasUnsupportedFeature
  - PDFSaveURLAs
  - PDFModalPromptForPassword
 Change the prefix of these messages from ChromeViewHostMsg_ to PDFHostMsg_
. Move PDFTabHelper into //components/pdf from //chrome/browser/ui/pdf.
  Put this code in the 'pdf' namespace. This code lives in 'pdf_browser'
  target. 'chrome_browser' depends on this target.

BUG=401242
R=blundell@chromium.org, raymes@chromium.org, thestig@chromium.org, tsepez@chromium.org
TBR=darin@chromium.org for DEPS

Review URL: https://codereview.chromium.org/477263003

Cr-Commit-Position: refs/heads/master@{#292313}

BUG=406575
TBR=cpu@chromium.org for changes to *.grd

Review URL: https://codereview.chromium.org/497843002

Cr-Commit-Position: refs/heads/master@{#292312}

. RootNodeManager->ConnectionManager. A better name might be
  ViewManagerServiceImplsManager, but I can't come to type that in.
. Node->ServerView. I really want to use View, but having a class
  named View in the server and lib has confused everyone I've talked
  to and makes talking about View extremely abiguous.

BUG=none
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/513923004

Cr-Commit-Position: refs/heads/master@{#292311}

BUG=

Review URL: https://codereview.chromium.org/512943002

Cr-Commit-Position: refs/heads/master@{#292310}

BUG=405744

Review URL: https://codereview.chromium.org/491943004

Cr-Commit-Position: refs/heads/master@{#292309}

BUG=

Review URL: https://codereview.chromium.org/515603002

Cr-Commit-Position: refs/heads/master@{#292308}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/505393002

Cr-Commit-Position: refs/heads/master@{#292307}

We're supposed to use a unique id that increments for each
distinct touch. That's tracking id, not slot.

BUG=none
TEST=chrome on pixel with --ash-touch-hud
NOTRY=true

Review URL: https://codereview.chromium.org/512553002

Cr-Commit-Position: refs/heads/master@{#292306}

BUG=none
R= mkearney@chromium.org, smain@chromium.org, binji@chromium.org, binji@google.com, kalman@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/483163002

Cr-Commit-Position: refs/heads/master@{#292305}

The selection handle was wrongly set to left handle instead of center.
Corrected it. Also added test case to verify that the paste popup is
shown when long pressed on empty input with some text in clipboard

BUG=407185

Review URL: https://codereview.chromium.org/499393002

Cr-Commit-Position: refs/heads/master@{#292304}

Removing hacky code that sends made up data to V8 to trick it into running
GC more often. This was added a long time ago and it is unlikely it is
actually helping things anymore. Removing this code also eliminates
WebMediaPlayerImpl's dependency on V8 which helps with moving this code
to media/blink.

BUG=408338

Review URL: https://codereview.chromium.org/512033002

Cr-Commit-Position: refs/heads/master@{#292303}

BUG=n/a
TEST=should pass all existing tests (no behavioral change)

Review URL: https://codereview.chromium.org/515493002

Cr-Commit-Position: refs/heads/master@{#292302}

device_data_manager shouldn't include event.h as they are in different
targets and we don't want event_base depending upon event.

BUG=none
TEST=none
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/512553003

Cr-Commit-Position: refs/heads/master@{#292301}

BUG=404868
TEST=perf fyi bot

Review URL: https://codereview.chromium.org/508363002

Cr-Commit-Position: refs/heads/master@{#292300}

This CL allows clients to specify a minimum cross axis size when using
a BoxLayout.

BUG=406983

Review URL: https://codereview.chromium.org/494273003

Cr-Commit-Position: refs/heads/master@{#292299}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/507053002

Cr-Commit-Position: refs/heads/master@{#292298}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506153002

Cr-Commit-Position: refs/heads/master@{#292297}

Move SocketsTcpUnitTest as the first test to use it.

BUG=397164

Review URL: https://codereview.chromium.org/461273003

Cr-Commit-Position: refs/heads/master@{#292296}

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#292295}

This is the media/ portion of a reverted CL: https://codereview.chromium.org/459603003/

BUG=349320

Review URL: https://codereview.chromium.org/516543004

Cr-Commit-Position: refs/heads/master@{#292294}

These issues came up while running for a few days with the
flag --enable-remote-core-animation.

Fix flashes of old frames by hooking up the DiscardBackbuffer (which
happens when being made non-visible) to re-set the CAContext and
CALayer (so the browser gets a new one with new content for the next
frame).

Add support for disabling vsync by using setNeedsDisplay to draw.

Change the backpressure mechanism to rely on the browser to apply
backpressure in its compositor via the cc:: output surface.

Add a ScopedSetGLToRealGLApi structure to ensure that we are talking
to the real GL API while in the CoreAnimation callback.

BUG=312462

Review URL: https://codereview.chromium.org/516643002

Cr-Commit-Position: refs/heads/master@{#292293}

+rsesek for crash key/value OWNERS.

R=scottmg,ananta,cpu
TBR=rsesek@chromium.org
BUG=399233

Review URL: https://codereview.chromium.org/508393002

Cr-Commit-Position: refs/heads/master@{#292292}

This CL allows specification of the profile to show the app list for when
launching the app list via the command line.

Currently --show-app-list always uses the last used app list profile, but we
want to allow testers to more easily load the app list for a particular
profile.

On Windows, this can be used for making shorcuts to a particular profile's
app list but this will always bind to the main shortcut due to the app id.

BUG=400874

Review URL: https://codereview.chromium.org/500333002

Cr-Commit-Position: refs/heads/master@{#292291}

These files will be used in Athena.

BUG=408373
R=calamity@chromium.org, oshima@chromium.org
TEST=no functional change

Review URL: https://codereview.chromium.org/512943003

Cr-Commit-Position: refs/heads/master@{#292290}

This is hacky, and a stopgap while we wait on property plumbing.

BUG=none
TEST=manual on link_freon
NOTRY=true

Review URL: https://codereview.chromium.org/514943003

Cr-Commit-Position: refs/heads/master@{#292289}

Revert of Initialize the now_funciton to the HighResNowWrapper in case High Res is supported (patchset #7 of https://codereview.chromium.org/446203002/)

Reason for revert:
It causes a Canary crash

https://code.google.com/p/chromium/issues/detail?id=408354

The added static initializer causes a crash in libpeerconnetion used by WebRTC

Fix to reland: remove static initializer.

Original issue's description:
> We have noticed a clock shift when QPC was deployed. It shows as a regression on the perf bots
> https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win8-dual&tests=startup.warm.dirty.blank_page%2Fwindow_display_time&rev=286928
>
> It is not a real regression, the initial_time and initial_ticks are not properly initialized when switching to HighResolution (i.e. QPC).
> This CL initializes the now_function to the HighResNowWrapper instead of setting it to RolloverProtectedNow then to the HighResNowWrapper.
>
> By doing that, we avoid getting an incorrect initial_time and initial_ticks using the RolloverProtectedNow and avoid having to reinitialize.
>
> BUG=158234
>
> Committed: https://chromium.googlesource.com/chromium/src/+/10c40c221c314e41add0a5b4df1ee7467681a430

TBR=jar@chromium.org,willchan@chromium.org,maruel@chromium.org,thakis@chromium.org,jam@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=158234

Review URL: https://codereview.chromium.org/516693002

Cr-Commit-Position: refs/heads/master@{#292288}

sysconf via get_nprocs_conf glibc function calls opendir() which calls
openat() syscall, make them gracefully fail with EPERM instead of killing with SIGSYS.

This fixes crash trying to start chrome tracing when running
application with BareMetal with recent glibc.

BUG=407516
TESTED=launched BareMetal NaCl app and started chrome tracing and doesn't crash.

Review URL: https://codereview.chromium.org/509783003

Cr-Commit-Position: refs/heads/master@{#292287}