GitLab

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/465693002

Cr-Commit-Position: refs/heads/master@{#290688}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290688 0039d316-1c4b-4281-b951-d872f2087c98

This is required in order for the host to be able to safely use X11
across multiple threads, e.g. for input-injection, screen capture and
any UX.

Review URL: https://codereview.chromium.org/487453004

Cr-Commit-Position: refs/heads/master@{#290687}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290687 0039d316-1c4b-4281-b951-d872f2087c98

separate the process to initialize environment, and
start the session.

These are necessary step to launch athena in chrome.

BUG=397167

Review URL: https://codereview.chromium.org/485183002

Cr-Commit-Position: refs/heads/master@{#290686}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290686 0039d316-1c4b-4281-b951-d872f2087c98

This uses substitution patterns in toolchains to allow the toolchain to specify more flexibly how files are to be named and generated at each step. The toolchain now has control over the naming of object and executable files, for example, where before these were hardcoded.

This removes most of the OS-specific logic hardcoded into the GN tool. There is still a bunch in action invocation; this will be done in a followup.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/440333002

Cr-Commit-Position: refs/heads/master@{#290685}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290685 0039d316-1c4b-4281-b951-d872f2087c98

Now, WillStartBrowser method is never called on the benchmark tests.
This patch override the stub PageTest.WillStartBrowser in
RecorderPageTest. When WillStartBrowser is called, it forwards the call
to it's benchmark test.

The same behaviour is also applied to DidStartBrowser method

R=
BUG=400894

Review URL: https://codereview.chromium.org/447633002

Cr-Commit-Position: refs/heads/master@{#290684}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290684 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Re-land: content: Enable impl-side painting on Windows. (patchset #2 of https://codereview.chromium.org/392623003/)

Reason for revert:
Breaks telemetry unittests.

NOTRY=TRUE
NOTREECHECKS=TRUE
TBR=
Original issue's description:
> Re-land: content: Enable impl-side painting on Windows.
> 
> BUG=169282
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290535

Review URL: https://codereview.chromium.org/487933003

Cr-Commit-Position: refs/heads/master@{#290682}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290682 0039d316-1c4b-4281-b951-d872f2087c98

This fixes:
Tooltip for NO_BLUETOOTH state has '$1' instead of Chromebook
Adds PHONE_UNSUPPORTED state
Clears screenlock state when Easy Unlock gets turned off

BUG=403831,404775

Review URL: https://codereview.chromium.org/485243002

Cr-Commit-Position: refs/heads/master@{#290681}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398964
NOTRY=True

Review URL: https://codereview.chromium.org/490613003

Cr-Commit-Position: refs/heads/master@{#290680}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398964
NOTRY=True

Review URL: https://codereview.chromium.org/492513002

Cr-Commit-Position: refs/heads/master@{#290679}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290679 0039d316-1c4b-4281-b951-d872f2087c98

See bug for details - similar issue as http://crbug.com/122026

BUG=368018

Review URL: https://codereview.chromium.org/434753002

Cr-Commit-Position: refs/heads/master@{#290678}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290678 0039d316-1c4b-4281-b951-d872f2087c98

The problem was introduced by https://codereview.chromium.org/365783002

BUG=404615

Review URL: https://codereview.chromium.org/443873011

Cr-Commit-Position: refs/heads/master@{#290677}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290677 0039d316-1c4b-4281-b951-d872f2087c98

Mesa GL driver supports GL_ARB_texture_storage extensions, not
GL_EXT_texture_storage. GLES3 supports glTexStroage2D by default.
This CL makes Intel Chromebook and Linux take advantage of
immutable texture.

BUG=106142

Review URL: https://codereview.chromium.org/471603003

Cr-Commit-Position: refs/heads/master@{#290676}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290676 0039d316-1c4b-4281-b951-d872f2087c98

Support None value for the following telemetry values: scalar, string, list_of_scalars, list_of_strings

See https://docs.google.com/a/google.com/document/d/1vzmYzpKK5ImV-ItSE9j2TpC2o0BLcKGaXvsnoUeBCno/
for more of the motivation behind this.

BUG=

Review URL: https://codereview.chromium.org/475503004

Cr-Commit-Position: refs/heads/master@{#290675}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404659
TEST=manually

Review URL: https://codereview.chromium.org/488563002

Cr-Commit-Position: refs/heads/master@{#290674}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290674 0039d316-1c4b-4281-b951-d872f2087c98

The missing RemoveObserver call is causing a shutdown crash in Debug.

BUG=378892
TBR=jar@chromium.org

Review URL: https://codereview.chromium.org/487713003

Cr-Commit-Position: refs/heads/master@{#290672}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290672 0039d316-1c4b-4281-b951-d872f2087c98

Switch callsites to use tracing_controller.

BUG=356763

Review URL: https://codereview.chromium.org/471763003

Cr-Commit-Position: refs/heads/master@{#290671}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290671 0039d316-1c4b-4281-b951-d872f2087c98

The EME-WD specification now describes the format of the license
request provided to the application via the message attribute of
the message event as being JSON formatted. This change updates
the ClearKey implmentation to return the JSON formatted attribute.

For backwards compatibility with the prefixed EME implementation,
the old format (single key id as Uint8Array) is still used for
any prefixed calls.

BUG=358271
TEST=Updated EME layout tests pass

Review URL: https://codereview.chromium.org/427993002

Cr-Commit-Position: refs/heads/master@{#290669}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405266
NOTRY=true

Review URL: https://codereview.chromium.org/485363002

Cr-Commit-Position: refs/heads/master@{#290668}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290668 0039d316-1c4b-4281-b951-d872f2087c98

Use the RRTR ntp timestamp to make sure that any packets that is way older than the
newest packet we've seen is rejected. This is needed because we use 8-bit frame IDs,
and by doing this it should become impossible for old packets to confuse the logic
that tries to extend 8-bit frame IDs to 32-bit frame IDs.

Also clean up some logic in congestion_control that was exposed as buggy by the new test.

Review URL: https://codereview.chromium.org/480563004

Cr-Commit-Position: refs/heads/master@{#290667}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290667 0039d316-1c4b-4281-b951-d872f2087c98

Added assert() and assertInstanceof() declaration, added handling of assert() and cr.ui.decorate() to compiler's coding convention

BUG=393873
R=dbeam@chromium.org,tbreisacher@chromium.org
TEST=./third_party/closure_compiler/compiler_customization_test.py

Review URL: https://codereview.chromium.org/471363002

Cr-Commit-Position: refs/heads/master@{#290666}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290666 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290664}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290664 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180548:180549&mode=html
TBR=mkwst@chromium.org,dglazkov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/476123005

Cr-Commit-Position: refs/heads/master@{#290663}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290663 0039d316-1c4b-4281-b951-d872f2087c98

TBR=iannucci@chromium.org
BUG=399054
NOTRY=true

Review URL: https://codereview.chromium.org/485263004

Cr-Commit-Position: refs/heads/master@{#290662}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290662 0039d316-1c4b-4281-b951-d872f2087c98

Make PrivetLocalPrinterTest accept 2 or more query packets (as opposed to
exactly 2) being sent. This should solve flakiness in slow execution.

BUG=405040

Review URL: https://codereview.chromium.org/490673002

Cr-Commit-Position: refs/heads/master@{#290660}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290660 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the page info close icon so when it is clicked, it closes the dialog
properly. This was a regression introduced by
https://codereview.chromium.org/473643002/ where the widget's Close() method was
accidentally moved inside of a conditional in the button handler when it really
should have been executed on all button presses. This moves the Close() method
outside the conditional so it properly closes the dialog.

BUG=404963
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/485723004

Cr-Commit-Position: refs/heads/master@{#290659}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290659 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290657}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290657 0039d316-1c4b-4281-b951-d872f2087c98

Only pulls in ffmpeg.gyp changes that tweak clang warning flags:
https://gerrit.chromium.org/gerrit/#/c/71267/

BUG=82385
R=dalecurtis@chromium.org
TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/485303002

Cr-Commit-Position: refs/heads/master@{#290656}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/470323002

Cr-Commit-Position: refs/heads/master@{#290655}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290655 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290654}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290654 0039d316-1c4b-4281-b951-d872f2087c98

It will also verify committers can commit by attempting to push to
a test git repository. It will run only once (or rather once per git
configuration), so it shouldn't significantly increase runhooks
duration.

R=iannucci@chromium.org
BUG=399054
NOTRY=true

Review URL: https://codereview.chromium.org/483873003

Cr-Commit-Position: refs/heads/master@{#290653}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290653 0039d316-1c4b-4281-b951-d872f2087c98

Rely on standardized sans serif font instead.

Review URL: https://codereview.chromium.org/474523002

Cr-Commit-Position: refs/heads/master@{#290652}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290652 0039d316-1c4b-4281-b951-d872f2087c98

The fix is to remove the tab index from the X button in the list so that when a user presses <TAB>, the next control has focus instead of the next item in the list.

Tests that were added:
- Verify that appropriate languages are assigned to page. This is to make sure that the list of languages remains deterministic. This also has the effect of failing the test if we do not navigate to the language options.
- Verify that when the correct element has focus after the <TAB> key is pressed when the list had focus. This will verify that the bug is fixed correctly.

BUG=399352

Review URL: https://codereview.chromium.org/464703002

Cr-Commit-Position: refs/heads/master@{#290651}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290651 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290650}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290650 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405149

Review URL: https://codereview.chromium.org/483323005

Cr-Commit-Position: refs/heads/master@{#290649}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290649 0039d316-1c4b-4281-b951-d872f2087c98

Broke ASan/LSan:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6376

@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@Direct leak of 136 byte(s) in 1 object(s) allocated from:@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #0 0x4f295b in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/browser_tests+0x4f295b)@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #1 0x4f41e33 in GrGpuGL::onCreateIndexBuffer(unsigned long, bool) third_party/skia/src/gpu/gl/GrGpuGL.cpp:1374:13@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #2 0x4ec41b3 in createIndexBuffer third_party/skia/src/gpu/GrGpu.cpp:159:12@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #3 0x4ec41b3 in GrGpu::getQuadIndexBuffer() const third_party/skia/src/gpu/GrGpu.cpp:273@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #4 0x4ecbad0 in GrInOrderDrawBuffer::onDrawRect(SkRect const&, SkRect const*, SkMatrix const*) third_party/skia/src/gpu/GrInOrderDrawBuffer.cpp:174:34@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #5 0x4e998f8 in drawRect third_party/skia/src/gpu/GrDrawTarget.h:384:9@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #6 0x4e998f8 in drawSimpleRect third_party/skia/src/gpu/GrDrawTarget.h:391@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #7 0x4e998f8 in GrContext::drawRect(GrPaint const&, SkRect const&, GrStrokeInfo const*) third_party/skia/src/gpu/GrContext.cpp:904@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #8 0xf895e0c in SkAlphaThresholdFilterImpl::asNewEffect(GrEffect**, GrTexture*, SkMatrix const&, SkIRect const&) const third_party/skia/src/effects/SkAlphaThresholdFilter.cpp:287:17@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #9 0x4d531c9 in SkImageFilter::filterImageGPU(SkImageFilter::Proxy*, SkBitmap const&, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) const third_party/skia/src/core/SkImageFilter.cpp:272:5@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #10 0xf8b4aad in filter_texture(SkBaseDevice*, GrContext*, GrTexture*, SkImageFilter const*, int, int, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) third_party/skia/src/gpu/SkGpuDevice.cpp:1398:16@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #11 0xf8b3d42 in SkGpuDevice::drawSprite(SkDraw const&, SkBitmap const&, int, int, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice.cpp:1434:13@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #12 0x4d16942 in SkCanvas::drawSprite(SkBitmap const&, int, int, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:1194:13@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #13 0xe2828c3 in cc::ApplyImageFilter(scoped_ptr\u003Ccc::GLRenderer::ScopedUseGrContext, base::DefaultDeleter\u003Ccc::GLRenderer::ScopedUseGrContext> >, cc::ResourceProvider*, gfx::Point const&, gfx::Vector2dF const&, SkImageFilter*, cc::ScopedResource*) cc/output/gl_renderer.cc:722:3@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #14 0xe275474 in cc::GLRenderer::DrawRenderPassQuad(cc::DirectRenderer::DrawingFrame*, cc::RenderPassDrawQuad const*) cc/output/gl_renderer.cc:1051:13@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #15 0xe4598a4 in cc::DirectRenderer::DrawRenderPass(cc::DirectRenderer::DrawingFrame*, cc::RenderPass const*) cc/output/direct_renderer.cc:385:7@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #16 0xe458480 in cc::DirectRenderer::DrawFrame(cc::ScopedPtrVector\u003Ccc::RenderPass>*, float, gfx::Rect const&, gfx::Rect const&, bool) cc/output/direct_renderer.cc:232:5@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #17 0xe3bd5cc in cc::LayerTreeHostImpl::DrawLayers(cc::LayerTreeHostImpl::FrameData*, base::TimeTicks) cc/trees/layer_tree_host_impl.cc:1578:5@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #18 0xe3fb78e in cc::SingleThreadProxy::DoComposite(base::TimeTicks, cc::LayerTreeHostImpl::FrameData*) cc/trees/single_thread_proxy.cc:438:7@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #19 0xe3fade5 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks) cc/trees/single_thread_proxy.cc:356:7@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #20 0x651589b in ui::Compositor::Draw() ui/compositor/compositor.cc:234:5@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #21 0x345c43f in Run base/callback.h:401:12@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #22 0x345c43f in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #23 0x339b64c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:435:3@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #24 0x339c710 in DeferOrRunPendingTask base/message_loop/message_loop.cc:445:5@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #25 0x339c710 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:552@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #26 0x3445422 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #27 0x3445422 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #28 0x7f5f9395dd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539@@@
@@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@    #29 0x7f5f9395dd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075@@@

> Skia roll de21804:94ce9ac
> 
> https://skia.googlesource.com/skia/+log/de218041b99e8f9af0e80b34452b0e8d7f770765..94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f
> 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
> TBR=caryclark@google.com
> BUG=
> 
> Review URL: https://codereview.chromium.org/485173003

TBR=skia-deps-roller@chromium.org,caryclark@google.com

Review URL: https://codereview.chromium.org/485523003

Cr-Commit-Position: refs/heads/master@{#290648}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/463353004

Cr-Commit-Position: refs/heads/master@{#290646}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290646 0039d316-1c4b-4281-b951-d872f2087c98

Instead of recreating all the views when one is moved, let's just move the
existing ones.

BUG=404799

Review URL: https://codereview.chromium.org/487443002

Cr-Commit-Position: refs/heads/master@{#290644}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290644 0039d316-1c4b-4281-b951-d872f2087c98

For reasons that appear largely historical, the code path for determining the
default-allowing state in the settings UI is special-cased on Mac. This removes
that and just uses the cross-platform logic, which doesn't enable the button for
Canary.

BUG=370548
TEST=Put KSChannelID=canary in the Info.plist (or just run Canary) and chrome://settings button for the default browser is not present.
R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/490523004

Cr-Commit-Position: refs/heads/master@{#290642}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290642 0039d316-1c4b-4281-b951-d872f2087c98

Minor ServiceWorker cleanup. The Registration.Clear method potentially generated multiple listnener notificatons. This CL consolidates them into at most one.

Review URL: https://codereview.chromium.org/475533007

Cr-Commit-Position: refs/heads/master@{#290641}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290641 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that the NaCl validation caches are flushed when a new
version of app_shell is built.

BUG=402612
TEST=coming in next CL (I need to add an app_shell_unittests target)

Review URL: https://codereview.chromium.org/477113006

Cr-Commit-Position: refs/heads/master@{#290640}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290640 0039d316-1c4b-4281-b951-d872f2087c98