GitLab

TBR=penghaung@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7746005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98184 0039d316-1c4b-4281-b951-d872f2087c98

MenuItemView.

BUG=57890
TEST=thorougly test all menus in chrome: bookmarks, wrench menu,
context menu on page, extension menus...
TBR=ben@chromium.org
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7746012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98183 0039d316-1c4b-4281-b951-d872f2087c98

The webstore folks were finding it inconvenient to use javascript and a canvas
tag to get the base64 encoded data for the icon, and asked us to just add this
parameter to have the client fetch it.

BUG=93546
TEST=Includes a browser test, but requires webstore server changes to fully
test.

Review URL: http://codereview.chromium.org/7735001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98182 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7740016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98181 0039d316-1c4b-4281-b951-d872f2087c98

indicates FindPreference is returning NULL and we're in shutdown
because the last window is being closed. I suspect that for some
reason on some machines this triggers us to get a WM_CLOSE after we've
removed the property used to lookup the profile (removed in
WM_DESTROY) so that we fall back to the local state prefs which don't
have a property for window position and we crash. I'm adding debugging
code to determine whether that is in fact happening.

BUG=91396
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7727001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98180 0039d316-1c4b-4281-b951-d872f2087c98

for showing (running) the menu entirely to MenuRunner. This way I can
guarantee if MenuRunner is deleted, the related menu classes aren't
deleted until the nested message loop completes.

BUG=57890
TEST=thorougly test all menus in chrome: bookmarks, wrench menu,
context menu on page, extension menus...
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7720012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94195
TBR=zmo@chromium.org

Review URL: http://codereview.chromium.org/7747008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98178 0039d316-1c4b-4281-b951-d872f2087c98

This is pretty broad, but the leak is also pretty broad.

BUG=94195
TBR=zmo@chromium.org

Review URL: http://codereview.chromium.org/7748009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98177 0039d316-1c4b-4281-b951-d872f2087c98

Dropping files checked in by mistake.


BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7748007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=thakis@chromium.org
Review URL: http://codereview.chromium.org/7741008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98175 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98174 0039d316-1c4b-4281-b951-d872f2087c98

Update WebKit to r93717.

BUG=none
TEST=none
TBR=podivilov
Review URL: http://codereview.chromium.org/7727006

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7748008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98173 0039d316-1c4b-4281-b951-d872f2087c98

/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/browser_feature_extractor.cc:456:12:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
  request->set_suffix_prefix_hash(
  ~~~~~~~  ^
1 error generated.

/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:281:20:error: no member named 'has_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
  if (full_request.has_suffix_prefix_hash()) {
      ~~~~~~~~~~~~ ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:282:24:error: no member named 'set_suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
    sanitized_request->set_suffix_prefix_hash(
    ~~~~~~~~~~~~~~~~~  ^
/b/build/slave/cr-mac-rel/build/src/chrome/browser/safe_browsing/client_side_detection_service.cc:283:22:error: no member named 'suffix_prefix_hash' in 'safe_browsing::ClientPhishingRequest'
        full_request.suffix_prefix_hash());
        ~~~~~~~~~~~~ ^
3 errors generated.

Add support for client-side phishing detection for non-UMA users.

In this mode, a sanitized pingback is sent that does not include the URL or any
tokens extracted from the URL or page content.  Currently, this feature is
behind a command-line flag.

BUG=none
TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7635010

TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/7746011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98170 0039d316-1c4b-4281-b951-d872f2087c98

This change just deletes executable flags from files added by r98158.

TBR=bradnelson@google.com
BUG=none
TEST=fix check_perms errors
Review URL: http://codereview.chromium.org/7747007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98169 0039d316-1c4b-4281-b951-d872f2087c98

In this mode, a sanitized pingback is sent that does not include the URL or any
tokens extracted from the URL or page content.  Currently, this feature is
behind a command-line flag.

BUG=none
TEST=ClientSideDetectionServiceTest,BrowserFeatureExtractorTest


Review URL: http://codereview.chromium.org/7635010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98168 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98164 since there are missing dependencies on linux views build - Move resource_dispatcher_host_unittest.cc to content_unittests now that all its link time dependencies are in content.

BUG=90443
Review URL: http://codereview.chromium.org/7746008

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/7743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Virtual keyboard shouldn't remember state across different text fields.
TEST=Linux desktop


Review URL: http://codereview.chromium.org/7508025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98165 0039d316-1c4b-4281-b951-d872f2087c98

Move resource_dispatcher_host_unittest.cc to content_unittests now that all its link time dependencies are in content.

BUG=90443
Review URL: http://codereview.chromium.org/7746008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98164 0039d316-1c4b-4281-b951-d872f2087c98

Instead of a "started" and "completed" cookie, this now uses a separate
cookie for each test, so that the browser can monitor progress. Now it will
only time out if an individual test takes longer than the timeout, rather
than an entire test case.

TEST=this is
BUG=none
Review URL: http://codereview.chromium.org/7677031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98163 0039d316-1c4b-4281-b951-d872f2087c98

At the moment if we fail to process one entry, like encountering an unrecognized field, we fail the whole blacklist loading.  This CL relaxes this behavior, so if we encounter unknown features, ignore them but keep the entry; if we encounter unknown fields in an entry, ignore the entry but keep the rest of the blacklist.

BUG=91872
TEST=unittest
Review URL: http://codereview.chromium.org/7633038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7748004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=


Review URL: http://codereview.chromium.org/7725004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98160 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7745010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98159 0039d316-1c4b-4281-b951-d872f2087c98

No changes, as is.

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/7740013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98158 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org

Review URL: http://codereview.chromium.org/7743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93932
TBR=cbentzel@chromium.org

Review URL: http://codereview.chromium.org/7747004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98154 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7739001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98153 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7734005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98151 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90217
TEST=all


Review URL: http://codereview.chromium.org/7647014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98148 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of link dependency from content to chrome. Make it get the SpeechInputManager through the embedder interface.

I've renamed Chrome's SpeechInputManagerImpl to ChromeSpeechInputManager, to match what we've been doing for other chrome implementations of content classes.

BUG=76697
Review URL: http://codereview.chromium.org/7729001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94103
TEST=none
Review URL: http://codereview.chromium.org/7740010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19082
TEST=manual testing

Review URL: http://codereview.chromium.org/7714008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98144 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98143 0039d316-1c4b-4281-b951-d872f2087c98

Only contains Ninja changes; should have no effect on the build.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98142 0039d316-1c4b-4281-b951-d872f2087c98

invoke the corresponding delegate.

ExtensionHosts and TabContents which are RenderViewHost delegates no longer dispatch the 
ViewHostMsg_RunFileChooser message. Instead this message is handled by overriding the
RunFileChooser method in the RenderViewHostDelegate interface.

We eventually want to get rid of the pattern of sending IPC messages from content and handling
them in chrome and vice versa.

BUG=87335
Review URL: http://codereview.chromium.org/7729002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98141 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dennisjeffrey@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7740009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98140 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93951
TEST=Client doesn't crash when disconnecting

Review URL: http://codereview.chromium.org/7730002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98139 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94006
TEST=Build Chromium with Make on Mac. It works.

Review URL: http://codereview.chromium.org/7731001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98137 0039d316-1c4b-4281-b951-d872f2087c98