- 22 Aug, 2014 40 commits
-
-
creis@chromium.org authored
BUG=397185 TEST=RenderFrameHostManagerTest.DisownOpener*. TBR=nasko (just for DisownSameSiteOpener test) Review URL: https://codereview.chromium.org/497183003 Cr-Commit-Position: refs/heads/master@{#291556} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291556 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Currently, the ScaleGestureDetector will create a standalone GestureDetector instance for detecting double-tap events. This is overkill, however, as the only real callback it requires is the one for the initial |OnDoubleTap|, and running detection for all other gestures is wasteful. Avoid this by consolidating the GestureListener and ScaleGestureListener constructs, instead exposing an explicit |ScaleGestureDetector::OnDoubleTap()| method that is called indirectly using the existing GestureDetector instance. BUG=406175 Review URL: https://codereview.chromium.org/501503003 Cr-Commit-Position: refs/heads/master@{#291555} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291555 0039d316-1c4b-4281-b951-d872f2087c98
-
ericzeng@chromium.org authored
Implement CloseContents for ExtensionOptionsGuest. CloseContents propagates a 'close' event up to the <extensionoptions> node. In WebUI, when the extension options overlay receives this event, it will close the overlay. Extension options pages that used window.close() to close their tab in the old options page UI will now close their embedder overlay. BUG=386842, 386838 Review URL: https://codereview.chromium.org/490783002 Cr-Commit-Position: refs/heads/master@{#291554} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291554 0039d316-1c4b-4281-b951-d872f2087c98
-
reillyg@chromium.org authored
A device may only have HID output or feature reports. In this case we missed report IDs associated with this reports. This patch uses Window's HID descriptor parser to scan though all report types looking for HID collection information. BUG= Review URL: https://codereview.chromium.org/502573002 Cr-Commit-Position: refs/heads/master@{#291553} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291553 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=406631 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/501633002 Cr-Commit-Position: refs/heads/master@{#291552} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291552 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
of updating that templating library. History: this dependency is owned by me, and I changed the name to avoid confusion with the "handlebars" templating system. R=yoz@chromium.org, brettw@chromium.org Review URL: https://codereview.chromium.org/498813002 Cr-Commit-Position: refs/heads/master@{#291550} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291550 0039d316-1c4b-4281-b951-d872f2087c98
-
hendrikw@chromium.org authored
BUG=405364 Review URL: https://codereview.chromium.org/492943002 Cr-Commit-Position: refs/heads/master@{#291548} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291548 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
This is just a couple of quick sanity checks to prevent future regressions like the one in the linked bug. It tests both a Search+Shift shortcut and the corresponding Prefix Key shortcut. Adds support for sending the meta modifier key in aura/x11 tests. BUG=404470 Review URL: https://codereview.chromium.org/490443002 Cr-Commit-Position: refs/heads/master@{#291547} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291547 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291546} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291546 0039d316-1c4b-4281-b951-d872f2087c98
-
wolenetz@chromium.org authored
Includes cherry-pick to fix aac/ac3 parser bitstream buffer size BUG=405416 R=dalecurtis@chromium.org TEST=media_unittests all pass with proprietary codecs with asan Review URL: https://codereview.chromium.org/499643003 Cr-Commit-Position: refs/heads/master@{#291545} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291545 0039d316-1c4b-4281-b951-d872f2087c98
-
tmandel@chromium.org authored
In order to ensure that the time of each sample is as accurate as possible to report valid power usage, gather time and power as a single shell command instead of two. BUG= Review URL: https://codereview.chromium.org/485003004 Cr-Commit-Position: refs/heads/master@{#291544} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291544 0039d316-1c4b-4281-b951-d872f2087c98
-
amistry@chromium.org authored
Review URL: https://codereview.chromium.org/496223002 Cr-Commit-Position: refs/heads/master@{#291543} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291543 0039d316-1c4b-4281-b951-d872f2087c98
-
hanxi@chromium.org authored
2. Move its ipc handler to extensions. BUG=352290 Review URL: https://codereview.chromium.org/497103002 Cr-Commit-Position: refs/heads/master@{#291542} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291542 0039d316-1c4b-4281-b951-d872f2087c98
-
dhnishi@chromium.org authored
TBR=asanka@chromium.org Review URL: https://codereview.chromium.org/501473004 Cr-Commit-Position: refs/heads/master@{#291541} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291541 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291540} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291540 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG=405792 TBR=dtu@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/500633003 Cr-Commit-Position: refs/heads/master@{#291539} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291539 0039d316-1c4b-4281-b951-d872f2087c98
-
hcarmona@chromium.org authored
BUG=none NOTRY=true Review URL: https://codereview.chromium.org/499443003 Cr-Commit-Position: refs/heads/master@{#291535} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291535 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This allows HTML5/WebRTC audio and video capture to work inside apps. * Apps in app_shell are given access to the first available camera and microphone via WebContentsDelegate:: ProcessMediaAccessRequest(). * Introduce media_capture_util so code can be shared between ShellExtensionHostDelegate (for audio capture from background pages) and ShellAppWindow (for normal windows). * Extract ShellExtensionHostDelegate into its own file because it's a little too big to sit where it is. BUG=404299 TEST=manual, see app attached to bug Review URL: https://codereview.chromium.org/493453004 Cr-Commit-Position: refs/heads/master@{#291534} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291534 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291533} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291533 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/1f31e7671721a9f2c204a0e1842961f43e7b53ca..3e42a4638559d71481ba598857f2d0c715c8d4b3 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=caryclark@google.com BUG= Review URL: https://codereview.chromium.org/498763002 Cr-Commit-Position: refs/heads/master@{#291531} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291531 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
More copy/pasta. Discovered via pending tests on the Blink side. BUG=392621 TEST=http://crrev.com/430993002 R=jkarlin@chromium.org,gavinp@chromium.org,michaeln@chromium.org Review URL: https://codereview.chromium.org/495423002 Cr-Commit-Position: refs/heads/master@{#291529} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291529 0039d316-1c4b-4281-b951-d872f2087c98
-
dongseong.hwang@intel.com authored
|internal_format| which a client passes as argument and dest internal format which is the format of current destination texture can be different. If different, glCopyTextureCHROMIUM redefines the destination texture. So we should check dest internal format using |internal_format| argument. In addition, some platforms reports error when |internal_format| is GL_ALPHA, GL_LUMINANCE or GL_LUMINANCE_ALPHA, because those formats can not attached as color attachment of FBO on some platforms. So we restrict |internal_format| to GL_RGB and GL_RGBA. TEST=GLCopyTextureCHROMIUMTest.InternalFormat, GLCopyTextureCHROMIUMTest.RedefineDestinationTexture Review URL: https://codereview.chromium.org/481913005 Cr-Commit-Position: refs/heads/master@{#291528} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291528 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Since r289474, the sync factory nulls out the video context which means the destruction is uncontrolled. Context destruction is synchronous, so can cause deadlocks if there are not webviews attached to view tree to run GL. This is a rewrite of r289474 that just returns null VideoContextProvider if no webview is ready to use it. But still hold on to the reference to the context to avoid destruction. BUG=403882 Review URL: https://codereview.chromium.org/498623002 Cr-Commit-Position: refs/heads/master@{#291527} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291527 0039d316-1c4b-4281-b951-d872f2087c98
-
hush@chromium.org authored
Prevent calling postInvalidateOnAnimate inside VSync handler, because this will cause the invalidation to be one frame delayed. BUG=394604 Review URL: https://codereview.chromium.org/470523006 Cr-Commit-Position: refs/heads/master@{#291525} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291525 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
BUG=405541 NOTRY=true Review URL: https://codereview.chromium.org/499653002 Cr-Commit-Position: refs/heads/master@{#291524} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291524 0039d316-1c4b-4281-b951-d872f2087c98
-
tengs@chromium.org authored
BUG=404744 TEST=manual NOTRY=true Review URL: https://codereview.chromium.org/501573002 Cr-Commit-Position: refs/heads/master@{#291523} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291523 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
BUG=399674 Review URL: https://codereview.chromium.org/504453002 Cr-Commit-Position: refs/heads/master@{#291522} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291522 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Revert of Replace StreamListenSocket with StreamSocket in HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/) Reason for revert: looks like it caused net_unittests failures: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/44610/steps/net_unittests/logs/MultipleRequestsOnSameConnection Original issue's description: > Replace StreamListenSocket with StreamSocket in HttpServer. > > 1) HttpServer gets ServerSocket instead of StreamListenSocket. > 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers. > 3) HttpServer handles data buffering and asynchronous read/write. > 4) HttpConnection has limit in data buffering, up to 1Mbytes by default. > 5) For devtools, send buffer limit is 100Mbytes. > 6) Unittests for buffer handling in HttpConnection. > > BUG=371906 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291447 NOTREECHECKS=true NOTRY=true TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/497223003 Cr-Commit-Position: refs/heads/master@{#291521} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291521 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Use android_dbg_tests_recipe for manual try jobs instead of android_dbg & android_dbg_triggered_tests since that's what the CQ uses now. BUG=403411 NOTRY=true Review URL: https://codereview.chromium.org/496873002 Cr-Commit-Position: refs/heads/master@{#291520} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291520 0039d316-1c4b-4281-b951-d872f2087c98
-
byungchul@chromium.org authored
NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/497853002 Cr-Commit-Position: refs/heads/master@{#291519} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291519 0039d316-1c4b-4281-b951-d872f2087c98
-
guohui@chromium.org authored
Fixed a regression introduced in cl 488163003. Manual navigation, e.g. typing url or clicking bookmark, is not considered user gesture. Thus with the cl 488163003, chrome will ignore x-chrome-manage-account header on manual navigation to gaia endpoints. We should honor header on both non web triggerable transitions and web triggerable transitions with user gesture. BUG=394869 Review URL: https://codereview.chromium.org/481053003 Cr-Commit-Position: refs/heads/master@{#291518} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291518 0039d316-1c4b-4281-b951-d872f2087c98
-
penghuang@chromium.org authored
BUG=405871 Review URL: https://codereview.chromium.org/495403002 Cr-Commit-Position: refs/heads/master@{#291517} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291517 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#291516} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291516 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180784:180790&mode=html TBR=wibling@chromium.org,gavinp@chromium.org BUG= Review URL: https://codereview.chromium.org/502613002 Cr-Commit-Position: refs/heads/master@{#291515} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291515 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
We don't have any. We should. Add some! :) BUG=391280 Review URL: https://codereview.chromium.org/469973005 Cr-Commit-Position: refs/heads/master@{#291514} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291514 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Otherwise, Windows Release incremental links fail with: dom_distiller_core.distilled_page_prefs.obj : error LNK2019: unresolved external symbol "public: void __thiscall user_prefs::PrefRegistrySyncable::RegisterIntegerPref(char const *,int,enum user_prefs::PrefRegistrySyncable::PrefSyncStatus)" (?RegisterIntegerPref@PrefRegistrySyncable@user_prefs@@QAEXPBDHW4PrefSyncStatus@12@@Z) referenced in function "public: static void __cdecl dom_distiller::DistilledPagePrefs::RegisterProfilePrefs(class user_prefs::PrefRegistrySyncable *)" (?RegisterProfilePrefs@DistilledPagePrefs@dom_distiller@@SAXPAVPrefRegistrySyncable@user_prefs@@@Z) R=nyquist@chromium.org BUG=404809 Review URL: https://codereview.chromium.org/496323003 Cr-Commit-Position: refs/heads/master@{#291513} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291513 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
Server nudge delays override the local ones, but must be longer than the default nudge delay. If set to 0, will reset the nudge to the default. To accomplish this the delay logic was refactored and moved into the sync scheduler, which is now aware of all delays for all types and sync cycles. BUG=401600 Review URL: https://codereview.chromium.org/488843002 Cr-Commit-Position: refs/heads/master@{#291512} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291512 0039d316-1c4b-4281-b951-d872f2087c98
-
alekseys@chromium.org authored
- make Print button blue and move it in front of Cancel - change 'Backround images and colors' to 'Backround graphics' - remove lines between options and reduce spacing - add 'More/less options' button and make non-essential sections collapsible BUG=397741 Review URL: https://codereview.chromium.org/477133004 Cr-Commit-Position: refs/heads/master@{#291511} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291511 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Since the classes have virtual functions. BUG=none Review URL: https://codereview.chromium.org/497213002 Cr-Commit-Position: refs/heads/master@{#291510} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291510 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This is necessary to switch app shell / chrome implementation. BUG=397167 TEST= no functional change. R=mukai@chromium.org, yoz@chromium.org Review URL: https://codereview.chromium.org/487843003 Cr-Commit-Position: refs/heads/master@{#291509} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291509 0039d316-1c4b-4281-b951-d872f2087c98
-