- 29 Nov, 2018 40 commits
-
-
Sam McNally authored
Bug: 909056 Change-Id: Idafd58064585c900805629044cd192b2cfe2461a Reviewed-on: https://chromium-review.googlesource.com/c/1354731Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612086}
-
Sam McNally authored
Bug: 909056 Change-Id: Ic5a91cccb89c55d65217e6e55444878e4ab623cd Reviewed-on: https://chromium-review.googlesource.com/c/1354733Reviewed-by:
-
Hirokazu Honda authored
Formerly, V4L2JEA calls S_FMT one time for YUV420M and checks if the pixel format filled by driver is either YUV420 or YUV420M. Then, a driver can fill NV12 even if it supports YUV420. V4L2JEA would rather execute S_FMT for YUV420M and YUV420 separately and check if the returned format is exactly same as the specified one. Bug: 908357 Test: VEA unittest on kevin Change-Id: I15b5bae4f8d1c728f0db0bb961a1f5d39fed3c53 Reviewed-on: https://chromium-review.googlesource.com/c/1352074 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612084}
-
David Staessens authored
This change moves all test-related setup and teardown to a separate test environment. It also fixes a small bug that causes a crash when destroying the video player without playing a video. TEST=ran new VD tests on nocturne BUG=879065 Change-Id: I0f746ff3aff1598130d563aa8241e87f3d739c8a Reviewed-on: https://chromium-review.googlesource.com/c/1350413Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#612083}
-
Hitoshi Yoshida authored
Templates and scripts to generate v8_context_snapshot_external_references have some dead code because of historical reasons. This CL clean up them to reduce the generate process and the generated code. As a result, the number of entries in the table becomes 1741 from 1766, and 3 includes are removed. In detail, this CL does following changes. - Avoids checking interfaces that are not exposed to Window - Removes unused white list - Removes unnecessary check - Removes unused template parameter - Renames internal const variable from snake_case to kCamelCase. Bug: None Change-Id: If7c439d7b1085ef8c03cfb72b37343e3989feaeb Reviewed-on: https://chromium-review.googlesource.com/c/1354724 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612082}
-
Luciano Pacheco authored
Fix metadataDownloads, MigratePinnedFiles and DriveFS RecoverDirtyFiles. Change |EnsureDownloadsFolderExists| to make sure that /Downloads folder has been added to internal map, this fixes tests running with PRE_ which creates the folder in the file system, but when the test run the entry doesn't exist in the internal map. Bug: 873539 Change-Id: I429ab76179f0e386df1d94842d2bfb9994d2100b Reviewed-on: https://chromium-review.googlesource.com/c/1354800Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612081}
-
Tetsui Ohkubo authored
UnifiedSystemTray can be expanded or collapsed by touch gestures, but it's confusing that it's also possible when a detailed view is shown. TEST=manual BUG=none Change-Id: Iac81bbb645036560aa01c43bd86de735e3e904dc Reviewed-on: https://chromium-review.googlesource.com/c/1352088 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612080}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe3edef96c84..e6732bb38dc8 Created with: gclient setdep -r src-internal@e6732bb38dc8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69fee12ff28c9d659cdbc5295adb0ce72592667a Reviewed-on: https://chromium-review.googlesource.com/c/1354631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612079}
-
Hayato Ito authored
No behavior change. Change-Id: I2f4f1500608c7537e15ac4e2f28374e992b1a3ad Reviewed-on: https://chromium-review.googlesource.com/c/1354718Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612078}
-
Mikel Astiz authored
SessionSyncService's API is sufficient to achieve the desired behavior, i.e. distinguish the exact state for tab sync: off, initial download in progress and done. It also issues a notification every time that state changes, so there's no need to monitor updates from ProfileSyncService directly. Bug: 895455 Change-Id: Icf66328fdde97f833e178f0571dedb248c91beca Reviewed-on: https://chromium-review.googlesource.com/c/1344029Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612077}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7c8f33a1f59c..c3daaa87ec17 git log 7c8f33a1f59c..c3daaa87ec17 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tsepez@chromium.org Remove CFWL_Widget::GetRootOuter() and Repaint() 2018-11-29 thestig@chromium.org Clean up CBC_ErrorCorrection and remove many fxbarcode/utils.h includes. Created with: gclient setdep -r src/third_party/pdfium@c3daaa87ec17 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I11da9f3ed1cf5f9cc2665dcc27c2a4bb835e20e2 Reviewed-on: https://chromium-review.googlesource.com/c/1354625Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612076}
-
Aleksei Koziatinskii authored
Node 8.x does not support breakOnAsyncCall param of Debugger.stepInto method. R=dgozman@chromium.org Bug: none Change-Id: I0e59e0a3742b85a2fd466ac1bac5f7b75aa7f841 Reviewed-on: https://chromium-review.googlesource.com/c/1352533Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612075}
-
Cathy Li authored
Remove the header in error and loading views and change the error view to look more like a typical error page. Bug: 907638 Change-Id: I6aca95c1bd6e1334b86416879283b0a26471719e Reviewed-on: https://chromium-review.googlesource.com/c/1347215Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#612074}
-
Esmael El-Moslimany authored
Bug: 908388 Change-Id: I0a93f9c648610331db2de63596f3349dd3d07333 Reviewed-on: https://chromium-review.googlesource.com/c/1351535Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612073}
-
Ken Rockot authored
Migrates resource_coordinator away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: I308746a7fc02402ec78d59f03c2c06395bc79b5c Reviewed-on: https://chromium-review.googlesource.com/c/1351775 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612072}
-
Hirokazu Honda authored
In the definition, S_FMT doesn't have to fail even if the queried pixel format is not supported on the device. The correct way of judging pixel format support is to compare the pixel format value returned on S_FMT with the queried pixel format. Bug: 908357 Test: VDA, VEA, JDA unittest on elm Test: JEA unittest on kevin Change-Id: Ie57eaa37aec954997e743ebea05beed130faf604 Reviewed-on: https://chromium-review.googlesource.com/c/1351049 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612071}
-
Charles Zhao authored
When chrome browser is under memory pressure, TabManager::GetSortedLifecycleUnits is called to return list of tabs sorted by its reactivation score. We want to log this event by: (1) generates (and logs) a query_id for this query. (2) for each tab, when its reactivation score is calculated, we log its tab_features (with a random label_id) for this query. (3) when the tab is later on reactivated or closed, we log the label with the label_id generated before so that feature-label can be paired. Please see more details in the bug. Changes made in this CL: (1) Extending TabMetricsLogger chrome/browser/resource_coordinator/tab_metrics_logger.h chrome/browser/resource_coordinator/tab_metrics_logger.cc chrome/browser/resource_coordinator/tab_metrics_logger_unittest.cc Minor change of these functions to also take label_id and query_id as input. (label_id is passed in as input since it's different per tab, query_id is saved and set inside TabMetricsLogger since it's the same of all tabs per discard-query) (2) Populating the label_id and query_id chrome/browser/resource_coordinator/tab_activity_watcher.h chrome/browser/resource_coordinator/tab_activity_watcher.cc chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc TabActivityWatcher::CalculateReactivationScore and TabActivityWatcher::WebContentsData::CalculateReactivationScore are extended to also take also_log_to_ukm as input. A tab_feature with a random label_id_ is logged whenever CalculateReactivationScore(true) is called. The same label_id_ is also logged in LogForegroundedOrClosedMetrics. We also add logic to block background time feature logging for now. (3) TabManager changes. chrome/browser/resource_coordinator/tab_lifecycle_unit.cc chrome/browser/resource_coordinator/tab_manager.h chrome/browser/resource_coordinator/tab_manager.cc These changes are necessary only because TabManager::GetSortedLifecycleUnits and TabActivityWatcher::CalculateReactivationScore are called at multiple places. And we only want to log some of them. a) TabLifecycleUnitSource::TabLifecycleUnit::GetSortKey is changed back to only sort by last_activity_time for now. b) is added as private function and called inside TabManager::DiscardTabImpl if TabRanker is enabled. c) CalculateReactivationScore(also_log_to_ukm=true) is called inside GetSortedLifecycleUnitsFromTabRanker, which is the only case we log query time features. Bug: 900454 Change-Id: Idc77b0ff6aa3488e10a449dfec6a96d4c61f8da0 Reviewed-on: https://chromium-review.googlesource.com/c/1350445Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612070}
-
Matt Falkenhagen authored
Started failing recently but I haven't found the culprit CL yet. Bug: 910011 Change-Id: Iaa86f960f86f8ed69df94627eee63275403bf469 TBR: kinuko No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1354737Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612069}
-
Min Qin authored
Currently we remove cancelled and completed download from in-progress DB. However, for non-resumable downloads, they should also be populated back to history DB. Once that is done, it can be removed from in-progress DB. BUG=893651 Change-Id: I95013b27c41953d503df4ee49da21acb9de07eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1352711 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612068}
-
Ken Rockot authored
Migrates identity, network, and tracing services and their tests away from the deprecated ServiceContext API to ServiceBinding, and from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: I0abd81aa8096735e51d3a21b1a4e4b0fa51d6d66 Reviewed-on: https://chromium-review.googlesource.com/c/1351770 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612067}
-
Giovanni Ortuño Urquidi authored
TBR=huayinz@chromium.org Bug: 909978 Change-Id: I9347d3f4c344ab19cffa3f3148dc26b557f1a724 Reviewed-on: https://chromium-review.googlesource.com/c/1354729Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612066}
-
Makoto Shimazu authored
Bug: None Change-Id: I9f3776e509274523053ac2b0cbb48efcf8372c8a Reviewed-on: https://chromium-review.googlesource.com/c/1354726Reviewed-by:
-
Jinsuk Kim authored
When ephemeral tab and contextual search both rely on overlay panel, and it's best for only one of them to work at a time. This CL disables contextual search while ephemeral tab is showing. The other case is already handled as cs gets dismissed when ephemeral tab is brought up. Bug: 864619 Change-Id: I7b0149fd028e8a6940321436ddac9c7901dfd8e8 Reviewed-on: https://chromium-review.googlesource.com/c/1349151 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#612064}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0eed05c79fc2..81cbcd45e1a2 git log 0eed05c79fc2..81cbcd45e1a2 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-29 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@81cbcd45e1a2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ieff5ff25a5c4045ddaa19ed69aabb92a5d6fac44 Reviewed-on: https://chromium-review.googlesource.com/c/1354627Reviewed-by:
-
Sam McNally authored
Convert keyboardSelectDriveDirectoryTree as an example. Bug: 909056 Change-Id: Ie08b6a787f4d9397d832f435b8f650d647e61ceb Reviewed-on: https://chromium-review.googlesource.com/c/1349157 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL fixes a TRACE_COUNTER1 naming, it should be "Vaapi input buffers" (see [1]) but is "Input buffers", which makes it appear as different in traces, as opposed to the intended accumulative effect. [1] https://cs.chromium.org/search/?sq=package:chromium&type=cs&q=%22Vaapi+input+buffers%22 Change-Id: If490041547701d5e10ca04b500dcbca4cb0942c8 Reviewed-on: https://chromium-review.googlesource.com/c/1354265 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
The new UseCounters will enable us to monitor its adoption in the wild. This CL also adds them to UKM allow list. Bug: 863305 Change-Id: Ie77ad0cba386c2a9a74005788d8c7ad508693bd2 Reviewed-on: https://chromium-review.googlesource.com/c/1350386 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#612060}
-
Jeremy Roman authored
Ordering guarantees required here are very weak, as it merely gathers aggregate stats about hash table use and external synchronization is expected if precise results are required. Did a quick local test to confirm that it still works correctly. Bug: 736037 Change-Id: Icc780ad38cd62474f2c21a973dfc393d5aa1ab75 Reviewed-on: https://chromium-review.googlesource.com/c/1352577 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#612059}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44d4b29082f0..9af233a50848 git log 44d4b29082f0..9af233a50848 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tikuta@chromium.org introduce ninjalog_uploader to autoninja Created with: gclient setdep -r src/third_party/depot_tools@9af233a50848 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:900161 TBR=agable@chromium.org Change-Id: I3e394b0369d5f83fe779729468d458c89b0602c5 Reviewed-on: https://chromium-review.googlesource.com/c/1354626Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 12104 12107 12114 12120 12125 12137 12141 12149 12155 12158 12165 12173 12175 12179 12183 12191 12199 12202 12209 12215 12216 12221 12231 12240 12244 2 lines were removed and 2 lines were deflaked by consecutive results since 12179. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I156fb782a414ab84dba53cb72620aa0cae03dca0 Reviewed-on: https://chromium-review.googlesource.com/c/1350438 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#612057}
-
Tetsui Ohkubo authored
In Notification Center, a notification slides out of the screen when it's removed. When a notification is removed by touch gesture, it's natural to respect the direction the user swiped. See the #6 of the bug for detail. TEST=manual BUG=882522 Change-Id: I89389a9e9c0297db855227eece2fe42369d2f96e Reviewed-on: https://chromium-review.googlesource.com/c/1353057Reviewed-by:
-
Dominick Ng authored
ArcAppListPref's browser-side cache of ARC apps may become out of date with the ARC container, as the async IPC communication pipe between container and browser may be flaky, or be established after the container has processed some package installations/removals. This means observer classes which follow the OnPackageAdded or OnPackageRemoved calls may miss installations/uninstallations. This CL augments ArcAppListPrefs::OnPackageListRefreshed to additionally call observers if it detects packages which have been installed or uninstalled which it has not yet seen. BUG=893927 Change-Id: Icd069fdc89e348918f1185102e566bfc772087e3 Reviewed-on: https://chromium-review.googlesource.com/c/1345705Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#612055}
-
Kent Tamura authored
This CL has no user-visible behavior changes. Bug: 768828 Change-Id: Ia6d694fdc2a82f098a6ac915ad90127fc4bc3c4c Reviewed-on: https://chromium-review.googlesource.com/c/1354722Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612054}
-
Keishi Hattori authored
Convert X*, cssvalue::* allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I105688f79bde5a58fe13f00e68b064264789bf81 Reviewed-on: https://chromium-review.googlesource.com/c/1353064 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 07ee5f0f. Reason for revert: StartTestServer(SpawnedTestServer::SSLOptions()) started failing after this CL https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17143 [ RUN ] SSLClientSocketReadTest.Read_WithSynchronousError/0 [56283:775:1128/182253.758810:39802574526192:ERROR:local_test_server_posix.cc(79)] poll() timed out; bytes_read=0 [56283:775:1128/182253.758860:39802574568901:ERROR:local_test_server_posix.cc(167)] Could not read server_data_len [56283:775:1128/182253.760826:39802576544202:ERROR:ssl_client_socket_unittest.cc(830)] Could not start SpawnedTestServer ../../net/socket/ssl_client_socket_unittest.cc:1532: Failure Value of: StartTestServer(SpawnedTestServer::SSLOptions()) Actual: false Expected: true Stack trace: 0 net_unittests 0x000000010f41750b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 net_unittests 0x000000010f416ec9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 net_unittests 0x000000010e7d9239 net::SSLClientSocketReadTest_Read_WithSynchronousError_Test::TestBody() + 585 [ FAILED ] SSLClientSocketReadTest.Read_WithSynchronousError/0, where GetParam() = false (10083 ms) Original change's description: > Generalize for non-address results in HostResolverImpl > > Now extensively using HostCache::Entry internally (but only internally > to preserve flexibility of HostCache) as a generalized results > container within HostResolverImpl. Added some needed setter/merge > functionality to Entry for that purpose. Many methods within the > resolver changed to use Entry for consistency even if they only ever > deal with address results, eg ResolveAsIP(). > > Slightly modified results port-setting functionality to only set port > to an input port (from |host.port()|) if the port in the results is 0 > (where before it would set it whenever it wasn't equal to the input > port). This will be necessary eg for SRV support where DNS provides a > specific port that needs to be maintained in the results. Also cleaned > up the port setting to consistently only ever happen just before > setting results on the RequestImpl and having 0 or a DNS-provided port > until then. > > Bug: 846423 > Change-Id: I679c0ac915e0f81b49adb5ee769f250be49c9c90 > Reviewed-on: https://chromium-review.googlesource.com/c/1340835 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611963} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: Icc3121b6f6de985fb64ed9b2bee4951faf5378a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846423 Reviewed-on: https://chromium-review.googlesource.com/c/1354746Reviewed-by:
-
Vlad Tsyrklevich authored
Currently, the Windows allocator shims do not hook _msize() causing sporadic crashes when GWP-ASan is enabled. This occurs because sqlite3 uses _msize() and the native implementation does not properly handle allocations not returned by the native allocator. Furthermore, the current (unused) implementation of WinHeapGetSizeEstimate() seems to be an artifact of the original implementation from crrev.com/2163783003. It incorrectly increases the size estimate returned by the native allocator, which can cause exceptions in sqlite3 (there are routines that will read the _msize of an allocation and assume the returned size forms a safe bound.) I changed this routine to just return the allocation size returned by the native allocator. Bug: 909720 Change-Id: Ie8975053992161cdc3e447f75733345f0a142978 Reviewed-on: https://chromium-review.googlesource.com/c/1354219 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#612051}
-
Fergal Daly authored
ElementRareDate::TraceAfterDispatch did not trace the part_ field. The fix is to make it trace it. Bug: 909609 Change-Id: I8fd00e7613af69272ff12298b0ea33d6494f80e5 Reviewed-on: https://chromium-review.googlesource.com/c/1354740Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#612050}
-
Andrew Grieve authored
Zero'ed timestamps means the build output is the same for each run, which is generally desireable. I checked that these two files were the same before/after: * cronet_api-src.jar * cronet_impl_common_java-src.jar Where "the same" means they no longer contain directory entries and also no "META-INF/MANIFEST.MF" file. Bug: 383340 Change-Id: I4f644378dc3c33e429010509202011dd7b7f9f95 Reviewed-on: https://chromium-review.googlesource.com/c/1351425 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612049}
-
Alexei Filippov authored
Drive-by: Fix an exception when a selected node is panned offscreen. BUG=901165 Change-Id: I26ae15f3506f89a93e3f91f5aa6715c3f0033b1a Reviewed-on: https://chromium-review.googlesource.com/c/1352627 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#612048}
-
Giovanni Ortuño Urquidi authored
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/74067 TBR=alph@chromium.org Bug: 905772 Change-Id: Ibd7635ff2a66eb387443775210439c167a8aa14f Reviewed-on: https://chromium-review.googlesource.com/c/1354743Reviewed-by:
-
