- 07 Dec, 2018 40 commits
-
-
David Bokan authored
In https://crrev.com/59d9ba119448a269289d57e7c3d23a7f04f19248 we added the restriction that an element can only be promoted to implicit root scroller if none of its ancestors have scrolling or clipping. This inadvertantly removed a special case for allowing a horizontally scrollable document. Bug: 837007 Change-Id: I5a52d821266a5775e5be8641bdb6ed56fc9892f3 Reviewed-on: https://chromium-review.googlesource.com/c/1366784Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#614688}
-
Christian Dullweber authored
To find out whether the flaky test is caused by a timing issue or if there is an actual problem, a short timeout is added. Bug: 912313 Change-Id: Iff4ff88fc64fa8addc0ff1f001aee7ba3bba0015 Reviewed-on: https://chromium-review.googlesource.com/c/1367644Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#614687}
-
Marc Treib authored
and into sync_service_utils.h/cc. It was already a static function, so easy to move. Generally, clients should not use (or even have to know about) the concrete *Profile*SyncService. This also cleans up its interface a bit. TBRing simple call site updates: tangltom for profile_chooser_view.cc dpapad for people_handler.cc TBR=tangltom,dpapad Bug: 884159 Change-Id: Id32e943a083d3cb851766171a3d1cfb3f9282ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1367604 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#614686}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f306df5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id90c647ea875c38691b79681ddc439dc200133d0 Reviewed-on: https://chromium-review.googlesource.com/c/1366821Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614685}
-
Leszek Swirski authored
Duplicate a slow test for the streaming-preload virtual test. Bug: 842995 Bug: 910846 Change-Id: Id3c5135d6585f4695ac33624ab563f3f867c685f Reviewed-on: https://chromium-review.googlesource.com/c/1358500 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#614684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/845f9d53..9dff9d14 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icfe6bb481dd4622ea2faf71bcd43d827058375d4 Reviewed-on: https://chromium-review.googlesource.com/c/1366823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614683}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0f50114b3c68..6f0e1f9d8235 git log 0f50114b3c68..6f0e1f9d8235 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 cwallez@chromium.org Remove BufferView and inline offset/size in BindGroup Created with: gclient setdep -r src/third_party/dawn@6f0e1f9d8235 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I60939ae1c79899eeb136631f7f7647c52689100f Reviewed-on: https://chromium-review.googlesource.com/c/1367586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614682}
-
Roman Sorokin authored
Active Directory devices apply the setting that come from device cloud policy. BUG=chromium:889893 Change-Id: I0738f35dfdad56042c388699f811b43f3a530501 Reviewed-on: https://chromium-review.googlesource.com/c/1365595 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#614681}
-
Ioana Pandele authored
The histograms are currently recorded downstream in CL 725249. Bug: 912033 Change-Id: I4266135e3b63ad0bbafdb0a06ea7bd7a2a8c2ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1361722Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#614680}
-
Marc Treib authored
The dialog contains a ListView of encryption options, and an explanatory text (with a "reset sync" link) below it. Before this CL, if there was insufficient screen space to fit everything, then the text could get pushed offscreen and become inaccessible, because only the ListView was scrollable (see bug). This CL moves the explanatory text into the ListView as a footer. This way, it is part of the scrollable area and thus remains accessible even if not everything fits on screen at once. Two small changes were necessary to make things work: - The text view now needs to be created dynamically, since it's not possible to set a footer view in xml. - ListView does not support margins on its elements, so we use padding instead. Bug: 911635 Change-Id: Ida64735ae571fd9d4d9b1dd3e5650a322d81207f Reviewed-on: https://chromium-review.googlesource.com/c/1365611 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#614679}
-
Bence Béky authored
Introduce HTTP2_RELOADABLE_FLAG_COUNT and remove platform-specific prefix. This way HTTP2_RELOADABLE_FLAG_COUNT syntax will be identical across platforms. Also remove unused HTTP2_FLAG_COUNT_N and HTTP2_CODE_COUNT* macros. This CL merges internal change 224404468 by bnc. Bug: 488484 Change-Id: Ib1c29d1c59101af7a60c85805ed53ae612212b25 Reviewed-on: https://chromium-review.googlesource.com/c/1366576Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#614678}
-
David Jean authored
This is a reland of 965f2dd7 Original change's description: > Reland "[ios] add credit card test for manual fallback" > > This is a reland of 30e1dd18 > > Adding feature flags to slimnav. > Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970 > > Original change's description: > > [ios] add credit card test for manual fallback > > > > Also adds AutofillManualFallbackPhaseTwo to test bots. > > > > Bug: 845472 > > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d > > Reviewed-on: https://chromium-review.googlesource.com/c/1337347 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611171} > > TBR=rohitrao@chromium.org > > Bug: 845472,908970 > Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29 > Reviewed-on: https://chromium-review.googlesource.com/c/1352328 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611679} Bug: 845472, 908970 Change-Id: Ia84d71d73733d5c326443c3441e3127b700e73ef Reviewed-on: https://chromium-review.googlesource.com/c/1356718 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614677}
-
Marc Treib authored
Previously, GetRegisteredDataTypes and GetForcedDataTypes were only exposed from the (concrete) ProfileSyncService, not from the (interface) SyncService, as opposed to GetPreferredDataTypes and GetActiveDataTypes. It seems right and sensible to expose the registered and forced data types too. Concretely, this will allow us to write more code (e.g. PeopleHandler) in terms of SyncService rather than ProfileSyncService. Bug: 884159, 910518 Change-Id: I1d9176d4d2ced1dc5defda1b85b6ced2fa51afba Reviewed-on: https://chromium-review.googlesource.com/c/1365594 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL removes the remaining public and private BVC tab creation methods, and instead factors callers to directly call into the tab model. Bug: 90338 Change-Id: I44231cf05816130875dd17f5892f43a7389ed402 Reviewed-on: https://chromium-review.googlesource.com/c/1329742Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#614675}
-
Dan Elphick authored
Replaces use of deprecated BooleanValue, Int32Value, Get and GetOwnPropertyNames v8 functions. Bug: v8:7279, v8:8238 Change-Id: I73bb7deb93dffb985d4ea2fdf77fb8400d436913 Reviewed-on: https://chromium-review.googlesource.com/c/1352760Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#614674}
-
Boris Sazonov authored
This CL is a follow-up to https://crrev.com/c/1345069, which added isOperationInProgress and runAfterOperationInProgress methods to SigninManager. This CL modifies SigninManager to make it testable (by making some methods non-static and adding a constructor with explicit dependencies) and adds tests for the new methods. Bug: 903657, 903658, 906188, 906193, 906788 Change-Id: Iba91ca038898d7abd015b4ab194bc26edbe34479 Reviewed-on: https://chromium-review.googlesource.com/c/1350908 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#614673}
-
Anders Hartvoll Ruud authored
Currently, we are passing a String to ForEachProperty's callback, and then parsing that String again with the cssPropertyID function in order to obtain the CSSPropertyID that was lost in the conversion to String. This is nonsense. Use CSSPropertyName all the way instead, to retain the CSSPropertyID. Note: WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS is necessary to allow CSSPropertyName in HeapVector. It should be totally fine to allow this for CSSPropertyName, as the same is already allowed for AtomicString. This CL should have no behavior change. Change-Id: I85305a0267e1dfd144a0558d671145b38da206b1 Reviewed-on: https://chromium-review.googlesource.com/c/1363174 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614672}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92625db7babd..6ced5efe4094 Created with: gclient setdep -r src-internal@6ced5efe4094 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62cc95d139c59dcc1b357e0f5ce303289094e74e Reviewed-on: https://chromium-review.googlesource.com/c/1367123Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614671}
-
Jordan Demeulenaere authored
Bug: b/119554665 Change-Id: I9087ab89ff72f083d9fc97512a539026551e4fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1365441 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#614670}
-
Boris Sazonov authored
This CL adds SigninHelper.resetSharedPrefs calls to SigninHelperTest so the state doesn't leak between tests. This should fix flaky tests in this suite. Bug: 906712 Change-Id: I52afb02a8d9ab94eb859f7539cebd1d171d8e89e Reviewed-on: https://chromium-review.googlesource.com/c/1365246 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Alex Clarke authored
This test is sensitive to the ordering of delayed vs non-delayed tasks. We can fix this by adding a couple of extra RunLoop().RunUntilIdle(); TBR=miu@chromium.org Bug: 863341, 891670 Change-Id: Ia55858149464387a90450f9e9ad651139b5cb723 Reviewed-on: https://chromium-review.googlesource.com/c/1366287Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#614668}
-
Gauthier Ambard authored
This CL fixes the way the multilines labels are handling the accessory view. Instead of getting resized when the accessory is added to the view, they have a width taking into account the accessory view. Bug: 911088 Change-Id: I153a0939600ca89d7f27c80ab411c287c6408398 Reviewed-on: https://chromium-review.googlesource.com/c/1363192 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7c985f5c4f1a..e14feaf5b9aa git log 7c985f5c4f1a..e14feaf5b9aa --date=short --no-merges --format='%ad %ae %s' 2018-12-07 jiajia.qin@intel.com ES31: support ssbo as an argument of aggregate type Created with: gclient setdep -r src/third_party/angle@e14feaf5b9aa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Idf4289ce70ccaf29c301e4327563a0f206d1f33b Reviewed-on: https://chromium-review.googlesource.com/c/1367122Reviewed-by:
-
Gauthier Ambard authored
This CL moves the switchToTabForParams: method to a more correct pragma section. Bug: none Change-Id: I1ca1e97a6ccce23bec39cb510834d96304fa0e98 Reviewed-on: https://chromium-review.googlesource.com/c/1355130 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd3092d1..845f9d53 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib2891b4da0a7907b0252395bf36cfb8ca919fa49 Reviewed-on: https://chromium-review.googlesource.com/c/1367486Reviewed-by:
-
Victor Costan authored
sql::Database::DoesColumnExist currently compiles and runs a "PRAGMA table_info" [1] SQL query and iterates over the result looking for the desired column name. This is more brittle and expensive than using the the sqlite3_table_column_metadata() [2] API, which pulls schema data directly, bypassing query compilation and execution. This CL introduces a behavior change -- the previous PRAGMA table_info implementation works for views [3, 4], whereas sqlite3_table_column_metadata() only works for tables. The behavior change is not visible, because Chrome currently uses views in a single feature [5], namely extensions [6]. DoesColumnExist should only be used for migrations, which should operate on concrete tables. In steady-state, each feature should have the database schema migrated to the current version, so column existence is known statically. So, removing support for views in DoesColumnExist() is acceptable. [1] https://www.sqlite.org/pragma.html#pragma_table_info [2] https://www.sqlite.org/c3ref/table_column_metadata.html [3] https://www.sqlite.org/matrix/pragma.html [4] https://www.sqlite.org/matrix/matrix_dpragma.html#R-35224-32827-55933-44478-17553-06933-55583-57822 [5] https://cs.chromium.org/search/?q=file:%5C.cc+sql::+VIEW+case:yes [6] https://cs.chromium.org/chromium/src/chrome/browser/extensions/activity_log/counting_policy.cc?q=VIEW+case:yes Bug: 910955 Change-Id: I44474585e6bb2523b5cd91c76c3444058822e601 Reviewed-on: https://chromium-review.googlesource.com/c/1357825Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#614663}
-
BUG=762641 TBR=rkc@chromium.org Change-Id: I601ae55d3e5890dffc0ccdff96c20b47d797acb8 Reviewed-on: https://chromium-review.googlesource.com/c/1367484 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d28aa4cc9bd..92625db7babd Created with: gclient setdep -r src-internal@92625db7babd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifcada80648b4b32bd2cebe32052d6bd64ec6e88f Reviewed-on: https://chromium-review.googlesource.com/c/1367121Reviewed-by:
-
Clemens Arbesser authored
See corresponding bug b/120547988 Bug: 806868 Change-Id: I03dda72cbdccdf98cd5d34f621dc71d412b9e99b Reviewed-on: https://chromium-review.googlesource.com/c/1366285Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c799ff4c. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I37c06920e2fe91eae06587cd764f7f48f340e586 Reviewed-on: https://chromium-review.googlesource.com/c/1367367Reviewed-by:
-
Sami Kyostila authored
This patch adds a workaround and a test for a scenario where the invalidation of the delayed work timer (using non-public APIs) causes a nested native run loop to hang. The exact root cause of the hang is unknown since it involves the closed-source Core Foundation runtime, but the steps needed to trigger it are: 1. Post a delayed task that will run some time after step #4. 2. Allow Chrome tasks to run in nested run loops (with ScopedNestableTaskAllower). 3. Allow running Chrome tasks during private run loop modes (with ScopedPumpMessagesInPrivateModes). 4. Open a pop-up menu via [NSMenu popupContextMenu]. This will start a private native run loop to process menu interaction. 5. In a posted task, close the menu with [NSMenu cancelTracking]. At this point the menu closes visually but the nested run loop (flakily) hangs forever in a live-lock, i.e., Chrome tasks keep executing but the NSMenu call in #4 never returns. The workaround is to avoid timer invalidation during nested native run loops. DANGER: As the pop-up menu captures keyboard input, the bug will make the machine's keyboard inoperable during the live-lock. Use a TTY-based remote terminal such as SSH (as opposed to Chromoting) to investigate the issue. Bug: 912273, 891670 Change-Id: I76562ddbf45f714397d7cb385f5f690d64e377d0 Reviewed-on: https://chromium-review.googlesource.com/c/1363208 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#614658}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I21e65426d9d25b9b9e654c6edf8c255ee17e7f34 Reviewed-on: https://chromium-review.googlesource.com/c/1353888Reviewed-by:
-
Jordan Demeulenaere authored
This CL allows to specify a pseudo type when matching an element. This is required as some websites hide the actual element we should click on and relies on the user to click on a pseudo element (e.g. an element with :before or :after pseudo type). See b/119759415 for more details. Change-Id: I816c71719a4012757c6fdcdfc39c44b2dbc6b484 Reviewed-on: https://chromium-review.googlesource.com/c/1361020 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#614656}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bba465b98299..d2a590893903 git log bba465b98299..d2a590893903 --date=short --no-merges --format='%ad %ae %s' 2018-12-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ec06305b8216..7c985f5c4f1a (2 commits) Created with: gclient setdep -r src/third_party/skia@d2a590893903 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I4dec236661e9292707461c33a3cbf1d7f1ff9b57 Reviewed-on: https://chromium-review.googlesource.com/c/1367120Reviewed-by:
-
Yuzu Saijo authored
This is a part of OOM intervention v2 project, which aims to mummify a page (IOW drop v8 heap). This CL adds a new life cycle state kContextIsMummified, where global object is detached and there is no transiton to the next state. The code is designed so that it would not add an extra condition to the existing code path as much as possible, considering OOM intervention happens rarely for a limited part of Android devices. Change-Id: I9b2bb76e0aec780969a8cda64deb46755251f332 Reviewed-on: https://chromium-review.googlesource.com/c/1347967 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#614654}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Idd5a72e490fc012a103770b1371fd4a732240387 Reviewed-on: https://chromium-review.googlesource.com/c/1353919Reviewed-by:
-
Hitoshi Yoshida authored
We allowed to use Promise without return types. But now no specs use Promise without return types. This CL drops the support of unspec'ed Promise use cases. Bug: 900628 Change-Id: Ife6f6fe62894ea48f0a3d6a6778f95d7b44bd0bf Reviewed-on: https://chromium-review.googlesource.com/c/1367069 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614652}
-
Yeol authored
LogoTracker is now an implementation detail of LogoService. In order to simplify things further, its implementation was moved inside LogoService. Bug: 761829 Change-Id: I33e5ab909e3f66aec31546bb1833069f973216c9 Reviewed-on: https://chromium-review.googlesource.com/c/1349511Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#614651}
-
Zhiqiang Zhang authored
This CL makes Cast and Remoting have separate notification controllers so they can behave differently. Bug: 711860 Change-Id: I8fb5559b86d21678cd2d96c903a22085b08a3860 Reviewed-on: https://chromium-review.googlesource.com/c/1365230 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#614650}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6f7eee8488a..5d28aa4cc9bd Created with: gclient setdep -r src-internal@5d28aa4cc9bd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4920f88ae512976b6a382152c13240030134ef4a Reviewed-on: https://chromium-review.googlesource.com/c/1367118Reviewed-by:
-
