GitLab

BUG=354881
TBR=ygorshenin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/494223003

Cr-Commit-Position: refs/heads/master@{#291383}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370025

Review URL: https://codereview.chromium.org/489893002

Cr-Commit-Position: refs/heads/master@{#291382}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291382 0039d316-1c4b-4281-b951-d872f2087c98

Closing a file should not be abortable, since we could end up on files which
once opened, are never closed.

TEST=browser_tests: *FileSystemProvider*WriteFile*
BUG=405821

Review URL: https://codereview.chromium.org/497673002

Cr-Commit-Position: refs/heads/master@{#291381}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405985
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/485893009

Cr-Commit-Position: refs/heads/master@{#291380}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291380 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291379 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/495313002

Cr-Commit-Position: refs/heads/master@{#291378}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291378 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291377}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291377 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180754:180760&mode=html
TBR=wibling@chromium.org,gavinp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/498663002

Cr-Commit-Position: refs/heads/master@{#291376}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291376 0039d316-1c4b-4281-b951-d872f2087c98

BUG=406236

Review URL: https://codereview.chromium.org/485103005

Cr-Commit-Position: refs/heads/master@{#291375}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291375 0039d316-1c4b-4281-b951-d872f2087c98

- sizeimage DCHECK:
The video device can adjust the buffer size to be bigger
than we need as long as the data can fit. Theoretically
sizeimage should be bigger than PlaneAllocationSize. But
Exynos driver has a 256 byte padding for sizeimage. It is
rounded up when calculating coded_size. So sizeimage can
be smaller than PlaneAllocationSize. For example, say
format.fmt.pix_mp.width and height are 1920x1088.
format.fmt.pix_mp.plane_fmt[0].sizeimage is 2089216
(1920*1088+256). |sizeimage| is rounded up and |coded_size|
becomes 1920x1089. So format.fmt.pix_mp.plane_fmt[i].sizeimage
(2089216) is less than PlaneAllocationSize (1920*1090=2092800).

Also, we should not round down because the coded size is passed
VideoEncodeAccelerator::Client::RequireBitstreamBuffers.
The client will allocate buffers according to the coded size.

- bytesperline DCHECK:
bytesperline of different planes should be checked against
media::VideoFrame::row_bytes, not the width of coded size.

BUG=387701
TEST=Run Hangout in debug builds.

Review URL: https://codereview.chromium.org/406893002

Cr-Commit-Position: refs/heads/master@{#291374}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291374 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/495223002

Cr-Commit-Position: refs/heads/master@{#291373}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291373 0039d316-1c4b-4281-b951-d872f2087c98

It was introduced by http://codereview.chromium.org/426873004/

BUG=406160
TEST=Run the VDA_Unittest on ARM CrOS device

Review URL: https://codereview.chromium.org/483093005

Cr-Commit-Position: refs/heads/master@{#291372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291372 0039d316-1c4b-4281-b951-d872f2087c98

Show "This video could not be loaded" error on playing unsupported video.

BUG=405860
TEST=manually testted

Review URL: https://codereview.chromium.org/495003002

Cr-Commit-Position: refs/heads/master@{#291371}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291371 0039d316-1c4b-4281-b951-d872f2087c98

Reason: Failure on ASAN build bots.
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(3)/builds/2854/steps/athena_unittests/logs/OneAppActivity

> Athena: Adding basic resource management framework (un-/re-loading) of V2 applications
> 
> Functionality:
> 
> The |AppRegistry| has for each running application an |AppActivityRegistry|.
> 
> The |AppActivityRegistry| knows all activities associated with the application it represents.
> It can furthermore shut the app entirely down upon resource manager request. It will then create
> an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This
> placeholder can then ask the |AppActivityRegistry| to restart the application again.
> 
> A shutdown request for the application is only performed when all activities were marked for
> UNLOAD.
> 
> If there were multiple activities upon shutdown for one app, the app has to take care of
> re-creating all windows and thus re-creating all activities. Since an activity match cannot
> be performed, the |AppActivityProxy| will only be shown once and it will show in the location
> of the most recently used activity of that app. If we later on find an app which really uses
> multiple windows and it is imperative to keep the history for all of them tact & the app is
> recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and
> try to address it in a cleaner way, but at this time that seems rather un-useful since it is
> not known if required.
> 
> BUG=388085
> TEST=AppActivityTest.*
> 
> Review URL: https://codereview.chromium.org/477523002

TBR=skuhne@chromium.org

Review URL: https://codereview.chromium.org/497013002

Cr-Commit-Position: refs/heads/master@{#291370}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291370 0039d316-1c4b-4281-b951-d872f2087c98

And while I'm at it, change the includes to use the qualified path for
the grit generated header file
($gen_dir/content/app/resources/grit/content_resources.h).

BUG=338338
TEST=None
R=avi@chromium.org,jamesr@chromium.org,thestig@chromium.org,tony@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/486573002

Cr-Commit-Position: refs/heads/master@{#291369}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405955
NOTRY=true

Review URL: https://codereview.chromium.org/484353003

Cr-Commit-Position: refs/heads/master@{#291368}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401588

Review URL: https://codereview.chromium.org/469993006

Cr-Commit-Position: refs/heads/master@{#291367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the list redraw partially instead of full-redraw when some contents are changed in the directory. This should improve the performance of redraw.

In addition, as the result of the fix, the cache is not flashed on partial redraw, and the issue 374713 has gone.

BUG=374713
TEST=manaul tested

Review URL: https://codereview.chromium.org/486783006

Cr-Commit-Position: refs/heads/master@{#291366}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291366 0039d316-1c4b-4281-b951-d872f2087c98

It caused a failure on Android bot:

********************************************************************************
New warnings.
Please fix, or perhaps add to /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt
--------------------------------------------------------------------------------
M C IJU: TestCase org.chromium.content.browser.PopupZoomerTest defines setUp that doesn't call super.setUp()  At PopupZoomerTest.java
--------------------------------------------------------------------------------



Original patch comments:

> Hide PopupZoomer when the container view or window loses focus
> 
> Currently there is a method which hides all the popups but call to 
> hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
> hidePopups and hiding the zoomer when the view loses focus or the 
> window loses focus. Also added unit test code.
> 
> BUG=405477
> 
> Review URL: https://codereview.chromium.org/470193005

TBR=r.ghatage@samsung.com

Review URL: https://codereview.chromium.org/497693002

Cr-Commit-Position: refs/heads/master@{#291365}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324170
TEST=None

Review URL: https://codereview.chromium.org/474563004

Cr-Commit-Position: refs/heads/master@{#291363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291363 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291362 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180746:180753&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/493383002

Cr-Commit-Position: refs/heads/master@{#291361}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371538
TBR=pkasting@chromium.org for include fix in chrome/browser/ui/omnibox/omnibox_edit_model.cc

Review URL: https://codereview.chromium.org/469623004

Cr-Commit-Position: refs/heads/master@{#291360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291360 0039d316-1c4b-4281-b951-d872f2087c98

Currently there is a method which hides all the popups but call to 
hide PopupZoomer is missing. Added the call to hide PopupZoomer inside 
hidePopups and hiding the zoomer when the view loses focus or the 
window loses focus. Also added unit test code.

BUG=405477

Review URL: https://codereview.chromium.org/470193005

Cr-Commit-Position: refs/heads/master@{#291359}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405345
NOTRY=true

Review URL: https://codereview.chromium.org/492393002

Cr-Commit-Position: refs/heads/master@{#291358}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291358 0039d316-1c4b-4281-b951-d872f2087c98

This patch resolves a few issues with GitilesFileSystem.

BUG=404239
NOTRY=True

Review URL: https://codereview.chromium.org/498503002

Cr-Commit-Position: refs/heads/master@{#291357}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291357 0039d316-1c4b-4281-b951-d872f2087c98

dragend would never fire on mac because
BrowserPluginEmbedder::SystemDragEnded() clears |guest_dragging_over_|, which stops
BrowserPluginEmbedder::DragSourceEndedAt() to send the dragend
message.
This isn't an issue in aura b/c, we see DrageSourceEndedAt() before
SystemDragEnded().

BUG=401941
Test=On mac, load a <webview> in a chrome app, register a "dragend"
listener to a draggable div. Drag that div, observe "dragend" listener
firing properly.

Review URL: https://codereview.chromium.org/499493002

Cr-Commit-Position: refs/heads/master@{#291356}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383635

Review URL: https://codereview.chromium.org/498563002

Cr-Commit-Position: refs/heads/master@{#291355}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291355 0039d316-1c4b-4281-b951-d872f2087c98

I'm changing two things to Connector:
. Removing setting destroyed_flag in NotifyError. This seems wrong
  since Connector hasn't been destroyed. If destoyed_flag_ was
  non-NULL and we set it to true and we're nested, then when the stack
  unravels destroyed_flag_ won't be unset even though Connector may
  not have been destroyed. This would leave Connector in a very bad
  state.
. Makes NotifyError cancel a wait. If there was a wait outstanding or
  a notification was in flight than if we don't cancel the wait we may
  very well end up back in OnHandleReady trying to do something.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/494243002

Cr-Commit-Position: refs/heads/master@{#291354}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291354 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to avoid a pairing request prompt when connecting to a service on
a system that tries to upgrade the connection from general bonding to general
bonding with MITM protection, which according to Android and ChromeOS Bluetooth
experts is the correct behavior.

BUG=403069
TEST=chrome.easyUnlockPrivate.connectToBluetoothServiceInsecurely() should work
     just like chrome.bluetoothSocket.connect(), but not show a pairing request
     prompt when pairing with Android L.
R=tengs@chromium.org, keybuk@chromium.org

Review URL: https://codereview.chromium.org/491753002

Cr-Commit-Position: refs/heads/master@{#291353}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291353 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/468913003

Cr-Commit-Position: refs/heads/master@{#291352}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291352 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405904
R=mschilder,juanlang,xiyuan

Review URL: https://codereview.chromium.org/495033002

Cr-Commit-Position: refs/heads/master@{#291351}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291351 0039d316-1c4b-4281-b951-d872f2087c98

Skia no longer require SkPictures to be cloned for playback on
different threads. This removes all compositor code that exists
only to handle the cloning requirement.

BUG=235280

Review URL: https://codereview.chromium.org/362073002

Cr-Commit-Position: refs/heads/master@{#291350}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291350 0039d316-1c4b-4281-b951-d872f2087c98

Originally an IDL argument like "[out] int[] foo" will generate
int* foo[]. It means an array of pointers to integers and what we
want is a pointer to an array of integers. Change the output to
int** foo to be not confusing.

BUG=387547
TEST=Run generator and build chrome.

Review URL: https://codereview.chromium.org/490433002

Cr-Commit-Position: refs/heads/master@{#291349}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291349 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291343}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291343 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=370554

Review URL: https://codereview.chromium.org/499533002

Cr-Commit-Position: refs/heads/master@{#291341}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291341 0039d316-1c4b-4281-b951-d872f2087c98

This is needed by some files in these targets. The GYP build has this dependency.

TBR=jam

Review URL: https://codereview.chromium.org/478853005

Cr-Commit-Position: refs/heads/master@{#291340}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291340 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Create a new AccountTrackerService (patchset #8 of https://codereview.chromium.org/425823002/)

Reason for revert:
Likely causing chrome.browser.signin.OAuth2TokenServiceIntegrationTest failures on Android.

TBR=rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true

Original issue's description:
> Create a new AccountTrackerService PKS based on the existing AccountTracker.
> 
> This CL is one part of the effort to change chrome to use gaiaid instead of
> email address as the unique id for an account.
> 
> BUG=341408
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291263

Review URL: https://codereview.chromium.org/490403002

Cr-Commit-Position: refs/heads/master@{#291335}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=finnur@chromium.org, dtseng@chromium.org

Review URL: https://codereview.chromium.org/493903003

Cr-Commit-Position: refs/heads/master@{#291330}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291330 0039d316-1c4b-4281-b951-d872f2087c98

The test is failing on all platforms with the following error message:
"[FAIL] createGuestViewDOM: uncaught exception: Error in event handler for extensionOptionsInternal.onSizeChanged: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params)
Stack trace: Error: Invocation of form guestViewInternal.setAutoSize(undefined, object) doesn't match definition guestViewInternal.setAutoSize(integer instanceId, object params)
    at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:113:11)
    at Object.\u003Canonymous> (extensions::binding:326:30)
    at ExtensionOptionsInternal.resize (extensions::extensionOptions:178:21)
    at ExtensionOptionsInternal.onSizeChanged (extensions::extensionOptions:153:10)
    at ExtensionOptionsEvents.handleSizeChangedEvent (extensions::extensionOptionsEvents:66:33)
    at Object.EXTENSION_OPTIONS_EVENTS.sizechanged.customHandler (extensions::extensionOptionsEvents:20:15)
    at info.evt.addListener.instanceId (extensions::extensionOptionsEvents:55:12)
    at EventImpl.dispatchToListener (extensions::event_bindings:397:22)
    at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26)
    at EventImpl.dispatch_ (extensions::event_bindings:379:35)
Error
    at extensions::test:93:22
    at exports.handle (extensions::uncaught_exception_handler:15:3)
    at EventImpl.dispatch_ (extensions::event_bindings:384:9)
    at dispatchArgs (extensions::event_bindings:247:26)
    at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://obocclgnomgjhjnenilbpmgkgfmdhecn/test.html (0)

> Implement smoother autosizing of the extension options overlay
> 
>  - Use element.animate to resize the overlay for embedded extension
>    options. When an <extensionoptions> element is embedded in a WebUI
>    overlay, if its size changes the overlay will smoothly expand to
>    surround the element.
>  - Add an API to <extensionoptions> to defer autosizing until its
>    embedder is ready. This is used to 'pin' the element's size until
>    the overlay is done expanding.
>  - Move the <extensionoptions> off screen until the overlay is done
>    expanding.
>  - Prevent <extensionoptions> from shrinking after the initial sizing.
>    This makes the look of the embedded options page more consistent.
> 
> BUG=386842
> 
> Review URL: https://codereview.chromium.org/480243003

TBR=ericzeng@chromium.org

Review URL: https://codereview.chromium.org/498633002

Cr-Commit-Position: refs/heads/master@{#291328}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291328 0039d316-1c4b-4281-b951-d872f2087c98