- 04 Aug, 2020 40 commits
-
-
Rebekah Potter authored
This reverts commit 853e0dd9. Reason for revert: Change seems to have caused consistent unit_tests failures on the TSAN bot, see https://bugs.chromium.org/p/chromium/issues/detail?id=1112825 Original change's description: > service worker: Use mojo version of GetUserDataForAllRegistrations > > This CL starts using mojo version of > GetUserDataForAllRegistrations{,ByKeyPrefix}(). > > The type of the return value of these methods is also changed from > map<registration_id, value> to array<ServiceWorkerUserData>, > and ServiceWorkerUserData now has registration_id. > These changes are required to handle a situation where a > registration_id is associated with multiple values. Some features like > payments could associate multiple values for a registration_id. > > Bug: 1055677 > Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794447} TBR=falken@chromium.org,kinuko@chromium.org,bashi@chromium.org,nhiroki@chromium.org Change-Id: If41653b493ad11a6af679ee000a207be5b65f73b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677, 1112825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337273 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794695}
-
John Lee authored
Bug: 686905 Change-Id: I6f9a55492b7f6cd02be0fda7e9c4110fed2cb4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333289 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794694}
-
Rune Lillesveen authored
EnsureStyleResolver used to do this partially, which made us not crash before [1] landed. [1] https://crrev.com/0e37e8a49d3cfb0f81fa8a9e8ec147c50914e926 Bug: 1109639, 1104634 Change-Id: Ia4d8246b954251d0d3e566cf29081dd8157a5fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336081Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#794693}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/74cc8ea2b8df..a3e03e1086d5 2020-08-04 dpranke@google.com Fix a Python3-compatibility issue for write_icd_json.py. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1112479 Tbr: swiftshader-team+autoroll@google.com Change-Id: I511d932a4bc5e9d6f059e8bd85709bf44b7baf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794692}
-
Tommy Li authored
This CL is the most basic implementation possible of requesting zero-prefix suggestions (ZeroSuggestProvider) when the user deletes the permanent text in the omnibox. In other words, when the flag is on, and the user enters user_input_in_progress mode by deleting everything, this will request ZeroSuggestions. This doesn't implement the oft=2 mode yet, so there's no distinction between on-clobber and on-focus requests. Bug: 1106096 Change-Id: I2f0f3353605f82b378cc2d73499b8f03ceb83f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335509Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794691}
-
Dirk Pranke authored
I'm now consistently only using 'dpranke@google.com', so there shouldn't be any need for the other address. Change-Id: I7576a8bf318cc9455862ea8ef48960e0e6abf641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336508Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#794690}
-
Nicolás Peña Moreno authored
This changes the opacity 0 paints that are ignored by the LCP algorithm. Before, paints that would later be composited were not ignored, which resulted in an inaccurate metric due to detecting LCP too early. After this change, even will-change opacity paints are ignored, which could result in elements not becoming candidates because they are never repainted. In the special case where documentElement changes its opacity, we consider the largest content that becomes visible as a valid LCP candidate. In other words this CL does the following 3 changes: 1) Ignores all LCP signals under style.opacity: 0, as before styles with 'will-change: opacity' were not ignored. 2) Saves off the LCP for ignored LCP signals if they are under non-nested style.opacity = 0. 3.) If the document opacity style changes from opacity: 0 to non-zero, we record the saved off LCP signal. Bug: 1092473 Change-Id: I2a970a34fdb1db6c7c746060c286077553b816a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316788 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794689}
-
Jan Wilken Dörrie authored
This change removes the last references to base::string16 from chrome/chrome_cleaner. All existing instances of base::string16 have been replaced by std::wstring. Bug: 911896 Change-Id: I94235148f23f63642023cf787498f0145d221a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332718Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794688}
-
Tommy Martino authored
This CL adds a new file, text_fragment_utils, which will provide logic for handling text fragments (the URL specifiers which power the scroll-to-text feature). It invokes those utils at the last possible moment of navigation. I've implemented the basic guard logic that checks the preconditions for completing such a navigation; actually performing the scroll to text will be added in a follow-up CL. Bug: 1099268 Change-Id: I522119abe28cc0bd323bdf230a1ca8951c157835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333044Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#794687}
-
Clark DuVall authored
This reverts commit 02b24a76. Reason for revert: Reintroduces the perf regression: https://pinpoint-dot-chromeperf.appspot.com/job/16e0ecee920000 Original change's description: > Move getPacProcessor() to GlueApiHelperForR > > Follow up after feedback on http://crrev.com/c/2328302. > > Bug: 1111909 > Change-Id: If3107a6bc513d2aad898e8bc87c8436392ee057d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335385 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794655} TBR=torne@chromium.org,ntfschr@chromium.org,cduvall@chromium.org Change-Id: I8451360f542ba1b546975c5fd84f84d81b0c502a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335768Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794686}
-
Dan Harrington authored
And threaded access to xsurface FeedActionsHandler Bug: 1044139 Change-Id: I0857f876776f285728ad938f9f41e92ebea50988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335478Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#794685}
-
rbpotter authored
Bug: 1110756 Change-Id: Id0200e0adaefddcd53be7659514cc64a234653c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333061Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794684}
-
Martin Kreichgauer authored
|nserr| is implicitly autoreleased and therefore shouldn't be captured in a scoped_nsobject. Bug: 1109968 Change-Id: I0af640b396983adbe5dbd425f3ad08fcc61513a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337120 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794683}
-
James Vecore authored
Adds the policy for allowing/disallowing Nearby Share via policy. A new policy handler type is introduced to map a policy value of false to pref value of false, but when the policy is true, the pref is not changed. This allows the policy to force off a feature when disallowed, but the user must still manually enable the feature if the policy allows it. This avoids having to introduce another "allowed" pref. For now, Nearby Share will only be supported on CrOS. However, full desktop browser support is planned and this policy will be reused. The policy is currently set to launch in M87 for CrOS so it is left with no supported_on set yet. Change-Id: Ibfcc4ececf49de646ef7c72872db9c6f14c68e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316887 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#794682}
-
Henrique Nakashima authored
Heavily based on tools/binary_size/libsupersize/upload_html_viewer.py. Bug: 1111056 Change-Id: I71dfe9850e60a0f194ffe42896e79335f273c6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333453 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#794681}
-
Jeroen Dhollander authored
Logging the actual HTML makes debugging easier, but it is very big. So I've decided to only show it on the most verbose VLOG level (3). Tests: manually deployed. Bug: N/A Change-Id: I08571942cd21774ab2254bb6d907a67bc5e84698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336281 Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794680}
-
Miguel Casas authored
Certain platforms and codecs suffer from horrible artifacts (Intel BYT, H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of error in the tracking of the VASurfaces lifetime in the driver: every time we get a new resource from the pool to decode onto, this is imported into libva as a VASurface: this works fine almost everywhere but doesn't play well in these old platforms (see CreateSurface() body). This CL adds a map that keeps the ref-counted VASurfaces alive and indexed by the unique GpuMemoryBufferId until the VA Context is destroyed. In so doing, we're basically observing the "contract" of va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all contexts using these surfaces have been destroyed". [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 Bug: b:142019786 b:143323596 Change-Id: I78cc08cd882fda51ff036c88a7050adb577e53ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295947 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#794679}
-
Julian Mentasti-Meza authored
iOS14 devices will now use Apple's createPDFWithConfiguration to generate single page PDFs. CreateFullPagePdf will now render the PDFs asynchronously to behave like createPDFWithConfiguration. Unittests have been updated accordingly. Bug: 1103777 Change-Id: I6774f78c69e79d560e4d6f52ad08a7a054a88ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324104 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#794678}
-
minch authored
https://crrev.com/c/2325274 adds 'feedback' item to power menu in the login screen. https://crrev.com/c//2297746 makes the menu content view will only be set if |menu_widget_| is nullptr. Menu items will be added or removed to the content view on needed, which will cause the FocusManager can not get the next focusable item view correctly. This cl resets the |menu_widget_| on login status changes to make sure the content view will be reset too while menu items change to fix the issue. Bug: 1112655 Change-Id: Ie748866a0a4edd0ab4ab194908002822ec748bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337116 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794677}
-
Fred Mello authored
https://docs.google.com/document/d/1fDi6x6aaIdPR0KpGvKV3wGcXyICQNA_EAA6Piyy2i5U Bug: 1112872 Change-Id: Ibbecdfea97ad4de2cb2673821922cb50b85aef48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337257 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#794676}
-
Varun Khaneja authored
* SafeBrowsing.Pref.Scout.SetPref.SBER2Pref.* => SafeBrowsing.Pref.Extended.* * SafeBrowsing.Pref.SawInterstitial.SBER2Pref => SafeBrowsing.Pref.SawInterstitial * Assume ownership of these new histograms (lpz@ is no longer working on this code). * Mark a lot of suffixes as obsolete. Fixed: 1089426 Change-Id: Icc4319e8220adbf7e14a2a8ab8f067449108f5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333999 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#794675}
-
Domenic Denicola authored
This finishes testing all the ways in which document.domain can affect cross-window access. Bug: 1042415 Change-Id: Id56aad05178333c480f0682fc00bddc28829769d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335636Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#794674}
-
Maxime Charland authored
The subtitle for the Reading List has been change to explicitly mention "Read Later". Bug: 1098328 Change-Id: I3d5c1759f782a8e2c404b3aca2299a96922d6be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336783Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#794673}
-
Joe DeBlasio authored
The New Tab Page in CCTs doesn't work quite like you'd expect (since they don't happen in organically), so this CL prevents using the NTP as the default "safe page" for Safety Tips when a better recommendation isn't available. Instead, this CL either navigates back (if possible), or closes the CCT (if not possible). This isn't an ideal solution either, but there probably isn't a magical option. Bug: 1007029 Change-Id: I63f53e361d734f4b26480467f74b182612dd210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334591 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#794672}
-
Adrienne Walker authored
When indexeddb moves to the storage service, this static getter will use the file system proxy for the storage service instead of an unrestricted one. See: https://chromium-review.googlesource.com/c/chromium/src/+/2079642 Bug: 1052045 Change-Id: I8e02c888ea548d4fd60bda4c221f785a442a3aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333057 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#794671}
-
Rune Lillesveen authored
Move to NeverFixTests since the keyword is not supported and group with previously failing clip issues. R: ikilpatrick@chromium.org Bug: 966283 Change-Id: I77f3c51a78c6f621d240f35b253b05f8f587e435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333201 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#794670}
-
Collin Baker authored
This name is more discoverable and is consistent with chrome/browser/ui/in_product_help. Bug: 1106523 Change-Id: Ie611c9c25333ff349b8a2bc4c7110f6d1c047edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332700Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#794669}
-
Aaron Colwell authored
Adding crash logging to the BrowserContext destructor to help diagnose cases where a RenderProcessHost object still references a BrowserContext that is being destroyed. These situations can potentially lead to UAF bugs so this logging should help us detect potential issues earlier. This change will make it easier to debug the crashes that caused http://crrev.com/c/2305674 to get reverted without causing user visible crashes. This change also fixes a few tests that were accidentally keeping around objects that kept a RenderProcessHost alive beyond the lifetime of its BrowserContext. Bug: 1099998 Change-Id: I45f9e2e281807b9364f560e675447a9f5d3a69c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324408Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#794668}
-
Min Qin authored
If clicking on a tile triggers a search, currently the AQS params are missing as the search URL is built directly from TemplateUrlService. This CL fixes that behavior by going through the AutocompleteController to find the right AutocompleteMatch, and build the search URL from it. BUG=1110034 Change-Id: I6479726c93b8dd71d21c2753c35284d7fd5abc35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324770 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Cr-Commit-Position: refs/heads/master@{#794667} -
Haiyang Pan authored
This could enable users to use avd.py script via CIPD, rather than checking out the entire chromium source. Bug: 1112429 Change-Id: Ie4693191da4a2ddcb21930af8886b7ec5b54ba72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334685Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#794666}
-
Boris Sazonov authored
Creates WebSigninBridge class that listens to IdentityManager and AccountReconcilor on the native side and notifies the code on the Java side when the sign-in process is completed. Bug: 1093741 Change-Id: Ia2b00ac796a46e6d332ad4df11982fc49bbbd218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327051 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#794665}
-
Aaron Krajeski authored
This reverts commit 5abb4e4d. Reason for revert: crbug.com/1112723 was the real culprit Original change's description: > Revert "Add managed text view in Security settings page." > > This reverts commit 835d50e1. > > Reason for revert: Linux CFI failures https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI > > Original change's description: > > Add managed text view in Security settings page. > > > > Screenshot: http://screen/zaaBRbPGsTd > > > > Bug: 1097310 > > Change-Id: I26b76f2071d4e2ee5b4fc5ff04868b24bed88a8c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316829 > > Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> > > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > > Reviewed-by: Varun Khaneja <vakh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794260} > > TBR=vakh@chromium.org,chouinard@chromium.org,xinghuilu@chromium.org > > Change-Id: I065975a7f0ee2fbb6d04b22c36adc12bc8502d13 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1097310 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333685 > Reviewed-by: Aaron Krajeski <aaronhk@chromium.org> > Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794520} TBR=vakh@chromium.org,aaronhk@chromium.org,chouinard@chromium.org,xinghuilu@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1097310 Change-Id: I4d1c5b5050ad570b411c2843d84f2acb4769e30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337113Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#794664}
-
Curt Clemens authored
NearbyShareCertificateStorageImpl requires that Initialize be called before calling any functions that rely on LevelDB. This change queues up any calls made before initialization succeeds so that the caller doesn't have to wait for initialization to complete. Change-Id: I9f6de24826c9b5d449142366ceb86828f8e0ef4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332332 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794663}
-
John Lee authored
Bug: 1084620 Change-Id: I6f09aad6cd13fd5c6edbb6015edc3d09a7cc5ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333171 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794662}
-
yilkal authored
This cl fixes the bug where the child user is stuck in EDU account addition flow when the user's parental control setting is 'Only allow certain sites'. Inorder to prevent this error from happening we will do only safe search filter for the EduCoexistence webview and not enforce the 'Only allow certain cites' settings potentially set by the child's parents. "https://accounts.google.com" is manually whitelisted. This is because there is a race condition where we don't know whether the WebContent is an inner WebContent belonging to EduCoexistence flow or not by the time throttling happens. This happens because navigation to accounts.google.com is started before the <webview> WebContents is attached to the outer WebContents hosted by the EduCoexistence flow WebUI. We are making this exception only to the webview that is present in the EDUCoexistence flow. The exception is made because the parent is present with the child during the flow. Extending this exception to every inner webcontents will may allow the child to break parental settings. Bug: 1079510 Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#794661}
-
Mohamed Amir Yosef authored
Follow up CL will make use of this API. Bug: 1108181 Change-Id: I931e2aac81ff5164b129c8556b0bb27d1e15fc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333835Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794660}
-
Mike Wittman authored
Updates the image builder to support non-relocatable ELF images and instantiates the tests for the non-relocatable images. Replaces GetElfBaseVirtualAddress() with GetRelocationOffset(). Relocation is a well defined concept in the ELF standard, while 'base virtual address' is not, and is at odds with the 'base address' concept. For clarity, avoids the implicit assumption that the first load segment's file offset is 0. Makes the handling of the ELF base address consistent among the functions. Bug: 1101023 Change-Id: I6eac949a79a02e7e3a662f604193bf414d5ad38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305570 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794659}
-
Tibor Goldschwendt authored
The dummy module helps us build out the module infrastructure. This CL adds the dummy module plus a few management functions to register and render modules. + Add feature flag to enable NTP modules. Fixed: 1110055 Change-Id: Iea63854a82bc9facacb7f75aad2d26f629e60e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333526 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794658}
-
Rebekah Potter authored
This reverts commit 7e3a7255. Reason for revert: Consistent failures of external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker.sub.html in blink_web_tests on multiple builders started after this change landed. Original change's description: > [WPT] Test script's base URL used in dynamic imports > > This CL checks base URL used in resolving relative URL-like > specifiers in dynamic imports() from > > - `<script>`s, > - worker top-level scripts, and > - worker scripts imported by `importScripts()`. > > This is for https://github.com/whatwg/html/issues/5751. > > Bug: 1082086 > Change-Id: I778fb4d34b2e61f57799600006963c93aee5272c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198835 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794492} TBR=hiroshige@chromium.org,domenic@chromium.org Change-Id: I2fd1c341c96d0364a6dbe6cce31a8c2630403b27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335460Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#794657}
-
Xiaoling Bao authored
Bug: 1068797 Change-Id: Iaf56825d95fdb1ba502dfb2d8538f288192e3c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332572 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794656}
-