GitLab

Switches the "Mac FYI Experimental Retina Release (AMD)" and
"Mac FYI Experimental Retina Release (NVIDIA)" builders to run tests on
10.13.6.

Bug: 868032
Change-Id: Ice3945b56ae57260910970188d81266b6f4b2355
Reviewed-on: https://chromium-review.googlesource.com/1158984Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579900}

52ff1accbbe8 linux: Fix locating modules with multiple mappings from
             offset 0
063ff78a2571 Use __aarch64__ instead of __arm64__
1e662c2fcb6c [cq.cfg] Add all luci trybots as experimental
42b57efa554a CQ: Flip all builders except Windows to LUCI
6759969bf653 doc: Update Doxyfile to 1.8.14
bc50af15a28d Migrate from ScopedZxHandle to libzx containers
9cd2bae5ab23 Use Microsoft's ARM64 context layout

Change-Id: I9bca31d7177efc1fb20e8d5cbfc7d76e4dd4616f
Reviewed-on: https://chromium-review.googlesource.com/1159109Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579899}

This adds a NetworkConnectionTracker::AddLeakyNetworkConnectionObserver
method and makes DialRegistry use it. Prior to this change, every
NetworkConnectionTracker observer needed to unregister itself before
the NetworkConnectionTracker was deleted, but there are several
observers that are leaky singletons. We can't have BrowserProcessImpl
call a cleanup method on every leaky singleton since that's horrible,
and we can't hook into thread or message loop destruction to do the
unregistering because that happens after the NetworkConnectionTracker
gets deleted and asserts that everyone has cleaned up.

I want to keep the clean up assertion, so I decided to add this
AddLeakyNetworkConnectionObserver method, the callers of which will not
be expected to unregister themselves before exit. Callers of the
AddNetworkConnectionObserver method are still expected to clean up.

Bug: 868001
Change-Id: I200d991828d958f8a2849f8d7e031ccb204a0da3
Reviewed-on: https://chromium-review.googlesource.com/1157541
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579898}

Bug: 867893, 853940, 869912

Change-Id: Ia9a2729682dd8cbbc662562ab4ce9f79bfc1fbd2
Reviewed-on: https://chromium-review.googlesource.com/1158720Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579897}

We don't actually make use of the reference counting, so let's simplify
lifetime and adopt a single ownership model.

In the new implementation, we also enforce sequence affinity during
object destruction, because it's likely to catch future bugs where
future datatypes adopt BlockingModelTypeStore directly.

The changes affect a few tests which assumed that two in-memory stores
coexisting in time would share the same underlying data, which is
quite brittle and counter intuitive.

Bug: 862942

# Bypass PRESUBMIT script bug, see crbug.com/867823
No-Presubmit: true

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I98b754dd63d6bca65fe79769ae3a105e10328dbc
Reviewed-on: https://chromium-review.googlesource.com/1142778
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579896}

This unifies the addition of a new Tab to WebStateList in Tab Grid
with that used in Tools menu and long tap menu of the Tab Grid icon on
the bottom toolbar. See tab_model.mm
-insertTabWithLoadParams:opener:openedByDOM:atIndex:inBackground:.

In order to have InfoBars added to a New Tab Page, new page must be
loaded before added to WebStateList because the latter triggers the
observers.

Bug: 867623
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia5f3b0ee4a70bebd6713e5c8e242edd36d8f8ce5
Reviewed-on: https://chromium-review.googlesource.com/1157552
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579895}

After a fetch resumes, the Job Controller needs a
BackgroundFetchRequestInfo to update and complete the download.

Change-Id: Id8f8721381049cdf057214f08fa7372b5256c095
Reviewed-on: https://chromium-review.googlesource.com/1155584
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579894}

The changes are:
1. If the found navigation event has no referrer, always check for a
retargeting event, instead of stopping in the case of user gesture.
2. If a navigation handle is not renderer initiated, and has no
gestures, mark it as BROWSER_INITIATED instead of
RENDERER_INITIATED_WITHOUT_USER_GESTURE, since the latter is confusing.
3. Do not terminate the referrer chain on BROWSER_INITIATED events.


Change-Id: Ia6746a1a85ab63968199f90a7fbef3fef7104293
Reviewed-on: https://chromium-review.googlesource.com/1157542
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579893}

https://pdfium.googlesource.com/pdfium.git/+log/56094c50c0da..ad39141331e5


git log 56094c50c0da..ad39141331e5 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 thestig@chromium.org Fix sign mismatch in CPDFSDK_FormFillEnvironment::GetPageViewCount().


Created with:
  gclient setdep -r src/third_party/pdfium@ad39141331e5

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9fadd3d75a1be3b62594ad93aaad39c3bfa47f79
Reviewed-on: https://chromium-review.googlesource.com/1159021Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579892}

This helps increasing discovery reliability by refreshing the list of
DIAL devices and obtaining the latest list on user gesture.

This patch also shifts where |latest_sinks_| is cleared in the
discovery code. This is to allow RemoveSink() (called from Cast
discovery code) and the subsequent triggering of the timer to be handled
correctly after a round of discovery has ended.

Bug: 808720
Change-Id: Ib109e6ac8081b99001a76058ff51bd424a07080e
Reviewed-on: https://chromium-review.googlesource.com/1157000Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579891}

Bug: 862419
Change-Id: Icbf4fd7664324c25099f3125076b793fd8846ba2
Reviewed-on: https://chromium-review.googlesource.com/1150832Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579890}

Tweak the Touchable Refresh dimensions to make everything in the Omnibox
and Suggestions box line up.

Bug: 865766
Change-Id: Ibe9ec38e6b2c1c9d92e56ffff60cf32faa92c59c
Reviewed-on: https://chromium-review.googlesource.com/1157562Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579889}

Exiting the tab grid on iPad, especially for tabs close to the top of the screen, shows a white flicker in the toolbar area of the tab.

This is due to the fade in/fade out of the grid cell header and the toolbar snapshot, which transitions through a state where the header is totally white. The timing is such that this can happen right when the top of the tab is in position, making for a distinct flash in the toolbar.

This CL fixes this by using a crossfade instead of the fade in/ fade out. The transition is fast enough that the crossfade doesn't look muddy, and it remove the abrupt flash.

Bug: 865440
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifbceef6a79cbde4ea08c76b6f7e6a35bd8225330
Reviewed-on: https://chromium-review.googlesource.com/1158832
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579888}

Currently GbmDevice is-a DrmDevice is-a GbmDeviceLinux. Instead, put a
GbmDevice inside DrmDevice. This also removes a bunch of unnecessary
casts.

Bug: 869206

Change-Id: If7ea97f495081ebf4d05f44af2bd78c3357e23da
Reviewed-on: https://chromium-review.googlesource.com/1157254Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579887}

This CL adds a delay for the voice over announcement of the InProduct
Help tips. This delay is added to prevent the announcement to be
cancelled by the element being focused, when the tab is presented.
It also adds an accessibility label to the empty space where the omnibox
should be if the toolbar was visible.

Bug: 866936
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia75dd56772203e39b8d0bf1e94bef9cfacd87fdd
Reviewed-on: https://chromium-review.googlesource.com/1158236
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579886}

Bug: 835029
Change-Id: Ia50091e2e1669f180f4d9eb5860a59a141bc0c4c
Reviewed-on: https://chromium-review.googlesource.com/1150636Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579885}

And we only use features "disable_timestamp_queries" to disable
glQuereyCounter.

Bug: 811661
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I81eaf2001d17b31d56dbaadadb1b34f6741e0af0
Reviewed-on: https://chromium-review.googlesource.com/1159098Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579884}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like these callsites can use the THREAD_POOL_EXECUTOR instead,
since these uses don't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: I0a2c9021be07447d9437c7e33606307ea3685fc5
Reviewed-on: https://chromium-review.googlesource.com/1159105Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579883}

Bug: 863174
Change-Id: I4d694bc9d8faedb7d74a5aedb0d6bf7caffc8d0a
Reviewed-on: https://chromium-review.googlesource.com/1157662Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579882}

BUG=859779

Change-Id: I053e26086599ffb68f6379844bb20bf894e613e1
Reviewed-on: https://chromium-review.googlesource.com/1155663
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579881}

Bug: 851293
Change-Id: Icd8963e26cb1bea4e4109080b3b06d42beb26e1d
Reviewed-on: https://chromium-review.googlesource.com/1157285
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579880}

Also:
* Add no_default_deps to mini_installer.
* Updates an incorrect comment and removes an unnecessary dependency on
  libc++ in mini_installer/BUILD.gn which became broken in [1].

[1] https://chromium-review.googlesource.com/1073613

BUG=None

Change-Id: I44f8f09e36f2764b3077af5d0cd7605a575b347e
Reviewed-on: https://chromium-review.googlesource.com/1157509
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579879}

Compositing update may change the state of the throttling, causing
the lifecycle state to not update for the local root frame. This patch
ensures that the DCHECK doesn't fail due to throttling.

R=chrishtr@chromium.org

Bug: 869807
Change-Id: Iae4de9420f566b5901be1a0bbbb92dd47eafcacb
Reviewed-on: https://chromium-review.googlesource.com/1158991Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579878}

If overview mode is opened behind the current dragged window, we should
not do the animation when entering overview.

Bug: 823769
Test: None
Change-Id: I1d89bcdc27ea784449698183e026aa63f1c2cf2c
Reviewed-on: https://chromium-review.googlesource.com/1157289
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579877}

As we develop the motion spec in pieces, the UI may regress until the
choreography is fully implemented. To prevent this, I added a constant
that we can use to gate changes that should not be enabled until
additional motion specs are also implemented.

This change is gated by that flag, so this change will not be visible
by default.

See bug for spec/demo.

Bug: b:111890130
Change-Id: I88ab63e4ba83e8210eacdd3dd8b3c45b305d0373
Reviewed-on: https://chromium-review.googlesource.com/1152208Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#579876}

https://android.googlesource.com/platform/external/perfetto.git/+log/ebafd75a0c5d..6af2bfe03baf


git log ebafd75a0c5d..6af2bfe03baf --date=short --no-merges --format='%ad %ae %s'
2018-08-01 treehugger-gerrit@google.com Merge "Allow to send multiple fds over UnixSocket."


Created with:
  gclient setdep -r src/third_party/perfetto@6af2bfe03baf

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I316f3d9861190e8417f8691201a197a344571f51
Reviewed-on: https://chromium-review.googlesource.com/1158785
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579875}

Bug: 806868
Change-Id: I2877c4cfa3241dc6a783311b69f46c27c3b347c5
Reviewed-on: https://chromium-review.googlesource.com/1158855
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579874}

GetOriginsTask is ref counted, and its first reference is implicitly
retained by base::Bind() in GetOriginsTask::Run().
Though this case is safe, an upcoming base::Bind change rejects this
pattern of the first reference retention.

After this CL, the caller of GetOriginsTask::Run() keeps the first
reference to the GetOriginsTask instance to avoid the check failure.

Bug: 866456
Change-Id: Ia011ccc3b815a626200403b22c63b8133c83fbb0
Reviewed-on: https://chromium-review.googlesource.com/1158664
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579873}

1. /pkg, /svc and /config/ssl are now cloned to Context processes.
   https://crrev.com/1149262 removed FDIO_SPAWN_CLONE_NAMESPACE.
   As result the context process was failing to open /pkg/icudtl.dat.
2. Added FDIO_SPAWN_CLONE_JOB flag - job needs to be cloned so the
   context process can start its own children.
3. Updated SandboxPolicyFuchsia not to clone /tmp - it doesn't appear
   to be necessary for any sandboxed processes.
4. Removed FDIO_SPAWN_CLONE_STDIO for Context and sandboxed processes.
   Instead stderr is added fds_to_map.

Bug: 852145, 869216, 868556
Change-Id: I89c429231cd0e295247c80f12e587e1c7335456b
Reviewed-on: https://chromium-review.googlesource.com/1155967
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579872}

Attribution section should be removed after clicking restore default
background. Adding clearAttribution function when the
restoreDefaultInteraction is called.

Screenshot:
https://screenshot.googleplex.com/AQT8eBddJ7A.png

Bug: 869693
Change-Id: I18526c72c74fbff84320faf5f8a756c545138fcf
Reviewed-on: https://chromium-review.googlesource.com/1157650Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579871}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0d97057a..b538ae75

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I65b789ae482ea58277b26e78d4cfb82aa563ab12
Reviewed-on: https://chromium-review.googlesource.com/1158397Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579870}

* Make it a little easier to understand
* Remove some panel-related code (a lot more of that in a separate CL)

No change in behavior.

Bug: 805612
Bug: 788033
Change-Id: I70225cc90cba940a8e2cb148be4aa887ebaa01ce
Reviewed-on: https://chromium-review.googlesource.com/1150776
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579869}

This change:
- writes to settings each time ChromeVox changes a tts property
- updates from prefs on startup
- observes pref changes and announces when rate, pitch, and volume changes
- adds a new key binding (Search+o, s) which opens the tts settings
- adds a new menu item in the ChromeVox menus opening tts settings

There should be no functional change for ChromeVox commands (e.g. keyboard shortcut to change pitch).

Changes to global tts settings should be reflected in ChromeVox immediately once changed.

Change-Id: Ic701c6f7b4422194ac8a957fbaf4fe0fd60e00af
Reviewed-on: https://chromium-review.googlesource.com/1157173
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579868}

Allows each target to then append and customize the license file based
on their third-party sub-licenses.

Bug: 869935
Change-Id: I732c132abaf386f7ce763fb7452384717c1264ed
Reviewed-on: https://chromium-review.googlesource.com/1158964
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579867}

This CL supports showing toasts on lock screen.

If the device is locked and the toast can be in the lock screen,
ToastOverlay appears in kShellWindowId_LockSystemModalContainer
instead of kShellWindowId_SystemModalContainer.

kShellWindowId_LockSystemModalContainer can be used only during
the lock screen is visible, so we switched the container when the
lock status is changed.

Bug: b/79951342
Test: ash_unittests --gtest_filter="ToastManagerTest.*" passes

Change-Id: I40d62e21b437686fcfc4b119a0c9954207f3533d
Reviewed-on: https://chromium-review.googlesource.com/1154783
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579866}

Change-Id: I9a2287102428a6c386fde09d9d237c6a9419e824
Reviewed-on: https://chromium-review.googlesource.com/1156589Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579865}

This CL fixes the Size we SetAll() in the viz::TextureDrawQuad
from an empty one to the appropriate CanvasResource Size -- this
is needed to indicate to e.g. Ozone the |resource_size_in_pixels|
of the overlay candidate, but it's also more correct in general.

Also removes an unused variable and adds {} in a few needed places.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ice28fb8c9d7f9a4eee29a22f8634b08c9dfb2e36
Reviewed-on: https://chromium-review.googlesource.com/1157232
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579864}

This CL implements the Read and Write functionality for the new
data store. It has not yet replaced the existing notification
database.

Bug: 856603
Change-Id: Ie218078f1a17ef0948279fef4632c24cdc437ff0
Reviewed-on: https://chromium-review.googlesource.com/1140163
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579863}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite can use the THREAD_POOL_EXECUTOR instead,
since this use doesn't appear to rely on the concurrency guarantees that
SERIAL_EXECUTOR provides.

Bug: 869907
Change-Id: I7dce5b4f28520a3d2a81491756f5aec5f6806fa9
Reviewed-on: https://chromium-review.googlesource.com/1158962Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579862}

Adds a Views::GetAnchorBoundsInScreen() method. This defaults to
GetBoundsInScreen() but can be overridden for views whose visual
bounds differ from their actual bounds. This is the case for toolbar
buttons on Touch (that provide larger hit targets than their visual
size).

This method is then used for the menus spawned by AppMenuButton and
ToolbarButton as well as BubbleDialogDelegate which allows these
specific menus and BubbleDialogDelegates in general to be better
aligned visually to their anchors.

Bug: chromium:800372, chromium:869928
Change-Id: I9c516d8a7ecb6c922e347d4db61ce1db72c71be7
Reviewed-on: https://chromium-review.googlesource.com/1152525
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579861}