- 27 Jul, 2018 40 commits
-
-
Oscar Johansson authored
When building using jumbo, files get merged and functions and variables with the same name may end up in the same namespace and conflict. This happens in: media/cast/net/cast_transport_impl.cc media/cast/net/udp_transport_impl.cc Since the functions and variables are identical they are moved to a common util file. Bug: 867350 Change-Id: I08747781d56b78e9a8783bfec870c7084183062a Reviewed-on: https://chromium-review.googlesource.com/1152738 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#578596}
-
Pin-chih Lin authored
Currently VideoEncodeAccelerator::Initialize() does not take level into account which is a factor of AVC encoding. Instead, it always set the fixed level in VEA implementation. For upstream Android CTS, it requires AVC level setting and checks the level of output encoded stream is within configured one. To satisfy this we need to pass level on initialization. Since there is a bunch of parameters we decide to refactor VEA::Initialize() to use Config struct bundling all parameters as VideoDecodeAccelerator did. This CL only modifies VEA::Initialize() API to use Config struct as input to cover original parameters and output_level. Once this is approved to change, we will implement the utilization of output_level inside VEA. BUG=b:110811755 BUG=863321 TEST=build and deplot chrome on eve TEST=build and run video_encoder_accelerator_unittest on eve TEST=build media_unittests TEST=build content_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I002169634a2b2d23a00178eb5015a14f4ddcf5dc Reviewed-on: https://chromium-review.googlesource.com/1130570 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#578595}
-
Oscar Johansson authored
When building using jumbo, files get merged and functions with the same name may end up in the same namespace. This happens with the functions InProgressFrameEncode defined in: media/cast/sender/external_video_encoder.cc media/cast/sender/h264_vt_encoder.cc This commit solves the issue by renaming the functions to something more file specific. Bug: 86750 Change-Id: I8f6fb84783539dcec4aae824bb971e982b4db5c2 Reviewed-on: https://chromium-review.googlesource.com/1152745 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files gets merged. Files and variables with the same name may merge into the same namespace or scope and conflict. This happens in the files: media/filters/aom_video_decoder.cc media/filters/ffmpeg_video_decoder.cc media/filters/vpx_video_decoder.cc This commit solves the issue by renaming the function GetThreadCount to something more file specific. It also moves some constants to that function. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id57aa6cc6ac10acd0073eee032d0d04592ba87e4 Reviewed-on: https://chromium-review.googlesource.com/1151311 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files merged and functions with the same name may end up in the same namespace/scope. This happens for the function OnError() that gets called by Bind(). OnError() is defined in: media/filters/audio_video_metadata_extractor.cc media/filters/media_file_checker.cc This commit solves the issue by renaming one of the functions to something more file specific. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1b762e4f1c4b11751df2302874af53106889d085 Reviewed-on: https://chromium-review.googlesource.com/1151316 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
Oscar Johansson authored
In jumbo builds the compiler complain about not knowing about the template specialization of the function OnStartOfCodedFrameGroup, that is defined in source_buffer_stream.cc. To solve this issue a fordward declaration is done before usage. Bug: 867350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If090b848bc2ae78121620aba2349eac4c63d8a65 Reviewed-on: https://chromium-review.googlesource.com/1151313 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4db8708c903..55b1e6168454 git log c4db8708c903..55b1e6168454 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 dbd1612782f5..18f7e5033040 (1 commits) 2018-07-27 herb@google.com const all the things 2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-26 ziadb@google.com SkAR Java: refactored project structure 2018-07-26 ziadb@google.com SkAR Java: changes to DrawManager/FingerPainting 2018-07-26 halcanary@google.com site: Documentation & Fiddle links on front page Created with: gclient setdep -r src/third_party/skia@55b1e6168454 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ib2b45c09f9e0f4cdfa425c6591808cbcea5f1115 Reviewed-on: https://chromium-review.googlesource.com/1152613Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578590}
-
Anita Woodruff authored
This prevents developers updating the channel id of a notification and forgetting to update the channel id that is logged. Bug: 772027 Change-Id: Ic32cead46f91a24d3164592c196b527fc21edcdd Reviewed-on: https://chromium-review.googlesource.com/1148321 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578589}
-
Daniel Bratell authored
Some osmesa code uses the "real" OSMesa API headers and those are not 100% compatible with the wrapper API headers normally used. That incompatibility means that they cannot compile in the same translation unit (jumbo builds). This splits the osmesa files into their own build target to avoid potential conflicts. Also changes the code to be consistent with how osmesa.h is included. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifc96cf25f7b69f23f293e297ab59ce5192f1cd20 Reviewed-on: https://chromium-review.googlesource.com/1149874Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#578588}
-
Daniel Bratell authored
In jumbo compilation many cc files compile in the same translation unit and if they use the same local variable names, there will be compilation clashes. That happened in the automatically generated code with info about various problems in gpu drivers or the like. This patch makes sure necessary variables have unique names by adding a unique keyword for each set of data. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ief86248f2d17f123602c7e641c286d0550a85d89 Reviewed-on: https://chromium-review.googlesource.com/1151314 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578587}
-
Jose Dapena Paz authored
IWYU: it fixes the build with libstdc++ after dc24395b "Retry initializing download db on failure" Bug: 819294 Change-Id: Id8a9bdf56f74d979d4e48747a3a6fbd9c51f59c6 Reviewed-on: https://chromium-review.googlesource.com/1150530 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578586}
-
Colin Blundell authored
Currently, AccountTracker::GoogleSigninSucceeded() calls AccountTracker::OnRefreshTokenAvailable() for each account that the token service knows about. However, this is conceptually somewhat confusing, as it's not the case that the refresh tokens for those accounts have suddenly become available. Moreover, an upcoming conversion of this class to use IdentityManager will make it even less suitable, as the corresponding observer callback passes information that AccountTracker won't have (and doesn't need) when invoking it manually. This CL changes AccountTracker::GoogleSigninSucceeded() to directly call through to AccountTracker::UpdateSigninState(), better reflecting the actual flow. Bug: 809923 Change-Id: Ic7673659cb9383d55eb8eda5cfb84a22f3a72214 Reviewed-on: https://chromium-review.googlesource.com/1150223 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578585}
-
Takuto Ikuta authored
Currently MSVC builder cannot build v8 and pdfium with cl.exe. TBR=dpranke@chromium.org, thakis@chromium.org Change-Id: Ic7fc3bd57583f33f56a795e1534e5c04774c6612 Reviewed-on: https://chromium-review.googlesource.com/1152645Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578584}
-
Vasilii Sukhanov authored
The spec specifies max width for labels in the password dropdown. Bug: 868020 Change-Id: I112c0866e7f0f0165b82f72bdc55c21a25c6c09f Reviewed-on: https://chromium-review.googlesource.com/1151637 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#578583}
-
Vadym Doroshenko authored
This Cl copies and adapts creating pending credentials from PasswordFormManager to NewPasswordFormManager. No changes in logic. Creating of pending credentials is the step in implementing of saving in NewPasswordFormManager. Next steps will be to implement Save() and Update() methods. Bug: 831123 Change-Id: I2a7f24c85e46ecd1474f99cf26c9b5136fe2ae9d Reviewed-on: https://chromium-review.googlesource.com/1148393 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578582}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dbd1612782f5..604d873e1df5 git log dbd1612782f5..604d873e1df5 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 oetuaho@nvidia.com Fix multiview combined with flat interpolation 2018-07-27 fjhenigman@chromium.org Vulkan: make DynamicBuffer reusable, always valid. Created with: gclient setdep -r src/third_party/angle@604d873e1df5 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I12373ce7d2a0d223b8dbea76ee55f4ceb65bc32c Reviewed-on: https://chromium-review.googlesource.com/1152614Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578581}
-
Dan Elphick authored
Gets the Isolate via ToIsolate(LocalFrame*). Change-Id: I8e6fcb1043d5774483cd9533d848ae5d0fcf6179 Reviewed-on: https://chromium-review.googlesource.com/1151195Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578580}
-
Dan Elphick authored
since they infer the Isolate from the address of the String they're called on. This will cease to work reliably in future V8 releases, so this change replaces all uses in chromium with ones that pass in the Isolate explicitly. v8: :Write, v8::WriteUtf8 and v8::Utf8Length are marked V8_DEPRECATE_SOON Change-Id: I13780586c91de98375adec0ad414d65476ed5170 Reviewed-on: https://chromium-review.googlesource.com/1149879Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578579}
-
Boris Sazonov authored
This CL modifies the intent used by SyncPromoView and Sync customization pages when master sync toggle in Android is turned off. New intent opens main Sync settings page instead of the specific page for the signed in account. This is necessary because master sync toggle is not accessible from the account sync page. Bug: 863370 Change-Id: I5b2b410084bc0945b6190aec6a0c9cbf1277fefd Reviewed-on: https://chromium-review.googlesource.com/1151988Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#578578}
-
Henrik Boström authored
It was added in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1145872 I wasn't sure whether to revert that CL or disable the test. Disabling. It's flakily not terminated: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939871163610794448/+/steps/webkit_unit_tests_on_Windows-10-15063/0/logs/WorkerThreadTest.TerminateWorkerWhileChildIsLoading/0 TBR=japhet@chromium.org, nhiroki@chromium.org NOTRY=True Bug: 868253 Change-Id: I286472514666b2d11627a515fdab92e0d73cd155 Reviewed-on: https://chromium-review.googlesource.com/1152743 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Henrik Boström authored
TBR=fdoray@chromium.org, reillyg@chromium.org NOTRY=True Bug: 868254 Change-Id: I5e80699e1d04e51be31a097b2b4deb0ec5e3a7ce Reviewed-on: https://chromium-review.googlesource.com/1152737 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib683d4e2468e6454d9ac3ee53ec56218f024071e Reviewed-on: https://chromium-review.googlesource.com/1152700Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578575}
-
Takuto Ikuta authored
Change-Id: Id6ede6f1c9dd441cd54ac7b757ce18c6859b8b71 Reviewed-on: https://chromium-review.googlesource.com/1152721 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578574}
-
Elad Alon authored
Improve readability in WebRtcEventLogManager by introducing OnFirstBrowserContextLoaded() in it. Bug: 775415 Change-Id: I7b99e891eb816e763edfbd4b8c2cca05ed81f22c Reviewed-on: https://chromium-review.googlesource.com/1150172 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578573}
-
Alexandr Ilin authored
This CL adds a new feature that allows the app using Chrome Custom Tabs to prefetch resources in parallel with loading the main intent url. The implementation reuses the DetachedResourceRequest API that was used before for the CCTParallelRequest feature (leapfrog v2). Bug: 866460 Change-Id: If22fbc5a430ba9cef3db69da93605eb448afa00a Reviewed-on: https://chromium-review.googlesource.com/1146801Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578572}
-
Takuto Ikuta authored
TBR=yosin@chromium.org Bug: 698165 Change-Id: I9c4e7f82ade5b91176df1a6c943665bdfbc8986c Reviewed-on: https://chromium-review.googlesource.com/1152748 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578571}
-
Mattias Nissler authored
This reverts commit bcbd1740. Reason for revert: The bug that prompted disabling of the state-preserving firmware update feature has been fixed per https://chromium-review.googlesource.com/1123830 so we can re-enable the feature. Original change's description: > Disable state-preserving TPM firmware update. > > The test team found an issue where cryptohomed fails to deal with the > state the TPM is in for the case when the update installation gets > interrupted and recovery is invoked to retry and complete the update. > Disable device-state preserving updates for now until the issue is > resolved. > > BUG=chromium:854576 > TEST=Triggering TPM firmware update via chrome://chrome will not invoke the device state preserving update flow. > > Change-Id: I4ac4d325bfbf953cfa14a501e871a3f9f59c699c > Reviewed-on: https://chromium-review.googlesource.com/1111998 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Mattias Nissler <mnissler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570020} TBR=stevenjb@chromium.org,mnissler@chromium.org Bug: chromium:854576 Change-Id: Iab59dc64130792b92071d45b82a77ddbd4553aa4 Reviewed-on: https://chromium-review.googlesource.com/1127539Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#578570}
-
Anita Woodruff authored
- This doNothing() is not actually needed for the tests to pass; I suspect it's a hangover from when these tests were instrumentation tests. R=mlamouri@chromium.org Bug: 772027 Change-Id: Ia2b2103d2bdf6962c065ed5e34ecb1333d8300f5 Reviewed-on: https://chromium-review.googlesource.com/1151320Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#578569}
-
Yuki Shiino authored
SecurityOrigin::CanAccess distinguishes file://host/ from file:/// (empty host), however, the security tokens for file: scheme were always "file://" regardless of host. This makes Blink think two origins are cross origin but V8 think the two are the same origin. This patch changes the security tokens in case of file: scheme to null string (will fallback to the default security token and V8 will always ask Blink to perform a security check). Bug: 858990 Change-Id: If305a994d6150984e8dd41b964003ce1eafb8b99 Reviewed-on: https://chromium-review.googlesource.com/1133105Reviewed-by:
-
David Grogan authored
We now set AvailableSize and PercentageResolutionSize on the ConstraintSpace properly. And also now give the flex layout algorithm more accurate offsets and main axis size. Bug: 845235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia24778ffd24a6f1122e778919686a082a63d4b06 Reviewed-on: https://chromium-review.googlesource.com/1142729 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#578567}
-
Takuto Ikuta authored
TBR=pmonette@chromium.org, pennymac@chromium.org Bug: 868233 Change-Id: I526e832c16daa533ce53d03be717d265a67576e9 Reviewed-on: https://chromium-review.googlesource.com/1152726Reviewed-by:
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org, fdegans, sergeyu Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6499e133cd71503143426575ead473bb973be2ea Reviewed-on: https://chromium-review.googlesource.com/1151096 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I0e2795dd7c8b4fb1a9ec58bc56a019eb8b2bbafd Reviewed-on: https://chromium-review.googlesource.com/1152699Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578564}
-
Alan Cutter authored
This CL turns on the DesktopPWAWindowing flag on by default for Windows and Linux. We are targeting M70 for this so since M69 recently branched we're flipping the flag so this feature can start baking before next branch point. Bug: 851845 Change-Id: Ib0f6232aacfa753054791419ed694687fa3b5671 Reviewed-on: https://chromium-review.googlesource.com/1152339Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#578563}
-
Mark Cogan authored
This CL introduces an appearance change for the tab grid when tabs are being reordered. It adds a second collection view layout to make all of the non-moving cells slightly transparent, and to make the moving cell slightly larger. Bug: 804593 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6ba416844281aa7a106552c24ef1d9c854bff567 Reviewed-on: https://chromium-review.googlesource.com/1151297Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#578562}
-
Wenzhao Zang authored
A follow up to CL https://chromium-review.googlesource.com/c/chromium/src/+/1141349 TBR=yusukes@chromium.org Bug: NONE Change-Id: I120dde78eeab5f35a8edc5fbcb021abbe8f2f535 Reviewed-on: https://chromium-review.googlesource.com/1152693Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578561}
-
Christian Dullweber authored
BrowsingDataRemoverBrowserTestP.SessionStorageDeletion and BrowsingDataRemoverBrowserTest.StorageRemovedFromDisk were flaky when MojoSessionStorage was temporarily disabled. This CL enables the tests again and forces the kMojoSessionStorage flag to be enabled during the test. Bug: 865802 Change-Id: I1f3b0b2bad792089f624a33271600ecf23875b29 Reviewed-on: https://chromium-review.googlesource.com/1150532Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#578560}
-
Hiroki Nakagawa authored
ThreadableLoadingContext has been used for encapsulating ExecutionContext-dependent things for loaders. Thanks to recent off-the-main-thread efforts, now most of resource loading can run off-the-main-thread and this abstraction is no longer necessary. In addition to removing unnecessary code, this cleanup is useful for removing WorkerShadowPage for installed service workers (issue 820329), and introducing FetchClientSettingsObject in loaders (issue 845285). Bug: 820329, 845285 Change-Id: Id6e329c9c783057ba68abab78a2e86054a3b0c29 TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1150957 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#578559}
-
Yoichi Osato authored
This reverts commit c7c6a230. Reason for revert: Findit identified the culprit r578404 with confidence 70.0% in the config "chromium.linux / Linux Tests" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKLAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzLzcxMzQ0L3Zpel9icm93c2VyX3Rlc3RzL1YyVmlVblJqUkdWemEzUnZjRU5oY0hSMWNtVkNjbTkzYzJWeVZHVnpkQzVTZFc1elUyTnlaV1Z1YzJoaGNtVkdjbTl0VDI1bFZHRmlWRzlCYm05MGFHVnkMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Original change's description: > [NTP] Add ability to add/delete/reset custom links from the New Tab Page > > Added functionality for adding/removing links and restoring the Most > Visited tiles. If the URL is not valid, the link will not be added. The > blacklist button now opens the edit dialog (editing links is currently > not functional and will be added in a later CL). > > Also added hover/pressed/focus styling to the input fields and the > buttons. > > Design Doc: go/chrome-ntp-custom-links > > Video: https://screencast.googleplex.com/cast/NTQyNDU2OTc1ODI1MzA1NnwwMjFkODAwYi1kMg > > Bug: 851293 > Change-Id: Ic92e46ba93a4abcb375467a1d047cbb573f231ba > Reviewed-on: https://chromium-review.googlesource.com/1149458 > Commit-Queue: Kristi Park <kristipark@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578404} TBR=bauerb@chromium.org,mathp@chromium.org,treib@chromium.org,kristipark@chromium.org Change-Id: Ibd93fac9b68c14b68c4dd26a174818bb10b1a719 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851293, 868237 Reviewed-on: https://chromium-review.googlesource.com/1152594Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578558}
-
Yoichi Osato authored
This reverts commit 2094f015. Reason for revert: viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/28406 Original change's description: > chromeos: Support a11y caret highlight in shortcut viewer app and mash > > The existing code updates the text input caret highlight by observing > input method state. This works in classic ash because the input method > is shared globally across ash and browser code. This doesn't work with > remote apps because ash can't see the input method in the remote > process. The caret doesn't work in mash because the ash process can't > see the browser's input method. > > Add support for a11y to observe the input method objects created by the > browser's input method driver / bridge. Explicitly forward the > text caret bounds to ash, which then updates the highlight. > > Bug: 867110 > Test: added to ash_unittests and browser_tests > Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72 > Reviewed-on: https://chromium-review.googlesource.com/1151897 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578473} TBR=jamescook@chromium.org,xiyuan@chromium.org,tsepez@chromium.org Change-Id: I8d2ed52affae2063d705f1ded9a2eca5dfdbda13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867110 Reviewed-on: https://chromium-review.googlesource.com/1152593Reviewed-by:
-
