- 28 Jul, 2020 40 commits
-
-
Avi Drissman authored
Files named "*_messages" are used to contain IPC messages and there are special presubmit rules to enforce security team reviews of those files. The "error_messages" files in the chrome/utility/image_writer directory are not IPC messages, so change the filenames so they don't fall under the presubmit check. Bug: none Change-Id: I52025f88ab98c545fc59e6f3ab15ec58f639acc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321525Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792237}
-
Keith Lee authored
Pipe autocorrect character bounds from TextInputClient to getAutocorrectCharacterBounds api surface The CL is dependent on https://chromium-review.googlesource.com/c/chromium/src/+/2251638 Bug: 1108170 Change-Id: Idb651077f9f935b5a9b2a677887b8258eff22310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315658 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#792236}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I692e76739860b75e8cf8de53f3025f581403b1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792235}
-
Guido Urdaneta authored
This reverts commit e5e98cf1. Reason for revert: Tests have been corrected. New attempt. Original change's description: > Revert "Reland "Do not expose media devices before a successful getUserMedia()"" > > This reverts commit 8b10bc20. > > Reason for revert: camera.CCAUISanity.fake is failing again: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/27932 > > Original change's description: > > Reland "Do not expose media devices before a successful getUserMedia()" > > > > This reverts commit 69a60019. > > > > chrome-prefixed URLs are exempted from the getUserMedia() requirement. > > > > Original change's description: > > > Revert "Do not expose media devices before a successful getUserMedia()" > > > > > > This reverts commit d64e736a. > > > > > > Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680 > > > > > > Original change's description: > > > > Do not expose media devices before a successful getUserMedia() > > > > > > > > This is a spec-compliance change. > > > > > > > > This CL also adds some improvements to the blink MediaDevices unit test. > > > > > > > > Bug: 1101860 > > > > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808 > > > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#786253} > > > > > > TBR=hta@chromium.org,guidou@chromium.org > > > > > > Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1101860 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282 > > > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > > > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786615} > > > > TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1101860 > > Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833 > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#791797} > > TBR=shik@chromium.org,hta@chromium.org,guidou@chromium.org,wtlee@chromium.org > > Change-Id: I6b18c308de10dc5e5251025fd887892ecfef938b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1101860 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320081 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791822} TBR=shik@chromium.org,hta@chromium.org,guidou@chromium.org,adithyas@chromium.org,wtlee@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1101860 Change-Id: I43537e2be617b8d66f40ba1cbd73771a07b79507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320791Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#792234}
-
Marc Treib authored
In some rare cases, clearing of account-scoped passwords can fail (e.g. if there's no network connection). In such cases, we should let the user know that passwords might remain at passwords.google.com. This CL adds an error dialog in chrome://settings/clearBrowserData. Screenshot: https://screenshot.googleplex.com/h9HmAk4sVCq Strings are not final. Bug: 1099260 Change-Id: I252787d9f9d3e8f39f435e6ddb37fb22ea3d7e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#792233}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the PIN dialog, triggered during the challenge-response login (a.k.a. smart card based login), receives a wrong PIN several times until the lockout happens. Bug: 1033936 Change-Id: Ibe90e48fd2a32fb990e22357704afab2bdd6e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317230 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792232}
-
Elly Fong-Jones authored
These tests don't work because the sampler is disabled on Big Sur. Bug: 1101399,1098119 Change-Id: Ibf42402ba0ab2abdcf225cc5de54e5b2939a5572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317806 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#792231}
-
Jonathan Mengedoht authored
The NavigationThrottle validates if a site supports .well-known/change-password urls and redirects to the origin if not to not show the user a 404 page. The NavigationThrottle is guarded by the WellKnownChangePassword feature flag. Bug: 927473 Change-Id: I4c9bf4bc61878096fbfec06cc922d1852a71fb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316164 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#792230}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595894324-d422a20c76a9a0bf9c80e2917291820d179a400b.profdata to chrome-mac-master-1595937363-e1ba3bb5d536598606cbf11f12f7443f2b2cf4cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie0fb8aa9f6a9ecf8a1623df25e68c4346ed77a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792229}
-
Kevin Ellis authored
Initially the table of contents was omitted as it is not populated when viewed in code search; however, it is properly generated if viewed via: chromium.googlesource.com/chromium/src/+/master/<code_path> Use of the [TOC] tag is pretty common in Blink READMEs, and believe it will be quite useful here as well when using a markdown viewer that supports the tag. Change-Id: I354d17ea1a889f91461e5427609a714e8fa24d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320889Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#792228}
-
Leo Zhang authored
When WithSandboxType is deprecated, a wrong Mojo interface was set for ImeService launching, which invalidates the "ime" sandbox. And ImeService's sandbox is set to "utility" by default always. BUG=b:161958233 TEST="--service-sandbox-type=ime" was set for the ime process. Change-Id: I14d0d4141fe8fe684935153ca05dee6cdd86fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320448Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792227}
-
Oleh Lamzin authored
Bug: b:159927590 Change-Id: I732477f033d1afe263203ddf180c61e827f9a3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320277Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#792226}
-
Torne (Richard Coles) authored
Switch to the R SDK and system SDK, and add the WebView code to support WebView R APIs. Bug: 1106471 Change-Id: I4fa349ff6b79983730bca609b95532b019e3e05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310800Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792225}
-
Mathias Bynens authored
CL that temporarily disabled the test: https://chromium-review.googlesource.com/c/chromium/src/+/2320612 Downstream DevTools CL that impacts the expected results: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2318257 CL that rolls the updated devtools-frontend into Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/2322214 Bug: chromium:1103854 Change-Id: I4888e1ef9f27839147386596d7ac145046b36b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321310Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#792224}
-
Mason Freed authored
Prior to this CL, there was a magic 166 alpha applied to the system focus ring color (the Accent Color setting). This has now been pulled into native_theme. Along the way, I also added a Color::operator SkColor() to convert blink::Color to SkColor, and used it in gradient.cc, along with here in layout_theme_mac.mm. I'm sure there are other such converters sprinkled around which could be migrated, but this was all I found. Quick note on testing: this change will be best tested by [1] once it lands. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2150765 Fixed: 1108169 Change-Id: I54ac4e60a1df1b39123721adffda9f39aac94fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317294 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#792223}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/df34e3c37407..c6c2cc49fa95 2020-07-28 thestig@chromium.org Remove some OS_ comments on #else lines. 2020-07-28 thestig@chromium.org Use int16_t with CPDF_CIDFont::GetVertOrigin(). 2020-07-28 thestig@chromium.org Make OutputFormat in pdfium_test.cc an enum class. 2020-07-28 vmiklos@collabora.co.uk Add FPDFSignatureObj_GetSubFilter() API 2020-07-28 thestig@chromium.org Rename "render" to "process" in some places in pdfium_test. 2020-07-28 thestig@chromium.org Improve object type checking for /CIDToGIDMap. 2020-07-28 thestig@chromium.org Fix some nits in CPDF_CIDFont. 2020-07-28 thestig@chromium.org Clean up CPDF_TextObject::GetCharInfo(). 2020-07-27 nigi@chromium.org Enable embedder tests RenderWithPause and RenderWithoutPause for Skia/SkiaPaths. 2020-07-27 nigi@chromium.org Consolidate repetitive checksum values for embedder tests. 2020-07-27 nigi@chromium.org Enable FPDFEditEmbedderTest.AddMarkCompressedStream for Skia/SkiaPaths. 2020-07-27 tsepez@chromium.org Remove friendship between CPDFXFA_Context and CPDFXFA_DocEnvironment. 2020-07-27 tsepez@chromium.org Remove CXFA_RenderContext 2020-07-27 tsepez@chromium.org Use uniform snake_case_ member names in CXFA_DocumentBuilder 2020-07-27 tsepez@chromium.org Move ownership of XML document up to CPDFXFA_Context. 2020-07-27 nigi@chromium.org In test suite FPDFAnnotEmbedderTest, enable ExtractInkMultiple and GetSetStringValue for Skia/SkiaPaths. 2020-07-27 nigi@chromium.org Enable FPDFAnnotEmbedderTest.ModifyRectQuadpointsWithAP for SkiaPaths. 2020-07-27 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from a2a7e05eb765 to 0606ae6f9a56 (61 revisions) 2020-07-27 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Code Coverage from a70177d4a2e5 to af90718d311e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6505b1bb2f88329f0c0f26fd946279e80f882c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792222}
-
Jiewei Qian authored
This CL adds a basic browsertest to verify System Web Apps works after a reinstall. This typically happens on a version upgrade. This CL tests that the installation process completes without crashing, and the installed Apps can be launched (with the exception of Terminal). Terminal requires resources that are only available in Chrome OS images, so we can't launch it from chromium source. Tast tests are needed for this scenario. Bug: 1095524 Change-Id: Ib7053ea56cf0eee8031c66b5d77edcc283236972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316191Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#792221}
-
Chris Hamilton authored
This allows the WebDedicatedWorkerHostFactoryClient to use a strongly typed interface without introducing a circular dependency. BUG=1085129, 1096617 Change-Id: I40fe440211265c679aa766f3bad048f5ee0676cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303310Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#792220}
-
Maksim Ivanov authored
Provide test coverage for the scenario when the PIN dialog, triggered during the challenge-response login (a.k.a. smart card based login), first receives a wrong PIN and only then the correct one. Also verify the PIN dialog title in the test for the successful scenario. Bug: 1033936 Change-Id: I1813f75b11f1662555271fac2e7aee84cf19dbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316865Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#792219}
-
Alex Ilin authored
SitePerProcessBrowserTestWithSadFrameTabReload.ReloadHiddenTabWithCrashedSubframe is flaky. TBR=jyasskin@chromium.org Bug: 1049885 Change-Id: If530bac5cbaa5d1230c87e6b6c6033d258cc4ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322887Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792218}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1ed85887c9ec..75770d6f7f01 2020-07-28 sigurds@chromium.org Fix flaky test 2020-07-28 sigurds@chromium.org Add missing typescript module 2020-07-28 mathias@chromium.org Reland “De-obfuscate X-Client-Data header values in Network tab” 2020-07-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md No-Try: true Bug: chromium:1103854,chromium:1110102 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie631548a8a2facc54414fccff7ac595d3ec2fc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322214 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792217}
-
dizg authored
creation signin promo. Screenshot for light mode: https://drive.google.com/file/d/1_S5ORmtvAA2McOYRO_vnZhgxby-ttpzX/view?usp=sharing Screenshot for dark mode: https://drive.google.com/file/d/1wobhOD-XgCWaaXgNz_I4wMfDOx69sNFA/view?usp=sharing Bug: 1105865 Change-Id: Ib98c7ead7bbe31d545c1c0908e52468d1e085305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316107Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#792216}
-
Alex Ilin authored
This reverts commit 596311e0. Reason for revert: causes flakiness in ErrorPageReloadBrowserTest.ReloadOnNetworkChanged test, https://crbug.com/1110192 Original change's description: > [WebLayer] Use NetErrorAutoReloader > > Navigations which fail with network errors may attempt to > auto-reload in some cases, in order to more seamlessly recover > from transient failures. > > This behavior was previously implemented renderer-side and copied > verbatim from Chrome. The Chrome implementation has been moved > browser-side (see bug for why) and also made into a reusable > component. > > This changes WebLayer to use the same component implementation > and deletes all the corresponding renderer logic. > > Fixed: 1098578 > Change-Id: I10c337abcae36f64be47f31b89e36c7393989077 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311371 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792028} TBR=jam@chromium.org,rockot@google.com,cduvall@chromium.org Bug: 1098578, 1110192 Change-Id: I7b05267e5bc9c13528607bebfa35beb485b0c965 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323150Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792215}
-
arthursonzogni authored
The [window.idl] defines CrossOrigin indexed and named 'getter', but it doesn't define their 'setter' counterpart. As a result, we should remove test for them. They were added in excess. [window.idl]: third_party/blink/renderer/core/frame/window.idl Bug: chromium:1090273 Change-Id: I31fb77c65b82fef3d6f44297bfa63a331a9e1b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315694Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792214}
-
Anders Hartvoll Ruud authored
MatchingStyles can apparently be called from from within probe:: AnimationPlayStateChanged. Updating style synchronously here means that new animations can start (via CSS animations). The animations team wants to prohibit starting/updating animations from within the probe call (see bug for details). Therefore we must avoid recalculating style here, since that _may_ trigger new/updated animations. As it happens, we don't actually need to recalculate the style, since this function is only matching selectors. It's sufficient to UpdateActiveStyle() instead, which ensures that information needed for selector matching is up-to-date. Fixed: 1106539 Change-Id: I75eb10ee1792f78ca1e5d44e42a63974af55162a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317795Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#792213}
-
arthursonzogni authored
If we don't, then a crash will happens when whenever the user tries to restore a tab on a URL using Cross-Origin-Opener-Policy-Report-Only (COOPRO). A test depending on this patch will be added on this branch. The current code is still potentially incorrect. Some TODO are added. Bug: chromium:922191 Change-Id: I10c2e08daf3aff3b3de7ee6c0eee90b1f3e777c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317964Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792212}
-
arthursonzogni authored
Run the CrossOriginOpenerPolicyBrowserTest with and with the BackForwardCache. There is one failing test: VirtualBrowsingContextGroup.HistoryNavigation failing. Bug: chromium:1102285,chromium:1109648 Change-Id: I473f559af095069236e80da9849f6fcf6c26b4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317959 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792211}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: If38556a36f3a3145c7ead239dac22797585cc7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322172Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792210}
-
Boris Sazonov authored
Removes ChromeSigninController.get().setSignedInAccountName(null) from IdentityManagerIntegrationTest. Almost all code that was using ChromeSigninController has been migrated to IdentityManager, so resetting sign-in state in this test is no longer necessary. Bug: 1046412 Change-Id: Ibafb9acc8de1ea16d305898d21ac9689787851bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316163Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792209}
-
Maksim Sisov authored
We don't have a fuzzer bot for ozone running and that's why we failed to spot when the fuzzer became broken. However, given that I started to enable use_x11 && use_ozone at the same time, the linux-libfuzzer-asan-rel started to compile the wayland fuzzer, and that revealed some compilation problems. This CL fixes that. The design of initialization of the test env was taken from other fuzzer tests. For example, ui/gfx/render_text_fuzzer.cc Bug: 578890 Change-Id: I1517731dc531cb48934cbdbd35023adea818c7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322706Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792208}
-
Anatoliy Potapchuk authored
Previouisly, in case of failure to download the terms of service, we were saying "Something went wrong" without a chance for user to redownload the ToS in case they are under flaky network. This cl makes the text on that screen more verbose and adds "Retry" button. Bug: b/156695308 Change-Id: Idd934bcd7572732d2b5b03f8b43c8fd937121ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316202Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792207}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8cfc41ae955d..53be1753dea9 2020-07-28 priyeshkkumar@gmail.com Fix `-Wformat' compiler warnings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie49cc5010e1466e845d203393aad9ecb478f7306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322076Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#792206}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e8ccc7d7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I71d516c685e96951a2800b8828edd259f10e4460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321452Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792205}
-
Carlos Caballero authored
Make sure we never show a prompt on behalf of a page that is not current for example because it was moved to the back forward cache. For that we need to associate all requests with the originating frame (RenderFrameHost). Before we actually show the prompt we check whether the frame still exists (could have been deleted) and is current. If that is not the case we just cancel the request. This is an extra safeguard on top of what is already done in PermissionRequestManager::DidFinishNavigation, which only clears queued requests at the time of the navigation commit, but does not prevent us from accepting requests after that. Ideally we would not cancel those queued requests but store them on the side in case the frame becomes current again (gets out of the cache). Change-Id: Ib7eaa6b935b96cfe76d9f8cbcd7a3712900855fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307212 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792204}
-
Tim Schumann authored
This reverts commit b9f1aa01. Reason for revert: Suspected to break ProactivelySwapBrowsingInstancesSameSiteTest BUG: 1110281 Original change's description: > Reuse process on history navigations between same-site cross-BI pages > > See crbug.com/1096135 for context. When doing same-site navigations, we > might do a proactive BrowsingInstance swap, but we will reuse the > renderer process whenever we can. On history navigations between pages > that are same-site but have different BrowsingInstances (not only on > cases that are caused by proactive BI swap), we should try to reuse the > renderer process. > > Bug: 1096135 > Change-Id: I58f72bedecbbf94e4e05218bb9c15970a502d8a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282553 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792195} TBR=creis@chromium.org,alexmos@chromium.org,rakina@chromium.org Change-Id: Ibb0391564b89172e0c1080a8efad014b1243886a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322626Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#792203}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595807480-d17b0499af342f0654e8c059a08be3424e0d8a06.profdata to chrome-win64-master-1595894324-3cfde226a7530b6c961e3b6919ae369552837a05.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4473c0aaee139cbcf0ba4319be05e971ce739ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322068Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792202}
-
Andrei-Laurențiu Olteanu authored
Fix untrusted typo. Bug: b:162261251 Change-Id: Ib477041a7e97b6c4992cc6ef48f354062e7b923a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320610Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#792201}
-
Hwanseung Lee authored
there is unnecessary if statement. because always same code execute regardless of if statement expression. so remove it. Bug: None Change-Id: Ifd921cc0c965cd3249f28a001d9bc633f56bd46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321908 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#792200}
-
Maria Kazinova authored
Bug: 1075444 Change-Id: I229f5ca4c20bae2d4dda248d88bd80002b960a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320269 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792199}
-
rajendrant authored
This CL adds API to stop the throttling which resumes the paused media responses immediately. Subsequent CL will make use of this to stop throttling on video play stalls. Bug: 1082554 Change-Id: I51137a1158e8aed8bd63e7a6db344aefe94a6720 TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309005 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792198}
-