- 06 Sep, 2019 40 commits
-
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/sync_sessions. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=vitaliii@chromium.org Bug: 891670 Change-Id: I7d613562534207fcb526a2e8cbd1bff08ddb28e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786847 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#694221}
-
Javier Ernesto Flores Robles authored
All passwords is now presented from the browser coordinator. Browser Coordinator is now the AutofillSecurityAlertPresenter. PasswordListNavigator has been split into 2 protocols. FormInputAccessoryCoordinatorDelegate is renamed to FormInputAccessoryCoordinatorNavigator ivars named manualFillInjectionHandler renamed to injectionHandler. Regression test: crrev.com/c/1783446 Bug: 997632 Change-Id: I85166491cdd6b898ee4451a6fcb9e0b343c75e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784614 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#694220}
-
Olga Sharonova authored
TBR=lanwei@chromium.org Bug: 999261 Change-Id: Ide11dca175c8dc96fdd279294b2e39171065ab20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789232Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#694219}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ebdb12ff. With Chromium commits locally applied on WPT: 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js" 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3f47374f958d8d1a25f6d0d45f41434605a3b7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789442Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac3232fef4c9..dff4674a483a Created with: gclient setdep -r src-internal@dff4674a483a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia4cb382bd53cdf7efe954e9e5440368285d0cba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694217}
-
François Beaufort authored
This CL makes GPUDevice an EventTarget. When an uncaptured error is raised in Dawn, the "uncapturederror" error is fired in GPUDevice. Change-Id: Ib0082e080667448e309d9879ea22de7ac1706fad Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787504 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#694216}
-
Rune Lillesveen authored
Only the root element of the display:none subtree needs that. ComputedStyle below the root will follow from propagating the StyleRecalcChange down RecalcStyle() if necessary. This CL avoids unnecessary style recalc passes over display:none or non-slotted children. Bug: 972752 Change-Id: I39dc393104b27a6734705120902b2f173dfd9566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782855Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694215}
-
Armando Miraglia authored
This CL replaces the usage of unretained pointers with weak pointers in VideoCaptureManager. This conversion is safe because all places where the pointers are saved are on the IO thread as well as the place were the callbacks are then executed (see line 326 and 348). BUG=998548 Change-Id: I47bda798fa7bcbd66bf23682ee6c6dd26b5642c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789223Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#694214}
-
Olga Sharonova authored
TBR=aee@chromium.org Bug: 1000950 Change-Id: Iee20cc3507c1e3e174450bb1f2dc7bf90114ca90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789286Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5d0faf9be9d7..6726fcfdd4aa git log 5d0faf9be9d7..6726fcfdd4aa --date=short --no-merges --format='%ad %ae %s' 2019-09-06 swiftshader.regress@gmail.com Regres: Update test lists @ 5d0faf9b Created with: gclient setdep -r src/third_party/swiftshader@6726fcfdd4aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I5a5cc1cc69c759d24ba7bd037ea2b40a51857ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694212}
-
Nazerke authored
This CL changes splash screen, shown before 'Accept and continue' screen, after fresh install and launch chrome into dark in dark mode. Bug: 997170. Change-Id: If35987cf9b50ca12a662f9de7f15080a0909f3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787384 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#694211}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/75e2290af2dc..50b0baf510da git log 75e2290af2dc..50b0baf510da --date=short --no-merges --format='%ad %ae %s' 2019-09-06 yvesg@webrtc.org [tsan] Guard TestStatictics against concurrent access. Created with: gclient setdep -r src/third_party/webrtc@50b0baf510da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Icdcfd40c0563059aeb93049b3c7734a926c2b8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789402Reviewed-by:
-
Sergio Villar Senin authored
NullValue() is represented as a NaN in a double. We could better return a base::Optional<double> and use the undefined base::Optional as null value. Also there is no need for the IsNull() call as we could just use the returned value as a boolean. Bug: 994811 Change-Id: Iafc8a738d972bca6f6f41cba10b82f703e8e7490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778497 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#694209}
-
Alex Chau authored
- Add a JNI method to callback when both DeviceInfoTracker and LocalDeviceInfoProvider are ready - Also removed redundant setVibration in SharingNotificationUtil Bug: 996318 Change-Id: Id4df6b407ac2fb1c1622071ffb7ee8bb3a747b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787379 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#694208}
-
Mike West authored
This commit reverts the change in [1] which sent `Sec-Fetch-*` headers over non-secure transport. Now that [2] has landed, we can impose the restriction safely, as we're consistently setting `Sec-Fetch-Mode` whenever we set `Sec-Fetch-Site`. The `*.cc` file changes are a strict revert of the original patch. The test changes are rewrites of tests that originally landed with incorrect expectations. Now that the code is sending the `Sec-Fetch-Mode` header when it's supposed to, the tests need to change as well. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1762079 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1780725 Bug: 995745, 971938, 964053 Change-Id: I240ed9e62d18583c2d48e290d1cae086a387fc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787318 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694207}
-
Olga Sharonova authored
TBR=lanwei@chromium.org Bug: 1000530 Change-Id: I8368aa32a991e9aba2bfebe44ad344025d533a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789292Reviewed-by:
-
Stephen Chenney authored
Enable by default the feature that defers commits for a short period on same-origin navigations. Input is suppressed while the content remains unpainted to avoid the danger of users clicking on unseen content. Tested manually thoroughly over the last several months, with additional tests to ensure the feature is active, but only used on the promised navigations (same origin etc). One test, IntentPickerBubbleViewBrowserTest, does a same origin navigation then expects immediate input handling, and fails with this change. Disable the feature for that test (having confirmed we do commit after the input is dropped). Bug: 805798 Change-Id: Iee6859ac41128476bb9ad295ebdc763b97af4d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1467982 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#694205}
-
arthursonzogni authored
Tbr: michaelbai@chromium.org Bug: 1001400 Change-Id: I8a6e2467f020372d7b0de031b84c07948834cfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789283 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694204}
-
Robbie Gibson authored
This follows a similar approach to https://crrev.com/c/1070506. Instead of always using match.answer->first_line() to get the text of the main line of the question (the part corresponding to what the user has typed), we now use match.contents to get that part, and then append on any additional_text or status_text from the first line. One small visual change is that now, the "user text" part of answers have bolding (from the match contents and classification). Before, they didn't because we ignored the server-provided HTML bold tags and didn't provide anything in their place. My asusmption is that this is fine. Bug: 763894 Change-Id: I4a9ec9da56454433dfe33aa3db2c0ee5b555c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787508Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#694203}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/chromeos/policy. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=antrim@chromium.org Bug: 891670 Change-Id: If003533b375a502c364fe87b05ee261a03d1f5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787109 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#694202}
-
Olga Sharonova authored
Disabling flaky WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureAttributeApplies TBR: mlamouri@chromium.org,mlamouri@google.com Bug: 1001249 Change-Id: I820dc7b2098154a7aec094055cbfbd29d770be9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789224Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3d465168e7a3..d0131152681b git log 3d465168e7a3..d0131152681b --date=short --no-merges --format='%ad %ae %s' 2019-09-06 vapier@chromium.org licensing: tighten up printing Created with: gclient setdep -r src/third_party/chromite@d0131152681b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4f28b4ec1c296979fda7d77a25feb780559572db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789085Reviewed-by:
-
Eric Seckler authored
.. to avoid SMB exhaustion during the commit. System trace data could get lost since we switched to kDrop mode (and was susceptible to deadlocks before). With this patch, we commit the data in smaller batches and wait for an acknowledgement from the perfetto service before committing the next batch. Bug: 998940 Change-Id: Ic38a07a3d91f5798f074ac67d25e06a2026dbea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782620 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694199}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6f226a03abc6..2fb6e6107309 git log 6f226a03abc6..2fb6e6107309 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 fmayer@google.com Merge "Minor improvements to bookkeeping." Created with: gclient setdep -r src/third_party/perfetto@2fb6e6107309 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I562c8b8a9092c5af304e73dd1301033bfc443924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789262Reviewed-by:
-
Sergey Poromov authored
3 -> 2 4 -> 3 Bug: 940648 Change-Id: Ib18b926faff51435d3c76cf383e15a23168ed607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789284 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Auto-Submit: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#694197}
-
Jan Krcal authored
This CL refactors the avatar toolbar button so that the UI state is extracted into one state getter which results in consistent treatment across different functions displaying the UI and simplifies the code. Bug: 967317 Change-Id: I8d3e8f56d9f3b4931a188a9a34eed93f45f71590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782820 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#694196}
-
Lowell Manners authored
For the initial version of the BackForwardCache, we want to store only one document per tab to minimize memory usage. As part of this change the test SubframeSurviveCache4 was deleted, because the scenario it covers is no longer possible with a cache size of 1. Change-Id: I9dacb0c2c81c3266310f65f06337f72865ae6351 Bug: 1000658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782902 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 83d03872. With Chromium commits locally applied on WPT: 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." c1907c87 "[WPT/common/security-features] Rename common.js to common.sub.js" 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I117d357051ec2f9a74618b227ae97e72cfbaeac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789054Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ba5f8e94c87e..75e2290af2dc git log ba5f8e94c87e..75e2290af2dc --date=short --no-merges --format='%ad %ae %s' 2019-09-06 yvesg@webrtc.org Rollback to strict audio codec tests for libopus on android (neon). Created with: gclient setdep -r src/third_party/webrtc@75e2290af2dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:986727 Change-Id: I613b2f1fc809ebef6162071327dda338be271548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788947Reviewed-by:
-
Naoki Fukino authored
In Android, a removable media labelled as "UNTITLED" is mounted at /storage/removable_UNTITLED instead of /storage/UNTITLED. This behavior change was made by ag/6513597, but Chrome side didn't follow the changed paths. *Example* CrOS path: /removable/media/UNTITLED/foo.jpg Wrong path to request media scan (today's behavior): /storage/UNTITLED/foo.jpg Correct path to request media scan: /storage/removable_UNTITLED/foo.jpg This CL alters the path in Chrome side, since Android side can't tell if the requested path is on a removable device or not. Bug: 1000163 Test: Manually tested on Kevin. Change-Id: I318735135900ed47f144bff13a51965b0bcb0ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787620 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#694192}
-
Mikel Astiz authored
The patch adopts the more modern camelcase naming convention and avoids the sentiel PASSPHRASE_TYPE_SIZE value, which otherwise needs to be listed as unreachable code in all switch statements. The patch is mechanical and without behavioral changes. Bug: 1000146 Change-Id: I4c3dd3cef674174f2ac800cde5f119d34e1408f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781683 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#694191}
-
Florian Uunk authored
Bug: 967668 Change-Id: I9d9edb8f5eb4961100eabef7e9a914f2ab40caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787040Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#694190}
-
Marc Treib authored
This adds some first integration tests for the account-scoped storage for passwords: In Sync-transport mode, passwords show up in the account-scoped storage instead of the profile-scoped one, and the account-scoped storage gets cleared on signout. Bug: 998455 Change-Id: I87118560901a659fe7b63498ada117f80bfdf92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782161 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#694189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c53161a5cd46..ac3232fef4c9 Created with: gclient setdep -r src-internal@ac3232fef4c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ife98ef763984d8274af9a654e1c991b429a1fb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789023Reviewed-by:
-
arthursonzogni authored
Every tests: WebContentsSplitCacheBrowserTestEnabled.* have been verified to pass. Bug: 992891, 999849, Change-Id: Ib3bb0cd682464bf004f77a5ea096b9efca3301aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786645Reviewed-by:
Lowell Manners <lowell@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#694187}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of heap/handle.h by 0.15MB. Bug: 242216 Change-Id: Iaf91efa9d16993402cf6ee885f8183ca92069b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787665Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#694186}
-
arthursonzogni authored
In addition to the histogram: Navigation.IsSameProcess Add the histograms: Navigation.IsSameSiteInstance Navigation.IsSameBrowsingInstance During a navigation, getting a new SiteInstance do not necessarily implies switching processes. This new histograms will help to understand the effects of some experiments like ProactivelySwapBrowsingInstance. Bug: 977562 Change-Id: Ib598f67fcfe1dd9aab45fa2e2250d3fa300fce41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776050 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#694185}
-
Sigurd Schneider authored
When using the coverage reload feature, gutter installation could fail due to a race condition between code loading having not finished yet, and the coverage decoration manager trying to install gutters. Bug: chromium:1000155 Change-Id: I45d0c9af3d1639a396865d5486de19d0168d7a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#694184}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /google_apis/gcm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=peter@chromium.org Bug: 891670 Change-Id: Ic359afa58bb711c2b5e681a3417fe020173ec740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787058 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#694183}
-
Stepan Khapugin authored
Creates the controller, state, and delegate for scenes. Updates the plist to use the SceneDelegate. Fixes the bundling issue for the storyboard. Bug: none Change-Id: I92b80d3c95fcedb413bbeb5d5a20378a3b09afd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787779 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
