- 09 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebcfc4bfc670..cdb673f91738 Created with: gclient setdep -r src-internal@cdb673f91738 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044639,chromium:1049638 Tbr: jbudorick@google.com Change-Id: I06b5bba8d21700418ac669adbe8d24ae7d8ad651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095417Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748341}
-
Kevin McNee authored
This test is flaky under MSAN. Tbr: alemate@chromium.org Bug: 1031545 Change-Id: Ie22aff087919b8f7c4f74d06710b500734d6766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095405Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#748340}
-
Mustafa Emre Acer authored
Background (taken from crbug/583195): translation_expectations.pyl contains the list of translatable grd files and the languages they're expected to be translated into. It's used internally during the translation process to determine which grd files should be copied to google3 for translation, etc. Each repository with grd files (desktop, Android, iOS) has a translation_expectations.pyl file, which must list every grd file that contains strings. translation_expectations.pyl isn't used at all when building (neither locally nor on the bots), so there's no indication to developers if translation_expectations.pyl needs to be updated (e.g. because a grd file was added) or is malformed. Instead, an error will occur much later when the weekly translation run happens, causing unnecessary back-and-forth between TPMs and developers and introducing delays. This happens every few weeks. This CL adds a presubmit that checks if the contents of the translation_expectations.pyl matches the list of .grd files in the repository. The presubmit only runs if a .grd or .grdp file is modified, so in most cases it's a no-op. It lists the names of missing and unlisted files in the warning. Bug: 583195 Change-Id: I5013311dac5db1f0578f59022832dc8e33c1ee37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464078Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748339}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f291e9f01a9c..c598caf81aa3 git log f291e9f01a9c..c598caf81aa3 --date=short --first-parent --format='%ad %ae %s' 2020-03-08 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-07 sanikak@chromium.org auto_updater: update _GetPayloadSize method to ssh into devserver 2020-03-07 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-06 saklein@chromium.org image_test: Remove special case check. 2020-03-06 kimjae@chromium.org image_test: Allow /opt/pita/* -> /run/* 2020-03-06 saklein@chromium.org flash_ap: Python 3 compatibility fix. 2020-03-06 ayatane@chromium.org cros_update: Allow Python 2 again for real Created with: gclient setdep -r src/third_party/chromite@c598caf81aa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I5e2bd8c791513707261c564eb8368ec3cb3df5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748338}
-
Ana Salazar authored
Because we are scaling the icon bounds to animate long press gestures, some values might be incorrectly rounded. Change the method that calculates the bounds with scale to use floating values and then Round the resulting rect to adapt to grid layer. Also, include the icon shadows for scaling. Bug: 1050730 Change-Id: Ief19fcf0d2894f570a77047f8209e53eeb461b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086317Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#748337}
-
Sujie Zhu authored
Add base::string16 nickname to credit card class. Also update Compare() function (which is used in sync bridge to calculate the diff between existing cards and new synced cards) to ensure that any updates on nickname will be stored in autofill table. We use base::string16 type because it's a UI string. The follow up will be: 1. update masked_credit_card table schema with nickname column 2. store the nickname from sync response. Bug: 1059087 Change-Id: Ib01e30aa905559aee90608ddda702218d361d58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091716 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#748336}
-
Avery Musbach authored
Bug: None Change-Id: I57b77195bafd94aa6f0c06d7d9fa8a5a8ce1b189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095206Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#748335}
-
Alain Michaud authored
Reason for revert: The flag has never been used and the underlying fix is being replaced by an upstream bluez fix which does not rely on this interface. Bug: 942089 Originally Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652709 Change-Id: I52e6c4f3762f248bdc94383ee5b7f39935db6881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948095Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Alain Michaud <alainm@chromium.org> Cr-Commit-Position: refs/heads/master@{#748334}
-
Nate Fischer authored
This guards stability metrics behind kWebViewWakeMetricsService. While not directly related, AwStabilityMetricsProvider has the same effect as enabling this flag because it logs a "user action" for every page load. This puts the entire metrics provider behind the off-by-default flag, to avoid any accidental UMA volume increase until we've found a path forward for launching that feature. Bug: 1058684 Test: None Change-Id: I0937a1d44aaf4d0c54dee8dfe4644c2216d77891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095196 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#748333}
-
edchin authored
We're bringing Chrome Flag Ownership to iOS go/chrome-flags-ios More about flag ownership here: https://chromium.googlesource.com/chromium/src/+/master/docs/flag_ownership.md This CL adds flags used in iOS with these owners: ewannpv@ gambard@ olivierrobin@ sczs@ thegreenfrog@ Note that the unit test to enforce flag ownership in iOS is not yet enabled. It will be enabled once all iOS flags have been added to flag-metadata.json. Change-Id: Ia37ba495a6e235ed7ac0f2591b261d8c45be377b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092811Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748332}
-
Adrienne Walker authored
Bug: 1015214 Change-Id: Ib10ceee07159d4086526f1dc3c36f45f1b49f488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090175Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#748331}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/532be50b761b..be6cd5188880 git log 532be50b761b..be6cd5188880 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 rharrison@chromium.org Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@be6cd5188880 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I24b3d3bdbd689f0fa4c3799d36510d4815db68d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095323Reviewed-by:
-
Adam Langley authored
Not currently wired up from anywhere, full of TODOs, and not yet plumbed into the GMS FIDO APIs and thus non-functional. BUG=1002262 Change-Id: I65a01b6cf38ce9897dc83310f3af6c6b3c0c6e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079613Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#748329}
-
Scott Violet authored
This reverts commit c00d0991. Reason for revert: This is causing dependency errors on some chromeos bots. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3850 : Step _generate_buildfiles failed. Error logs are shown below: ERROR Unresolved dependencies. //chrome:angle_vulkan_symbols(//build/toolchain/linux:clang_x64) needs //third_party/angle/third_party/vulkan-headers/src:libvulkan(//build/toolchain/linux:clang_x64) Original change's description: > Enable GL_TEXTURE_2D for IO-Surface-backed textures on SwANGLE > > GL_ANGLE_rectangle_texture is unavailable on Swiftshader's Vulkan > frontend, so SwANGLE on Mac uses 2D textures instead. > > Bug: chromium:1015454 > Change-Id: Id99850fbfae798b33eaff4f3a285deb043b4ae7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056931 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#748322} TBR=avi@chromium.org,dcheng@chromium.org,ccameron@chromium.org,geofflang@chromium.org,kbr@chromium.org,jonahr@google.com Change-Id: I46797fd879c66b3af00eeafd5264657223a6c20a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1015454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095406Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#748328}
-
Greg Thompson authored
BUG=1043624 R=zmin@chromium.org Change-Id: I85d61ae1e6d937011661c54ff227ead8962a971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093593Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#748327}
-
Kevin McNee authored
Mark http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope.html flaky Tbr: majidvp@chromium.org Bug: 1059123 Change-Id: I5a00a50b719b5b025c9d66420c82025ebd81d88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094251Reviewed-by:
-
Tom Anderson authored
The flag was set iff is_desktop_linux, so remove it to reduce some complexity. R=sky BUG=None Change-Id: I4948debfa1eafa33532689c7d3f847a1b0cb9a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092875 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Oriol Brufau authored
It seems that r713066 made this test fail in legacy (not in LayoutNG). Now it has been fixed as a side-effect of r745012. Just adding it to WPT to avoid future regressions. BUG=1051086 Change-Id: I83a6db87cd5f5d5a64046681b5e8a5f31cf0998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093227Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#748324}
-
James Cook authored
SyncTypesListDisabled allows admins to disable individual sync "user selectable types" by name. Extend it to work for OS types ("osApps", "osPreferences", and "wifiConfigurations") as well. Add migration support. While we are rolling out SplitSettingsSync the existing browser data types names "apps" and "preferences" will control the migrated types. Add unit tests for SyncTypesListDisabled to SyncPolicyHandler, for both the existing behavior and the new behavior. disable "apps", "bookmarks" and "preferences". Verify that without the SplitSettingsSync flag those data type toggles are disabled in browser sync settings. Verify that with the SplitSettingsSync flag those toggles are disabled in OS settings (for apps and preferences) and in browser settings (for bookmarks). Bug: 1058853 Test: Use test DM server to add SyncTypesListDisabled policy to Test: added to components_unittests Change-Id: Id3427b6611007f1d1a0701f4b2eeceff607c06b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090205 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#748323}
-
Jonah Ryan-Davis authored
GL_ANGLE_rectangle_texture is unavailable on Swiftshader's Vulkan frontend, so SwANGLE on Mac uses 2D textures instead. Bug: chromium:1015454 Change-Id: Id99850fbfae798b33eaff4f3a285deb043b4ae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056931Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#748322}
-
edchin authored
This reverts commit 2752e8be. Reason for revert: This has since been removed from other platforms. The easiest and most transparent way to remove this flag is to revert this CL. Original change's description: > SearchProviderLogos: Add about:flags entry for UseDdljsonApi on iOS > > This is basically the iOS version of > https://chromium-review.googlesource.com/c/600309. > It'll make manual testing of the feature much easier. > > Bug: 690467 > Change-Id: I46656106f42821346bb323c655296e63e4ddd2b1 > Reviewed-on: https://chromium-review.googlesource.com/602129 > Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#492020} TBR=rohitrao@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 690467 Change-Id: I48510ac9539f101bd6927c161473b71185af7af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095399Reviewed-by:
-
Arthur Eubanks authored
Pointers are only guaranteed to be castable to an integer of at least the same size. Bug: 1059231 Change-Id: Idbdad6080968ea1c6496b32ab09d9eb8e8cdd485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091215 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#748320}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c2d9f15..5bcc6fa4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77844ede4f57ab7930d90319e15e226f166f34ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095188Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748319}
-
Victor Costan authored
Change-Id: I366028613a73736af28799440cf87bfac5af3aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093551 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#748318}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f77f10f33266..1cd52d2cfe4c git log f77f10f33266..1cd52d2cfe4c --date=short --first-parent --format='%ad %ae %s' 2020-03-09 cnorthrop@google.com docs: Document how to use ANGLE on Android Created with: gclient setdep -r src/third_party/angle@1cd52d2cfe4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I9c4bdc2e98ef00804aaf5e1e8750925df7ff9c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095327Reviewed-by:
-
Scott Violet authored
This reverts commit 564fad0b. Reason for revert: This has broken a number of builders, such as https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/35679 . I believe you misspelled DISABLED_, you have DISABLE_. I would fix it, but it'll take longer to cycle through the CQ then a straight revert. Original change's description: > Add feature flag for disabling local predictions > > This allows us to run the Client-Side Reactive Preconnect in the below > configs: > 1) Default - Local predictions only > 2) Local predictions with optimization guide filling in > 3) Optimization guide only > 4) No predictions > > Bug: 1050101 > Change-Id: I9eb87170aa0079f3384f1797b03cd3d850b1228e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094246 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748290} TBR=tbansal@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org Change-Id: I434d86687d555ece46617b62d59cbe492904a5b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094542Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffd02955e668..a12175c2a7a9 git log ffd02955e668..a12175c2a7a9 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 ehmaldonado@google.com git-cl: Use _create_description_from_log instead of GetLocalDescription Created with: gclient setdep -r src/third_party/depot_tools@a12175c2a7a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibdd43fb9b46db9b14c10c2cd3fd3dcb2f25d6559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095333Reviewed-by:
-
Scott Violet authored
This way the embedder has a way to persist state with a tab. Without this the embedder has no way to identify what tab the data was associated with. BUG=1056710 TEST=BrowserFragmentLifecycleTests Change-Id: I944e538ba0110f5d3434d5dfd8aa76fe2fdd08e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093691 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#748314}
-
chrome://media-router-internalsmark a. foltz authored
This patch adds the following: - GetState(), a new MediaRouteProvider API to allow the Media Router to query the internal state of MRPs - GetProviderState(), a new MediaRouter API to expose this to chrome/ - Implementation of GetState() in the Cast MRP - A call to GetState(CAST) from the Media Router Internals WebUI, which renders the results as JSON. The initial use case is to allow Cast developers to access the Cast session ID from a running session. However, this can be extended in the future for feedback reports and debugging. This also adds some basic styling to the internals page for readability. (Much more could be done here.) Bug: 1046078 Change-Id: I20d1c2123486c70e0f5ec24243ea1c4ec016dc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084675 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#748313}
-
Alex Gough authored
The backing store for low level rules uses a fixed allocation which must be satisfied for all process launches on Windows. This adds plumbing and a metric to track how much of that allocation is really necessary. The plumbing can be removed once the metric is no longer needed. Bug: 1059129 Change-Id: Id02a1002ef006fc14ff9197aed91465baedd08ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090850Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#748312}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0d9de2003ea9..6190ec8363a0 git log 0d9de2003ea9..6190ec8363a0 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 wolfi@chromium.org Add referrer info to documentation links Created with: gclient setdep -r src/third_party/devtools-frontend/src@6190ec8363a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3da19b662283517a4048bdf681f5a52c93df9c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095328Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1056621 Change-Id: I8b711ae0142d42abd3bf79ac18d900b48bb82bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078651 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#748310}
-
Leonard Grey authored
This team has their own triage process Bug: None Change-Id: Ie8682d88f3513d4a28f9cfd61a750f7fdb400f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094470 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#748309}
-
Toby Huang authored
This browser test is flaky due to invalid OAuth tokens from FakeGaiaMixin. Look into the root cause and re-enable the test when fixed. Bug: 1052604 Change-Id: If63ba31c03a77e1f5f9667e2a653780e1f2858a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095203Reviewed-by:
-
Denis Kuznetsov authored
Bug: 1058022 Change-Id: I289c91d03ae7e1ac6c3e47224e5ea890b64e94a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093483 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#748307}
-
Jarryd authored
Add an guard to QuotaManager::MaybeRunStoragePressureCallback() for the case when |total_space| is 0. Also add a TODO to figure out how we want to handle this case over the long run. Bug: 1059221 Change-Id: I9abba6cf21f810339fc6f115d9d484eaaed88abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093692Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4077.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie339c68cd2f36c168adc85ae0fb81b4105524a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095422Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c27e70235ff5..23899c64e3db git log c27e70235ff5..23899c64e3db --date=short --first-parent --format='%ad %ae %s' 2020-03-09 borenet@google.com [infra] gen_tasks: Fix TODOs in usesGit() 2020-03-09 jlavrova@google.com Enable skia_use_icu for iOS 2020-03-09 egdaniel@google.com Add empty GrD3DResourceProvider class. 2020-03-09 nifong@google.com Add shader makers to SkShader externs 2020-03-09 borenet@google.com [infra] More gen_tasks tweaks 2020-03-09 nifong@google.com JS files to support running jasmine tests in google3 Created with: gclient setdep -r src/third_party/skia@23899c64e3db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I28ac8e2a34ac2c814447f5058983a0b1d980efb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095329Reviewed-by:
-
David Tseng authored
A sample window tree might look like: node id=116 role=window state={} parentID=108 childIds=[] className=HomeScreenContainer node id=117 role=window state={"invisible":true} parentID=108 childIds=[] className=UnparentedControlContainer node id=118 role=window state={} parentID=108 childIds=[128] className=Desk_Container_A node id=128 role=window state={} parentID=118 childIds=[129,102] name=Chrome - New Tab className=BrowserFrame node id=129 role=window state={} parentID=128 childIds=[130] className=NativeViewHostAuraClip node id=130 role=window state={} parentID=129 childIds=[131] name=New Tab className=WebContentsViewAura node id=131 role=window state={} parentID=130 childIds=[] name=New Tab node id=102 role=window state={} parentID=128 childIds=[132] name=New Tab - Google Chrome (Guest) className=Widget node id=132 role=window state={} parentID=102 childIds=[133] name=New Tab - Google Chrome (Guest) className=BrowserRootView node id=133 role=client state={} parentID=132 childIds=[134,86] name=Google Chrome className=NonClientView node id=134 role=titleBar state={} parentID=133 childIds=[135] className=BrowserNonClientFrameViewAsh node id=135 role=unknown state={} parentID=134 childIds=[136,137,138] className=FrameCaptionButtonContainerView node id=136 role=button state={"focusable":true} parentID=135 childIds=[] name=Minimize className=FrameCaptionButton node id=137 role=button state={"focusable":true} parentID=135 childIds=[] name=Maximize className=FrameCaptionButton node id=138 role=button state={"focusable":true} parentID=135 childIds=[] name=Close className=FrameCaptionButton node id=86 role=client state={} parentID=133 childIds=[88,89,139] className=BrowserView node id=88 role=unknown state={} parentID=86 childIds=[140,85,141] className=TopContainerView node id=140 role=unknown state={} parentID=88 childIds=[142] className=TabStripRegionView node id=142 role=tabList state={} parentID=140 childIds=[87,143] className=TabStrip node id=87 role=tab state={"focusable":true,"multiselectable":true} parentID=142 childIds=[144,145] name=New Tab className=Tab node id=144 role=staticText state={} parentID=87 childIds=[] name=New Tab className=Label node id=145 role=button state={"focusable":true} parentID=87 childIds=[] name=Close className=TabCloseButton node id=143 role=button state={"focusable":true} parentID=142 childIds=[146] name=New Tab className=NewTabButton node id=146 role=unknown state={} parentID=143 childIds=[] className=View node id=85 role=pane state={} parentID=88 childIds=[11,12,147,84,13,14] className=ToolbarView node id=11 role=button state={} parentID=85 childIds=[90] name=Back className=ToolbarButton node id=90 role=staticText state={} parentID=11 childIds=[] className=Label node id=12 role=button state={} parentID=85 childIds=[91] name=Forward className=ToolbarButton node id=91 role=staticText state={} parentID=12 childIds=[] className=Label node id=147 role=button state={"focusable":true} parentID=85 childIds=[151] name=Reload className=ReloadButton node id=151 role=staticText state={} parentID=147 childIds=[] className=Label node id=84 role=group state={} parentID=85 childIds=[152,16,83,153] className=LocationBarView node id=152 role=unknown state={} parentID=84 childIds=[] className=FocusRing node id=16 role=image state={} parentID=84 childIds=[15] name=Search icon className=IconLabelBubbleView node id=15 role=alert state={"offscreen":true} parentID=16 childIds=[] className=AXVirtualView node id=83 role=textField state={"editable":true,"focusable":true,"focused":true} parentID=84 childIds=[] name=Address and search bar className=OmniboxViewViews node id=153 role=unknown state={} parentID=84 childIds=[] className=PageActionIconContainerView node id=13 role=button state={} parentID=85 childIds=[156] name=Guest className=AvatarToolbarButton node id=156 role=staticText state={} parentID=13 childIds=[] name=Guest className=Label node id=14 role=popUpButton state={"focusable":true} parentID=85 childIds=[158] name=Chrome className=BrowserAppMenuButton node id=158 role=staticText state={} parentID=14 childIds=[] className=Label node id=141 role=unknown state={} parentID=88 childIds=[] className=Separator node id=89 role=unknown state={} parentID=86 childIds=[159] className=View node id=159 role=webView state={"focusable":true} parentID=89 childIds=[1] childTreeID=DCF0C2E5B3BC5F0DDDF52090169AEB49 className=WebView From the root downward, we have a tree of role=window nodes (most backed by aura::Window, and others backed by view::Widget, or views::RootView). The issue this change addresses is that the views/aura system makes no guarantees about which of these windows gets a WindowObserver::OnWindowTitleChanged call. Namely, we do not receive it on the window backed by views::Widget. As a result, in some instances, some of the windows (as seen in an accessibility extension) will have a stale title (see below bug). This change also ensures that we only fire events on actual window nodes. Bug: 1058613 Change-Id: I46b2205f6ed7df08fb09399cbc2ffff433ce1801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090023 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#748303}
-
edchin authored
iOS flag owners were asked to claim ownership and state an expiry in this announcement email: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This is one of several CLs that adds iOS flag ownership information into flag-metadata.json. The owner of these flags was identified via git blame. A placeholder expiry milestone of M86 was added. Please either LGTM, or suggest a new owner and/or expiry. Bug: 1058614 Change-Id: I973334e2bf430038cef630a5034c3a98c20ed19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093914Reviewed-by:
-
