- 12 Sep, 2019 40 commits
-
-
Scott Haseley authored
This CL performs the following renames: - Task --> DOMTask - TaskQueue --> DOMTaskQueue - Scheduler --> DOMScheduler The generic nature of the previous names led to some confusion between classes in base/ and platform/scheduler. "DOM" is commonly used as a prefix to differentiated web-exposed classes. Bug: 979017 Change-Id: I285e31d2ef72f3b6fc0b17e0b3cfbaf16ef4fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796115 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#696112}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia6b0a3994055266ead3310e67a63f30664492a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696111}
-
Alex Clarke authored
We were incurring the binary size cost of passing a scoped_refptr<TaskRunner> by value which impacts PostTaskAndReply. This patch removes that overhead saving ~4kb. Bug: 906125 Change-Id: Iac456b5328b96e2b61f811f704f96e0beffecd66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790448 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#696110}
-
Stephen Chenney authored
The compositor thread sends input and looks at renderer_deferral_state_, while the main thread sets that state through other methods. Make renderer_deferral_state_ atomic. R: danakj@chromium.org Bug: 1002124, 999189, 998313 Change-Id: I4bef32551892f1a096a9993246f719ac53f13d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796265Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#696109}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chromeos/dbus/power. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=abhishekbh@chromium.org Bug: 891670 Change-Id: I18c556c1f133cd90acd9f09e488e2ac7a5791966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786688 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#696108}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d94d6a3d1103..c9fa9fe9379f git log d94d6a3d1103..c9fa9fe9379f --date=short --no-merges --format='%ad %ae %s' 2019-09-12 digit@google.com [memfd] Create support class for Linux memfd-backed region. Created with: gclient setdep -r src/third_party/swiftshader@c9fa9fe9379f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140419396 Change-Id: Ib38f1b5d2be2cb612e6e90325da1faa57d0f24f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696107}
-
David Black authored
Per guidelines from UX, when the view is un-hovered, the auto-close timer should resume with whatever time is left remaining. Bug: b:140645793 Change-Id: I0370d2ac6f534a9e0b3ac8dd4486d6298fe48ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797344 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#696106}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9baaac63..52bc8577 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4266a4b038cfe2429f950f7e2a1c9d8c27adeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801070Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696105}
-
Kevin Plybon authored
Change-Id: I034db408f5787f8d8a4dc4ad40c53319410b9756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801069 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#696104}
-
Peter Kasting authored
Cleanup only, no functional change. Bug: 1000055 TBR: sadrul,kinuko,thestig, mthiesse, zmo, msarda, csharrison, jochen Change-Id: Idc3d434d6cd5a5d9125c5e00047cbc6219616769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790724 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#696103}
-
Pavel Yatsuk authored
This CL adds boolean column created_from_play_api to keywords table. The column will indicate search engine created from information retrieved from Play API. R=pkasting@chromium.org,wylieb@chromium.org BUG=1002271 Change-Id: Ib3b814a382675cc2c9b6c7d3cb7c6c539df07a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798883Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#696102}
-
Aleks Totic authored
NG was computing inline_size of replaced elements with no intrinsic size (only aspect ratio) incorrectly. Element's margin was not considered. The fixes are: - update code to use margin when computing inline_size - update wpt exaustive replaced size test to include margins - remove many stale expectations for position-absolute-replaced-minmax.html With the updated test, Legacy still fails single test. I might have to update expectations. Bug: 1002748 Change-Id: I98b8595ce0e4dc0d19d1d8020e33fe17e125d41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799422 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#696101}
-
Xianzhu Wang authored
After we removed MULTIPLE_TEXTURE_MASK, SINGLE_TEXTURE_MASK just indicated whether a layer was a mask. As whether a layer is a mask is only determined by Layer::SetMaskLayer(), the status can be indicated with a bool flag. This prepares for simplification of mask layer implementation. Bug: 994361 Change-Id: I40f062fe0c08221316a4ffb5a479777053fe9d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798760 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#696100}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/5a0242ba5c8f..c094391e954a $ git log 5a0242ba5..c094391e9 --date=short --no-merges --format='%ad %ae %s' 2019-09-10 jianj vpx_clear_system_state after drop due to overshoot Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=999780 Change-Id: I03d4a6231088a20c6cfe3d51b2b49aba2fcc7205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799310 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#696099}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/gcm_driver. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=fgorski@chromium.org Bug: 891670 Change-Id: Ic03b7ee5179a0e97bff844b3df0913b574f25efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787138 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696098}
-
Antonio Gomes authored
... when peer_connection_dependency_factory.cc|h gets Onion soup'ed. Namely, the methods are: - GetWebRTCMediaPermission() - GetWebRTCRendererPreferences() In order to test the code being added right away, the CL also routes the callsite through the newly added methods. The CL eliminates the needs for PeerConnectionDependencyFactory::CreatePortAllocator(), to reference RenderFrameImpl and RenderViewImpl directly. In a follow up CL, further methods will be added to replace the remaining references to base::CommandLine & switches. BUG=787452 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ia897d304a21395c89fb032a4bfc80ec1a82ff858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799102 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#696097}
-
Emily Stark authored
This reverts commit 060c246f. Reason for revert: A blocker bug has been fixed, so this revert re-enables HTTP auth committed interstitials on ToT. Original change's description: > Disable HTTP auth committed interstitials by default > > Committed interstitials for HTTP auth renders the 401 body underneath > the auth prompt. This has proven to be problematic in some cases (see > bug). This CL disables committed interstitials for HTTP auth by > default while I work on a fix for avoiding rendering the 401 body. > > Bug: 992639 > Change-Id: I63195a66c4ad81452e24d260afdc7dd938eab769 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756638 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687695} TBR=vasilii@chromium.org,estark@chromium.org Bug: 992639 Change-Id: I8c31e07ab4ea2ab70bd4f7006a0d19970d7f7d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801057Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#696096}
-
danakj authored
The size is not used intentionally because it can be wrong, but is plumbed around by everyone anyways. The only consumer is for browser plugin. Since the size is updated shortly after (that's why it is ok to ignore says the comment in WebContentsViewAura) we don't need all these setters and plumbings just for WebContentsViewGuest. R=avi@chromium.org TBR=halliwell Bug: 998273 Change-Id: I5e783a3469a36f108766cdd256e629039dadc2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790483 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#696095}
-
David Black authored
Per discussion with UX, increasing max width from 240dp to 280dp and making configurable in case feedback indicates we need to adjust this value further. Bug: b:140649426 Change-Id: I82d89ad96df5d0a9e4e1028fc8bd8fb291cd1f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793788 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#696094}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b077afffb867..2b6c52bb82a0 git log b077afffb867..2b6c52bb82a0 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 fmayer@google.com Merge "Create a NormalizeCmdLine function that operates on C strings." Created with: gclient setdep -r src/third_party/perfetto@2b6c52bb82a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iadd21bf0826fddf554da5f53e0882203bfcb331a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801245Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696093}
-
Peter Kasting authored
Bug: 761570 Change-Id: I69a8fe4e3aa7f5f573cd51435c44e0662f1579a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794269Reviewed-by:
Justin Schuh <jschuh@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#696092}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a588508b2b95..60f970aa1987 git log a588508b2b95..60f970aa1987 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 mikenichols@chromium.org cros_oobe_autoconfig: Refactor test to utilize partition loopback mounts 2019-09-12 engeg@google.com Paygen: Fix timeout test flakes with Memory Semaphore 2019-09-11 yshaul@google.com pupr: Fix chroot path redux 2019-09-11 tcwang@google.com afdo: Increase AFDO_ALLOWED_STALE_DAYS when checking AFDO freshness 2019-09-11 yshaul@google.com Fix ebuild path in package service 2019-09-11 achuith@chromium.org commands: Set default jobs for autoninja. 2019-09-11 mikenichols@chromium.org test_image: Quick refactor to utilize partitions for loopback mounts 2019-09-11 geohsu@google.com Update for M78 2019-09-11 dburger@chromium.org Slightly modify comment - fix up lint errors. 2019-09-11 nednguyen@google.com Remove Lamont and Ned from build OWNER 2019-09-11 vapier@chromium.org metrics: add more debug code 2019-09-11 dhaddock@chromium.org Add 'payload_type' field to PayloadTest. 2019-09-11 saklein@chromium.org Build API: Adding mock responses. 2019-09-11 saklein@chromium.org Build API: Add mock-call functionality. 2019-09-11 engeg@google.com Add MemoryConsumptionSemaphore to payload generation 2019-09-11 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-11 lamontjones@chromium.org config: clean up config_skew checks. 2019-09-10 yshaul@google.com afdo: Regenerate manifest during uprev 2019-09-10 wbbradley@chromium.org cros lint: remove chdir once --source-path is available 2019-09-10 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-10 yshaul@google.com Set make_stable=False when updating ebuild 2019-09-10 tcwang@google.com afdo: Add schedule to verify and publish Chrome profiles. 2019-09-10 yshaul@google.com Add afdo/kernel-profiles endpoint 2019-09-10 vapier@chromium.org metrics: add some debug code 2019-09-10 haddowk@chromium.org [moblab] Change memory size of the moblab vm to match hardware. 2019-09-10 vapier@chromium.org key_value_store: split LoadFile into LoadData 2019-09-10 vapier@chromium.org parseelf: switch to io.BytesIO 2019-09-10 vapier@chromium.org alerts: switch to io.StringIO 2019-09-10 dhaddock@chromium.org Update OWNERS of auto_update files. 2019-09-09 jnchase@google.com chromeos_config: add excelsior to builders 2019-09-09 tcwang@google.com afdo: Fix a small bug kernel-verify builder. 2019-09-09 vapier@chromium.org key_value_store: pull LoadKeyValueFile into a module 2019-09-09 mikenichols@chromium.org cros_oobe_autoconfig_unittest: Force a data sync after image creation 2019-09-09 ahassani@chromium.org cros_flash: Merge ChromiumOSUpdater and ChromiumOSFlashUpdater 2019-09-09 vapier@chromium.org vm: fix arguments-differ lint warning 2019-09-08 jclinton@chromium.org Re-add betty to PreCQ 2019-09-07 vapier@chromium.org fix more old style raise syntax usage 2019-09-07 vapier@chromium.org auto_updater: avoid disabling lint warning 2019-09-07 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-06 vapier@chromium.org handle tempfile.TemporaryFile buffering changes in Python 3 2019-09-06 seanabraham@chromium.org cros_branch: use upstream to get branch to bump 2019-09-06 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-06 tcwang@google.com afdo: Implement chrome-release-afdo-verify builder. 2019-09-06 khegde@chromium.org Mistral builds will continue to fail due to a compilation error in the 2019-09-06 chrome-bot@chromium.org Update config settings by config-updater. 2019-09-06 vapier@chromium.org table_unittest: switch to cros_build_lib.OutputCapturer 2019-09-06 akeshet@chromium.org test_stages: drop _PoolHack 2019-09-06 bpastene@chromium.org cros_test: Set CHROMIUM_OUTPUT_DIR when running a host-side cmd. Created with: gclient setdep -r src/third_party/chromite@60f970aa1987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I15eea9babf80b99268a3ddbf6c7e3b9d4edfa0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800731Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696091}
-
Antonio Gomes authored
.... and instead just reference to its Blink base interface, WebRTCPeerConnectionHandler. This is a preliminary step to move peer_connection_dependency_factory.cc|h|unittest to Blink. RTCPeerConnectionHandler is not being moved to Blink yet, so peer_connection_dependency_factory.cc can not reference to it directly while being moved. Hence, we moved the implementation body of PeerConnectionDependencyFactory::CreateRTCPeerConnectionHandler to RendererBlinkPlatformImpl::CreateRTCPeerConnectionHandler and adapt the call sites accordingly. A TODO is added to move this implementation body of RendererBlinkPlatformImpl::CreateRTCPeerConnectionHandler back to PeerConnectionDependencyFactory::CreateRTCPeerConnectionHandler in a future step. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ib02e85c29d9d02dd1143fd3b4c45d34e787f3729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798274 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#696090}
-
Lei Zhang authored
|kSettingPreviewModifiable| set to true means the content being printed is web content. This is typically the case in printing tests, so make the print ticket setting reflect that. This change does not actually change the results in the affected tests. Change-Id: I2061089c5fb34c16c7b0bf5ca4b84c6b12413949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790265 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#696089}
-
Esmael El-Moslimany authored
review and testings before releasing the enhancement Bug: 1001742 Change-Id: I30774fa496ff566cecb8f33db1179ad0ae746bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790410Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#696088}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02a52463b483..11965977822f Created with: gclient setdep -r src-internal@11965977822f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic8093287c5b9ac1a287f54f8d2991a1134abb496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801051Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696087}
-
Willie Koomson authored
This change adds an observer that unthrottles ARC while it is booting, unless a Chrome session restore is simultaneously taking place. during login to see ArcBootPhaseThrottleObserver de/activate in response to container boot and session restore. Test: Build & deploy to betty-arcnext, observe /var/log/chrome/chrome Bug: b:133417350 Bug: b:139510821 Change-Id: Ia3b92068268f1fab47217162e4dabc3d2fadc3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773327 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#696086}
-
Sven Zheng authored
The current implementation will only checkout goldctl when building chrome/win on linux. With this change, 'gclient sync' will checkout both goldctl and goldctl.exe when building chrome/win on linux. Bug: 1001907 Change-Id: I855e10ae8dae500a226da355ed7ac8214e63e343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799690Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#696085}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c979465c52c6..18bc4ae25cdb git log c979465c52c6..18bc4ae25cdb --date=short --no-merges --format='%ad %ae %s' 2019-09-12 khokhlov@google.com [Telemetry] Simplify the interface for adding diagnostics Created with: gclient setdep -r src/third_party/catapult@18bc4ae25cdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349 Change-Id: I6198139c4d9a489fcd9639b24bacac9b43b7e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696084}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I7836e1ba930da2bc3037eb890cdc1763240571c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798524Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696083}
-
Antonio Gomes authored
... from content/public/common. This is another preliminary step to Onion souping peer_connection_dependency_factory.cc|h|unittest. No functionality change expected. The solution is described in section 5 of the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org, jam@chromium.org, thestig@chromium.org Change-Id: I5c5d89a403c20da85e08750712ba1d579c6b1d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798266Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#696082}
-
Reid Kleckner authored
There is no macro that we can use to distinguish between old versions of clang where __builtin_unreachable becomes ud2 on Win64 and new versions where it does not. Relax this test for now to accept the sequence without the ud2s, and plan to remove the relaxation and update TRAP_SEQUENCE2_ in sync with the next clang roll. R=dcheng@chromium.org Bug: 1002498 Change-Id: I50459d5aafa5d4baef9161b7944b3e967c92719f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799662Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#696081}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d8ac383bba8e..ca79dc6779d7 git log d8ac383bba8e..ca79dc6779d7 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 nisse@webrtc.org Delete VideoReceiver2::TriggerDecoderShutdown. Created with: gclient setdep -r src/third_party/webrtc@ca79dc6779d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I06150bcda033b8a3eed186a7f2b75b2da2620fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696080}
-
Vladimir Levin authored
This patch changes the squashing system to disallow squashing, when this would cross the contain: layout boundary. Note that for the purposes of this, if the element itself has contain: layout, and it is composited, then it will not be squashed since it itself is a layout containment boundary. This change allows us to better isolate the element and its subtree by not relying on squashing layer to process the squashed one. R=chrishtr@chromium.org Bug: 1000997 Change-Id: I9c41a799be95045c85e9f87671965ad979e69ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799023 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#696079}
-
Li Qingmei authored
If messageTemplate cantains %xx, such as http://somesite.com/?q=%28test%29, String.Format will throw a ILLegalFormatConversionException. if Log is invoked in some jni thread, so the jni env will be polluted, may be got a native crash. Change-Id: I5dc7eed0898a581d37e67b6ae2992155d749cbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781926 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#696078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2645895e. With Chromium commits locally applied on WPT: 20133397 "[sensor] Upstream sensor layout tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia39a85c10b014d8446efe82f3c8e63d9bf93446a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801067Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696077}
-
Robert Sesek authored
dSYMs are listed as outputs on the toolchain’s link rule, so they do not need to be listed explicitly by targets. Bug: 330301 Change-Id: I7eca7b8a6b1bcddffead9c2f55d6d16b8c975254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801324Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696076}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a424536401d3..032cf12f2b84 git log a424536401d3..032cf12f2b84 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 bsalomon@google.com Make blurrect_compare GM work on GPUs without renderable A8 2019-09-12 bsalomon@google.com Update fully lazy proxy checks to look for negative w/h Created with: gclient setdep -r src/third_party/skia@032cf12f2b84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:1000004 Change-Id: Iddaa3e41f26cb7148e88cebf9ce179bdbe2b5373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696075}
-
Mohamed Abdelhalim authored
Next steps: - Remove usages of NavigationHandleImpl and replace it with NavigationRequest using NavigationRequest::From. - Remove NavigationHandleImpl class and make NavigationRequest inherit from NavigationHandle. Bug: 995268 Change-Id: Ie378765b5a17b682367791c5fbd44bee013ba97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776047Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696074}
-
Mila Green authored
milagreen@chromium.org to the list of owners (chrome/updater). Change-Id: I9a5b8be05ecca9011a2c37e1e8a406d94d7f07b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800520 Auto-Submit: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#696073}
-