- 26 Jan, 2019 20 commits
-
-
Eric Orth authored
Added HostResolverSource::LOCAL_ONLY setting to only allow local (eg cache and HOSTS) resolution through the newer API. This will replace the old ResolveFromCache() method (which was poorly named as it could do other non-cache local sources). Also turned |allow_cached_response| into |cache_usage| that adds a third |STALE_ALLOWED| option. Setting this will replace the old ResolveStaleFromCache() method, except that it doesn't do cache-only unless also paired with LOCAL_ONLY. EntryStaleness works a bit differently in the new API. Before it was returned iff ResolveStaleFromCache() was used (and set to a default non-stale value if the result doesn't come from the cache). Now it gets set on the ResolveHostRequest object iff the result came from cache (even if |STALE_ALLOWED| is not set). More consistent and more reasonable for the newer pattern of results being on-demand through Get*() methods rather that an out parameter. Bug: 922699 Change-Id: Ia5c55beaf3c3c931a9503bb80e0b95f3334c5266 Reviewed-on: https://chromium-review.googlesource.com/c/1423577 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#626287}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/19ec8ef577ff..1b0dd7244802 git log 19ec8ef577ff..1b0dd7244802 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 jflat@chromium.org Add samus-kernelnext to internal release boards Created with: gclient setdep -r src/third_party/chromite@1b0dd7244802 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic412f1df6d57728930e1b7b15884ad3453d80e24 Reviewed-on: https://chromium-review.googlesource.com/c/1436765Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626286}
-
Nico Weber authored
Makes clang package ~7% smaller and lets the tot and upload bots cycle ~7% faster. Since we don't use either of these features, let's disable them. Bug: 925145 Change-Id: I2570531caca6ca38173da35b8d4a76a925b31044 Reviewed-on: https://chromium-review.googlesource.com/c/1437255Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#626285}
-
Brandon Jones authored
Bug: 916299 Change-Id: I533f0f9847892cdf2cdd5c49f9c7ba957c391298 Reviewed-on: https://chromium-review.googlesource.com/c/1437524 Commit-Queue: Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#626284}
-
Xiaohui Chen authored
The settings ui should only show when feature is enabled. Also hide the "delete" button for now per ux request. Bug: b:123254533 Test: locally build and run Change-Id: Ice44a9888b2d02f901206518967aea2d7bdb43a4 Reviewed-on: https://chromium-review.googlesource.com/c/1434755Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#626283}
-
Aaron Colwell authored
Removes some redundant code that appears to have been as accidentally introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1409551 Change-Id: I784b6cb91f788dfc2e2c8bd3b1e888e8b54699b2 Reviewed-on: https://chromium-review.googlesource.com/c/1433144Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#626282}
-
Martin Kreichgauer authored
This turns on both features by default. They are slated to launch fully via Finch in M72. Also removes the obsolete flag for testing the Windows WebAuthn API integration with an incompatible API version. Bug: 897741,898718 Change-Id: I90b6d68331e74befb807aa7bc18e72ed253dc779 Reviewed-on: https://chromium-review.googlesource.com/c/1435760 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#626281}
-
Daniel Rubery authored
Add //chrome/browser/safe_browsing to the allow_circular_includes_from list for //chrome/browser/ui, and //chrome/browser/extensions. A real solution would involve rather substantial refactoring of the Safe Browsing code base. So do this to prevent build instability in the meantime. Bug: 919683, 925153 Change-Id: Iff0c9d0c67098c6255217721b55a390999e65737 Reviewed-on: https://chromium-review.googlesource.com/c/1436035 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#626280}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/578e24839231..a8c86c2b674e git log 578e24839231..a8c86c2b674e --date=short --no-merges --format='%ad %ae %s' 2019-01-25 tsepez@chromium.org Delete "NULL terminator" CFXA_Node property/attribute records. Created with: gclient setdep -r src/third_party/pdfium@a8c86c2b674e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I815a46fd300522dec7aa1f7c40db9f57519ce059 Reviewed-on: https://chromium-review.googlesource.com/c/1437814Reviewed-by:
-
Daniel Cheng authored
They are never displayed, and it ends up requiring a bunch of null checks elsewhere in the layout code. Bug: 578349 Change-Id: I318c86c27200e5ea270c077d9e458dcdaa7e4b3a Reviewed-on: https://chromium-review.googlesource.com/c/1431872 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#626278}
-
Fabrice de Gans-Riberi authored
This reverts commit c6df4d27. Reason for revert: Broke Fuchsia browsertests. Bug: 925574 Original change's description: > [Fuchsia] Implement extra headers support in NavigationController. > > This implements setting and using the |headers| data in > LoadUrlParams. A new test fixture is added to ensure the extra headers > are properly received by the test server. > > Bug: 923598 > Change-Id: I59a44c886f1853bbc631ae016b0655dd1d4d539b > Reviewed-on: https://chromium-review.googlesource.com/c/1427565 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625912} TBR=wez@chromium.org,kmarshall@chromium.org,fdegans@chromium.org Change-Id: I82c9a5dead06edd58553a0999b708c6cc8b8dfd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923598 Reviewed-on: https://chromium-review.googlesource.com/c/1437914Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#626277}
-
Lukasz Anforowicz authored
Bug: 925035 Change-Id: I2966cb89faa5a2c3db593f522b6cc8f50f064ab3 Reviewed-on: https://chromium-review.googlesource.com/c/1434754Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#626276}
-
Andreas Butler authored
This change removes transaction error-tracking for IndexedDBCursor error cases in which the cursor has been closed. Closing a cursor involves nulling out the transaction associated with it, so attempting to track the number of errors on the transaction after cursor close was causing a null dereference. Bug: https://crbug.com/925235 Change-Id: Ia0b854bca327f875d0f31f606cd636799f880137 Reviewed-on: https://chromium-review.googlesource.com/c/1437261 Commit-Queue: Andreas Butler <andreasbutler@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#626275}
-
Dan Beam authored
R=hcarmona@chromium.org BUG=925278 Change-Id: Ia5c5f4770609a3794737732188312b5da4ebc43a Reviewed-on: https://chromium-review.googlesource.com/c/1437272 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#626274}
-
Aaron Leventhal authored
Once an HTML validation alert appears, do not remove the errormessage relation until the form control becomes valid. The disappearance of the validation alert is a timeout for the convenience of sighted users, but does not indicate whether the error message still applies. Bug: 924996 Change-Id: Icb43dba7bb29f64fb7f4814dc86cb56c24ed33c9 Reviewed-on: https://chromium-review.googlesource.com/c/1434796Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#626273}
-
David Black authored
Previously, it was possible to switch active sessions via hotkey and keep Assistant open from the primary profile. In this case, LibAssistant would not be running so interactions with Assistant would fail, but the desired UX is to close Assistant completely in this case. To address this, we associate the Assistant window with the active user. The window manager will appropriately close the window in response to profile changes. Bug: b:121223805 Change-Id: I9253cd58aa90e97645513e1b640ec3c7f8d77ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1385850 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#626272}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager, this CL replaces all uses of ATS with IdentityManager's ones in chrome_password_protection_service_unittest.cc. TEST: All tests of ChromePasswordProtectionServiceTest should work well. Bug: 922768 Change-Id: I551403c7d7c4333b1246fe4b5b933c12783637e7 Reviewed-on: https://chromium-review.googlesource.com/c/1433259Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#626271}
-
Mustafa Emre Acer authored
Testing four site both in the main profile and incognito is slow and causing test timeouts. Separate the tests. Bug: 923917 Change-Id: I2f93b0a200dd0c811fa66681afc4ef6da9f81aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1427619Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#626270}
-
danakj authored
Have RenderWidget clear itself as the MainThreadEventQueue client when it is closing, in OnClose(). The queue already deals with trying to handle an event when the client is gone. However, it does not deal with the fact that when not handling the event it must still run the mojo reply callback or suffer the wrath of a DCHECK. RenderWidget does deal with this fact already. But instead of dealing with this callback behaviour at multiple levels, have the handle methods return a boolean back up to Dispatch(), where if it gets false it can run HandledEvent() with the failure args from a single place. Remove the closing early outs for MainThreadEventQueue methods in RenderWidget. R=bokan@chromium.org Change-Id: I0f836ed4df801ce470afb10894c9c3caa70c5711 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1435520Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#626269}
-
Xing Liu authored
This CL converts download notification to use new builder API which support general notification metric recording, including: Mobile.SystemNotification.Action.Click Mobile.SystemNotification.Content.Click Mobile.SystemNotification.Dismiss TBR=dtrainor@chromium.org Bug: 898269 Change-Id: I0a0634d9fc4bc52da2258e54dca0de7cdd3d4f09 Reviewed-on: https://chromium-review.googlesource.com/c/1433137 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#626268}
-
- 25 Jan, 2019 20 commits
-
-
Paul Miller authored
WebUINavigationThrottle blocks WebUI (chrome://...) pages from loading non-WebUI pages in subframes. When a renderer navigates to a WebUI page, a "WebUI bindings" bit is set in that renderer's ChildProcessSecurityPolicyImpl::SecurityState, and it remains for the lifetime of the renderer process. WebUINavigationThrottles are created for renderers with this bit set. In multi-process mode, navigating away from the WebUI page creates a fresh renderer with a fresh SecurityState, so subsequent non-WebUI pages are again able to load non-WebUI subframes. In single-process mode, the WebUI bit remains. After visiting a WebUI page, iframes on all other pages will be broken until Chrome is restarted. This breaks Android WebView as well, since WebView uses single-process on old Android versions and low-memory devices. It breaks CTS because testOnSafeBrowsingHit loads chrome://safe-browsing/match?type=malware, which sets the bit, and then testShouldOverrideUrlLoadingOnCreateWindow tries to use an iframe. Fix this by not creating a WebUINavigationThrottle in single-process mode. BUG=924799 Change-Id: I5a61f45dc065681f0e6b97e0b205e804edbd7402 Reviewed-on: https://chromium-review.googlesource.com/c/1432953 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
-
Ted Choc authored
TBR=rouslan@chromium.org BUG=924131 Change-Id: I4662993b74824089e8828a42be75cda6f913a3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1437617Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#626266}
-
Matt Falkenhagen authored
See https://github.com/w3c/ServiceWorker/issues/1385 Bug: 924959 Change-Id: I5e2850b743d0702b36f1f20a84c87591c3baab19 Reviewed-on: https://chromium-review.googlesource.com/c/1433657Reviewed-by:
-
Dave Tapuska authored
Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: https://github.com/whatwg/fetch/pull/853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d41c1876d834..f6a2348535c9 git log d41c1876d834..f6a2348535c9 --date=short --no-merges --format='%ad %ae %s' 2019-01-25 reed@google.com remove tricky asint 2019-01-25 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-01-25 halcanary@google.com DEPS: use our mirror for Nima-Cpp 2019-01-25 bsalomon@google.com Avoid checking extension string in GrGLGpu::onResetContext. 2019-01-25 ethannicholas@google.com fixed Metal matrix constructors 2019-01-25 brianosman@google.com Revert "Remove --readPath/-r from DM" Created with: gclient setdep -r src/third_party/skia@f6a2348535c9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I606168691534d565d9a1bd9fbe5969ead8e7713d Reviewed-on: https://chromium-review.googlesource.com/c/1437402Reviewed-by:
-
Malay Keshav authored
This patch adds support to clear stored touch calibration and association data from display prefs. To achieve this, any and all touch data is cleared from the stored pref before adding new pref values. The system already does this indirectly when it instantiates a new dictionary pref value for the touch data to be stored. However if the touch data map that the system is about to store is empty to begin with, this instantiation of a new dictionary never happens and the change to delete any stale stored touch data fails to propogate. Bug: 925551 Change-Id: I7230e05d0106e87b9223b2b75d2883f2269cf8c5 Component: Display prefs, touch calibration Reviewed-on: https://chromium-review.googlesource.com/c/1437519Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#626262}
-
Nate Chapin authored
https://crrev.com/624035 made all javascript url navigations async. Some sites appear to depend on "javascript:''" behaving like "about:blank" and committing synchronously. The spec doesn't say anything about this, but given the real-world breakage, I'm inclined to consider this a very narrow partial revert of https://crrev.com/624035 while we figure out whether this is a spec oversight or a case where we just need to encourage libraries to update. Bug: 923585 Change-Id: Ia030d0a06b5d8f20df319916a1a02297d916e4db Reviewed-on: https://chromium-review.googlesource.com/c/1435821 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#626261}
-
Ken rockot authored
It is uninteresting to fuzz messages received from the trusted broker process to non-broker client processes. On Windows it's also effectively impossible to safeguard against invalid HANDLE transmissions in such cases, and this is the mode the existing channel fuzzers have effectively been emulating. The result is crashy fuzzers. This changes the Channel and NodeChannel fuzzers to more closely emulate the trusted broker environment, where junk HANDLEs from untrusted clients can be effectively detected and discarded without risk of crashing. Bug: 925213 Change-Id: I562df5e3b97b3f109a649b34300cbbe18d2151f0 Reviewed-on: https://chromium-review.googlesource.com/c/1436887Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#626260}
-
David Tseng authored
1. make updates so that the ChromeVox menus are up to date (e.g. remove the prefix key command, remove the ChromeVox activate/deactivate command from the menus). 2. apply the |disallowOOBE| bit to appropriate commands; remove it from the help command. 3. add support for |disallowOOBE| to CommandHandler Bug: 921803 Change-Id: Ia3ff73c90b2c4aa94a455ccd9cc15ec20f4c0a41 Reviewed-on: https://chromium-review.googlesource.com/c/1436016 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
danakj authored
TBR=piman@chromium.org Change-Id: I8b7e62b44c596e95f14a4644c27bc4e99d883a5e Reviewed-on: https://chromium-review.googlesource.com/c/1432293 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#626258}
-
Mario Sanchez Prada authored
Use the IdentityManager and observe events from IdentityManager::Observer to replace all direct usage of AccountTrackerService's APIs, leaving for now just a reference to AccountTrackerService, required to initialize the chromeos::AccountMapperUtil private member from the constructor. Bug: 922785, 922786 Change-Id: Ieec3c3818a6993739fa204b112add0e5cc2f7f7b Reviewed-on: https://chromium-review.googlesource.com/c/1437194 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Dominic Mazzoni authored
This code change results in a nearly 50% speedup of the line_breaks test in blink_perf.accessibility by avoiding the use of Positions. Also fixes CSS first-letter accessibility, the inline text boxes were missing the first letter and in fact the Layout NG code seemed to have extra logic to duplicate the broken behavior. Bug: 921789 Change-Id: I58a21de6286e040ba0c10a9a591932de52908fa5 Reviewed-on: https://chromium-review.googlesource.com/c/1419222Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#626256}
-
Khushal authored
Make sure we use the correct format/usage bits when using AImageReader with videos requiring a secure surface. R=liberato@chromium.org Change-Id: I898535f38e1d2e8d1693c52e1e4c2aa01486cca8 Bug: 889328 Reviewed-on: https://chromium-review.googlesource.com/c/1428407Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#626255}
-
Lutz Justen authored
Flyby fix, test was crashing with dbus[37655]: dbus message iterator has already been closed, or is uninitialized or corrupt BUG=None TEST=chromeos_unittests --gtest_filter=ShillManagerClientTest.GetNetworksForGeolocation Change-Id: Ifc50110746348ecb917f0beb09c1351eb9be36c5 Reviewed-on: https://chromium-review.googlesource.com/c/1436045 Auto-Submit: Lutz Justen <ljusten@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Varun Khaneja authored
Flow: 1. AndroidTelemetryService::OnDownloadCreated called on UI thread. Calls MaybeCaptureSafetyNetId() on the UI thread. 2. If safety_net_id_on_ui_thread_ is already set, END. Otherwise, schedules SafeBrowsingDatabaseManager::GetSafetyNetId on the IO thread and the result of that is scheduled to go to AndroidTelemetryService::SetSafetyNetIdOnUIThread on the UI thread. 3. When SetSafetyNetIdOnUIThread() gets called, it sets safety_net_id_on_ui_thread_ on the UI thread. Also, if chrome://safe-browsing is open, sends CRSBLOGs to DLOG also. Bug: 907280 Change-Id: Id65ed62817f37ed911e5b3b8a623bc1e1c74ea5f Reviewed-on: https://chromium-review.googlesource.com/c/1436186 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfb698e79191..4420ef0c7306 Created with: gclient setdep -r src-internal@4420ef0c7306 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I11751ea6a93a18c2eb352b278fcf8b3fb38c1dc4 Reviewed-on: https://chromium-review.googlesource.com/c/1436763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#626252}
-
Maxim Kolosovskiy authored
This reverts commit d0364f52. Reason for revert: Branch point is over. Button titles should be re-enabled. Original change's description: > [Password Generation] Disable button titles calculation in Beta, Stable > > Button titles are not used in Beta, Stable channels at the moment. They will be crowdsourced later (as a part of crbug.com/896719). > Button titles inference is expensive, especially, for <form>less forms. See the metric PasswordManager.ButtonTitlePerformance.NoFormTag. This will be fixed as a part of new parser refactoring. > This CL temporarly disables button titles before branch point. > > Bug: 910546 > Change-Id: I55ac7d3bcbdc895e165cd3a46288fe089b558967 > Reviewed-on: https://chromium-review.googlesource.com/c/1432854 > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625600} TBR=dvadym@chromium.org,kolos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=dvadym@chromium.org Bug: 910546 Change-Id: I16766fbd93ce627b5385965ce334f78c59a04631 Reviewed-on: https://chromium-review.googlesource.com/c/1437614 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#626251}
-
Parastoo Geranmayeh authored
Validate the profiles as soon as their validity states become out of date and before updating the database. Also, - Refactoring the personal data manager unittests. - Validator should have a copy of the profile, as the pointer may get out-dated. - Handle delayed validations. See go/af-pdm-scheduling for explaining the algorithm. See go/autofill-use-validation. Bug: 899254 Change-Id: If8a173302ec0766a4a549efa84faa4885d546b8c Reviewed-on: https://chromium-review.googlesource.com/c/1395832 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#626250}
-
Ahmed Fakhry authored
When forced mirror mode for tablets is enabled, external displays should not be considered as candidates for mirror mode restore. This CL also fixes an issue with display prefs being saved when they should not be during forced mirror mode for tablets. BUG=919994 TEST=Added new test. Change-Id: I3e2bfc7ec7339baa19e4a0f43a753d30fe1cb7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1436142 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#626249}
-
Antonio Gomes authored
This is the second out of two CLs that convert user_policy_signin_service_unittest.cc away from using SigninManager and PO2TS APIs directly, in favor of the IdentityManager APIs. The first CL migrated it away from SigninManager in [1] [1] https://chromium-review.googlesource.com/c/1301814 At this time, the CL makes use of a newly added IdentityTestEnvironment API named IsAccessTokenRequestPending to keep the testing functionality unchanged. BUG=916262 Change-Id: I9fbea90856313b442c26ec24929f1ad08896eee7 Reviewed-on: https://chromium-review.googlesource.com/c/1418818 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
