- 29 Sep, 2018 29 commits
-
-
Bailey Berro authored
-Switches SmbFileSystem to using the new Start/Continue ReadDirectory flow Bug: chromium:757625 Change-Id: I7e6501b90c4158775440871125dba0d05df7b508 Reviewed-on: https://chromium-review.googlesource.com/1231918 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#595288}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd9671dd3ecf..2a5a40ce0acc Created with: gclient setdep -r src-internal@2a5a40ce0acc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I88e6f1df9a26295bf1347b949ffdc643085a3d55 Reviewed-on: https://chromium-review.googlesource.com/1252918Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595287}
-
Chih-Yu Huang authored
For VP9 video, when the flag "show_existing_frame" is set, the decoder should output the specified reference picture which is decoded previously. Originally V4L2 slice VDA and Vaapi VDA didn't handle this situation that the reference picture is sent to client but not returned back. This CL supports this feature at these two VDA. If the reference picture is sent to client side, then VDA just sends it directly. BUG=755887 TEST=./video_decode_accelerator_unittest --ozone-platform=gbm --test_video_data=vp90_2_10_show_existing_frame2.vp9.ivf:352:288:16:16:35:150:12 on Kevin and Eve device. TEST=Run AppRTC on Scarlet successfully TEST=Pass media:media_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9876fa5aabaf15e9dff813ff5efd564d8991eee1 Reviewed-on: https://chromium-review.googlesource.com/1119726 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Pawel Osciak <posciak@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#595286}
-
John Budorick authored
Bug: 887429 Change-Id: I5605019fb5373c6df8127b8dd689ab64f57fd25c Reviewed-on: https://chromium-review.googlesource.com/1253062Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595285}
-
Jordy Greenblatt authored
Bug: 890425 Change-Id: I8b8f3bc7751c94e01e44f781a732012f954fb7e2 Reviewed-on: https://chromium-review.googlesource.com/1252527Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#595284}
-
Karan Bhatia authored
This CL adds more developer documentation for the declarativeNetRequest API. BUG=878052 Change-Id: Iefef25a5ac89fa1a76924fbdeaff88c04368cb35 Reviewed-on: https://chromium-review.googlesource.com/1249575 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595283}
-
Josh Nohle authored
Bug: 882647 Change-Id: I358d737e7b2e073d42d1e7da7825a5d0e378a9aa Reviewed-on: https://chromium-review.googlesource.com/1252841Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#595282}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 479cc175. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25473 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I50a1fb0a97c4a3b91e6e5d3ac896d9c23942fdb9 Reviewed-on: https://chromium-review.googlesource.com/1252858 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595281}
-
Weilun Shi authored
After trigger the existing one's timeout, the existing one's will add the "hide" class to the bar that makes both of them disappear because they share the same notification bar. Instead of triggering the old one, we clear the timeout and replace it with the new one. Screencast: https://screencast.googleplex.com/cast/NjQzMTIwODQ1NjA2MDkyOHw4ODNkMjg4OS01OA Bug: 889257 Change-Id: Ifb6b5a0acb2f68470cc80ef1bea0c6e176f34bcb Reviewed-on: https://chromium-review.googlesource.com/1252462 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595280}
-
Devlin Cronin authored
Bug: 890470 Change-Id: Ia61501586134d16cc1cd1456cdea1c82a26b4e1d Reviewed-on: https://chromium-review.googlesource.com/1252638 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595279}
-
Kyle Horimoto authored
Before this change, buttons resided directly within the top-level <multidevice-setup> element. However, once we integrate this flow with OOBE, special OOBE-specific buttons must be used, so it is not possible to embed these buttons directly. This CL adds <slot>s for both the forward and backward buttons, which allow each implementation to pass in its own button type. For the current flow, normal <paper-button>s are passed. A future CL will pass OOBE-specific buttons when appropriate. Bug: 884058 Change-Id: I062bfaa95454e51c0aa6ce19c16ef1a0bca8ab07 Reviewed-on: https://chromium-review.googlesource.com/1237533 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Shakti Sahu authored
Bug: 889357 Change-Id: Idda6b6556f06b6ce1e6e638adb4495036b11d6cb Reviewed-on: https://chromium-review.googlesource.com/1252982Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595277}
-
dpapad authored
The previous version suffered from a bug that caused some properties defined in CSS mixins to have improper fallback values. Bug: 888965 Change-Id: I56c39162bdd2d99ac9a3c370c0fbf22ad359c0b1 Reviewed-on: https://chromium-review.googlesource.com/1252379Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595276}
-
Tom Anderson authored
BUG=737995,881371 Change-Id: I9a64690248693f9963211587b4bbcc40e1480f97 Reviewed-on: https://chromium-review.googlesource.com/1249826 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#595275}
-
Tianran Liu authored
Bug: 112321746 Change-Id: I4e0367e80f3738a2963ca9521ef28fdf9f1ba77e Reviewed-on: https://chromium-review.googlesource.com/1252536 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595274}
-
Fredrik Söderquist authored
The current pattern wouldn't be able to sniff the 'lossless' and 'extended' WebP formats. Adjust the pattern to match the one described by [1]. [1] https://mimesniff.spec.whatwg.org/#matching-an-image-type-pattern Bug: 889420 Change-Id: I4b5a73d4d9477502d58df7460b9494e6540a59f3 Reviewed-on: https://chromium-review.googlesource.com/1248782Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#595273}
-
Wenzhao Zang authored
The brand code map uses similar pattern with the policy map: https://cs.chromium.org/chromium/src/chrome/browser/policy/configuration_policy_handler_list_factory.cc?type=cs&q=configuration_policy_handler_list_factory.cc&g=0&l=129 It's trivial work to add more entries in the future. Bug: 846033 Change-Id: Ib343476a2338eb17cdcf0fc24bc7c139dec40d02 Reviewed-on: https://chromium-review.googlesource.com/1237541 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#595272}
-
Miguel Casas-Sanchez authored
crrev.com/c/1245467 got reverted due to a silly oversight -- I have to delete the pointer in the Deleter operator(). Solution is crrev.com/c/1249481/1..5 Original CL description ------------------------------------- JPEGCodec{RobustSlow}::Decode: refactor to use unique_ptr. This CL removes the class DecompressDestroyer in favour of a unique_ptr<> with specific Deleter. Less lines of code. Functionality covered by gfx_unittest, also under asan bot. Bug: 868400 Change-Id: I53ff80d4304b02c08719a1b0c5b1175e3a0d061d Reviewed-on: https://chromium-review.googlesource.com/1249481 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595271}
-
Esmael El-Moslimany authored
Also fixing an issue with the position of a knob when tracking. Bug: 881290 Change-Id: Ib3520d4c89d7a9f5ac4575b47976e4ceb14131f3 Reviewed-on: https://chromium-review.googlesource.com/1228980 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Renjie authored
This CL is a fix/improvement on crrev.com/c/1186112. Previously in the situation where host resolution returned first but connection from stale host hasn't called back yet, nothing was done. And this could cause a crash because when QuicChromiumClientSession::OnCryptoHandshakeEvent() was finally called, OnConnectComplete callback would run. In the case where the stale host doesn't match with the fresh host, the session would be closed and deleted. So anything after the callback would fail. To solve this, hosts should be validated immedaitely when host resolution returns. This change also improves performance because now if the two hosts are different, the Job won't waste time waiting for the invalid stale connection to finish. To further avoid accessing a deleted session, when a connection is deemed invalid, CloseSessionOnErrorLater() is used instead of CloseSessionOnError(). Bug: 787942 Change-Id: I4bdb0e5b810445134e4ef305ba401d330adb2f79 Reviewed-on: https://chromium-review.googlesource.com/1250140 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#595269}
-
Annie Sullivan authored
This will be used to guide the investigation into why not all user-initiated navigations are tied to input events (see linked bug). The metric will be re-evaluated at its expiration date at end of year to see if it could be useful for anything else, and removed if not. Bug: 889220 Change-Id: I992e6ada4f892603b672daa812e80b69bc901678 Reviewed-on: https://chromium-review.googlesource.com/1246903Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595268}
-
Shakti Sahu authored
UX: https://docs.google.com/presentation/d/14pBMf4Qrhd_a4qF6KdXJJfAZYLdmv_JN0gL8GC4SWAU/edit#slide=id.g3e1f1f7199_0_0 Bug: 850596 Change-Id: I29b20d0eb051fc1e03259833801e5f6601ba8f0e Reviewed-on: https://chromium-review.googlesource.com/1237538 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
bsheedy authored
Re-enables WebVrBrowserTestOpenVrDisabled.TestWebVrNoDevicesWithoutOpenVr and increases the timeout that was flakily being hit when many tests were run in parallel. Bug: 890380 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iebb10f25848ac0ab3a2913fff4e35dad919fd4bc Reviewed-on: https://chromium-review.googlesource.com/1252642Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595266}
-
Bailey Berro authored
- Implements Start/ContinueReadDirectory methods to SmbFileSystem Bug: chromium:757625 Change-Id: Ib692fb34b488c951c518d265af19cb147ee40c9e Reviewed-on: https://chromium-review.googlesource.com/1231816 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Jian Li authored
Bug: 885144,890091 Change-Id: Idbf08df67e8783ef305e273680cc12287ac1d53d Reviewed-on: https://chromium-review.googlesource.com/1250169Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#595264}
-
Siddhartha authored
This reverts commit 6275b810. Reason for revert: Fixes the crash due to accessing TLS after thread is destroyed. Original change's description: > Revert "memlog: Add task contexts from allocation context to native mode" > > This reverts commit 3e6c0cd8. > > Reason for revert: Causes crashes on Mac while accessing TLS. > > Original change's description: > > memlog: Add task contexts from allocation context to native mode > > > > The task context is useful to debug mojo memory leaks since IPC messages > > are tagged with contexts > > > > BUG=874530 > > > > Change-Id: Id59d016f963f41fdeda6af69b3c470f0101dbfe7 > > Reviewed-on: https://chromium-review.googlesource.com/1232683 > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593458} > > TBR=erikchen@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 874530, 888899 > Change-Id: I70e2dc4a91f8512dc98a68d5dd0736f5e511da54 > Reviewed-on: https://chromium-review.googlesource.com/1244829 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594158} Bug: 874530, 888899 Change-Id: I3710b3d50f50a2bfa69b964e336b4f6e691f641b Reviewed-on: https://chromium-review.googlesource.com/1252521 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595263}
-
Peter Kvitek authored
DevTools performance metrics now allows collection and reporting of duration related metrics using monotonically increasing abstract time and thread running time. Change-Id: Ica54cc291ba456c8dcc6a47a962e99a87cb8a475 Reviewed-on: https://chromium-review.googlesource.com/1247528Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595262}
-
Jordy Greenblatt authored
Bug: 890425 Change-Id: Id1150f263c6cd1fded5422b395ac94f0166687e2 Reviewed-on: https://chromium-review.googlesource.com/1252915Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72f78323a89f..cd9671dd3ecf Created with: gclient setdep -r src-internal@cd9671dd3ecf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4b618f506a3f4590c2b5e68ed5ec36864dc00f7d Reviewed-on: https://chromium-review.googlesource.com/1252375Reviewed-by:
-
- 28 Sep, 2018 11 commits
-
-
Lukasz Anforowicz authored
Returning true for WebUI pages in DoesSiteRequireDedicatedProcess helps to keep enforcing a SiteInstance swap during chrome://foo -> chrome://bar navigation, even after relaxing BrowsingInstance::GetSiteInstanceForURL to consider RPH::IsSuitableHost (see https://crrev.com/c/783470 for that fixes process sharing in isolated(b(c),d(c)) scenario). I've manually tested this CL by visiting the following URLs: - chrome://welcome/ - chrome://settings - chrome://extensions - chrome://history - chrome://help and chrome://chrome (both redirect to chrome://settings/help) Bug: 510588, 847127 Change-Id: I55073bce00f32cb8bc5c1c91034438ff9a3f8971 Reviewed-on: https://chromium-review.googlesource.com/1237392 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595259}
-
Kyle Horimoto authored
Before this CL, the <multidevice-setup> element was told what "UI mode" (i.e., OOBE vs. post-OOBE) and behaved differently depending on what mode was active. This abstraction was leaky, since it caused the element to change its logic based on what its client at a higher level was. This CL adds a MultiDeviceSetupDelegate interface and injects this interface into the <multidevice-setup> element, which uses it to perform tasks such as setting the host device. One concrete implementation of this interface is provided for the post-OOBE case; a future CL will add an implementation for OOBE. This CL also removes multidevice_setup_dialog.js in favor of adding a new <multidevice-setup-post-oobe> element. Bug: 884058 Change-Id: I76b6553928e706da4870339d306bc32bea7ac3e6 Reviewed-on: https://chromium-review.googlesource.com/1247525Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595258}
-
Zhenyao Mo authored
BUG=838970 TEST=GPU FYI waterfall R=kbr@chromium.org Change-Id: Idf1b701539c427a63ed5648396a3c6588d305733 Reviewed-on: https://chromium-review.googlesource.com/1252630Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595257}
-
Peter Kasting authored
This is dead in Refresh. The only exception is in CrOS, where we can still have such an icon for teleported windows. Bug: none Change-Id: Ibfadbc3a463d689db5203ff5a74157e8b75c2aef Reviewed-on: https://chromium-review.googlesource.com/1244882 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#595256}
-
Ben Pastene authored
TBR=jbudorick Bug: 876587 Change-Id: Ic121bccd2343fe48eefbbaf2ccf60d2d01969ca2 Reviewed-on: https://chromium-review.googlesource.com/1252911Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595255}
-
Dominic Mazzoni authored
Currently it's just a mojo struct containing a string, but it should be relatively easy to turn it into a different type now. Follow-up to http://crrev.com/c/1212484 - eventually we may want this to be a base::UnguessableToken. This change should completely eliminate any assumption that ui::AXTreeID is a particular type, only that it's possible to serialize and unserialize it as a string (which is necessary because we need this to be passed through JavaScript APIs). Bug: 881986 Change-Id: Ifb53e4ca2ea56c53488c89d6df188a1f131197ae Reviewed-on: https://chromium-review.googlesource.com/1246297 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#595254}
-
Nico Weber authored
While here, also remove unused GetAllowOtherViews() / SetAllowOtherViews() from WebContents and WebContentsView. Bug: 832676 Change-Id: I18e6385b08599e12e0a8f2d85c06d429e92396c7 Reviewed-on: https://chromium-review.googlesource.com/1251323Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595253}
-
Scott Violet authored
This is necessary when running ash_unittests in chromeos vm as we hit some DCHECKs otherwise (the real StatisticsProvider DCHECKs that it was initialized). BUG=866114 TEST=test only change Change-Id: I0ad82f28f266460a6c9dccc23e86566750aed8f4 Reviewed-on: https://chromium-review.googlesource.com/1252853Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595252}
-
Devlin Cronin authored
Add metrics to record the number of extensions that have withheld host permissions, and, if host permissions are withheld, the number of explicitly granted hosts. Only record these metrics if the RuntimeHostPermissions feature is enabled. Add unittests for the same. Bug: 889659 Change-Id: Ia2ae175ad7116d1aa6665514055a42efeb39f0da Reviewed-on: https://chromium-review.googlesource.com/1249529 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Jeremy Klein authored
This is a reland of 3e67df64 Fixed the ASAN test by actually just removing some unnecessary code. Original change's description: > Install Messages PWA when host is set or verified. > > This change moves the logic for installing the Android Messages PWA into > a helper class which is a HostStatusProvider::Observer. This allows it > to install the PWA when a host is set and also when signing into a new > Chromebook if the account already has a valid host. > > Bug: 887775 > Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b > Reviewed-on: https://chromium-review.googlesource.com/1248130 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594943} Bug: 887775 Change-Id: I1941c20d7c31f8424f3d080db8e3580be01cd41f Reviewed-on: https://chromium-review.googlesource.com/1252626Reviewed-by:
-
Matt Falkenhagen authored
Reland of r592363, which was reverted due to timeouts. The timeout issue should be fixed by r594723, which changed the mechanism of sending the "last url" message from the navigated frame. Other revisions from the original patch: - Removed the unused expected_tags parameter from the default variant test function. - Removed the dummy message resolver for "last url" from client_variant_test, which is no longer needed after the change mentioned above. - Fixed a bug in redirect-worker.js's getClients(), where we returned instead of continued to the next iteration. Original commit description: > This adds a ?client variant to navigation-redirect.https.html, which > does a lot of redirect tests. This tests the following: > - resultingClientId is the id of the client, if one was created via > that request. > - get(resultingClientId) for requests that did not create a client > resolves with undefined. > - resultingClientId is reset on cross-origin redirects. > - Client.url is the creation URL. > > Bug: 778497 > Change-Id: I08387e96a97df4656d800637862b67b7c8466e14 > Reviewed-on: https://chromium-review.googlesource.com/1206054 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592363} Bug: 778497 Change-Id: I770f98cef7618c89c1b54245bc89a9c53a19bd5c Reviewed-on: https://chromium-review.googlesource.com/1250306Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595249}
-
