- 05 Oct, 2020 40 commits
-
-
Nohemi Fernandez authored
Currently it is difficult to understand that the GAIA refresh logic only triggers for the google.com domain. This patch adds a comment to this effect and ensures that only Google domain URLs are processed when executing a navigation. Bug: 1131027 Change-Id: Iebdbd804ef378ce48dda95be98de3ed76c9642d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435184Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#813656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f8d793e3bb0..af6c5c622733 2020-10-05 treehugger-gerrit@google.com Merge "[trace processor] Add RAIL Mode power metrics" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia290a191936b6a069bc3ca058e0abaea5bc61cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813655}
-
Kent Tamura authored
This CL makes ScrollbarThickness() and HasValidAvgCharWidth() of LayoutTextControl static and public in order to share them with LayoutNG. - ScrollbarThickness(): It takes a LayoutBox argument - HasValidAvgCharWidth(): Pass only Font to it because both of SimpleFontData and the family name can be obtained through the Font. This CL has no behavior changes. Bug: 1040826 Change-Id: Ie7000ef7cca04284b2b1a6ff934809560d37a2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449094 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#813654}
-
Roberto Moura authored
Set the zPosition of each cell to its index so that they don't overlap during a transition from thumb strip to tab grid. Bug: 1127604 Change-Id: I9763cc2c716e1db17c51affe6c335d422280501d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445782 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#813653}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Icb49329e594d7ea9cf3dd3f467cb1fb58d7911c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445480Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813652}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601853620-58f3e166d029ce41b2a670400388c632a12e05f3.profdata to chrome-linux-master-1601877511-28b93e09fa0b9618306e073ac2e467bbc2486723.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Iec101d136e024eeaed890695b3f8035c11fb32f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449114 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kuo Jen Wei authored
This CL fix the UI looks of CCA under RTL language in following aspect: 1. Use flex-start on setting menu. 2. Mirror the directional icon. 3. Substitute padding/margin-left/right with start/end. 4. Have extra rtl rule flipping css left/right attribute. Bug: 1133093 Test: Manually on LTR/RTL languages. Change-Id: I684ac98903be3338e15aea28005e92aa57d4b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437318Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#813650}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia1ac6d3542d75306aa3f8fae5d2177c1e9ef4b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448681Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813649}
-
arthursonzogni authored
The DomSerializerTest are executing browser-side and renderer-side code in the same process. This was written 10 years ago. The renderer is no more expected to load new documents without requesting navigations from the browser process. This patch updates the DomSerializerTest. Now the browser process is free to kill more renderer when they try to commit unexpected navigation. This patch looks big, but it isn't. This patch consists of: 1. Update LoadContent to use regular navigations. It is now called from the browser process instead of the renderer. 2. For every test: Replace the callback (executed by the renderer process) by a lambda expression. Split the lambda around every call to LoadContent. It is now executed from the browser process. 3. Update GetRenderView(). The navigation can now happens in a different RenderView[Host], this wasn't the case previously. The value returned can now change. Bug: 1133115 Change-Id: I683149fbe353cf19fe1db96cda803eab079d8f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435350Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813648}
-
Tymofii Chudakov authored
Add feature flag for Privacy Advisor. Bug: 1083878 Change-Id: I577cc36c7255a7d304c610ce6943931c7a2daf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416452 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#813647}
-
sauski authored
To reduce the number of records pending update in the access context audit database, an in memory set of previously seen cookie accesses is added. This set is consulted before attempting database insertion and is cleared on navigation. Bug: 1132947 Change-Id: I87f1b2e1283c8c9a1ee76dc3649ce2f2f598f82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438391 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813646}
-
Henrique Ferreiro authored
When porting StartDragging to Mojo in https://crrev.com/c/2320268, the image contents weren't being set in the drop data. This resulted in a link being saved on Windows and an error shown on Linux. Bug: 1039255, 1132953 Change-Id: I2d21e0424c89306d5df8caf940e93999d16f78f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444996Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#813645}
-
Colin Blundell authored
This CL moves the C++ AdsBlockedInfoBar class away from being a ChromeConfirmBar to directly subclassing the //components-level ConfirmInfoBar. This change is necessary to support componentization of the infobar and reuse in WebLayer. There is no behavioral change intended. Bug: 1116095 Change-Id: I289bd30d1a956e2db41744a007247c2893410213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442829 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#813644}
-
Alessio Bazzica authored
No-Try: True Bug: webrtc:7494 Change-Id: I590ec5371db86b66e7523209d3131b065a2463ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449369Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#813643}
-
Kent Tamura authored
InnerEditor's paddings are always zero. Web authors can't customize InnerEditor's style. This CL has no behavior changes. Change-Id: Ida6e95a07c3c7c2f2d6700a54c5c40cf06835e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449095 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Maksim Sadym authored
rebase CL 2044170 part 2. part 1 was merged in CL 2431864. DevTools uses `ExecuteJavaScriptMethod` instead of `ExecuteJavaScript`, which should reduce serialisation/deserialisation overhead. Loading Chrome DevTools on the page https://www.facebook.com/Shakira: Before: V8.CompileCode, 130.326 ms, 2227 times V8.ParseProgram, 49.329 ms, 1878 times After: V8.CompileCode, 18.571 ms, 343 times V8.ParseProgram, 0.053ms, 2 times Loading Chrome DevTools on Chrome DevTools on the page https://www.facebook.com/Shakira: DevTools on DevTools Before: V8.CompileCode, 180.928 ms, 3708 V8.ParseProgram, 59.535 ms, 3700 After: V8.CompileCode, 4.956 ms, 92 V8.ParseFunction, 1.945 ms, 92 Bug: chromium:1029427 Change-Id: I78011c8f80a99c85d65354fb4a8a776491ac4f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442012 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813641}
-
Maksim Sisov authored
All the tests from the filter pass now. Enable them back. Bug: 1040382 Change-Id: I3e7b2d926fabc3f8e0028a2668fc2c5667c5ea5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444315Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#813640}
-
Yunke Zhou authored
Bug: 1134074 Change-Id: I14494519a53375d61d6c106c5529727af00d67f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440512 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813639}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99fa0ad98a95..7028f1d3895f 2020-10-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib5931b119d8a2bd60a1f9feb0e62197366e280ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449111Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d6364fc..2fc8a89c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iecd9bc1acb720331c833f2902d0859613c16b6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448975Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813637}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e34a8d7f01ff..43865d38f022 2020-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1693b283 to 2cd17d78 (541 revisions) 2020-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 375fee944c76 to b3c1e71eb1cb (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I9e685e4611a43244fa6263f270f900bc9c9b4bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449109Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601853620-cfab2714faed86a38ca94c2606f6bcdf84d8c1a0.profdata to chrome-win32-master-1601866325-a85f6ecffc151934e2e0b93e1917188663da3160.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I302390d71930ccec5c3675175996eea1fcff5acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448940Reviewed-by:
-
Maksim Sisov authored
This is required to allow Ozone/X11 later reuse that. No functional changes are made. Bug: 1134495 Change-Id: I7cf66fd0fd01d3237e3d3c763cc01bd1c00c26a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445109 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#813634}
-
Dominic Mazzoni authored
The specific event was fired from Blink but never used anywhere else in the code, because the event can be implicitly generated. Replace it with a call to MarkDirty and update web tests. Bug: 699438 AX-Relnotes: N/A Change-Id: Ic1d3649da6ee4bcf8e8a0935276e7a95f5ea9671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440588Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813633}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b97ea4e4140..771de5b81a2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tasak@google.com Change-Id: I248e27b16c8bc246ca3aec5a7b02086568bfc6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448945Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813632}
-
Christopher Cameron authored
In crbug.com/353047, we encountered the problem where Chrome would upgrade itself from 32-bit to 64-bit, but app shims would be stuck on 32-bit. A mechanism was added to upgrade the shims "when needed", based on a kAppShortcutsVersion local preference. This number has been incremented several times for various incompatibilities. Add a separate kAppShortcutsArch preference which saves the architecture that apps have been being created in. Whenever this does not match base::SysInfo::OperatingSystemArchitecture, re-create all shims. This will fix the situation whereby a user data dir, including all of its local prefs, is copied from an Intel mac to an ARM mac. A few caveats: - This will only re-create PWA shims. Legacy apps will need to be re-launched from Chrome. - This only fixes the issue if the user launches Chrome before launching a PWA. The PWA shim copied from x86, if it succeeds in running, will start Chrome with the start URL for the PWA. Bug: 1117599 Change-Id: I4d9e1a87e91c1d461b592b0a8250b22120368d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444130 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#813631}
-
Koji Ishii authored
This patch adds an early return logic to |NGBoxFragmentPainter::NodeAtPoint|, copied from |LayoutNGBlockFlowMixin::NodeAtPoint|. This early return in |LayoutNGBlockFlowMixin| was added in r508056 crrev.com/c/710498 in 2017. Not sure where it came from, legacy as of ToT does not seem to have such code, but it seems effective to reduce computations for a large tree, and better done in |NGBoxFragmentPainter| than in |LayoutNGBlockFlowMixin| when we move forward to fragment traversals more. |NGPhysicalFragment| had empty implementations for |InkOverflow| and |ContentsInkOverflow|. Moved the implementations from |NGBoxFragmentPainter| for non-inline CSS boxes (excludes inline boxes and column boxes.) Bug: 1134574 Change-Id: Idb2baddc75da2599478bba4cea91ab541903b155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448269Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#813630}
-
Bartek Nowierski authored
And fix a comment while at it. Change-Id: I111d12a05bd3413e857c2d54b089763f03f9ff95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448073 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#813629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b54ce23a7cb1..e34a8d7f01ff 2020-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1fd3e5d89a8f to 500704812409 (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Test: Test: Test: angle_deqp_egl_tests Change-Id: I11453ed01ce519debcf752ca26a48e57b459020d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448941Reviewed-by:
-
Ramin Halavati authored
This CL adds a new Guest profile type without the enforced OTR layer over it. In subsequent CLs, all calls to |IsGuestSession| function should be audited and based on whether they are needed for new profiles or not, would be covered by |IsEphemeralGuestProfile| as well. Please refer to go/guest-on-disk for more context. Bug: 1125474 Change-Id: I2516e3d0822c6753ddb2421e2756ac51c38e49df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434925Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#813627}
-
Alexandre Courbot authored
The queue statements on input buffers were not checked, which could lead to errors going unnoticed and only being noticed later. Similarly an error when queueing an output buffer should result in an error message. BUG=None TEST=video.DecodeAccel.h264 passes on Trogdor. Change-Id: Ib96af994c34dadf63c827f0284a8c8a581c016b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440327 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813626}
-
Wei Lee authored
Change from 12s to 6s. Bug: 1133935 Test: Manually Change-Id: Ie453082c0943c29f66b60f8faf2fd32b7776f304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448716 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 920451c0. Reason for revert: suspect causing browertests failure on linux-chromeos-dbg browser_tests failed because of: - NearbyOnboardingPageTest.All First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20674 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867535501208450768/+/steps/browser_tests/0/logs/Deterministic_failure:_NearbyOnboardingPageTest.All__status_FAILURE_/0 --- ReferenceError: loadTimeData is not defined at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/nearby_share/shared/nearby_onboarding_page_test.js:50:5) --- Original change's description: > [Nearby] Validate device name in onboarding. > > This adds support for validating the device name that a user enters > during the Nearby Share onboarding flow. Validation happens as the user > types and also when they try to proceed to the next screen. If an > invalid name is detected, an error message will appear and the "Next" > button will be disabled. > > Screenshots: > https://screenshot.googleplex.com/3USR7ftg7QCwJhR.png > https://screenshot.googleplex.com/6Cr6pedUxWnUKju.png > > Bug: b:169582004 > Change-Id: I07d4822e0ea099b30d23ed34a5f70f01940a3009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441150 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Michael Hansen <hansenmichael@google.com> > Cr-Commit-Position: refs/heads/master@{#813193} TBR=khorimoto@chromium.org,vecore@google.com,hansenmichael@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:169582004 Change-Id: I6a9dd1f9f40c6f54e6a467de3053b75f8f264645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448510Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#813624}
-
Wei Lee authored
The new strings are proposed by the UI reviewers. Bug: 1127587 Test: Manually Change-Id: I8359f6f05595b6ca801a2f2052a387847e9446fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449029 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
Renjie Tang authored
Bug: 1123769 Change-Id: I6fb06abfee7868ae4b951f70d80305eaf6755b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446198Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813622}
-
Bartek Nowierski authored
TestVector is used inside WTF::Vector, hence isn't stack allocated. Co-incidentally, we've discovered it during go/miracleptr project when converted raw pointers to CheckedPtr wrapper, which have non-trivial default constructor & destructor (when using the BackupRefPtr variant), thus requiring placement |new|. Bug: 1080832 Change-Id: Ia5e8b410e4cf8609783c8a3ee78d6c3d115513b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448712 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9263936c95ad..99fa0ad98a95 2020-10-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I072d3b1f563851c29be0fec8152057de1c40c110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448936Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit 635cbc1a. Reason for revert: suspect causing views_unittests failure on Linux ChromiumOS MSan Tests --- BoxLayoutViewTest.NoLayoutInvalidationWhenPropertyUnchanged BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged --- First test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20798 Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867505219215733920/+/steps/views_unittests/0/logs/Deterministic_failure:_BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged__status_CRASH_/0 --- [ RUN ] BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged ==11171==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5570eca375a3 in testing::AssertionResult testing::internal::CmpHelperNE<int, int>(char const*, char const*, int const&, int const&) ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:1638 #1 0x5570eca375a3 in ?? ??:0 #2 0x5570ed05abfe in views::BoxLayoutViewTest_LayoutInvalidationWhenPropertyChanged_Test::TestBody() ./../../ui/views/layout/box_layout_view_unittest.cc:78 --- Original change's description: > Views: Add BoxLayoutView > > This CL adds class member getters and setters to the BoxLayout class > where needed for the BoxLayoutView properties. Adds a TODO to ensure > layout is invalidated when these members are set. > > Bug: None > Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561 > Reviewed-by: Wei Li <weili@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813351} TBR=weili@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I4683ac2a66b75c98da6adf20a80636fb6486aeef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448573Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601845200-65bf911e0b3e8963df3fa359c712100fa3aa7dc1.profdata to chrome-win32-master-1601853620-cfab2714faed86a38ca94c2606f6bcdf84d8c1a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I30142b0baef2c423469349e751c40acac5be49d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448607Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I022b82fa450c41dbb0155ac860b75319e9f68a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448935Reviewed-by:
-
