- 30 Oct, 2018 40 commits
-
-
Henrik Boström authored
The SDP negotiation operations - createOffer(), setLocalDescription(offer), setRemoteDescription(offer), createAnswer(), setLocalDescription(answer) and setRemoteDescription(answer) - can be used in a "safe" or "unsafe" way when thinking about the default of sdpSemantics changing from Plan B to Unified Plan. In particular, it is "unsafe" to use complex SDP without explicitly setting sdpSemantics, since this case results in SDP that is incompatible between Plan B and Unified Plan clients. This CL adds histograms for "safe", "unsafe" and "unknown" usage of SDP for each operation. Bug: 899747 Change-Id: I9a21e3190c3f35153e6e8f31fb63f775d2ea8d31 Reviewed-on: https://chromium-review.googlesource.com/c/1304558 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#604039}
-
Evan Stade authored
This relands commit 1e9af071. The original commit and subsequent test failure uncovered a real bug which only impacted Mash. In classic mode, frameless windows don't act as a WindowState observer so they don't inform the app of OS-triggered fullscreen changes and therefore ShouldEnableImmersive() doesn't return true, allowing the test to pass. It seems like a bug that the app doesn't know it's in fullscreen just because it's frameless, but I will err on the side of preserving existing behavior there. In contrast, in Mash, frameless windows do update the app object wrt changes in window state, therefore the implementation of ShouldEnableImmersive must be enhanced slightly to explicitly rule out frameless windows from being placed in immersive (as the briefly failing test verifies). The test passed before 1e9af071 simply because the two different immersive mode properties lagged in respect to one another. TBR=tsepez@chromium.org Bug: 640365 Original change's description: > Merge two immersive mode window properties. > > aura::client::kImmersiveFullscreenKey is folded into > ash::kImmersiveIsActive > > No bug here currently, but it's confusing to have two different > properties that are both meant to indicate immersive mode is active. > > Also removed some unnecessary ash:: prefixes from //ash. > > Change-Id: I0c43873fa8f128c3799d32f2c479a1f2caa9a7cf > Reviewed-on: https://chromium-review.googlesource.com/c/1298493 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603778} Change-Id: Id4a498cf7d6f721d6459bd75392564abbfda60b5 Reviewed-on: https://chromium-review.googlesource.com/c/1307842 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#604038}
-
Livvie Lin authored
Android and iOS don't have the File security chip, and therefore still need to show the file scheme. (Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/1274985.) Bug: 818528 Change-Id: Ib42601f637a513d21c965bcbd48f8c66fcc5cc99 Reviewed-on: https://chromium-review.googlesource.com/c/1308077 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#604037}
-
Lukasz Suder authored
Passing profile allows us to create the profile on the fly which is needed for using contact details from Payment Request. Bug: 806868 Change-Id: Ia90efadc0e26304110b60fd930320c0f6111f9fa Reviewed-on: https://chromium-review.googlesource.com/c/1301595 Commit-Queue: Lukasz Suder <lsuder@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604036}
-
jdoerrie authored
This is a reland of 3b214250 Original change's description: > Reland "[base] Harden base::JSONWriter::BuildJSONString" > > This is a reland of bbe71c7f > > Original change's description: > > [base] Harden base::JSONWriter::BuildJSONString > > > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > > It replaces the old base::Value API with the new one, thus implicitly > > replacing DCHECKs with CHECKs. > > > > Bug: 859477 > > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603508} > > Bug: 859477, 900041 > Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 > Reviewed-on: https://chromium-review.googlesource.com/c/1306356 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603889} TBR=rsesek@chromium.org Bug: 859477, 900041 Change-Id: I1a825493332a6889afe61897ee9007b651fe86e8 Reviewed-on: https://chromium-review.googlesource.com/c/1308196 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604035}
-
Eric Orth authored
Added ability to create a DnsConfigOverrides with all values overridden with DnsConfig defaults. Makes it easier to override the full config and not use any values from the base config at all. Also improved handling within HostResolverImpl when the full config is overridden (through the new flag or by having all values). When everything is overridden, system config changes are ignored (do not cancel pending requests) and we skip reading system config entirely. Bug: 846423 Change-Id: I310b221caee2fc52443991a79597e162fc4354a8 Reviewed-on: https://chromium-review.googlesource.com/c/1307592 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604034}
-
Victor Vasiliev authored
Merge internal change: 218906384 R=zhongyi@chromium.org Change-Id: Ieccc6cd9751574bb7b6f81c7bb285f7b84ddb555 Reviewed-on: https://chromium-review.googlesource.com/c/1306638 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604033}
-
Ryan Hansberry authored
Remove previous owners who are no longer involved with Smart Lock. Change-Id: Ie66d361db1ce44e883d0e30cb5011069488710ce Reviewed-on: https://chromium-review.googlesource.com/c/1308493Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604032}
-
Christian Biesinger authored
Instead of overriding AddChild in the box fragment builder to collect break tokens, we can collect them in the base class when there is a break token. Since line box children should not have break tokens this should be fast. Using the break tokens is still handled by the box fragment builder. Change-Id: I3812f7d75730421a96d0c0f1c41a8d1794f59c71 Reviewed-on: https://chromium-review.googlesource.com/c/1289673 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#604031}
-
Koji Ishii authored
When fragment-based BiDi reordering was implemented in r524977 (CL:827043), we chose to run the reordering to ensure more test coverage of the code. As the code is now stabilized, change to run BiDi reordering only when needed. |ComputeInlinePositions()| can be optimized further by computing positions as NGInlineLayoutAlgorithm adds children, but it diverges RTL code further. We may consider it in future if needed. Bug: 636993 Change-Id: Ie7e2a365e50618678b4e08b176bf27e99a37cecf Reviewed-on: https://chromium-review.googlesource.com/c/1306948Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#604030}
-
Maksim Ivanov authored
Introduce a (yet) empty Mojo API between the browser and the diagnosticsd daemon. Add implementation that bootstraps this Mojo communication via a D-Bus call. BUG=chromium:869377 TEST=manual Change-Id: I49ab831768e305754d0f3db786861e92b60f46c7 Reviewed-on: https://chromium-review.googlesource.com/c/1288273 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#604029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bc2ea919048..1b114f20625d git log 2bc2ea919048..1b114f20625d --date=short --no-merges --format='%ad %ae %s' 2018-10-30 treehugger-gerrit@google.com Merge "perfetto: Add proto message for opaque chrome system traces" Created with: gclient setdep -r src/third_party/perfetto@1b114f20625d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5f2635920de238dc6883571eff2ba8b3c0b48418 Reviewed-on: https://chromium-review.googlesource.com/c/1308694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604028}
-
rbpotter authored
This is the first step in adding a new cloud print interface, which will communicate with the C++ CloudPrinterHandler. Bug: 829414 Change-Id: I01c8cb25a7e42dae433833e6a6c0245ef6180626 Reviewed-on: https://chromium-review.googlesource.com/c/1308613Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604027}
-
Giovanni Ortuño Urquidi authored
Currently Bluetooth DBus clients use CallMethodWithErrorCallback which takes two callbacks one for success and one for failure. This patterns is hard to use for clients that implement a Mojo interface for example BluetoothSystem, so this CL deprecates the methods that take two callbacks and introduces one that takes a single callback. BluetoothSystem will soon replace all other clients of these DBus clients so it makes sense to move away from the two callbacks pattern and to the single callback pattern which BluetoothSystem can more easily use. Bug: 870192 Change-Id: I703a8b8ed277bf94de6adbef6cb954ac66f2b602 Reviewed-on: https://chromium-review.googlesource.com/c/1293292Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#604026}
-
Tarun Bansal authored
Bug: 900301 Change-Id: I11ccd4325c0db0763f85dab45c0c242b5ed1491f TBR: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1308973Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604025}
-
Charlie Harrison authored
This CL moves blocking policy to an anonymous function. It has no intended behavior change. Bug: None Change-Id: I3ba807562a20d6a6fa59d633510b7c04a590e753 Reviewed-on: https://chromium-review.googlesource.com/c/1308433Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#604024}
-
Yuri Wiitala authored
Fixes: 1. The timestamp field in the event traces has been made consistent (between the Capture and OnBufferReceived trace events). This allows pipeline tracking of individual frames (and fixes the 97-100% drop rate bug). 2. Add BUILD.gn target dependencies to build browser PAK/resources that are required in order to run the binary. 3. Allow thread-blocking in media::cast::test::UDPProxyImpl. Bug: 789192, 816466, 806238 Change-Id: If606989e8ea5eea34fd25e58246ecb7dd9cb75d1 Reviewed-on: https://chromium-review.googlesource.com/c/1308103Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604023}
-
Tommy Nyquist authored
The CL for updating the visuals of how a deprecated operating system should be displayed did not correctly pass along enough information to be able to always have an up to date content description, which is important for accessibility. The state of whether an update badge should be visible or not is always known at the time it has to be updated, so the state should be passed in. The reason is that whether the badge is really visible or not might be correct in all cases when the check happens. This CL therefore goes back to how things were before the visual update by passing the state in. In addition, the menu item itself did not always have a correct content description, but now it is forcefully set during decoriation of the item. Bug: 899695 Change-Id: I9f7e2d4cc6b60ccfaf95d7c07fc351c5c9e2a8ac Reviewed-on: https://chromium-review.googlesource.com/c/1306399 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#604022}
-
Akihiro Ota authored
Previously, Talkback would not report the new value of a slider when adjusted; in order to hear Talkback report the new value, user had to un-focus and re-focus the slider. Changed the AccessibilityEvent that is fired when detecting a slider value-change from TYPE_VIEW_SCROLLED to TYPE_VIEW_SELECTED, which triggers Talkback to report value of the focused item. This mimics Talkback behavior of native Android sliders. Bug: 836554 Change-Id: I4bb3bfafdb4d077f80e1ba4f3c9eecf8a7536497 Reviewed-on: https://chromium-review.googlesource.com/c/1308978Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#604021}
-
Ben Pastene authored
And also roll chromite. The latest roll is blocked due to the path changing slightly: https://chromium-review.googlesource.com/c/chromium/src/+/1306765 NOTRY=true Bug: 897540 Change-Id: Idc753e8b79dcf4c231e05fb9bb6ba3ad7b52592f Reviewed-on: https://chromium-review.googlesource.com/c/1308014 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#604020}
-
Egor Pasko authored
In http://crrev.com/596588 a few events were introduced to find out where time is spent on occasional slow runs (see the bug for more details). Remove the trace events that have proven to be quick (not noticed to take more than 1 frame on N5). On the other hand, in a trace from comment http://crbug.com/891797#c24 we observed these durations for the second startup: * ProcessInitializationHandler.initializePreNative(): 15ms of wall time (11ms CPU time) * ChromeBrowserInitializer.preInflationStartup: 55ms Keeping these events for now to keep the traces more informative. Bug: 891797 Change-Id: I543502973d19d768a94bbc5bec0a1446cc4338c5 Reviewed-on: https://chromium-review.googlesource.com/c/1305557 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604019}
-
Antoine Labour authored
Both CreateImageForGpuMemoryBuffer and CreateAnonymousImage take a BufferFormat which explains the format, and all callers pass a consistent internalformat (equal to the result of gpu::InternalFormatForGpuMemoryBufferFormat). Most GLImage implementations refuse a mismatch anyway. Bug: 900044 Change-Id: I7b1ba0711bc4242f263932c40644f884cbe081ce Reviewed-on: https://chromium-review.googlesource.com/c/1306780 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604018}
-
Robert Ogden authored
Requested by the server team. Added as a member to the pingback client impl which is constructed in the chrome layer, and is copied on every pingback request. Bug: 900224 Change-Id: Ic31ae471f09fc8cf9fe896ef42e9bffb3f6e9401 Reviewed-on: https://chromium-review.googlesource.com/c/1308078 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#604017}
-
Oystein Eftevaag authored
Reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541 TBR=skyostil@chromium.org Change-Id: I1b1ca495b8b7579bbfa46ced8de017d21e8d54e7 Reviewed-on: https://chromium-review.googlesource.com/c/1308415Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604016}
-
Ryan Hansberry authored
Add new team member hsuregan@, and remove an incorrect path. Change-Id: Ia823a4db42bcc87aa136fd6013507877381db59b Reviewed-on: https://chromium-review.googlesource.com/c/1308553Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604015}
-
Aiden Benner authored
Previously the @MainDex annotation would not be processed by the jni_generator for proxy natives. So method registrations that should be in main dex were incorrectly registered. This CL processes @MainDex annotations for proxy natives and properly splits up their declaration in generated registration headers. Bug: 898261 Change-Id: Iad9d3b3121085ef1427b958dcefc1acfb255312c Reviewed-on: https://chromium-review.googlesource.com/c/1303394 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#604014}
-
Bailey Berro authored
This change is a part of an ongoing series of changes to pull the add SMB share dialog out of settings. - Moves SmbHandler from ui/webui/settings/chromeos to ui/webui/chromeos - Changes SmbHandler from implementing a settings-specific WebUIMessageHandler to the more general version - Removes unused overridden methods Bug: chromium:887135 Change-Id: If196d3bdf53ec69d46ea25f1314a0bafff6c296d Reviewed-on: https://chromium-review.googlesource.com/c/1285519 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#604013}
-
manuk authored
Certain omnibox inputs, such as `http:www.` produce matches with invalid urls. Invoking GURL::spec on these invalid GURL's caused a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds. Bug: 898554 Change-Id: I89a27f902b77bf6b221c321ab396787e9249a4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1308260 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#604012}
-
Hubbe Hubinette authored
Not sure exactly what is affected by this, stumbled on it while working on fixing full-range video. Change-Id: I589e1b811ef5f10160111620b63f06492068f341 Reviewed-on: https://chromium-review.googlesource.com/c/1188968 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#604011}
-
Meilin Wang authored
Temporarily fix the Assistant UI flyout off the screen to the left when the container width grows larger than the screen width by explicitly setting x-axis value of container to be positive. But the side effect is when the screen is not wide enough, inside views will be clipped. Since it doesn't always make sense to apply a width restriction on Assistant UI to be less than the usable work area width (the workarea could be extremely narrow depending on the physical size and resolution combination), also the server side has assumptions about the card size, we may need a more comprehensive solution to resize the views correctly. In this CL, we just keep the 640 dip width assumption unchanged. Test: local compile and manually test. Bug: b:116807989 Change-Id: I257ac26cd28672ec284ff2555e46db5ab6a46246 Reviewed-on: https://chromium-review.googlesource.com/c/1250087Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#604010}
-
wutao authored
This cl fixes two descriptions of shortcuts. Bug: 896907 Test: manual. Change-Id: I035a4cab3e8315437111f0f72bcdf3bf681e2876 Reviewed-on: https://chromium-review.googlesource.com/c/1298475Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604009}
-
Matthew Jones authored
This patch removes unused swiple logic experiment flags and implementation from Chrome. Change-Id: Ic59a477a71291a355ac68538693f10b940e22d68 Reviewed-on: https://chromium-review.googlesource.com/c/1305814Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604008}
-
Kevin Strohbehn authored
Bug: 896790 Change-Id: I2d8de828cea27caa210755a0de8304ee293e55f9 Reviewed-on: https://chromium-review.googlesource.com/c/1307233 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604007}
-
John Chen authored
SessionHandlingTest.testGetSessions appears to trigger some race conditions and is flaky. Disabling it until a fix can be found. TBR=zmin@chromium.org Bug: 899919 Change-Id: I3c532559477a3597f20984783eb36acf6355ad7b Reviewed-on: https://chromium-review.googlesource.com/c/1308657Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604006}
-
Jamie Madill authored
This should force DEPS changes in ANGLE to trigger all trybots. ANGLE's bot config is a bit special since we use recursive DEPS. Bug: 850100 Bug: 899737 Change-Id: Iab6e996663386f66f1fa05f2ee10531d6bd85224 Reviewed-on: https://chromium-review.googlesource.com/c/1307734 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604005}
-
erikchen authored
Previously, local_device_test_run.py used SignalHandler() to catch SIGTERM, raise an exception, and then handle the exception. This prevents other SIGTERM handlers from ever receiving the exception. This CL changes local_device_test_run.py to instead use AddSignalHandler(), so that the exception is propagated to the previously registered SIGTERM handler. Bug: 895027 Change-Id: Ia6f84022ee4cf54e7dc36afad012acb3212b51e2 Reviewed-on: https://chromium-review.googlesource.com/c/1308753Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604004}
-
James Hawkins authored
R=dpapad@chromium.org, hansberry@chromium.org Bug: 899324 Test: none Change-Id: I01b9786b3e5f49490660829bd1c3a7659e73f9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1306916 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604003}
-
Wez authored
- Expose WebContentRunner's constructor to derived classes. - Move the common Runner and Component implementations under "common". - Move the scoped service publishing binding into WebContentRunner. - Move the default web.Context creation helper to the WebContentRunner. - Rename the ComponentControllerImpl to WebComponent. - Rename WebComponent::RequestTermination to ...::DestroyComponent. Bug: 893229, 856416 Change-Id: Ia4b8036d5f1b6f00472d201b7cb9dcf063377122 Reviewed-on: https://chromium-review.googlesource.com/c/1301114Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604002}
-
Peter Kvitek authored
Process handle and cumulative CPU usage is returned for browser and all renderer processes. BUG: 899823 Change-Id: I6d44630df3ea9ef80bed17f30367dad929ecaa17 Reviewed-on: https://chromium-review.googlesource.com/c/1303074 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604001}
-
Sammie Quon authored
Test: none Bug: none Change-Id: Idf8dc27a75ccbf3040e0f5950565d1dc856cc9a8 Reviewed-on: https://chromium-review.googlesource.com/c/1306664Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#604000}
-