GitLab

BUG=70829
TEST=tree gets greener
TBR=mpcomplete
Review URL: http://codereview.chromium.org/8585021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104582
TEST=bots go green
TBR=japhet
Review URL: http://codereview.chromium.org/8588022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104578
TEST=none

Review URL: http://codereview.chromium.org/8586018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8566027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110420 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Fix leak in X509UtilNSSTest VerifyCertificateSignature."

BUG=88782
TEST=none
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8587018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110419 0039d316-1c4b-4281-b951-d872f2087c98

Forgot to initialize the ScopedPLArenaPool, so the ASN1 functions were
leaking.

BUG=88782
TEST=memory bots
TBR=cpu@chromium.org

Review URL: http://codereview.chromium.org/8588015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110417 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93825
TEST=none

Review URL: http://codereview.chromium.org/8520024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=steveblock
Review URL: http://codereview.chromium.org/8479053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8585008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14439
TEST=None

Change-Id: Iab663c8eaeea198f9d3d74e8f5f069d678ae9429

Review URL: http://codereview.chromium.org/8513021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110411 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8526015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110410 0039d316-1c4b-4281-b951-d872f2087c98

The motivation is to solve a dependency issue between UpgradeDetectorChromeos
and DBusThreadManager, that'll replace CrosLibrary (i.e. UpgradeDetectorChromeos
will be using DBusThreadManager internally).

BUG=16564
TEST=Upgrade detector works as before. (create a new image, start dev server, and run update_engine_client --update, and confirm that an arrow is shown on the wrench menu icon, once the update is downloaded in the background).

Review URL: http://codereview.chromium.org/8568020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110409 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a possible data race issue.

Also convert NewRunnableMethod to base::Bind.

BUG=103901,87747
TEST=run chrome, then "echo hi | nc -U /tmp/.org.chromium.Chromium.FOO/SingletonSocket"


Review URL: http://codereview.chromium.org/8571019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots, local cros/arm build of chrome succeeds.


Review URL: http://codereview.chromium.org/8537032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8570011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110406 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=less CrOS Valgrind errors.
Review URL: http://codereview.chromium.org/8587015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110405 0039d316-1c4b-4281-b951-d872f2087c98

Move ShowPageInfoBubble to browser_dialogs.h, nix page_info_window.h.
Add BubbleDelegateView::SizeToContents(), slight refactoring.
Add non-const location_icon_view(), make animation impls protected.

BUG=97248,98312,98323
TEST=Page info bubble has the same behavior/appearance.

Review URL: http://codereview.chromium.org/8508048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8573031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110402 0039d316-1c4b-4281-b951-d872f2087c98

The new method cancels channel creation for pending channel. This 
prevents some potential crashes.


Review URL: http://codereview.chromium.org/8573013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8568038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110400 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8581003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110399 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101724
TEST=Preview a webpage. Click "Open PDF In Preview" option Observe that the pdf is displayed in native preview app. Complete the printing workflow by clicking "Print" or
"Cancel" button at the bottom of the preview app.

Review URL: http://codereview.chromium.org/8425008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110398 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8520032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104478
TEST=Hit tab mulitple times, browser should not crash, focus should cycle through printing options.


Review URL: http://codereview.chromium.org/8578010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles and ProcessSingletonTest passes.


Review URL: http://codereview.chromium.org/8574030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110395 0039d316-1c4b-4281-b951-d872f2087c98

The last try broke at least 2 things which I've fixed in this CL:
- Attempts to access geolocation from an extension would hang.
- We'd sometimes crash when shutting down the browser with an ExtensionPopup
open.

BUG=84146
TEST=extensions still work

Review URL: http://codereview.chromium.org/8587001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=X509UtilNSSTest


Review URL: http://codereview.chromium.org/8537025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110393 0039d316-1c4b-4281-b951-d872f2087c98

Data that's only pertinent to initially loading the document is stored in LoadTimes. These are carried over when the NavigationState changes due to in-document navigation.

I'd be interested in feedback on the position of LoadTimes. I'm not happy with it. I'd prefer to have it on WebDataSource, but I expect NavigationState was hidden in ExtraData for a reason.

This also impacts PLT histograms. In-document navigation is the cause of some of the missing start types. So, by fixing this, we should get more complete page load data. There are probably whole classes of sites where we have no PLT data, such as Google Docs.

BUG=79078
TEST=ui_tests


Review URL: http://codereview.chromium.org/8404018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=OWNERS

Review URL: http://codereview.chromium.org/8539001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=groby@chromium.org

Review URL: http://codereview.chromium.org/8590010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110390 0039d316-1c4b-4281-b951-d872f2087c98

This failure path has not received a lot of testing until now. Here are
the issues addressed by this patch:

- We usually check the return value of step() calls. However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step(). This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().

- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure. This will allow us to test these
error paths.

- Be careful in ShutdownOnSyncThread(). The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database. The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was. However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore. If this code
were to get executed it would put us into an inconsistent state. See
issue 103824. However, it's unlikely this code would get executed. If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().

- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails. Such a failure could
be due to bad local state. We don't know the actual cause because the
information is not available from the ProfileSyncService callback. The
safe course of action is to clear our local sync state and try again
later. It's the easiest way to get back to the most well travelled sync
initialization path.

- Fix error handling logic in OpenAndConfigureHandleHelper.  It used
to rely on a specially-crafted scoped_ptr to close the database if we
had to leave the function unsuccessfully.  This was wrong in two ways.
First, it did not reset the handle to NULL, which meant that the
DirectoryBackingStore would attempt to free the handle again when it
was destructed.  Second, it failed to clean up the handle when the
return value was not SQLITE_OK.  (Though I suppose it would have been
cleaned up by the DirectoryBackingStore destructor, thanks to the
previous issue).

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase


Review URL: http://codereview.chromium.org/8568028

TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/8586004

TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/8574045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110388 0039d316-1c4b-4281-b951-d872f2087c98

Revert 110355 - Use shared D3D9 texture to transport the compositor's backing buffer to the browser process for presentation.

Implemented ImageTransportSurface for Linux (without texture sharing), XP, Vista and 7. XP. The non-texture sharing Linux and XP paths just present directly to the compositing child window owned by the browser process as before.

PassThroughImageTransportSurface still needs a proper name. I will move it into its own file once that is decided.

I moved AcceleratedSurfaceBuffersSwapped outside of the platform specific ifdefs and made the signature the same on all platforms for greater consistency.

I removed the code related to sharing surfaces between processes and synchronizing resize and swapping out of GpuCommandBufferStub. It is all now in ImageTransportSurface implementations.
Review URL: http://codereview.chromium.org/8060045

TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/8587012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8587003

TBR=gene@chromium.org
Review URL: http://codereview.chromium.org/8586005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110385 0039d316-1c4b-4281-b951-d872f2087c98

This failure path has not received a lot of testing until now. Here are
the issues addressed by this patch:

- We usually check the return value of step() calls. However, we do not
check the return value of prepare() calls, which are more likely to fail.
If they do fail, we will DCHECK() or go on to dereference an invalid
pointer in step(). This patch checks the return value of one particular
prepare statement, the one in CheckIntegrity().

- Disable DCHECKs on sqlite errors, DirectoryManager open failure,
and SyncManager initialization failure. This will allow us to test these
error paths.

- Be careful in ShutdownOnSyncThread(). The directory will not be fully
intialized during shutdown if the database load failed.

- Add a ProfileSyncService unit test that simulates a load from an
unreadable database. The harness had to be modified slightly to make
this possible.

- Remove a setup_for_test_mode_ flag in SyncManager::SyncInternal::Init.
I don't know what the original intent of this flag was. However, I do
know that it prevents me from properly simulating a database load failure
and removing it seems to have no ill effects.

- Do not delete the database from DirectoryBackingStore. If this code
were to get executed it would put us into an inconsistent state. See
issue 103824. However, it's unlikely this code would get executed. If
the database were actually corrupt, we would DCHECK or de-reference an
invalid pointer on our way to this code because we don't check the
return value of the attempt to prepare an SQL statement in
DirectoryBackingStore::CheckIntegrity().

- Modify the DirectoryBackingStoreTest.Corruption unit test to expect the
new behaviour.

- Disable sync when backend initialize fails. Such a failure could
be due to bad local state. We don't know the actual cause because the
information is not available from the ProfileSyncService callback. The
safe course of action is to clear our local sync state and try again
later. It's the easiest way to get back to the most well travelled sync
initialization path.

- Fix error handling logic in OpenAndConfigureHandleHelper.  It used
to rely on a specially-crafted scoped_ptr to close the database if we
had to leave the function unsuccessfully.  This was wrong in two ways.
First, it did not reset the handle to NULL, which meant that the
DirectoryBackingStore would attempt to free the handle again when it
was destructed.  Second, it failed to clean up the handle when the
return value was not SQLITE_OK.  (Though I suppose it would have been
cleaned up by the DirectoryBackingStore destructor, thanks to the
previous issue).

BUG=103307, 103824
TEST=DirectoryBackingStoreTest.Corruption, ProfileSyncServiceTest.CorruptDatabase


Review URL: http://codereview.chromium.org/8568028

TBR=rlarocque@chromium.org
Review URL: http://codereview.chromium.org/8586004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110384 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8589002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110383 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104535
TEST=none

R=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8574041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104534
TEST=none

R=thestig@chromium.org

Review URL: http://codereview.chromium.org/8586003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110378 0039d316-1c4b-4281-b951-d872f2087c98