GitLab

Also add tests that assert OCSP responses and SCT extensions are returned in
the expected format.

BUG=408687
TEST=open https://embed.ct.digicert.com/ in Chrome for Android and
     tap the lock icon. Popup should say "The identity of this
     [...] and is publicly auditable."

Review URL: https://codereview.chromium.org/517083002

Cr-Commit-Position: refs/heads/master@{#293295}

W0105: 16,-1: String statement has no effect
C0323: 45,4:main: Operator not followed by a space
    print >>sys.stderr, out
           ^

BUG=

Review URL: https://codereview.chromium.org/539843002

Cr-Commit-Position: refs/heads/master@{#293294}

Revert of Blink roll 9d34a87:9a051c52 (patchset #1 id:1 of https://codereview.chromium.org/539713002/)

Reason for revert:
Breaks telemetry_perf_unittests on Mac.
Likely culprit is http://src.chromium.org/viewvc/blink?revision=181336&view=revision

	ASSERTION FAILED: (HashTableKeyChecker<HashTranslator, KeyTraits, HashFunctions::safeToCompareToEmptyOrDeleted>::checkKey(key))
	../../third_party/WebKit/Source/wtf/HashTable.h(645) : const ValueType *WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup(T) const [Key = blink::FontPlatformData, Value = WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, Extractor = WTF::KeyValuePairKeyExtractor, HashFunctions = blink::FontDataCacheKeyHash, Traits = WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, KeyTraits = blink::FontDataCacheKeyTraits, Allocator = WTF::DefaultAllocator, HashTranslator = WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, T = blink::FontPlatformData]
	1   0x5045c9b7 WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > const* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData) const
	2   0x5045c8fc WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >* WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::lookup<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData)
	3   0x5045fed9 WTF::HashTableIterator<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator> WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find<WTF::IdentityHashTranslator<blink::FontDataCacheKeyHash>, blink::FontPlatformData>(blink::FontPlatformData const&)
	4   0x5045fe51 WTF::HashTable<blink::FontPlatformData, WTF::KeyValuePair<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::KeyValuePairKeyExtractor, blink::FontDataCacheKeyHash, WTF::HashMapValueTraits<blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> > >, blink::FontDataCacheKeyTraits, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
	5   0x504556e8 WTF::HashMap<blink::FontPlatformData, std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int>, blink::FontDataCacheKeyHash, blink::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WTF::RefPtr<blink::SimpleFontData>, unsigned int> >, WTF::DefaultAllocator>::find(blink::FontPlatformData const&)
	6   0x50454b28 blink::FontDataCache::get(blink::FontPlatformData const*, blink::ShouldRetain)
	7   0x50446962 blink::FontCache::fontDataFromFontPlatformData(blink::FontPlatformData const*, blink::ShouldRetain)
	8   0x504467f1 blink::FontCache::getFontData(blink::FontDescription const&, WTF::AtomicString const&, bool, blink::ShouldRetain)
	9   0x5046298f blink::FontFallbackList::getFontData(blink::FontDescription const&, int&) const
	10  0x504620c9 blink::FontFallbackList::fontDataAt(blink::FontDescription const&, unsigned int) const
	11  0x50461d9d blink::FontFallbackList::determinePitch(blink::FontDescription const&) const
	12  0x4384da35 blink::FontFallbackList::isFixedPitch(blink::FontDescription const&) const
	13  0x4384d6b9 blink::Font::isFixedPitch() const
	14  0x43841394 blink::RenderText::widthFromCache(blink::Font const&, int, int, float, blink::TextDirection, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>*, blink::GlyphOverflow*) const
	15  0x4383c04d blink::RenderText::computePreferredLogicalWidths(float, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const*>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::DefaultAllocator>&, blink::GlyphOverflow&)
	16  0x4383ad0c blink::RenderText::computePreferredLogicalWidths(float)
	17  0x4383a603 blink::RenderText::trimmedPrefWidths(float, float&, bool&, float&, bool&, bool&, bool&, float&, float&, float&, float&, bool&, blink::TextDirection)
	18  0x4365b7ab blink::RenderBlockFlow::computeInlinePreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&)
	19  0x435f3d3c blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	20  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	21  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	22  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	23  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	24  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	25  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	26  0x435f4474 blink::RenderBlock::computeBlockPreferredLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	27  0x435f3d5a blink::RenderBlock::computeIntrinsicLogicalWidths(blink::LayoutUnit&, blink::LayoutUnit&) const
	28  0x435f4ecc blink::RenderBlock::computePreferredLogicalWidths()
	29  0x438059b1 blink::RenderTableCell::computePreferredLogicalWidths()
	30  0x4367488e blink::RenderBox::minPreferredLogicalWidth() const
	31  0x435766c8 blink::AutoTableLayout::recalcColumn(unsigned int)

Original issue's description:
> Blink roll 9d34a87:9a051c52
>
> https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf
> TBR=tkent@chromium.org,arv@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/203622e5b22fd772320684b7f8a1aa1fa4afc25b

TBR=arv@chromium.org,tkent@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/540023002

Cr-Commit-Position: refs/heads/master@{#293293}

Just a trivial update to README.chromium.

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+log/2ed5319ce40b..3963fbcd6c16

NOTRY=true
R=mnaganov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/537973002

Cr-Commit-Position: refs/heads/master@{#293292}

The new enhanced bookmark UI redefines what top folders are:
- Sub-folders of mobile node and others node.
- Desktop node.
- Managed bookmark node.
- Partner bookmark node.

So we need JNI bridge functions to query them.

BUG=386785

Review URL: https://codereview.chromium.org/516323003

Cr-Commit-Position: refs/heads/master@{#293291}

HTTP/2 header compression HPACK draft-09 requires pseudo-headers (names
starting with ":") to be encoded before regular headers.  Also, headers that
are in the header table are emitted before others, to avoid eviction before
they could be used.

This lands server change 74039742 by bnc.

BUG=395635

Review URL: https://codereview.chromium.org/537663002

Cr-Commit-Position: refs/heads/master@{#293290}

Cr-Commit-Position: refs/heads/master@{#293289}

The goal is to whitelist logged EV certificates so the requirement of
CT for EV certificates can be enabled without waiting for all EV certs
to be re-issued.

This change adds the code for unpacking the list of (truncated) hashes
of EV certificates. The compressed data format is the diff values
between the hashes, encoded using Golomb coding. This was suggested
by agl as an efficient encoding, since the hash values of the
EV certificates are uniformly distributed, so the differences between
them are geometrically distributed. See section 4 in:
http://algo2.iti.kit.edu/singler/publications/cacheefficientbloomfilters-wea2007.pdf

The code that generates the data can be found here:
https://github.com/google/certificate-transparency/blob/master/python/utilities/ev_whitelist/golomb_code.py#L27

Currently the code is not hooked into anything, but once the
compressed list would be fetched as a component update, we'll start
by logging statistics about known vs. unknown EV certs.

BUG=339128

Review URL: https://codereview.chromium.org/462543002

Cr-Commit-Position: refs/heads/master@{#293288}

Passing invalid handle was incorrect, because some handle were supposed
to be not null. Change the test to use mock handles instead.

NOTRY=true
R=ppi@chromium.org

Review URL: https://codereview.chromium.org/541633003

Cr-Commit-Position: refs/heads/master@{#293287}

Test are failing due to concurrent CL. Disabling those until they are
fixed.

R=ppi@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/539893003

Cr-Commit-Position: refs/heads/master@{#293286}

Previously, only apps were allowed to use this api, however most clients will
be actually written as extensions.

This patch has been once reverted due to a bug. See:
https://codereview.chromium.org/527663002/

TEST=browser_tests: *FileSystemProvider*Extension*
BUG=409487

Review URL: https://codereview.chromium.org/537153003

Cr-Commit-Position: refs/heads/master@{#293285}

To fix the Windows XP perf bots specifically.

BUG=336558
TEST=None.
TBR=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/537213004

Cr-Commit-Position: refs/heads/master@{#293284}

Revert of Remove unused license whitelist entry (patchset #1 id:1 of https://codereview.chromium.org/542513002/)

Reason for revert:
This breaks the android tree:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/65137

Original issue's description:
> Remove unused license whitelist entry for a removed file
>
> BUG=None
> TBR=mnaganov@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4808281fa6b22601ac969b66ea130eb8a5233ffe

TBR=mnaganov@chromium.org,tzik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/537303002

Cr-Commit-Position: refs/heads/master@{#293283}

Also move backward compatibility test into its own suite, as backward compatibility is implemented in Java and the test is passing.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/522353003

Cr-Commit-Position: refs/heads/master@{#293282}

We cannot scroll the mosaic view by touching since crrev.com/283688.
The touch event is covered by other elements. pointe-events:none does not help
to make it scrollable by touch.

BUG=404960
TEST=test scrolling on link

Review URL: https://codereview.chromium.org/535673004

Cr-Commit-Position: refs/heads/master@{#293281}

Since perf bots build in release mode, UNSHIPPED_TRACE doesn't work.

BUG=356842

Review URL: https://codereview.chromium.org/542463002

Cr-Commit-Position: refs/heads/master@{#293280}

Cr-Commit-Position: refs/heads/master@{#293279}

This is issue 511393007 all over again, but doesn't enable the test so it won't get reverted again.

BUG=356842

Review URL: https://codereview.chromium.org/540553002

Cr-Commit-Position: refs/heads/master@{#293278}

This is a power monitor that reads the Intel RAPL MSRs to get energy measurements.
It uses a defunct open source DLL and kernel driver, WinRing0, to access the MSRs.
WinRing0 is a little wonky, and we have to install the kernel driver to the Python executable's directory.
Python must be run as Administrator for this to work.

BUG=336558
TEST=tools/telemetry/run_tests winring0

Review URL: https://codereview.chromium.org/536243002

Cr-Commit-Position: refs/heads/master@{#293277}

While it's not a direct Telemetry dependency, it's referenced in the doc for setting up ChromeOS.
http://www.chromium.org/developers/telemetry/run_locally
Also, alphabetize the bootstrap_deps list.

BUG=None.
TEST=None.
R=tonyg

Review URL: https://codereview.chromium.org/540553004

Cr-Commit-Position: refs/heads/master@{#293276}

This also changes the way DomDistillerResult is read from base::Values by
updating to the new version of DomDistillerResult::ReadFromValue which
takes in a pointer to DomDistillerResult.

This CL also makes it possible to continue using the
update_domdistiller_js.sh script without modification by moving the
BUILD.gn file for protos to outside of the generated package folder.

Picked up changes:
432b2dc Added support for reading protos into a pointer.
32f096c don't prune a subtree when its only child is a text node.
90dc83c bump up nested-table heuristic
6f59530 Make comment filter a little more restrictive.

BUG=368941,408292,409274

Review URL: https://codereview.chromium.org/514423002

Cr-Commit-Position: refs/heads/master@{#293275}

WebContentsObserver::web_contents() is now public + cleanup of unnecessary getters.

BUG=408560

Review URL: https://codereview.chromium.org/525793002

Cr-Commit-Position: refs/heads/master@{#293274}

After this change the webapp will be use XMPP for signaling instead of
WCS.

BUG=274652

Review URL: https://codereview.chromium.org/530213004

Cr-Commit-Position: refs/heads/master@{#293273}

BUG=None
TBR=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/542513002

Cr-Commit-Position: refs/heads/master@{#293272}

Review URL: https://codereview.chromium.org/520303003

Cr-Commit-Position: refs/heads/master@{#293271}

if it fails to load ServiceMetadata's information from DB.
It tries to initialize for 5 times.

BUG=409737
TEST=./unit_tests --gtest_filter="Metadata*

Review URL: https://codereview.chromium.org/527163002

Cr-Commit-Position: refs/heads/master@{#293270}

TBR=jamesr

Review URL: https://codereview.chromium.org/535173003

Cr-Commit-Position: refs/heads/master@{#293269}

BUG=407777
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/537113002

Cr-Commit-Position: refs/heads/master@{#293268}

Metro mode requires a GPU process but there are a few
tablets and other devices that don't have a GPU. Currently
we don't expose the menu option for Metro mode on these
devices. This CL exposes the Metro mode option for all
Windows 8+ machines, and if a GPU isn't normally available
it turns on WARP support for Metro mode only.

BUG=314954

Review URL: https://codereview.chromium.org/435383002

Cr-Commit-Position: refs/heads/master@{#293267}

BUG=N/A
R=pdr@chromium.org

Review URL: https://codereview.chromium.org/540623004

Cr-Commit-Position: refs/heads/master@{#293266}

BUG=397741

Review URL: https://codereview.chromium.org/540563002

Cr-Commit-Position: refs/heads/master@{#293265}

The method declaration in the header file was left over in e2ea5183 when
EME related code was moved to EncryptedMediaSupportImpl.

TBR=acolwell

Review URL: https://codereview.chromium.org/537193002

Cr-Commit-Position: refs/heads/master@{#293264}

Until we can rework the guts of HTMLMediaElement and its interaction
with WebMediaPlayer, have WebMediaPlayerImpl track an ended state so it
can return the duration HTMLMediaElement expects to fire the ended
event.

This makes it easier to change how Pipeline's audio/video time is
implemented without worrying about the pecularities of HTMLMediaElement.

BUG=349543,370634

Review URL: https://codereview.chromium.org/526443003

Cr-Commit-Position: refs/heads/master@{#293263}

When a tile is shared (no invalidation) and is being drawn on the
active tree (ready-to-draw), then that tile is not marked as required
for activation since activating it can't cause a bad-resolution flash.

However, we also would also say that "twin_had_missing_tile" in this
scenario, which causes us to mark low-res tilings as required. But
this is a bug since the tile is not missing in this case, and we do
not need low res to fill it in.

Instead, check to see if the active tree's tile is /not/ ready-to-draw.
When that is the case, the active tile is not being drawn and is
actually missing. Then a low res tile should be required if the
active tree is showing a low res tile in the same place.

For perf tests without scrolling (ie pages that just update in place
without input), this fixes us to never require low res tiles to
activate, since we won't show them.

R=enne, vmpstr
BUG=407121

Review URL: https://codereview.chromium.org/540663002

Cr-Commit-Position: refs/heads/master@{#293262}

Code to take into account font path specified in registry which matches system font folder. Also adding UMA to measure font load times.

R=scottmg,cpu,ananta
BUG=408393

Review URL: https://codereview.chromium.org/541543002

Cr-Commit-Position: refs/heads/master@{#293261}

BUG=None

Review URL: https://codereview.chromium.org/536783003

Cr-Commit-Position: refs/heads/master@{#293260}

Proxy should use BeginFrame() to request new BeginFrame instead of BeginImplFrame().
The scheduler turns BeginFrames into BeginImplFrames or BeginRetroFrames
as necessary to make sure we don't start a new BeginImplFrame
before the previous deadline.

Some of public methods that are only used by itself moved into the private.

R=brianderson@chromium.org
BUG=NONE
TEST=cc_unittests

Review URL: https://codereview.chromium.org/536123002

Cr-Commit-Position: refs/heads/master@{#293259}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=408985,409110

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#293258}

* "added" type is added
* "num_total_jobs" member is added
* and this is for displaying the total number of jobs in Chrome OS file manager

BUG=400636
TEST=
manually
1. Copy the local file to drive directory.
2. Observe the status of syncing status.

Review URL: https://codereview.chromium.org/507293002

Cr-Commit-Position: refs/heads/master@{#293257}

Layout changes trigger view changes which get sent to the plugin. With the
in process plugin (PDF), the plugin is notified synchronously of the view
change. It then might execute scripts synchronously in the plugin but
scripts are not meant to be executed during layout changes. This change
runs the scripts asynchronously. I tested print preview to ensure that it
still works correctly.

Note that once we remove in-process plugins this won't be an issue because
view changes happen asynchronously out of process (besides the fact that
synchronous script execution is limited to private plugins).

BUG=351636

Review URL: https://codereview.chromium.org/530363002

Cr-Commit-Position: refs/heads/master@{#293256}