- 23 Oct, 2020 40 commits
-
-
Ramin Halavati authored
InProcessBrowserTest::CreateGuestBrowser does not work on ChromeOS and to create a Guest browser, proper switches need to be added while setting up the test. The function is excluded from ChromeOS build. Bug: 1125474 Change-Id: If14266e1a1372ebec4e4ae92c0fea16164d726f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490007 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820180}
-
Fredrik Söderqvist authored
Fold SVGResourcesCache::ResourceReferenceChanged into its two users, greatly tailoring the resulting code for one user (SVGPatternElement). Expose a function for updating the SVGResources object. Bug: 1028063 Change-Id: I439ca043c659bad7dbb3fa89d9a4d3d9578f7c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489650Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#820179}
-
Morten Stenshorne authored
This is a reland of 3786076d Original change's description: > Enable "gn check" for //third_party/blink/renderer/core/typed_arrays > > Bug: 800764 > Change-Id: I7e09231307f6de1c5457150581438f590b43de85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484596 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818852} Bug: 800764 Change-Id: Ibf1b672b0d773aee91c5ac33b2f379d8e950cd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490051Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#820178}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6abe5ba13913..e369f4fe6ec4 2020-10-23 almuthanna@google.com Reduce flickering for the profiling test 2020-10-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140926 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I81cd26aa62eecfea465b89dcd44e5b9916ca739b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494512Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820177}
-
Victor Hugo Vianna Silva authored
SyncController used to create a SignInStateObserver that would call ProfileSyncService.requestStart() on every sign-in. Soon users will be able to be signed in but not syncing, so this CL removes the observer. requestStart() is still called if sync is enabled, since SignInManager.finishSignInAfterPolicyEnforced() still calls AndroidSyncSettings.enableChromeSync() [1][2], eventually calling SyncController.updateSyncStateFromAndroid(). [1] https://source.chromium.org/chromium/chromium/src/+/3073cfbd9528937c5cdf94a15c96f56206f1fac5:chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java;l=568 [2] https://source.chromium.org/chromium/chromium/src/+/3073cfbd9528937c5cdf94a15c96f56206f1fac5:chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java;l=805 Fixed: 1141512 Change-Id: I6cba35e710d768810c63592d969f3be753aa32e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490014 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#820176}
-
Ricky Liang authored
When the render thread encounters GPU context lost, we need to re-create the SharedImage resources to recover the video capture stream. This is a reland of crrev.com/c/2455328 with a fix to address the MSAN test failure Bug: 1131998, b:169429427 Test: Manually with chrome://gpuclean on soraka TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I3d00abaea04ccf95a795e116f5fc7ff5c7d7f43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494406Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/734a27a2f391..58cf3fe83b93 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 22505a5afe1f to ade9a5235c73 (2 revisions) 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e02d8938821a to 8012e62471be (1 revision) 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d74754378f09 to 097f307e75a4 (10 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Test: Test: Test: angle_perftests -v --local-output --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: I4b79e7fc0f0e471571b95fffa1b443cd7a77eed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820174}
-
Daniel Cheng authored
Bug: 1140588 Change-Id: I2c55eeae2125a4c4dea4683a2a017723c3f14e22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488320Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#820173}
-
sauski authored
Added type checking for the following tests: - collapse_radio_button_tests.js - do_not_track_toggle_test.js - recent_site_permissions_test.js Bug: 1000989 Change-Id: I310777a6f17ffff9c63b03965c71ea14485b54d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489630 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#820172}
-
Andrew Shulaev authored
Bug: 171470675 Change-Id: I377272cc73f80a98efdeeed6d05c64bc23ea2630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489631Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#820171}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603410964-a2043bc9224640fe9aacb254c17e5c20cde84377.profdata to chrome-linux-master-1603426036-fdbbb30b2e93e949277645ff11f5cf593a24568b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I349f4d66d47328e94ad1a21ca4315c97c31071e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iafc2798927e20959e4f5b52ae1830eaae0b067da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820169}
-
Tal Pressman authored
Before crrev.com/c/2485659, this was done in RenderThreadImpl::CreateView, but this got lost when moving CreateView to AgentSchedulingGroup. Fixed: 1141547, 1141397 Change-Id: Iccf2ecab42b039640c53001544823e2b599ccbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494191Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#820168}
-
Bret Sepulveda authored
This reverts commit 43831226. Reason for revert: Causing failures in the generate_build_files step on multiple builders. See for example: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9336 https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/10837 https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome-easwa/1288 Original change's description: > Use grd generation in the Sample System Web App. > > Bug: None > Change-Id: I4485ddbb595ade6ef078abda2436fa887a0d8b7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489060 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820135} TBR=khorimoto@chromium.org,calamity@chromium.org,ortuno@chromium.org Change-Id: I62815e6e75e4d6483dd162ec8c0a415584667060 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494722Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#820167}
-
kouhei authored
Before this CL, RenderFrameProxyHost registered itself to per-process IPC channel. This is wrong, since RenderFrameProxy is bound to an AgentSchedulingGroup. This ends up AgentSchedulingGroupHost being queried `GetRoute()` to associate interface for the RenderFrameProxyHost, but fails, since it was never registered. This CL fixes the issue by correcting RenderFrameProxyHost to register its route to AgentSchedulingGroupHost. This behavior will be enforced by a DCHECK which to be introduced in an upcoming CL. Bug: 1111231 Change-Id: I135547ccb2d30268e84d9f3e6b054b6b2e9069f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494285 Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#820166}
-
Friedrich Horschig authored
Currently, the keyboard accessory may show stale suggestions. This is because sheets are cached by adding them with `emplace` to a flat_map. `emplace` only adds an item if it isn't present, so the oldest, non-empty sheet (for a given tab) will be shown forever. This isn't immediately obvious since sheets are also pushed directly when they are updated but with indirect updates (e.g. updating another sheet), the stale value will override the new one. By using `insert_or_assign`, the newer value replaces the old one. Bug: 1140358, 1134119 Change-Id: I933ec47a1da596f58fa99d5b9bc481954122c2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489899Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820165}
-
Hirokazu Honda authored
This adds WARN_UNUSED_RESULT to VaapiWrapper functions whose result should have the critical impact enough to regard its failure as video processing fatal. VaapiVideoDecoder actually doesn't handle the failure of VaapiWrapper::CreateContext. This CL also fixes it. Bug: b:171536540 Test: Build media_unittest and vaapi_unittest Change-Id: Iba6924849bfe8627fd328c3541c7a2c5cb0f0371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493742 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#820164}
-
sandromaggi authored
This can be used for sending keypresses instead of a click. This is intended for experimentation and not to be exposed to scripters directly. Bug: b/171280538 Change-Id: I83b4053cbc29f03ce2a2158ffefee8cf1f200e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484423 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820163}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2e5b59565826..6b3c8d667a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I57edfcc86c667f0ff4555b9a9ac192a3d57e4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493417Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820162}
-
Jiawei Shao authored
This patch adds a temporary command line parameter to allow the developers testing the performance of WebGPU with and without the robust buffer access pass in Dawn. BUG=dawn:480 Change-Id: I9ad312115e718d97cc9b89c0f20edf8aa0212518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490208Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#820161}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c97292f87f01..9a16bdb16349 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1126301,chromium:1130697,chromium:1138657,chromium:1141430 Tbr: kinuko@google.com Change-Id: I34f46b41837e271e713d6592c33b14e112a7786f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820160}
-
Ricky Liang authored
This reverts commit 8b1af9e8. Reason for revert: broke MSAN test on blink_platform_unittests Original change's description: > [VideoCapture] Handle GPU context lost for the zero-copy path > > When the render thread encounters GPU context lost, we need to re-create > the SharedImage resources to recover the video capture stream. > > Bug: 1131998, b:169429427 > Test: Manually with chrome://gpuclean on soraka > Change-Id: Ie6306653e779885fbf131c9964ae8ed90493ac76 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455328 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Ricky Liang <jcliang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820061} TBR=jcliang@chromium.org,ccameron@chromium.org,kbr@chromium.org,dcastagna@chromium.org,guidou@chromium.org,ccameron@google.com Change-Id: I06750ff6206af29192e0acf01fae1ded897e47a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131998 Bug: b:169429427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494193Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820159}
-
Makoto Shimazu authored
There's a bug that AddControllee and RemoveControllee don't match. This is a workaround to avoid notifying the mismatching OnControlleeRemoved. Bug: 1021718, 1015692, 1088353 Change-Id: I901de49164a650409275e43d51440ae58b5286be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493961 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820158}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2e5b59565826..6b3c8d667a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I02842b598288f6e3d5cfbdc7b03d70c0f77c5fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820157}
-
Chong Gu authored
Create _DEVICE_FINDER_TIMEOUT_LIMIT variable. Bug: 1080853 Change-Id: I21fb1ec1dcd462b005f76cd9287b7b400a0c83ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489323Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#820156}
-
Mugdha Lakhani authored
This does the remaining work to add BackgroundSync support. An end to end browsertest has been added to verify the registration + sync event firing. Also, manually tested using the site: https://webplatformapis.com/one_off_sync/one_off_sync.html Note that WebLayer doesn't yet wake the browser up to fire sync events, as the only user of WebLayer doesn't need this functionality. Bug: 1087486 Change-Id: Iceb8c3a4cbcf4f0f8611905b07c950ac069eb6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476282Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#820155}
-
Koji Ishii authored
This patch is a re-fix of r819722 <crrev.com/c/2489730>. It turned out that |NGLineBreaker| hangs the attached test case before r819722, and crashes after. This is because |Rewind| may fail if the line has floats, and in that case, the current item is not a text item. This patch changes it to just setting the state to |kTrailing| and return, so that, if |Rewind| succeeds, |BreakLine| will call |HandleText|, which will call |HandleTrailingSpaces| when the text item starts with spaces. When |Rewind| fails, |BreakLine| can handle non-text items too. Bug: 1141384 Change-Id: I96e428d2c9ff50b3685c2a83eafdcea509749594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492700Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#820154}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/74711eb54218..6abe5ba13913 2020-10-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-23 jalyn@microsoft.com Reland "Settings: Remove old ShortcutsScreen" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I343099f3d3214d515ebcf7e4af67a245f2160c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820153}
-
Hiroki Nakagawa authored
Before this CL, we called the navigation to prerendered contents "swap". However, we decided to consistently call it "activate". This CL replaces existing usage. Bug: 1132746 Change-Id: I4c45b177ceccda4732023ea529e8aeb3a3b0c16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494201Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#820152}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2ce1d927e98a..ade9a5235c73 2020-10-22 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8f7c80347dc6 to 88d705dc85ff (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: If0f17e3ce868e598e7d14effb356bb4cb14c7426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820151}
-
Maggie Cai authored
This CL updates the naming NATIVE_CHROME to CHROME for PreferredPlatform to make the language inclusive. TBR=djacobo@chromium.org Bug: 1097644 Change-Id: I53f160583f010dd612ea0f71e0f8992d679bc7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494262 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820150}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7bc3356fbcb9..871500da9041 2020-10-22 mbonadei@webrtc.org Trigger bots. 2020-10-22 jakobi@webrtc.org Revert "Default enable WebRTC-SendSideBwe-WithOverhead." 2020-10-22 sprang@webrtc.org Makes aborting probes after a > 10ms scheduling timeout the default. 2020-10-22 jakobi@webrtc.org Default enable WebRTC-SendSideBwe-WithOverhead. 2020-10-22 hta@webrtc.org Move initialization of WebRtcSessionDescriptionFactory to SdpHandler 2020-10-22 Byoungchan Lee Reland "Remove placeholder Obj-C headers and use angle-bracketed headers." 2020-10-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5ce796bc..1fe005a7 (819379:819750) 2020-10-22 mbonadei@webrtc.org Trigger bots. 2020-10-21 deadbeef@webrtc.org Avoid duplicate usrsctp_init if the last usrsctp_finish failed. 2020-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bdce889..5ce796bc (819224:819379) 2020-10-21 perkj@webrtc.org Offer VideoLayersAllocation if field trial enabled 2020-10-21 alessiob@webrtc.org RNN VAD: LP residual optimized (part 2) 2020-10-21 philipp.hancke@googlemail.com doc: move bug reporting instructions to the repository 2020-10-21 alessiob@webrtc.org RNN VAD: LP residual optimized (part 1) 2020-10-21 gustaf@webrtc.org AEC3: Prevent transparent mode from leaking low volume echo 2020-10-21 hta@webrtc.org Make WebRtcSessionDescriptionFactory depend on SdpOfferAnswerHandler 2020-10-21 hta@webrtc.org Remove friendship between PeerConnection and SdpOfferAnswerHandler 2020-10-21 alessiob@webrtc.org rtc::ArrayView reverse iterators 2020-10-21 philipp.hancke@googlemail.com Reland "introduce an unsupported content description type" 2020-10-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e057d1b..4bdce889 (819118:819224) 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cbcae3bb..9e057d1b (818998:819118) 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a07e999..cbcae3bb (818869:818998) 2020-10-20 hta@webrtc.org Delete the "initialize" method of PeerConnectionFactory 2020-10-20 danilchap@webrtc.org In Vp9 wrapper allow to use ScalableVideoController with simulcast structures 2020-10-20 olka@webrtc.org Cleanup after sorting out dependencies of OutputRateCalculator 2020-10-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5939e063..0a07e999 (818652:818869) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138878,chromium:1140452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd8850052cd3991310c9d21f603f707be28c2bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493097Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820149}
-
dpapad authored
This will be leveraged in follow up CLs, to auto-generate parts of webui_resources.grd. Bug: 1132403 Change-Id: I5bd5f8a411c2cbc1f023220a779d74be209e902c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489920Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#820148}
-
Anne Lim authored
Screenshot with feature enabled in light mode: https://screenshot.googleplex.com/BhwpMvUVBhWh4rD Screenshot with feature enabled in dark mode: https://screenshot.googleplex.com/5qyLr4ZMHm3HQLx Bug: 1135847 Change-Id: I6010f72c413b8c33814f178545861081fab2b32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469363 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820147}
-
yiyix authored
The CanvasImageProvider in CanvasResourceProvider keeps a set of images locked, up till a certain budget, since continuous lock/unlock with GPU discardable caused a regression with cases of repeated draws with the same image. Locked_image is added to solve this issue. However, it causes a big overhead to maintain the set of images or to track these images externally. It also causes bugs on memory leakage and other areas. So that the benefits it adds are diminished. In this cl, I am removing the locked_images logic from the code. Bug: 927834 Change-Id: I9425cc3dc9ff862b84d8a524d50841e05f44acae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422584 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#820146}
-
Yu Su authored
- remove the temporary implementation for shopping menu item with Prime - delete #classifyImage from LensController. The clank implementation is deleted in https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3355632 Change-Id: I4d772729c77f20f8a693f23aa30618c212ac5037 Bug: b/171421941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493002 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#820145}
-
Melissa Zhang authored
This CL adds a label when there are no targets in the sharesheet. Waiting on mocks for label typography which will be updated in a follow up CL. This CL also switches main_view grid layout to boxlayout for simplicity. Bug: 1138037 Change-Id: Iebec778996c1db648a7fe7880f637dea554c6293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487743 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#820144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/53281c712159..734a27a2f391 2020-10-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 502ec4ce to e47bf15e (424 revisions) 2020-10-22 johnstiles@google.com Allow SkSL compilers to reuse SkSL Pools without reallocating. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I9779f497757ef51be869a43a6dc482e29f302201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493732Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820143}
-
Renato Silva authored
Update PIN Autosubmit policy to reflect that it only works with PINs that are between 6 to 12 digits long. Change-Id: I0979f8da62199832420e787ded4253705b0f3976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490521Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#820142}
-
Ryan Hansberry authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/13e275d7e504..acf8878dcf83 $ git log 13e275d7e..acf8878dc --date=short --no-merges --format='%ad %ae %s' 2020-10-01 dlunev cryptohome: Have a specific error for vault recreation trigger. 2020-10-20 mcchou system_api: bluetooth: Add ConnectDevice method constant 2020-10-02 cherieccy system_api: Add GenerateVirtualFileId and OpenFileById to VirtualFileProvider Created with: roll-dep src/third_party/cros_system_api Bug: 1140471 Change-Id: Id9e38673017c7e01fc7f7be6f45504d3e98d4f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492967 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#820141}
-