- 05 May, 2014 40 commits
-
-
kuan@chromium.org authored
5f27b684f7: debugging mechanism for processing of next/prev page links - for easier debugging, disable next-page links in chrome viewer 7a12a9972b: recognize and parse OpenGraph Protocol Markup 0dcb6d78f6: recognize and parse IE Reading View Markup 8fe69642d3: recognize and parse Schema.org Markup feccd237e1: composite MarkupParser that requests properties from the above 3 parsers and expose them to chrome viewer BUG=356336, 362085, 364356 NOTRY=true Review URL: https://codereview.chromium.org/266823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268317 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=370168 NOTRY=true TBR=mfomitchev@chromium.org Review URL: https://codereview.chromium.org/266723017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268316 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Make its current clients use base/macros.h and stdint.h instead. No behavior change. BUG=138542 NOTRY=true Review URL: https://codereview.chromium.org/268063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268315 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
BUG=351959 Review URL: https://codereview.chromium.org/265073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268314 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
Page IDs are not safe to use on their own, without knowing which SiteInstance they correspond to. BUG=369661 TEST=Dead code, no behavior change. TBR=jam TBR=mkosiba Review URL: https://codereview.chromium.org/266053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268312 0039d316-1c4b-4281-b951-d872f2087c98
-
pvalenzuela@chromium.org authored
Note: this is a second go-round for this CL. It was originally committed as r267422 but was reverted due to a compile error in some dead code. The dead code was deleted in https://codereview.chromium.org/264773007/ (r267686). See https://codereview.chromium.org/234113002/ for the original CL. This CL creates a new InvalidationService implementation, FakeServerInvalidationService, to remove FakeServer-based tests' dependency on the Python XMPP server. Another major change is that FakeServer's HandleCommand is now executed on the UI thread and locking has been removed from FakeServer itself. BUG=323265 Review URL: https://codereview.chromium.org/267723012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268311 0039d316-1c4b-4281-b951-d872f2087c98
-
sebmarchand@chromium.org authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/263263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268310 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
Most of these are already implemented in WebWidget to do nothing so not need to override anymore. isAcceleratedCompositingActive() is no longer called so remove it. Depends on: https://codereview.chromium.org/267863007/ R=jbauman, piman BUG= Review URL: https://codereview.chromium.org/263823008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268309 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@chromium.org authored
This allows PDF to be run in incognito mode but changing the incognito manifest key to "split". This causes a new process to be loaded for the extension in incognito. This is a requirement for doing top level navigations to an extension in incognito mode as per https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser/extension_protocols.cc&rcl=1399166280&l=287 BUG=303491 Review URL: https://codereview.chromium.org/268963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268308 0039d316-1c4b-4281-b951-d872f2087c98
-
pearlchen@chromium.org authored
(1) The filename of a <pre> block is now hidden until hover. This fixes the data-filename grey box covering code when the first 1-2 lines of code are long. (2) In <pre> blocks, <b> and <strike> are more visible (3) Size of text bumped down slightly to fit more code in but still remain legible. (4) Text in <pre> blocks no longer wrap and horizontal scroll is enabled when a line of code is too long. BUG=none Review URL: https://codereview.chromium.org/269983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268307 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=None TEST=None TBR=sky Review URL: https://codereview.chromium.org/265333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268306 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
H264AnnexBBitstreamConverter has a bunch of parsing code that essentially duplicates what is in AVCDecoderConfigurationRecord. This change removes the duplicate code so that the same logic is used by H264AnnexBBitstreamConverter and the MP4StreamParser. BUG=364925 TESTS=All existing tests still pass. Review URL: https://codereview.chromium.org/264743016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268305 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268304 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
https://code.google.com/p/skia/source/list?num=6&start=14573 TBR= BUG= Review URL: https://codereview.chromium.org/268183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268303 0039d316-1c4b-4281-b951-d872f2087c98
-
robliao@chromium.org authored
Refactored the attempt manager to use a more obvious naming scheme as well as participate in promises for retries. This also entailed reexamination of all attempt managers in Chrome Now. Opt-in checking as a result became a first class state change citizen and is no longer part of the card checking pipeline, fixing a few opt-in aggression issues. With this change, we don't care how often a push message comes through that may indicate that Google Now is enabled. BUG=360649,362306 Review URL: https://codereview.chromium.org/248473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268302 0039d316-1c4b-4281-b951-d872f2087c98
-
armansito@chromium.org authored
This CL implements the getCharacteristic method of the bluetoothLowEnergy API. In addition, the instance ID mapping has been simplified by removing BluetoothLowEnergyEventRouter::GattObjectData and keeping string to string mappings, e.g. service ID -> device address, characteristic ID -> service ID, etc. Also added is a browser test for characteristic properties. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Review URL: https://codereview.chromium.org/262053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268301 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268300 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
Changes that affect chrome: - Changed local variable type from int to size_t. This fixes compiler warning to unblock env_chromium_unittests change: https://codereview.chromium.org/213303002 BUG= Review URL: https://codereview.chromium.org/264773009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268299 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Fix build error which occurs due to an incorrectly referenced member variable in the MetricsStateManager class. BUG=368413 R=asvitkine@chromium.org, miu@chromium.org, miu Review URL: https://codereview.chromium.org/266213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268296 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Caused build breakage because static initializer was added to ppb_nacl_private_impl.cc. Candidate (line 96): + const int32_t kPNaClManifestId = std::numeric_limits<int32_t>::max(); > Pepper: Move manifest logic to components/nacl. > > The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal. > > BUG=353592 > R=bbudge@chromium.org, mallinath@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268250 > > Review URL: https://codereview.chromium.org/264943003 TBR=teravest@chromium.org Review URL: https://codereview.chromium.org/265393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268295 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
These names get expanded twice into the pathnames of some built files which in some cases cause them to exceed Windows' MAX_PATH limit and kill the build. This reduces those path lengths by ~20 chars. e.g. ../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d becomes ../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_aot.gen/pnacl_newlib_x86_32-nonsfi/shim_aot/irt_shim_ppapi.o.d R=binji@chromium.org, dyen@chromium.org, mseaborn@chromium.org, teravest@chromium.org BUG=https://code.google.com/p/nativeclient/issues/detail?id=3846 Review URL: https://codereview.chromium.org/263083012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268292 0039d316-1c4b-4281-b951-d872f2087c98
-
mfomitchev@chromium.org authored
The ash/ part of the implementation of the Touch Exploration Mode. This is dependent on Part I: https://codereview.chromium.org/262483003/ BUG=368828 Review URL: https://codereview.chromium.org/261863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268291 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/266723016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268290 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268289 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173313:173328&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/269083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268287 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
Also move hpack fuzz targets to build on mac & win, and tweak fuzzer tools to build on win. Re-applied patch from issue 266003005. TESTED=Manually built on windows. BUG=353237 Review URL: https://codereview.chromium.org/268943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268286 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Chrome on iOS always need to have a BookmarkUndoService installed as an observer to all the BookmarkModel (there is no command-line switch on iOS). BUG=364044 Review URL: https://codereview.chromium.org/265743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268284 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Chrome on iOS does not support the clipboard, so install overrides that disable the clipboard on iOS and disable the corresponding unit tests. BUG=228147 Review URL: https://codereview.chromium.org/261013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268283 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
Those files are used by a lot of tests and do not depends on chrome/ or content/ so they can be moved to the component in a new library that will be used by the test (eventually components_unittests). BUG=367839 Review URL: https://codereview.chromium.org/268673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268282 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
BUG=364468 Review URL: https://codereview.chromium.org/261013008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268281 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal. BUG=353592 R=bbudge@chromium.org, mallinath@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268250 Review URL: https://codereview.chromium.org/264943003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268280 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=367863 Review URL: https://codereview.chromium.org/257193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268279 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
In version 2 of the API, initialize() returns the list of supported key types and add() expects one of these key types to be specified. At the moment, the only supported key type is KEY_TYPE_PASSWORD_PLAIN but this can now be expanded without changing the API. BUG=367847 TEST=Extended browser test Review URL: https://codereview.chromium.org/258123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268278 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
This call is no longer used after WebUI NTP was removed. BUG=284770 Review URL: https://codereview.chromium.org/263803006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268277 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
all their data(profile), too. If checked, user will be prompted again to confirm profile deletion. BUG=363272 NOTRY=true Review URL: https://codereview.chromium.org/235943011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268276 0039d316-1c4b-4281-b951-d872f2087c98
-
bolian@chromium.org authored
BUG=355604 Review URL: https://codereview.chromium.org/257663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268275 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268271 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Caused compile errors on Android GN bot. > Add flac into root BUILD.gn > > All hail GN. oRZ > > BUG=none > > Review URL: https://codereview.chromium.org/263503003 TBR=ajwong@chromium.org Review URL: https://codereview.chromium.org/264173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268270 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
This reverts commit da22c3c9. TBR=japhet@chromium.org BUG=364781 Review URL: https://codereview.chromium.org/268783004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268268 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
The change added a static initializer, breaking the build: ppb_nacl_private_impl.cc nacl::(anonymous namespace)::kPNaClManifestId > Pepper: Move manifest logic to components/nacl. > > The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal. > > BUG=353592 > R=bbudge@chromium.org, mallinath@chromium.org > > Review URL: https://codereview.chromium.org/264943003 R=teravest@chromium.org TBR=teravest@chromium.org Review URL: https://codereview.chromium.org/264143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268267 0039d316-1c4b-4281-b951-d872f2087c98
-