- 26 Sep, 2018 40 commits
-
-
Samuel Huang authored
Under diff mode, previously the HTML Viewer would report very large method (delta) counts. This was caused by the Python code assigning a delta count of 1 (instead of 0) for changed symbols. Moreover, to support delta count of 0, the JavaScript code change needs to be updated to read it (i.e., cannot use "||" to assign defaults). This CL fixes the above problems. Moreover, to reduce .ndjson file size, 0 is used as the default symbol count under diff mode (1 is still the defalut if one .size file is used to generate the .ndjson file). Bug: 884985 Change-Id: I8038f8b8298073c8ced5ccf9100cf9911e533861 Reviewed-on: https://chromium-review.googlesource.com/1246280Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#594431}
-
Xiyuan Xia authored
This is a reland of 23066c81 Original change's description: > Enable more content_browsertests tests > > After crrev.com/c/1233174, failures/time outs in the associated > bugs are gone. Enable more tests in single process mash. > > Bug: 877496, 884389, 884393 > Change-Id: I35a96699fbee450e0522ff84267842e96fb7c29c > Reviewed-on: https://chromium-review.googlesource.com/1243194 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594046} Bug: 877496, 884389, 884393 Change-Id: If452611db11c3b5e6f92e66e9a1f6890acac52f7 Reviewed-on: https://chromium-review.googlesource.com/1246152Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594430}
-
Weiliang Chen authored
Remove SkiaRenderer's bool that tracks whether we are drawing root render pass or child render pass. Also leads to deleting function on SkiaOutputSurface since it knows the current render pass id and both functions share majority of code. Bug: 644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I332012ed89f5edc825acaee4230f28bdfc271044 Reviewed-on: https://chromium-review.googlesource.com/1241734 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#594429}
-
Aleks Totic authored
The crash trigger was Legacy and NG painting the same float. This is how it happens: NGBlockNode::CopyChildFragmentPosition adds float to ContainingBlock() float list. Float might propagate to ContainingBlock()'s ancestor and set the ShouldPaint() flag. How this happens is still mysterious to me, the obvious suspect UpdateAncestorShouldPaintFloatingObject does not get called. NG will paint the float if ContainingBlock has PaintFragment(). My fix is a bit of a hack: in Legacy, if we know that float will get painted by NG, do not paint it. This fixes the crash. Test still fails, but that is block layout algorithm problem. Bug: 864398 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ebe82a2188baaa076476e4f5cbd78bab7127875 Reviewed-on: https://chromium-review.googlesource.com/1244246 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594428}
-
chcunningham authored
Metrics show that the DB makes its best predictions for a given key after accumulating ~2500 frames. With this change rows in the DB will begin to down-weight the existing frames after reaching the 2500 frame max. New appends of more than 2500 frames will completely flush out old stats. This roughly approximates a sliding window of the last 2500 frames without adding complexity to the DB of a real sliding window. This change also expires old statistics that have not received an update in the last 30 days. This ensures that clients who have a bad outlier decode performance aren't punished forever - otherwise sites may never give them another chance at that resolution / frame-rate. Change-Id: I82f6920fbe3f594dad36d35b12c55d32e65de5a6 Bug: 818889 Test: New unit tests Reviewed-on: https://chromium-review.googlesource.com/1113503 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#594427}
-
Aaron Colwell authored
Change-Id: Ie3062d15c52cc7c7ddc4a293f53f22c9ec47a8fc Reviewed-on: https://chromium-review.googlesource.com/1243409Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#594426}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/16285b48a4d5..74114507769e git log 16285b48a4d5..74114507769e --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@google.com generic_stage: Stop crashing on poor CIDB slave status. Created with: gclient setdep -r src/third_party/chromite@74114507769e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id10f28aa2ab83258a49244834db17adbaa50cb99 Reviewed-on: https://chromium-review.googlesource.com/1246230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594425}
-
Rouslan Solomakhin authored
Before this patch, Chrome Custom Tab would always be 100% height in all cases, including for showing a Payment Handler page. This hid the shop page from the user and increased the chance of the shop page renderer being killed. This patch adds a PaymentHandlerActivity that extends CustomTabActivity with a custom theme that has transparent background. The PaymentHandler-specific functionality is moved from CustomTabActivity into the PaymentHandlerActivity. This activity is 70% of the display height ("bottom sheet"), unless that's less than 500dp, in which case the height is 500dp. If a device rotates, the window is either in bottom sheet or fullscreen mode, depending on the amount of available vertical space. The underlying activity is dimmed by DimmingDialog, which is a fullscreen semi-transparent dialog. This was refactored out of PaymentRequestUI, which now uses the DimmingDialog and optionally adds opaque content at the bottom. After this patch, payment handlers are displayed in a bottom sheet with dimmed background. Bug: 872833 Change-Id: I4c104373f3e44130d1217cbf2c6923be3b63d1a1 Reviewed-on: https://chromium-review.googlesource.com/1169636 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:Peter Conn <peconn@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594424}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09a2951f46c3..620aaef23380 git log 09a2951f46c3..620aaef23380 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dproy@google.com Merge "Fix crash when chrome trace opened after android" Created with: gclient setdep -r src/third_party/perfetto@620aaef23380 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If5227f79b4ed7af4922f3164ce0b38be9eeeddf9 Reviewed-on: https://chromium-review.googlesource.com/1246233Reviewed-by:
-
Evan Stade authored
IndexedDBDispatcherHostTest.NotifyIndexedDBContentChanged is flaky. TBR=dmurph@chromium.org Bug: 879213 Change-Id: I933e46c2ec3df71920a1f7f809b80c300f19f80c Reviewed-on: https://chromium-review.googlesource.com/1246823Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#594422}
-
Justin DeWitt authored
This adds the Material icons we intend to use if the categories are not yet available - mostly if the user is offline during the First Run experience, or if the sqlite DB got corrupted for some reason. Bug: 888176 Change-Id: I2dcc31ae2b5afbe55561a389296239ba4c566a1c Reviewed-on: https://chromium-review.googlesource.com/1244737 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#594421}
-
Robbie McElrath authored
This migrates ReadingListDownloadService from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 887057 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: Ic86d3bca9b77a53f97e9039fa35369a8fa9968b1 Reviewed-on: https://chromium-review.googlesource.com/1239339Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#594420}
-
Kevin Marshall authored
Reland of CL https://chromium-review.googlesource.com/c/chromium/src/+/1241842. (Confirmed that the code builds on Cast builders, and manually examined all references to targets under //third_party/fuchsia-sdk to verify that all FIDL targets have been modified to reference the new sdk/ subdir.) This script uses the metadata JSON files in the SDK to generate a BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is regenerated whenever a new SDK is downloaded using "gclient sync". Only FIDL libraries are migrated for now. Additional metadata types can be migrated in followup CLs. TBR=scottmg@chromium.org TBR=sky@chromium.org Bug: 888753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7ec714982cdfbb6f6ccd8fad3cd7cbb48af4eb1c Reviewed-on: https://chromium-review.googlesource.com/1246681 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594419}
-
Simeon Anfinrud authored
This will allow other Observables and potentially others to use Sequencer. Added tests. Improved the efficiency of Sequencer. The old version used recursion heavily, which meant that the stack could grow arbitrarily large. The new version flattens the stack and avoids wrapping Runnables in other Runnables, saving both stack and heap space. Bug: None Test: cast_base_junit_tests Change-Id: I401a6fac6f2029e7d2744a459e03c64dd7a311ee Reviewed-on: https://chromium-review.googlesource.com/1187633Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594418}
-
David Tseng authored
This aligns us more closely with how TalkBack treats clickables. Note that at the moment, only ARC++ sets the |clickable| property. Bug: b:111083342 Change-Id: Ida5383ee34ae30b8d01a556c48044096a909eac4 Reviewed-on: https://chromium-review.googlesource.com/1243670 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#594417}
-
Marcin Wiacek authored
Change-Id: Ib0054cbbfd7eb07c59e27e32d9dbd3d2b636c277 Reviewed-on: https://chromium-review.googlesource.com/1244242Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#594416}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba614d6f..2012676a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic901ca66fbccf5dc5480dc459cab7c78fbbf35db Reviewed-on: https://chromium-review.googlesource.com/1246293Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594415}
-
Vladislav Kaznacheev authored
Contacts app is currently filtered out on the container side, which makes it completely inaccessible to Chrome. However, Contacts can still show up in system UI (when searching for app shortcuts, in Shelf when launched through Play Store or an intent). Bug: b:116356923 Test: set enable-app-shortcut-search, enter "cont" in the search box, observe that "Add contact" shortcut is badged with the Contacts icon and opens Contacts when clicked. Change-Id: Id0a108cd08024fd92b779c953c211cafb4445130 Reviewed-on: https://chromium-review.googlesource.com/1246287Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#594414}
-
Dominik Laskowski authored
This CL adds a remote-shell event to plumb more display information, namely the size in pixels and the EDID blob. Bug: b:77972358 Bug: b:112480270 Test: Print size and EDID in HWC. Change-Id: Ie254184033ae9426300962c474c1e40b40fad6c8 Reviewed-on: https://chromium-review.googlesource.com/1238564Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#594413}
-
Lei Zhang authored
Make them available to other unit tests. This time, add build dependencies for the "pdf_test_utils" source_set. Change-Id: I75a1665c61e77032f218686f272e3788cb059474 Reviewed-on: https://chromium-review.googlesource.com/1246682Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594412}
-
Aldo Culquicondor authored
The default implementation supports the GL tests to run on MSan successfully. Bug: 889186 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6d0f7bef6ddba8a2b508d1fd0c732dac1fb31205 Reviewed-on: https://chromium-review.googlesource.com/1246292Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#594411}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/90b47106a6e1..03a36fd1b06d git log 90b47106a6e1..03a36fd1b06d --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d73b871379e0..96a1ceb171cf (1 commits) 2018-09-26 stephana@google.com [infra] Upgrade Go to 1.11 2018-09-26 robertphillips@google.com Work around MSVC issue on older tool chains 2018-09-26 fmalita@chromium.org [skottie] Add a property setter sample/GM 2018-09-26 allanmac@google.com Updates for Vulkan AMD GCN Created with: gclient setdep -r src/third_party/skia@03a36fd1b06d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ic6c9263eb23b0948f7926bd79811498f1e64b0d2 Reviewed-on: https://chromium-review.googlesource.com/1246227Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4977a156c2fc..9a53f1444701 Created with: gclient setdep -r src-internal@9a53f1444701 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia2ad4c4c0705671dbe131256d1f62e221b4e7a92 Reviewed-on: https://chromium-review.googlesource.com/1246229Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594409}
-
chrome://dinoEdward Jung authored
Bug: 846473 Change-Id: I46923a902045b531578439e73068c0fd93c66691 Reviewed-on: https://chromium-review.googlesource.com/1240301Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#594408}
-
Xiaoqian Dai authored
Changes in this CL: - Remove have_seen_accelerometer_data_ variable. As this variable is not set if the device doesn't have kAshEnableTabletMode flag. - Only observe the display/lid/input device events if the ui mode is allowed to be changed. No functionality is changed in this CL. Bug: 887042 Change-Id: Ic42d4cc0c25667e7aa67efcf26f65032082db126 Reviewed-on: https://chromium-review.googlesource.com/1244289Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594407}
-
Khushal authored
This reverts commit 2b62fe72. Reason for revert: The change did not fix any crashes. Original change's description: > gpu: Expand oopr workaround to fallback to ES2 to all android versions. > > Temporarily make sure we always fallback to using ES2 for all android > versions to understand whether a particular crash spike associated with > the oopr experiment is a result of oopr enabling ES3 for skia. > > R=ericrk@chromium.org > > Bug: 884659 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If5668a65d967294d07687f8d09a114153aa0d09f > Reviewed-on: https://chromium-review.googlesource.com/1232198 > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592248} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884659 Change-Id: Ibf107c8e5c9bd42273393c8c8389f1cbd431d0fb Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1246298Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#594406}
-
Vladimir Levin authored
This patch converts a bool that indicates that we must do a subtree update of paint properties to a bitmask of reasons. The intent is to be able to clear some of the reasons when doing a prepaint walk, avoid some unnecessary work. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I32f1c905ba5648b34d9e544a7291817dc8b02ae7 Reviewed-on: https://chromium-review.googlesource.com/1244336 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594405}
-
Yiming Zhou authored
This change adds support for pre-recorded address and payment in Autofill Capture Site Tests. A recent change, 5e3e7faf, allows the Action Recorder Extension to record a user's saved address and payment information when recording a test recipe. This change completes the cycle by allowing the automation test framework to set up the saved address and payment information contained in a test recipe. Bug: 847905 Change-Id: I6a5b9cc246dc59cbab4e4e0c6362c148e1820a14 Reviewed-on: https://chromium-review.googlesource.com/1241756Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#594404}
-
Mugdha Lakhani authored
content setting out of the decision on whether we can start Background Fetch. For details, see this doc: https://docs.google.com/document/d/1rPYSlbzScw_6PLUJ3m96ZLIkxXVAWyBSL75-VDJEMso/edit?usp=sharing Bug: 886896 Change-Id: Ie6ba2ad6b906ab136eb65b846e67d34bad41e7e6 Reviewed-on: https://chromium-review.googlesource.com/1245799 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594403}
-
Marcin Wiacek authored
Change-Id: I786ced74864fa3a26f9ebebc2d481c0a3ddc0871 Reviewed-on: https://chromium-review.googlesource.com/1244439Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/903514f95445..b07993ebf420 git log 903514f95445..b07993ebf420 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dj2@everburning.com Remove SetContextMessageConsumer from markv_codec_test (#1926) 2018-09-26 dj2@everburning.com Remove stats use of internal API (#1924) 2018-09-26 stevenperron@google.com Allow 0 as argument to scalar replacement. (#1917) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b07993ebf420 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I82ff2543a0bf7dd393cc6ef9d5fe4c8e89cb47b7 Reviewed-on: https://chromium-review.googlesource.com/1246231Reviewed-by:
-
Lukasz Anforowicz authored
As explained in https://crbug.com/889301#c5, the test failure in single_process_mash_content_browsertests on linux-chromeos-rel is already expected and covered by an entry in //testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter: -SitePerProcessBrowserTest.* Therefore, there is no point in additionally disabling the test via //content/browser/site_per_process_browsertest.cc Bug: 889301 Change-Id: Id86d39792939c06b2972443ea8caecad774ee6e1 Reviewed-on: https://chromium-review.googlesource.com/1246285Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#594400}
-
Christian Biesinger authored
This reverts commit d572ce1d. Reason for revert: Caused regression crbug.com/889435 Original change's description: > [css-flex] Update to newer spec about definite flex item sizes > > Implements this change: > https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 > > external/wpt/css/css-flexbox/percentage-heights-003.html ostensibly tests > this, but I don't think the test is correct (and we don't pass it) > > TESTED=css3/flexbox/definite-main-size.html > > Bug: 784059 > Change-Id: I8ee0ee797b54a8166849ab6e9b9f019b9e43760b > Reviewed-on: https://chromium-review.googlesource.com/1240871 > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593707} TBR=cbiesinger@chromium.org,dgrogan@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 784059,889435 Change-Id: Ia74fb5cf500aebcb876672497cce5295b0959b43 Reviewed-on: https://chromium-review.googlesource.com/1246291 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594399}
-
Tibor Goldschwendt authored
Bug: 862689 Change-Id: If9713d4a079965047df35a8f5a4e93adf7e390bf Reviewed-on: https://chromium-review.googlesource.com/1246299Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594398}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8498332d304e..3cf15a9b47a0 git log 8498332d304e..3cf15a9b47a0 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 benjhayden@chromium.org Fix links in tracing/docs/ Created with: gclient setdep -r src/third_party/catapult@3cf15a9b47a0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9c56697c0f15c753c72ee9b24fe760effc873a8d Reviewed-on: https://chromium-review.googlesource.com/1246226Reviewed-by:
-
Jacob Dufault authored
Focus would move from the bubble dialog to lock contents view, which would then try to focus the auth user, which was a stale pointer that had been deleted. Bug: 884402 Change-Id: I72d729642f819d4ab2aa23c1e71edc6e851ae5ff Reviewed-on: https://chromium-review.googlesource.com/1239512 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594396}
-
Koji Ishii authored
This patch fixes: 1. ::first-line style is not applied when there are other anonymous inline boxes. 2. Inspector getPlatformFonts protocol collects fonts from two levels deep. Changed the logic not to include anonymous boxes to the depth limit. Also the incorrect expectation was fixed; legacy counts glyphs in ::first-letter twice. Bug: 636993, 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia028710b728e8e9172b540a46b42d804c9f57699 Reviewed-on: https://chromium-review.googlesource.com/1245078Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
This defines basic build targets for a Trichrome build using the upstream package names/configuration. The shared library APK contains the 32-bit version of libmonochrome.so and a few autogenerated Java pieces only at this stage, which means the total size of the three APKs is significantly larger than Monochrome at present. Bug: 887078 Change-Id: I3fcdfd6d7f717665a15c05dbb53602deda526b73 Reviewed-on: https://chromium-review.googlesource.com/1135546Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Dale Curtis authored
DecryptingDemuxerStream had no traces and the DecyrptingVideoDecoder had some old-style, incomplete traces. This adds traces to the former and expands the latter. Specifically we now have: - DecryptingDemuxerStream::DecryptPendingBuffer [async] - DecryptingDemuxerStream::WaitingForDecryptionKey [async] - DecryptingVideoDecoder::DecodePendingBuffer [async] - DecryptingVideoDecoder::WaitingForDecryptionKey [async] The DVD traces used to use a trace_id and provide a buffer size, but this isn't really necessary since the start trace is tagged correctly just by using |this| and providing the timestamp. BUG=879970 TEST=passes cq Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If21288e6c47414ec038f034bba381fcebf5ca99b Reviewed-on: https://chromium-review.googlesource.com/1244164Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594393}
-
Thoren Paulson authored
The generated serial is stored in SharedPreferences in order to keep it consistent between reboots. Bug: internal b/111077464 Test: look at logs Change-Id: If988936bedd4fe9a9946ef2671a747dfc622ecf7 Reviewed-on: https://chromium-review.googlesource.com/1237524 Commit-Queue: Thoren Paulson <thoren@chromium.org> Reviewed-by:
-
