GitLab

Introduce a new CustomViewBinder interface that allows
AppMenuPropertiesDelegates to handle binding for custom menu items.

This interface is used to provide a custom binder for the update menu
item, which relies on UpdateMenuItemHelper methods/classes that will not
be moved to the appmenu/ package when its modularized.

Bug: 966644
Change-Id: I6c49522775c1f0fca3cd64764a0eba6a5b82f3b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872980Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710895}

Clicks on the toolbar are currently passed through the url_bar behind it.
This leads to unexpected behavior when not user-visible views handle click events.
The change makes the toolbar intercept all click events on not user-visible views.

Accessibility is unaffected, see here: https://drive.google.com/file/d/1LDGfFfaCkg2meUNPX3211HE2_bIJGJNr/view?usp=sharing

Bug: 982018
Change-Id: Ibadba84a8f500cb7cf7aaa5129c91b11f2a5e9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887150Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mia Glaese <glamia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710894}

This involved updating the test fixture to use a different
mechanism because the execution of the JS script bodies via
ChromeEarlGrey injection hangs because of JS execution halts
while the dialogs are displayed.  Instead, there is now a
tappable link on the page that executes the dialog scripts
with a timeout so that the script execution can return while
the dialog is displayed.

Bug: 987646
Change-Id: Ifa90d923360ca03c686d662a7cc34575dff94037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883137
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710893}

We were missing a WaitForFirstVisuallyNonEmptyPaint in the test but
actually we can simplify it quite a bit as there is no need to put the
page in the bfcache to exercise the code under test.

Bug: 1019664
Change-Id: I1b714d77a4a4002ba8b3eae08ea881bcaad4b93e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890338Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#710892}

Change-Id: I0681b6feafe06b9434ea0df66ad0724f290aa17b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886897
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710891}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Convert BUILD.gn files below //base to instead use conditional
to include source files only on the platformn where they are
used.

The conversion was done by using a modified version of gn that
display all files filtered by set_sources_assignment_filter()
and updating the BUILD.gn files manually to explicitly add the
source files only on the platform that used them.

Bug: 1018739
Change-Id: I236542d7b8e2b5cba5b633b37791d1f1dbbe8d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879458
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710890}

This reverts commit 5f5c6c4b.

Reason for revert: As Boris points out in https://bugs.chromium.org/p/chromium/issues/detail?id=789531#c56 , my original revert was mistaken, it wasn't the offending CL, but rather was fixing the issue. Relanding.

Original change's description:
> Revert "[Android][Signin] Fix bookmark signin promo dismiss tests"
> 
> This reverts commit 04962c50.
> 
> Reason for revert: Test failures, see https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Tablet%20Tester/14131
> 
> Original change's description:
> > [Android][Signin] Fix bookmark signin promo dismiss tests
> > 
> > This CL fixes the bookmark signin promo tests when the promo is
> > dismissed in different scenarios.
> > 
> > Bug: 789531
> > Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628
> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Commit-Queue: Alice Wang <aliceywang@chromium.org>
> > Auto-Submit: Alice Wang <aliceywang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710784}
> 
> TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org
> 
> Change-Id: I68d849103de344e495520b8c015edfba75fd6388
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 789531
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890506
> Reviewed-by: Sky Malice <skym@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710853}

TBR=twellington@chromium.org,skym@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org

Change-Id: I43787dce3fd7d0004ef777b1724fec1935db0347
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891230Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710889}

-Add a flag to cr-searchable-dropdown so we can track whether the user's
 current text input in the dropdown matches the previously saved value.
 We use this flag to disable the printer add button if the user typed
 invalid input into either the Manufacturer or Model dropdown.

Fixed: 950887
Change-Id: I1f632b80fd8619718f13f8a5f5332ad7a62eb69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880181
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710888}

Bug: 932707
Change-Id: Ieb3cc5571e9e632cb451f317f87a59d912fd232a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887718Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710887}

BUG=None
R=fdoray@chromium.org

Change-Id: Ic566ca8d92ddaca27b127099f9437d0e0a4d6e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889973
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710886}

This reverts commit b936d5f1.

Reason for revert: Flaky crashes on webgl bot; see bug.

Original change's description:
> css/resolver: Refactor weaknesss in MatchedPropertiesCache
> 
> MatchedPropertiesCache was the single user of custom weakness using
> HashTraits. Supporting custom weakness in hash tables is responsible for
> a lot of complications in the tracing protocol.
> 
> MatchedPropertiesCache was using weakness to hold alive a cached entry as long
> as all of its matched properties are alive. Once a single matched property dies
> the entry was removed.
> 
> This can be modeled using a custom weakness callback that performs the same
> logic. Cached entry don't have any outgoing edges except for their cached
> matched properties, so ephemeron semantic is not required. Using a custom weak
> callback is also faster because the callback is only executed once and not part
> of the ephemeron fixed point protocol. The cached entry is unlinked using the weak callback and collected on next GC cylce.
> 
> After this conversion, custom weakness can be removed from hash traits.
> Weakness should always go through already supported types (e.g.
> WeakMember).
> 
> Bug: 1019191
> Change-Id: I52b7b24dcba8a3aaca896f86a351da665667fcf9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886611
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710693}

TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org

Change-Id: I30c098eb560e7fa62c6f5bd354188fc2a3eb2ab2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891190Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710885}

This change straightens out some of the convoluted logic in this method,
so that hopefully it is simpler and easier to understand.

Bug: None
Change-Id: I913e98c04c3f9f3a8c6727a25c6c0f4675695c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877664
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710884}

We'd like to turn off sequence manager anti-starvation logic but we
need to change this first to ensure the expected ordering of
PostTask and content::BrowserThread::DeleteSoon.

The observable difference is BrowserThread::GetCurrentThreadIdentifier
now inherits base::TaskPriority where previously it did not which is
dangerous.

Bug: 1013535, 1019767
Change-Id: I88cf03635b37f680f10b5aefd582afae35474a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886901Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710883}

This reverts commit fb7771dc.

Reason for revert: Long filenames excluded.

Original change's description:
> Revert "[CompositeAfterPaint] Rebaseline tests"
> 
> This reverts commit 9dc83eeb.
> 
> Reason for revert: causes bot_update failure on Win x64 Builder (dbg).
> 
> Sample build: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder%20%28dbg%29/99428
> 
> ---
> error: unable to create file third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance-with-scrollbar-expected.png: Filename too long
> ---
> 
> Original change's description:
> > [CompositeAfterPaint] Rebaseline tests
> > 
> > Most of these rebaselines are for the mock scrollbar change which missed
> > rebaselining for CAP.
> > 
> > The other rebaselines are for new tests added for
> > virtual/controls-refresh.
> > 
> > TBR=schenney@chromium.org
> > 
> > Change-Id: Ia710bd0bf371eae8367c1ee3739691985f314840
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888572
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710590}
> 
> TBR=wangxianzhu@chromium.org,schenney@chromium.org
> 
> Change-Id: Ic072356ff05e5c738f9b830a3ac398d0d8cb4f73
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889710
> Reviewed-by: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Cr-Commit-Position: refs/heads/master@{#710696}

TBR=wangxianzhu@chromium.org,tasak@google.com,schenney@chromium.org

Change-Id: Ia3500803eb9f24d078cc8919b453821147e3df9a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890950Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710882}

Now VisualViewport creates cc::Layers instead of GraphicsLayers, and
creates foreign layers directly during painting instead of by collecting
GraphicsLayers. This makes VisualViewport use the same code for CAP and
pre-CAP.

PaintLayerScrollableArea still uses GraphicsLayers which are created by
PaintLayerCompositor/CompositedLayerMapping.

GraphicsLayers created by PaintLayerCompositor/CompositedLayerMapping
no longer need to attach to VisualViewport which no longer creates
GraphicsLayers.

Bug: 1012594
Change-Id: I5ce76a3b5728d3810d85d536357cb437eea5fc4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869126
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710881}

Bug: 1019148
Change-Id: Ia49f1ac8317e4270225017231179b41fa3436d17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890495Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710880}

The hope is when we move to a more recent version of androidx we can
makes BrowserFragment package private (by way of FragmentFactory).
This patch removes the need to use BrowserFragment directly.

BUG=none
TEST=none

Change-Id: I7a4469fcf620f38c36c84a580cf4b8f666542c9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888389
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710879}

Uppercases every word in manufacturer names.
Also saves chromeos device model names as the family name(chromebook)
instead of model name(eve/sand).

Bug: 1016332
Change-Id: I8d088d1707156529abd1d5e254d7704c990662e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879228Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710878}

The feature has shipped, so we don't need the content flag any more.

Bug: 959850
Change-Id: I21ff38122377cd66fbb4740187d0877c9fb7e058
TBR: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873384
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710877}

We want to separate the HTTP auth cache by NetworkIsolationKey, as it
can be used for cross-site tracking. This will affect Enterprise more
then end users, so a (temporary) Enterprise opt-out seems warranted.

NOTRY: true
Bug: 993806
Change-Id: I96fdf314aadc5e68809f4dd34dfa2f90580d17ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869469
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710876}

Bug: 875486
Change-Id: I902d0e8246d01239f31d7cefc88be069bdc69756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846043
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710875}

Bug: 943901
Change-Id: Icae1e9ef4865230ee29f6fd031a5d939c13d9120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889292Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710874}

Bug: 995916
Change-Id: I7408905aa40e083c5dac81efc34bb87c45ffcb62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888375Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710873}

This prepares for blink::ScrollbarDisplayItem (for CompositeAfterPaint
composited scrollbars) which will share ownership of cc::Scrollbar
with cc's painted scrollbar layers.

Also make sure that cc::Scrollbar is accessed from the main-thread
only.

Bug: 931486
Change-Id: If64b14d8d917272873d35f33302ecbb66b20126b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884577Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710872}

Change-Id: I3c5f11a1d217b1c65af4b49a72d0fa31b9d3a862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890985
Commit-Queue: Luke Z <lpz@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Auto-Submit: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710871}

In certain cases, Gaia's /ListAccounts APIs claims accounts to be in a
valid state when they are actually invalid. This causes issues with
account reconciliation because |AccountReconcilor| uses /ListAccounts as
the source of truth and is unable to detect this state.
In this state, certain Google properties like Gmail for example send a
Mirror re-authentication header for the offending account. However, even
after the user re-authenticates the account, account reconciliation ends
up being a no-op because the reconcilor thinks that the user's cookies
are valid and there is nothing to reconcile.

Fix this by storing some flags in |CookieReminter| which are set when
we receive Mirror re-authentication headers from Gaia, and are cleared
when the next reconciliation cycle begins.

This is a temporary fix until we can submit https://crrev.com/c/1871591.

Bug: 1012649
Change-Id: I04fd971cdc788094f038ee808b4a38003ef48e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883652Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710870}

Bug: 876601
Change-Id: I0125dd4ac834b78d0809ae34eedc3e4183a4f968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872024Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710869}

https://android.googlesource.com/platform/external/perfetto.git/+log/0230acef3b45..fcfd69546437

git log 0230acef3b45..fcfd69546437 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 fmayer@google.com Merge "Block client for heapprofd CTS."
2019-10-30 taylori@google.com Merge "perfetto-ui: Add tabs to the details panel"
2019-10-30 hjd@google.com Merge "Fix use of NullTermStringView and enable test cases"
2019-10-30 hjd@google.com Merge "trace_processor: Add boiler plate for binder events"
2019-10-30 hjd@google.com Merge "Improve error for bad enums in txt format configs"

Created with:
  gclient setdep -r src/third_party/perfetto@fcfd69546437

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I844d3f9db3c8f054a9fa156d899a66df84c58278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890835Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710868}

https://skia.googlesource.com/skia.git/+log/7da048b5e8f1..a9ac8a51fdb3

git log 7da048b5e8f1..a9ac8a51fdb3 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 herb@google.com Change uses of code to glyphID
2019-10-30 senorblanco@chromium.org Dawn: s/dawn::/wgpu::/g.
2019-10-30 senorblanco@chromium.org Dawn: roll to ToT.
2019-10-30 robertphillips@google.com Allocate all vertex data in one go w/in GrTextureOp

Created with:
  gclient setdep -r src/third_party/skia@a9ac8a51fdb3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Ibd8226be682c2f0bab64a7d2b1171a981e9038a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890832Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710867}

Instead of forcing observers to be added and removed via AddObserver/
RemoveObserver, this allows ScopedObserver instances to define
their own method names. This is useful for classes where there is more
than one observer interface. For example, WMHelperChromeOS has:

  AddTabletModeObserver
  AddDisplayConfigurationObserver
  AddActivationObserver
  AddFocusObserver
  AddDragDropObserver

Adding this method template to ScopedObserver forces a couple of
changes to instantiations.

1. IWYU: the observed class must be fully declared. This is
   already a requirement for some compilers.
2. Observer type: the observer type must be the interface, not a
   subclass (such as the class that owns the ScopedObserver). i.e.,
   ScopedObserver<Widget, MyClass> becomes
   ScopedObserver<Widget, WidgetObserver>. This also reduces the
   amount of code generated since there will be fewer ScopedObserver
   one-offs.

Bug: none
Change-Id: I9f258324679e7a23859c7cab0d8b2189b623e87e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772419
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710866}

Fixes sizing when drawing image rep for the target scale - instead of
using the rep's pixel size, use DIP size multiplied by scale (in case
the icon image does not have exact representation for the target scale).

BUG=1018038

Change-Id: Idd184ffa34675816dc7b9a6b9d52eafc6c55c485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888654Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710865}

Throw an IllegalArgumentException when VisualStateCallback is null. This
will already cause a crash unless calling postVisualStateCallback is the
only method called in the WebView.

This CL effectively reverts http://crrev.com/c/1865155.

Bug: 1014924
Change-Id: I437780f571416e2090591410bc3493a3ffb9ad3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879920Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Auto-Submit: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710864}

This change encapsulates |addrinfo| in an RAII class and abstracts the
implementation details of invoking |getaddrinfo| from callers. (The callers
still need to know how to use |hints| however).

One helper function moved from host_resolver_proc to the |AddressInfo|
class, and some massaging of error codes from host_resolver_proc was
also moved to address_info.cc.

The actual call to |getaddrinfo| is wrapped in a class with two virtual
calls (eponymously named |getaddrinfo| and |freeaddrinfo|) so that they
can be replaced in unit tests.

Unit tests are added for the code in address_info.cc.

Change-Id: Iada36ebbe0b783cd395f100c4e9d5753b5de2265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760461Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Scott Sheehan <ssheehan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710863}

This change fixes a bug we had with
AXPlatformNodeTextProviderWin::GetSelection(). When there is no
selection, the range created was always a degenerate range describing
where would be the text insertion point (i.e. the caret) in an editable
text node.
However, according to UIA's documentation, we should only create a
TextRangeProvider and fill the SAFEARRAY with it when the generate range
is on an editable node. Otherwise, the expectations are that the
SAFEARRAY parameter be set to NULL.

Here's a list of what this CL does:
* Fixes the bug in AXPlatformNodeTextProviderWin::GetSelection().
* Adds a test case to GetSelection's unit test.
* Duplicates the implementation of HasVisibleCaretOrSelection() to
TestAXNodeWrapper so we can have the correct result in the unit test.

Bug: 928948
Change-Id: I2577434a5d8ee5ef98eddf1540bfd02df28db380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882298Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710862}

This is a reland of 099f851f

Original change's description:
> cros: Fix capturing orientation
>
> Instead of setting the rotation as part of the transform on
> ash root window, call viz SetDisplayTransformHint so that
> capturing code as a consumer of viz could get the correct
> orientation.
>
> Bug: 847693
> Change-Id: Id70f91dc84fc9274145d5a160a51b8c7fa50deed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825892
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707004}

Bug: 847693, 1016672, 1016980
Change-Id: If609cdaab06874c5b5b4a7fd623ecc00077c0351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876231Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710861}

According to UX, tapping overview background when in split view mode
should be no-op (to go home, the user would have to first exit split
view).

BUG=997885

Change-Id: Ie127e24d61b1741415b989ed85f18853be0c0da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889313Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710860}

Security UX is experimenting with using a grey triangle warning for
non-secure site connections (crbug.com/997972). When this icon is
shown, DevTools Security panel's security overview should match the
state shown in the omnibox.

crrev.com/c/1857047 swaps out the info icon for a grey triangle
for non-secure connections, so this cl uses the same logic
(factored out into a helper) to determine whether pages with
the NONE and WARNING security states should send Insecure or
Neutral over the DevTools protocol.

crrev.com/c/1881220 (DevTools frontend) should be submitted first.

Bug: 1008218
Change-Id: I524fc43bae2d86bbc5fbe394948c3c29cda21bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877653Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710859}

In UMA metrics PasswordProtection.RequestOutcome.AnyPasswordEntry, the
Unknown bucket is abnormally high. The reason is that "reason" is not set
when saved password is reused and SBER is disabled.

Bug: 1016540
Change-Id: I382e516f664cbd7b514c0005f4f90e6df607da45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888724Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710858}

Currently we are using StrictMocks in several places which force us to
set several expectations unrelated to what is being tested, making the
code harder to read. This CL updates these cases to use NiceMocks to
solve this issue. Sepcific tests that do care about these mocks can
still use EXPECT_CALL to setup expectations.

This is also consistent with googlemock guidelines [1]:
"""
Our general recommendation is to use nice mocks (not yet the default)
most of the time, use naggy mocks (the current default) when developing
or debugging tests, and use strict mocks only as the last resort.
"""

[1] https://github.com/google/googletest/blob/master/googlemock/docs/cook_book.md#the-nice-the-strict-and-the-naggy-nicestrictnaggy

Bug: 1018372
Test: Test cleanup only
Change-Id: Ie639f2706f02c9701cb2f4ab2d2ed2658006fb32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879685Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710857}

Bug: 985574
Change-Id: If8722bc3577d245f09c20f814c90e343b800c0fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889300
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Yun Liu <yliuyliu@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710856}