- 05 Oct, 2017 40 commits
-
-
Miguel Casas-Sanchez authored
This CL adds a ParseChromaticityCoordinates() service function to the bunch of edid_parser.cc functions, and adds unittests with a few real EDIDs collected in the wild. ParseOutputDeviceData() in that very file is minimally refactored for early-return. R=edid_parser_fuzzer Bug: 771345 Change-Id: I956609d381b6fb199021b725f3838f55fb1fda48 Reviewed-on: https://chromium-review.googlesource.com/699351 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#506876}
-
John Rummell authored
As Storage IDs are used by encrypted media to bind persistent licenses to the device which is authorized to play the content, this updates the preference so that it's authenticated and not easily modifiable via plain text. BUG=478960 TEST=unittests pass Change-Id: I60c0a6a023f3532a6180859c753a1dd42f266c0e Reviewed-on: https://chromium-review.googlesource.com/683309Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#506875}
-
Dirk Pranke authored
By default, we want to check out everything that is needed to run on one of the main waterfalls (see the list in the bug for specifics). However, we also want to support a "small" configuration that can be used to skip things like NaCl that are optional for development, in the interest of a smaller download. R=thakis@chromium.org, phajdan.jr@chromium.org BUG=768433 Change-Id: I45d8984616f7e25bd587070569d471eaab9ce8d7 Reviewed-on: https://chromium-review.googlesource.com/699834Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506874}
-
Scott Chen authored
This CL ports over the runtime error stack-trace and dev-view button that existed in the old extensions page. Bug: 768609 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I80fc989ca0b3bcc8af7483a2f475e673e2476674 Reviewed-on: https://chromium-review.googlesource.com/691181 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506873}
-
Shimi Zhang authored
This is for http://crrev.com/c/653432 [Smart Selection] Shrinking selection after Smart Selection expansion. Bug: 703884 Change-Id: Id32c5214f60de42bc3c9fd5abe5582c0f0aff7fa Reviewed-on: https://chromium-review.googlesource.com/701422 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506872}
-
Xiaohan Wang authored
Previously |type| was used to identify the type of a CDM (e.g. Widevine, or Clear Key CDM). As of 5591646b, we use CdmInfo.guid to uniquely identify the type of a CDM to be able to run different CDMs in different processes. Also, GUID is a much better ID than the |type|, which is a free format text string. With that, we don't need the |type| anymore. However, we still need a display name for the CDM type for various purposes. For example, in the future, we could use this name as the CDM process name. This CL renames |type| to |name| and updated the comment. TBR=thestig@chromium.org,alexmos@chromium.org BUG=771490 TEST=No functionality change Change-Id: Ia95a77e1c506a551e37798e5a73b6c0d5186ee82 Reviewed-on: https://chromium-review.googlesource.com/699858 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#506871}
-
Devlin Cronin authored
crrev.com/1f2b58d7 removed the old settings page code, but missed cleaning up the strings. Remove some that are no longer used. This covers: IDS_CERT_MANAGER_WRITE_ERROR_FORMAT -> IDS_COOKIES_COOKIE_ACCESSIBLE_TO_SCRIPT_LABEL Bug: 771795 Change-Id: Ib37177a27c9b57d234bf26e059adf0fc65b7861e Reviewed-on: https://chromium-review.googlesource.com/703154Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces |TextAffinity::kUpstreamIfPossible| as replacement of |VP_UPSTREAM_IF_POSSIBLE| to avoid including "VisiblePositoin.h" for improving compilation speed. This patch also gets rid of redundant include directive of "VisiblePositoin.h" from "LayoutSVGInlineText.cpp". Bug: 657237 Change-Id: I685c49a0adc4b2827929447ca8f3e6a5c518c113 Reviewed-on: https://chromium-review.googlesource.com/701958Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506869}
-
Theresa Wellington authored
Removes the bottom nav icons when the sheet is closed, saving 112kb on a Nexus 6P. Removes a number of unused views to reduce Java heap memory used in Chrome Home. Savings quoted from a Nexus 6P dump: - Homepage button, 30kb - Non-modern tabswitcher new tab button, 56kb - Incognito location bar badge, 81kb Also removes the shadow from IncognitoBottomSheetContent, aligning it with other modernized sheet contents and fixing a memory leak associated with not unregistering an observer (705kb on Nexus 6P). BUG=708006 Change-Id: I87d63c1ea7cb57347ef63dce8dd961a3946e92b6 Reviewed-on: https://chromium-review.googlesource.com/701284Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506868}
-
Daniel Bratell authored
This makes webkit_unit_tests support jumbo compilation. In CPU effort that reduces the reference build time by 2.5 CPU minutes (about 0.3% of the total build time) Bug: 713137 Change-Id: I358ff81769e5fb0ebf91cd1264713c547fd3e47e Reviewed-on: https://chromium-review.googlesource.com/677449Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#506867}
-
Bill Orr authored
There were a few clang-specific C++ extensions in use, and some warnings that hit only on MSVC. gltf tests had to be disabled because url->path parsing is not correct on Windows. BUG=744675 Change-Id: Ica976477da4b5009a68d738e71ee995af871d1f7 Reviewed-on: https://chromium-review.googlesource.com/695807 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#506866}
-
Chris Harrelson authored
fragment. Bug: 750500 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idc4608f9f871e912458310992703455d9d7ab4cf Reviewed-on: https://chromium-review.googlesource.com/703460Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506865}
-
Mike Baxley authored
testRedirectWindow and testRedirectRefresh are very falky on iOS 11 iPads. TBR: eugenebut Bug: 772128 Change-Id: Icacf5d4c8f0cad3693d161ad31ade70ecbd960c7 Reviewed-on: https://chromium-review.googlesource.com/703469Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#506864}
-
James Cook authored
We have not shipped Windows Ash for years. There is a 1:1 mapping between use_ash and is_chromeos, so consolidate them. Bug: 673826 Test: compiles, gn check for Chrome OS, Linux, Linux Ozone Change-Id: Ibdb2f52c19e3d49aa4742b58775013c425adff22 Reviewed-on: https://chromium-review.googlesource.com/702916Reviewed-by:
-
Justin Okamoto authored
This is a reland of 1dd22ad0 Original change's description: > Android: Allow per-target lint suppression configuration > > This change allows for Android lint suppression configurations > to be defined on a per-target basis (assuming said target is > "Android lint capable") rather than having one global config. > This will allow embedders to keep upstream's lint config for > Chromium targets (w/o patching), while using a separate config > for the embedding application. > > Bug: 737897 > Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc > Reviewed-on: https://chromium-review.googlesource.com/698297 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506393} Bug: 737897 Change-Id: I4d1aecea7d4893f8f525d53a13b4044f27a17221 Reviewed-on: https://chromium-review.googlesource.com/701317Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#506862}
-
Xiaocheng Hu authored
RenderedPosition caches two |InlineBox*|, and uses 1 as the magic value indicating the uncached value, which is a hacky approach. This patch changes them to Optional<InlineBox*> to make the caching not hacky. Bug: 771398 Change-Id: If8bef20755fcc75b04093de6c2211138d336600e Reviewed-on: https://chromium-review.googlesource.com/702924 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#506861}
-
Aleks Totic authored
Bug: 772087 Change-Id: I66bf95d43bd7a32718c6e0ad97e179be0db78cc7 Reviewed-on: https://chromium-review.googlesource.com/702816Reviewed-by:
-
Jingkui Wang authored
The units of touch_major and abs_mt_position_x could be different. We have to scale the values from touch_major/touch_minor before we map the value to radius (pixels). Bug: 771374 Change-Id: Ic5ca2424ff72e475e7146ff7a42725445d2fb250 Reviewed-on: https://chromium-review.googlesource.com/702758Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Jingkui Wang <jkwang@google.com> Cr-Commit-Position: refs/heads/master@{#506859}
-
Nicolas Pena authored
This CL adds methods to allow the MainThreadTaskQueue to determine whether its associated frame is main or not. This will be used to split EQT by frame type. Bug: chromium:747504 Change-Id: I478f2c1f20ce93c6de0837fdde90a495bc4409d7 Reviewed-on: https://chromium-review.googlesource.com/656110 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506858}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4ce4f5f8ab0b..480ca10f7a20 $ git log 4ce4f5f8a..480ca10f7 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 dsinclair Remove unused CPVT_SecProps 2017-10-05 dsinclair Remove more unused params 2017-10-05 dsinclair Remove unused parameters 2017-10-05 rharrison Add ObservedPtr to catch Widget being killed by JS 2017-10-05 rharrison Add ObservedPtrs to catch issues in SaveData 2017-10-05 npm Create FreeType roll script 2017-10-04 rharrison Make GIF decoder more standards complaint 2017-10-05 dsinclair Move CPDF_RenderOptions members to private 2017-10-05 dsinclair Remove friend from CPDF_ApSettings 2017-10-05 npm Roll FT to ae7dc1f62d826083d418e86cce3f66a76dff038a 2017-10-05 dsinclair Remove friends from form code 2017-10-05 dsinclair Remove friends from CPDF_VariableText Created with: roll-dep src/third_party/pdfium BUG=771979,756427,770337 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I875e810e00b7d619534e2dc24519c27088423e15 Reviewed-on: https://chromium-review.googlesource.com/703198 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506857}
-
Dirk Pranke authored
This reverts commit 570b9f37. Reason for revert: Turns out we weren't ready for this yet. Original change's description: > Stop expecting 10.9 builds for the layout tests. > > We are dropping layout test support on 10.9; the first step is to > stop expecting the bots to be running and generating baselines. > > R=qyearsley@chromium.org > BUG=736256 > > Change-Id: I2d5c647cfb2d68df3bf2d078332c504cfccfa8d7 > Reviewed-on: https://chromium-review.googlesource.com/699559 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506417} TBR=qyearsley@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 736256 Change-Id: I9633bbe19af74e9a7ba54cfa52f89baa82fcde47 Reviewed-on: https://chromium-review.googlesource.com/703375Reviewed-by:
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/e9c7b1c8ae85e5625e9d24d9e20ccedeaaeb0d0a..12fdd08a401d2ef562612638abd016f8b5794cc7 This removes the RecordType and NoSessionID TLS 1.3 variants. BUG=none Change-Id: I5edc8c6e0e67f581095efa326e4fdc3d339c7204 Reviewed-on: https://chromium-review.googlesource.com/698624 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#506855}
-
Rune Lillesveen authored
We tried to update the fragment anchor position immediately when all script blocking sheets are removed. As part of that update we do a style and layout update. The last script blocking sheet may be removed as part of removing a style element from the DOM. Updating style and layout in the middle of a DOM operation is not safe. Instead, update the fragment anchor position during the next safe lifecycle update. The crash was caused by Document still pointing to a documentElement being removed while updating the style and layout tree, but its parent pointer had already been set to null. Bug: 771088 Change-Id: Iaaaeece23d795c2e41d31b9fb97fc795eb2b8305 Reviewed-on: https://chromium-review.googlesource.com/698305 Commit-Queue: Rune Lillesveen <rune@opera.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506854}
-
Corentin Wallez authored
BUG=602737 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd8e5a4c6d1c7ccddbbd591ef22326d2719084f5 Reviewed-on: https://chromium-review.googlesource.com/700989 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506853}
-
Yoshifumi Inoue authored
This patch introduces |FrameSelection::SelectWordAroundCaret()| to move code to "FrameSelection.cpp" from "WebLocalFrameImpl.cpp" as preparation of removing usage of |VisiblePositon| and |VisibleSelection| outside "editing/" for improving code health. Bug: 657237 Change-Id: I75c92513e4fc577bb6336553256fdd69a594277d Reviewed-on: https://chromium-review.googlesource.com/702214Reviewed-by:
-
kristipark authored
Bug: 772067 Change-Id: Ia18e7aaa8c22a3c401611bc9952d1ab9fa3e01d9 Reviewed-on: https://chromium-review.googlesource.com/703497 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#506851}
-
Will Harris authored
NULL -> nullptr TRUE -> true FALSE -> false Changes that were not purely mechanical: - Move a few functions to anonymous namespace. - Replace some unneeded typedef with declfunc. - CreateEvent returns nullptr for invalid handle not INVALID_HANDLE_VALUE. - CreateFile returns INVALID_HANDLE_VALUE not nullptr. - Add enum for is_broker in filesystem interception. Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Iff1beaf7bd7433a32ccb15d09298a3244c6700d1 Reviewed-on: https://chromium-review.googlesource.com/698375 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#506850}
-
Weidong Guo authored
Changes: 1. Handle arrow up/down in SearchResultTileItemListView, so that focus could traverse vertically. 2. Move focus to search box when it is moved outside SearchResultPageView during vertical focus traversal. Design Doc: go/applist-focus BUG=766810 TEST=AppListViewFocusTest.* Change-Id: Idcd54e7d7c4f2cd6fe425e80218310581c7bcaaa Reviewed-on: https://chromium-review.googlesource.com/701578 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506849}
-
Devlin Cronin authored
crrev.com/1f2b58d7 removed the old settings page code, but missed cleaning up the strings. Remove some that are no longer used. This covers: IDS_ABOUT_BUTTON -> IDS_CERT_MANAGER_CERT_PARSE_ERROR Bug: 771795 Change-Id: I8b1ad50dcfc2d45e346945a36b62eb6807dac4e1 Reviewed-on: https://chromium-review.googlesource.com/702921Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506848}
-
Danyao Wang authored
restore_session.html is a magic file included in the app bundle that helps WKBasedNavigationManager implement restore. The navigation manager serializes and encodes the session history in the query parameter, and loads restore_session.html to inject the history into the web view. Bug: 734150 Change-Id: Ideaa7239eb3239322e3e72c5599736962962b465 Reviewed-on: https://chromium-review.googlesource.com/698465Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#506847}
-
David Trainor authored
Add the following logs to help us have an idea of what the service behavior is: - Download.Service.Entry.Event - Logs event actions taken on an Entry like start, resume, retry, and suspend. - Download.Service.Entry.RetryCount - At the time of a retry, logs which retry attempt this is. - Download.Service.Entry.ResumptionCount - At the time of resumption, logs which resumption attempt this is. Bug: 769426 Change-Id: I11e5974521c6ba610d9d58940b4dae61ae8c1fbb Reviewed-on: https://chromium-review.googlesource.com/701835 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#506846}
-
Devlin Cronin authored
ExtensionService::extension_registrar_ is constructed at ExtensionService construction time, and is never reset. There's no reason to have it as a std::unique_ptr<> instead of a stack-allocated member variable. Make it the latter. Bug: 770879 Change-Id: I68001b9214b6176fc4703e3c6d2f1cbdcece9dff Reviewed-on: https://chromium-review.googlesource.com/701398Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506845}
-
Morten Stenshorne authored
We already did ignore borders and padding, but forgot about scrollbars. This was quite catastrophic for multicol, if a horizontal scrollbar was actually taller than the columns. We'd end up pushing the scrollbar in front of us (in block direction), column after column. Infinite loop (until OOM). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5c3038406ccf30eeb0e107b31c6bb783c7089ffd Reviewed-on: https://chromium-review.googlesource.com/702299Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#506844}
-
Steven Holte authored
Bug: 754892 Change-Id: I3498e985e9382aa5149406fcad51a8314f42c43d Reviewed-on: https://chromium-review.googlesource.com/701257Reviewed-by:
-
Gregory Chatzinoff authored
The prior app store link does not work in iOS11, so use the new link instead. Bug: 771211, 761200 Change-Id: I5b3daff63f4e0f9f78ebe6721aa6497282339eee Reviewed-on: https://chromium-review.googlesource.com/702686 Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#506842}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/09fca0a3600a..400dbc4b2b00 $ git log 09fca0a36..400dbc4b2 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 dtu [pinpoint] Set `updated` on Run(), not using `auto_now` Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic4eec5029d0ad354c0bd4967525973ddd9c36c5b Reviewed-on: https://chromium-review.googlesource.com/702761 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506841}
-
Ken Rockot authored
This reverts commit 12234368. Reason for revert: Looks like a source of these build failures: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/69753 Original change's description: > Android: Turn on errorprone by default > > BUG=383646 > > Change-Id: Ia87d2dff787ffc5e4a59aca1af81a0ac9b727b4a > Reviewed-on: https://chromium-review.googlesource.com/702574 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506831} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Ie933459d048c090df574bf45b6e2b644de3e66e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 383646 Reviewed-on: https://chromium-review.googlesource.com/703395Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#506840}
-
Jian Li authored
We used to disable all form control elements when saving a page as MHTML since the form in the MHTML document cannot be worked on due to form submission and script execution disabled. As suggested by Jeffrey Yasskin, we switched to disable form control elements in the loaded MHTML document. Bug: 771786 Change-Id: I44b9c324192be052dd47db3d126a911ab5dd34e3 Reviewed-on: https://chromium-review.googlesource.com/701368 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
-
MinChen authored
Bug: 763240 Change-Id: Ibe0ce1f0d44dd947154d231769b53d0eda35dc09 Reviewed-on: https://chromium-review.googlesource.com/702722Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: min c <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#506838}
-
Daniel Bratell authored
"using namespace" in a global scope breaks jumbo builds (and are not allowed in the code style guide). This patch replaces them with explicit namespaces. Bug: 771153 Change-Id: If9c4de9e115c5531708cf06f64cb0088daca2d57 Reviewed-on: https://chromium-review.googlesource.com/697370Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
