- 07 Dec, 2020 40 commits
-
-
Eugene But authored
This is a follow up cleanup to crrev.com/c/1884550 where didFailOpenInMenuPresentation method call was removed. Bug: None Change-Id: I15f5f6982776681139397adbf937b28d6caea56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572781Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#834328}
-
Kramer Ge authored
wl_surface.commits of a frame can happen asynchronously due to wl_buffer import delay, frame callbacks, etc. This asynchrony can cause visual glitches when the root_surface commits before its subsurfaces commit. This CL ensures that a root_surface commit always happens after other commits in a frame. Change-Id: I7c83e122c4cdee42e6b8aca74875fa71b6c1ab5a Bug: 1144179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547395 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#834327}
-
Dominique Fauteux-Chapleau authored
This is done now to keep messages in sync in both code repos See cl/345275972 Bug: 1147036 Change-Id: Id779bdcebb68498daabb541d570f0d66c40b84a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570746Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834326}
-
Jeffrey Cohen authored
[Project Code Inclusion] Remove all uses of whitelist/blacklist in chrome/android/.../keyboard_accessory Bug: 1149543 Change-Id: I333d790ab61033d576e245c0e7ee243461c05aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572687Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834325}
-
Daniel Rubery authored
The metrics: SafeBrowsingBinaryUploadRequest.AdvancedProtectionScanVerdict and SafeBrowsingBinaryUploadRequest.MalwareScanVerdict had already been stopped being logged in https://crrev.com/c/2505943, so mark them obsolete and document the replacements. Fixed: 1153857 Change-Id: I9d732bdcebaffe312063dd749ebb69873f6fe12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577601 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#834324}
-
Fredrik Söderqvist authored
To avoid future clash with the member function with the same name. Bug: 1028063 Change-Id: I60dbf53c1949a7ee6e1000ea20629f10d35e6778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577223 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#834323}
-
chrome://kaleidoscopeBecca Hughes authored
This is so it can be used on the NTP. Change-Id: I6c3f2ee45a5b8c570661618191c81f1fb24a9e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441260Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#834322}
-
Sky Malice authored
Bug: 1155365 Change-Id: I2744a73368c450aa1cae0844a67503a1c0cd5347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573776Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#834321}
-
Garrett Beaty authored
Now that we no longer have multiple milestone-based buckets, it is safe to refer directly to the bucket when referencing another builder, so the builder_name function provides no value. Change-Id: If64a68d4d6e3c153c5d832a656fc2976ef18c7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576945 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834320}
-
Tim Volodine authored
Move the client side model loader code which currently lives in chrome/browser/safe_browsing/ to components/safe_browsing/content/ browser/ in order to be reused by both the chrome and weblayer implementations. The client_side_model_loader code is used by the ClientSideDetectionService and the PhishingDetector for setting the phishing model. This CL also moves the corresponding unit test, so that it will be running as part of the components unit tests. BUG=1115700,1152490 Change-Id: I5347884ae8c7f808f4b73858edba30237437a36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558399 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#834319}
-
Lukasz Anforowicz authored
This CL reintroduces the "url_loader_factory_debug_tag" crash key that hopefully will help understand the root cause behind `request_initiator_origin_lock` mismatches observed in the wild. The crash key has been previously introduced in r803843 and removed in r817762. Bug: 1151008, 1151438 Change-Id: I38c0355c04ca6109c76440bf9e095af79f6bc803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575368Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#834318}
-
Clark DuVall authored
This is a reland of 9124dffe Reason for reland: This was breaking Android N by accessing the base context too early: crbug.com/1156018c. Changes from original are from patchset 1 on. Original change's description: > Preload chrome split on startup > > The chrome split can take a long time to load, so we get significant > improvements in startup time if this work is offloaded to a background > thread. Ideally, we would give as much time as possible to allow this > preload to finish, which means running as much code as possible which > does not depend on the chrome split during the preload. This required > refactoring much of attachBaseContext into the base module, and moving > the pieces which could not be easily moved to the base module into > onCreate. > > The order of startup generally goes: > 1. Application.attachBaseContext > 2. Each provider is instantiated in order, and onCreate is called > 3. Application.onCreate > > If a provider lives in a split, it will call createContextForSplit on > the application. This will end up being the first thing needing the > chrome split, which will wait for the preload to complete. This is why > ChromeFileProvider was moved to the base module, so there could be more > time to preload. > > Pinpoint runs: > Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/16925180d20000 > -7% messageloop_start_time > -3% first_contentful_paint_time > -3.8% navigation_commit_time > > Android Go: https://pinpoint-dot-chromeperf.appspot.com/job/115e53e7520000 > -18.7% messageloop_start_time > -1.5% first_contentful_paint_time > -2.1% navigation_commit_time > > A couple notes: > - setUsageAndCrashReportingFromNative was removed from UmaUtils because > it is never used, and allowed for much more easily bringing UmaUtils > into the base module. > - I wanted to make sure PureJavaExceptionHandler is still set up as > early as possible, so left it in attachBaseContext. This required > loading PureJavaExceptionReporter by reflection if an exception > happens, since it has many hooks into chrome code. > - MainDexApplicationImpl is no longer needed since all the common code > was moved to SplitCompatApplication > > Bug: 1150600 > Change-Id: Idd6c11293e47fa5e8bd6eb30c14535e60c204867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570125 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833923} Bug: 1150600 Change-Id: Id9de8d25e74b18199fa10fb12a669384908acdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577546 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#834317}
-
Alexei Svitkine authored
It was disabled for all platforms even though it was flaky only on Android. Bug: 1131541 Change-Id: Ia8588057199e10de0d2c70d02729cdc00df49133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575764 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#834316}
-
Theo Johnson-kanu authored
Before this CL psim networks and tether networks provider names are displayed. This CL restricts this functionality to esim networks Bug: 1154407 Change-Id: Ife86112bb08422d172289294f6e09e2bbfe51be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575210Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#834315}
-
Elly Fong-Jones authored
Bug: 1156175 Change-Id: I948d76797152ab038beefc6c0cf85621037f593d Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575229Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834314}
-
Elly Fong-Jones authored
Bug: 1156218 Change-Id: I7a1730f4e607418df9a6300eb143e02d30007507 Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575832Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834313}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I2e772b1c28805ca6b9cfc45d2673ff1b25be86bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572682 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#834312}
-
Jeffrey Kardatzke authored
BUG=b:153111783 TEST=P010 overlays can scanout Change-Id: I9dcea6a161a82bf06e723fcc0170384863bd677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575999 Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#834311}
-
Daniel Nicoara authored
Original graphical artifacts no longer reproduce. Bug: b/171980418 Test: Check for artifacts during boot. Change-Id: Ie1501c903d4bc63f065de699c0dd4db2d6c206af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572708Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#834310}
-
David Van Cleve authored
The //chrome Trust Tokens browser tests live in //chrome/browser/net. This change moves the //content Trust Tokens browser tests to //content/browser/net to be consistent (and because Matt suggested it). R=mmenke Fixed: 1109279 Change-Id: I0556204718b6b8f26161c4e6ba0eb8204dd79bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575224 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834309}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/viz. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=flackr@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I2a2408fa37b2d0fdb12b3da83fd70efaaa540cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575054 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834308}
-
Elly Fong-Jones authored
Bug: 1156081 Change-Id: I3bf7d8569d96ba90a21de56feeec3f20d806b62b Tbr: asamidoi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577579Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834307}
-
Ben Pastene authored
Reportedly, they'll only trigger builds on https://luci-milo.appspot.com/p/chromium/g/tryserver.chromium.swangle/builders Bug: 1155894 Change-Id: I60db3e91d16fdc31b16f45b38ecfa1554bd168c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577610Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#834306}
-
wutao authored
The middle dot symbol is very small. Replace it with a larger symbol, bullet. Bug: b/173754433 Test: manual && modified test Change-Id: Ie7cd84a91b7d7374dff6087954f1f7be9426a62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577605 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834305}
-
Stephan Hartmann authored
localmatcher.h was added in icu-68.1 and is required with: https://crrev.com/741586ecfbe42908e66016eb6319a1cc0ffc379e Bug: None Change-Id: I5167cb3d6f35dd0c4d6268b46c876579f72656dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574858Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834304}
-
Vasiliy Telezhnikov authored
This CL actualized the feature list to match with server config. This doesn't change any actual state of the code, UseSkiaRenderer is forced in code for VizForWebView and UseSkiaForGLReadback doesn't exist anymore. Bug: 805739 Change-Id: Id36982afdc9547a569a23249b4c7b97610b5d197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576920Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#834303}
-
Bin Du authored
Bug=b:169624777 Change-Id: I765db98c825757d14ec8804298ea01fbd13fd176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577599Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bin Du <dubin@google.com> Cr-Commit-Position: refs/heads/master@{#834302}
-
David Black authored
HoldingSpaceItemViews fade in and translate up into place. When being removed, they fade out and also translate up. Demo: http://shortn/_UrRIQF1CXm Still TODO: - Animate container grow/shrink - Animate pinned section empty label - Animate section labels (when sections are going away) - Animate screen captures and downloads sections independently of each other so that adding/removing items from one section does not impact the other unnecessarily. Bug: 1154998 Change-Id: Ib28c35b79b20e265059c496c2c7c8ceb23defe6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575322 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834301}
-
Victor Vianna authored
Unused following crrev.com/c/2569518 and crrev.com/c/2572416. Change-Id: I8bba8f261a054aa4163f1a5651927eaf7ee21241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573476 Auto-Submit: Victor Vianna <victorvianna@google.com> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834300}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61f3e614..7da2cc8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I319985340c990f32967cbdd73ac79ac7dc85dde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577596Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834299}
-
Dominique Fauteux-Chapleau authored
This refactor is only the first step to getting Connectors policies to work on a profile basis, as the CBCM DM token is still read even when the policy is set at the user level. This refactor breaks a few assumptions of the previous implementation: - SetUpForTesting, TearDownForTesting and ClearCacheForTesting are no longer needed by ConnectorsManager since it is no longer a global singleton. - Extra null checks are added for ConnectorsService and SafeBrowsingPrivateEventRouter since they can be null in tests. This wasn't a problem before since ConnectorsManager::GetInstance never returned null and SafeBrowsingPrivateEventRouter::context_ wasn't read by test not using those classes, but that is no longer the case. - kEnterpriseConnectorsEnabled is moving to ConnectorsService since it will be used by future code outside of ConnectorsManager. - policy_test_cases.json is updated since the policies are now read from profile prefs, but the policies are not truly per-profile since they depend on the CBCM DM token so they are not marked as such in policy_templates.json. Bug: 1147464 Change-Id: Ifacd55555ef6a5edab796dacbd336d971b9ae1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529613Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#834298}
-
David Dorwin authored
Previously, web.Frames created for popups did not have any CreateFrameParams applied. Bug: 1148830,1155378 Change-Id: I7f81b729acb8300ac9249d0060a95a6eb50d09da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542124 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834297}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/external. Bug: 1113033 Change-Id: I27b68d87c1bcb1073372ce895800ae822b9df88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573121Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#834296}
-
Elaine Chien authored
Chrome Labs icon to the right of extensions icon: https://drive.google.com/file/d/1JmAXgwbqpFwgGcxhGUJjO3HLCHCPG_jK/view?usp=sharing Bug: 1145666 Change-Id: Id45c1431d75a647ac97bc390cfbdf967b743833f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570117Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Elaine Chien <elainechien@chromium.org> Cr-Commit-Position: refs/heads/master@{#834295}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/external. Bug: 1113033 Change-Id: I68d6f0ecfe4b0d25e9dc77bbd010a1d788911711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573122Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#834294}
-
Finnur Thorarinsson authored
A recent refactor of ShortcutManager left an uninitialized static member variable, which causes a crash on install. TBR=dominickn@chromium.org Bug: 1155763 Change-Id: I29db4dae2756fd100f05c67980e6ae613674d150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577361 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#834293}
-
Joel Riley authored
Search key + single click will navigate to paragraph. In existing STS, Search key + single click while STS is active would exit STS, now it will navigate to the given paragraph. When sentence navigation is implemented, we can navigate to the specific sentence rather than always starting from the beginning. AX-Relnotes: N/A Bug: 1143819 Change-Id: I5b5a73a20c8080922f7e9984af982c1ffc5bfc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569785 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834292}
-
Stephen McGruer authored
Bug: 997202 Change-Id: Ic14e10dfd0d4fbdc22c9b22289fb9a428eb3dbca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575453 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834291}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //third_party/blink/web_tests/external. Bug: 1113033 Change-Id: I57e5eaf69b7d9fbd8509d66b151da8abc33edcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572683Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#834290}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a59f15a6efc..e79095f5335b 2020-12-07 tvanderlippe@chromium.org Update third_party/puppeteer to 5.5.0 2020-12-07 tvanderlippe@chromium.org Fold cm_modes into text_editor 2020-12-07 kimanh@chromium.org [wasm] Use wasm subtype for context menu item titles 2020-12-07 tvanderlippe@chromium.org Fix formatter_worker entrypoint inclusion for unit tests 2020-12-07 tvanderlippe@chromium.org Fix copying of property paths in object properties view 2020-12-07 wolfi@chromium.org Update frame tree when frames are written to via JS 2020-12-07 leese@chromium.org Support one-to-many mapping for breakpoints in inline functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1024752,chromium:1127902,chromium:1140481,chromium:1140540,chromium:1150762,chromium:1155554 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iddc48373126c6dc4fb91e34b3793b08d1a317f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577531Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834289}
-