GitLab

BUG=240295

Review URL: https://chromiumcodereview.appspot.com/16325021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204096 0039d316-1c4b-4281-b951-d872f2087c98

Adds the following crash URLS to chrome/chromium builds when
ADDRESS_SANITIZER is defined (built with asan=1 in GYP_DEFINES).

  chrome://crash/heap-overflow
  chrome://crash/heap-underflow
  chrome://crash/use-after-free

This allows easy validation of the instrumentation/reporting
for a given build without having to track down a known/unfixed
memory error.

R= jamesr@chromium.org, sebmarchand@chromium.org, kcc@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16022009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204095 0039d316-1c4b-4281-b951-d872f2087c98

Added to code in crrev.com/203879 .

BUG=245033
R=jar@chromium.org

Review URL: https://codereview.chromium.org/16370002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204094 0039d316-1c4b-4281-b951-d872f2087c98

Modified the way keys (e.g. "100", "200") in the manifest are mapped to
valid scale factors to require a more exact match.

BUG=133934
R=pkotwicz@chromium.org
TEST=manual
out/Debug/unit_tests --gtest_filter='BrowserThemePackTest.HiDpiThemeTest'

Review URL: https://chromiumcodereview.appspot.com/16337020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242749

Review URL: https://chromiumcodereview.appspot.com/16337014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204092 0039d316-1c4b-4281-b951-d872f2087c98

enabling sync, now shows a spinner instead of a blank page.

BUG=244768

Review URL: https://chromiumcodereview.appspot.com/16335013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204091 0039d316-1c4b-4281-b951-d872f2087c98

After removing m_transformLayer from Blink's GraphicsLayer class,
TransferAnimationsTo is now dead code that can be removed. The WebLayer API
declaration is in Blink and will be removed in a follow-up patch.

BUG=245520

Review URL: https://chromiumcodereview.appspot.com/15896030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204090 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204089 0039d316-1c4b-4281-b951-d872f2087c98

R=alexeypa@chromium.org, ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/16383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204088 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduced a race on the host_ variable.

> Add a killswitch for CSD malware IP match and report feature. Use a new killswitch whitelist URL which is part of the CSD whitelist.
> 
> BUG=176647
> 
> Review URL: https://chromiumcodereview.appspot.com/14999008

TBR=kewang@google.com

Review URL: https://codereview.chromium.org/16398002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204087 0039d316-1c4b-4281-b951-d872f2087c98

Don't display the "charging not reliable" battery status in the
non-charging-non-discharging state, as that can happen normally in
some circumstances. Also, update the string to be more human-friendly.
See bug for details.

BUG=246336
TEST=manual, see bug
R=derat@chromium.org

Review URL: https://codereview.chromium.org/15993020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204085 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204084 0039d316-1c4b-4281-b951-d872f2087c98

This change deprecates sync_file_system::CreateFileSystemOperationForSync(),
but adds a new special FS type for internal sync:
kFileSystemTypeSyncableForInternalSync so that the existing
FileSystemOperation factory method (i.e.
FileSystemContext::CreateFileSystemOperation) can be used without hacky
code for internal sync operations.

This is a prerequisite cleanup for following further cleanups:
- To eventually move all syncable code out of webkit/fileapi
- To cleanup FileSystemOperatin related code

BUG=242422, 176444
TEST=content_unittests:LocalFile*,Syncable*
TEST=manual local/remote sync test with syncfs-editor

Review URL: https://chromiumcodereview.appspot.com/16330002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204083 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151723:151741&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16286011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204082 0039d316-1c4b-4281-b951-d872f2087c98

It depends on the Blink side of the change: https://codereview.chromium.org/16025003/
The spec for the change is here: http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCDataChannelInit

BUG=

Review URL: https://chromiumcodereview.appspot.com/16232004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234278
R=alecflett@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15927032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204080 0039d316-1c4b-4281-b951-d872f2087c98

Rather than going through the WindowManager and Display to get
DisplayMetrics, use the instance hanging off the context. This saves
several extra IPCs and reduces time in these functions during startup by
~20ms.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16093031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204079 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r196392 since r202696 brought the system print dialog back.

BUG=180997

Review URL: https://chromiumcodereview.appspot.com/16072015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204078 0039d316-1c4b-4281-b951-d872f2087c98

For the default bookmark shortcut icon (document look), we had both
png image and overlay drawing java code for coloring. However, the seperated
logic caused an inconsistency for the Nexus 7.  It is possible to
fix it by simply correcting dimens.xml (https://codereview.chromium.org/15875019/),
However, a better solution would be combining the two seperated logics.
This CL replaces the java drawing code by png images.

Tested on Galaxy Nexus, Nexus 10, Nexus 7, and Motorola Xoom.

BUG=241380

Review URL: https://chromiumcodereview.appspot.com/15992008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=RectTest.Subtract

Review URL: https://chromiumcodereview.appspot.com/15706011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204076 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204075 0039d316-1c4b-4281-b951-d872f2087c98

1641: ninja: Enable deps mode on non-windows.
1642: revert 1641
1643: Make rule variables to work with generated sources.

BUG=none
TBR=bungeman

Review URL: https://codereview.chromium.org/16374008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204074 0039d316-1c4b-4281-b951-d872f2087c98

We're seeing Activity Log related memory leaks. This patch suppresses the leaks so that the tests can keep running while we investigate.

NOTRY=true
BUG=246825

Review URL: https://chromiumcodereview.appspot.com/16212010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204073 0039d316-1c4b-4281-b951-d872f2087c98

The master is throwing an exception.
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16123014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/16093027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204071 0039d316-1c4b-4281-b951-d872f2087c98

It is disabled by default.

Also disabled D3D11 stats collection for all Vista machines and all machines with DisplayLink installed.

BUG=243125
Review URL: https://codereview.chromium.org/16270006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204070 0039d316-1c4b-4281-b951-d872f2087c98

The hash map is less convenient to use, but it promises much better
expected algorithmic complexity for the most common directory
operations. The indices converted with this patch almost never require
iteration, so it makes much more sense to use a hash_map (ie.
unordered_map) than a regular map.

This change also introduces a new index based on the server-assigned
unique tag. The server-assigned tag is set only on permanent items, so
there won't be many items in this index.

I ran some tests locally to confirm the new code does run faster.  On
certain model association tests I saw a speedup of ~10%.  I doubt we'll
see that much of a speedup in real world scenarios, but it could be a
noticeable improvement on some of our slower platforms.

BUG=238621, 115132, 241813

Review URL: https://chromiumcodereview.appspot.com/16231009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167037
R=kbr@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/16358011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=55316
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/16226004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245119

Review URL: https://chromiumcodereview.appspot.com/16063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=234278
R=alecflett@chromium.org,dgrogan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16005006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204065 0039d316-1c4b-4281-b951-d872f2087c98

Previously this settings page assumes that there are multiple
displays, but now this page provides settings for a single display.
Better to focus on the first display rather than the secondary one.

BUG=246587
TEST=manually
R=xiyuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15993017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204064 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245394
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15969022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204063 0039d316-1c4b-4281-b951-d872f2087c98

> Land Recent QUIC changes.
> 
> Merge internal change: 47341065
> 
> Fix to ensure the version matches before declaring that the public header
> flags exceed the max value. b/9190456
> 
> Merge internal change: 47324563
> 
> Fixing another backup bug (exposed by the last fix) that if we failed to
> write a standalone fin the stream would not be marked as write blocked.
> 
> Merge internal change: 47272116
> 
> Don't add QuicStreams to ActiveSessionList; Instead call DumpSession on
> alive streams via QuicSession.
> 
> Merge internal change: 47226512
> 
> Making the packet sequence number variable length to minimize bytes on the wire.
> 
> Merge internal change: 47220850
> 
> Fixing a bug in quic stream where we'd send rst stream packets for
> successful streams. The fin bit should be sufficient for both good
> request/response pairs and early response pairs.
> 
> Merge internal change: 47086343
> 
> Don't let FEC packets consume congestion window forever. If a FEC packet
> is not acked after a certain time, it is cleared from the congestion
> window. This timeout is higher than normal RTO.
> 
> Merge internal change: 47056082
> 
> Add QuicSession to ActiveSessionList.
> 
> Merge internal change: 47048300
> 
> Fixing a backup/resumption bug in QUIC.
> 
> It's possible to have a full congestion window worth of packets on the wire.
> 
> If we are in this state and a session tries to SendStreamData, the
> QuicPacketGenerator short-circuits without queuing packets because it checks
> to see if the connection CanWrite.
> 
> When we get an ack, we check to see if we have locally queued packets, but
> never call OnCanWrite on the session to clear any streams which write blocked
> without queueing packets.
> 
> Merge internal change: 47000173
> 
> QUIC: wire up the server-nonce parameters to the server config.
> 
> Merge internal change: 46985067
> 
> R=rch@chromium.org
> 
> Review URL: https://codereview.chromium.org/16256017

TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/16374004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204062 0039d316-1c4b-4281-b951-d872f2087c98

SkColorSetA returns the modified value and doesn't change it in place.

R=danakj@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16295025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204061 0039d316-1c4b-4281-b951-d872f2087c98

On some platforms such as Windows, IME APIs require
native window handle. With this patch set, IME API
wrappers are now able to obtain NativeWindow from
TextInputClient.

BUG=246516,246534

Review URL: https://chromiumcodereview.appspot.com/16154016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204060 0039d316-1c4b-4281-b951-d872f2087c98

It is failing on windows.
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16123012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204059 0039d316-1c4b-4281-b951-d872f2087c98

cc: Set resource->allocated to true within BindImage(). This mimicks the behaviour of BeginSetPixels() and fixes a DCHECK within LockForRead

BUG=175012

Review URL: https://chromiumcodereview.appspot.com/16055013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204058 0039d316-1c4b-4281-b951-d872f2087c98

objects that get passed in (canonically <input> elements apparently) which
recurse infinitely (as opposed to having a self-referential loop).

The previous solution to this problem (r150035) was to disable getters, which
apparently were the main cause, but this is no longer appropriate - we now use
this mechanism for all extension messaging, and this has become a problem (see
bug 246213).

TBR=jamesr@chromium.org, mpcomplete@chromium.org

BUG=246213,139933

Review URL: https://codereview.chromium.org/16295013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204057 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the user affiliation of enterprise-managed device-local
accounts to USER_AFFILIATION_MANAGED instead of USER_AFFILIATION_NONE.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/15792017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204055 0039d316-1c4b-4281-b951-d872f2087c98