- 30 May, 2018 40 commits
-
-
Aga Wronska authored
Make FilterActivityPeriodsByUsers() method use preference name that ActivityStorage was initialized with. This is a follow up for: https://chromium-review.googlesource.com/c/chromium/src/+/1056264. Bug: 837001 Change-Id: Iae481736122b62216514c8bb5125273ed97e443e Reviewed-on: https://chromium-review.googlesource.com/1077754Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#562819}
-
Daniele Castagna authored
crrev.com/c/1056165 moved setting |PLANE_CTM| properties trough HardwareDisplayPlane. Since we used to skip adding the cursor to HardwareDisplayPlaneManager::planes_, after that CL we stopped applying color correction to the cursor. This CL makes sure we always add the cursor to the list of planes, so that color correction will be applied correctly to the cursor. It also makes sure we don't assign the cursor to an HW overlay. Bug: 839487 Test: Ran unitests Change-Id: If8a29e3517d5ead7b8a5edadf6446f910c26176f Reviewed-on: https://chromium-review.googlesource.com/1077827Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#562818}
-
Ramin Halavati authored
ContentSettingsService handles incognito mode requests internally, so a flag is set to redirect incognito mode requests to the original profile. Also, in Set Content Settings API, incorrect use of include_incognito() function instead of IsIncognitoEnabled() is corrected. Two tests are added to check that all settings written in incognito are applied and do not affect regular mode, and incognito settings cannot be modified from regular mode. Bug: 832697 Bug: 845845 Change-Id: I6d65f824e3e3ca2fbd218ed0bf5af1ddc15c87ef Reviewed-on: https://chromium-review.googlesource.com/1061853 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561811} Reviewed-on: https://chromium-review.googlesource.com/1074651 Cr-Commit-Position: refs/heads/master@{#562817}
-
bungeman authored
Skia's sk_sp class is moving from operator pointer to field to explicit operator bool. As a result a few uses need to be updated. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b120d972ea88452b36093745b897445444ab745 Reviewed-on: https://chromium-review.googlesource.com/1075609Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Cr-Commit-Position: refs/heads/master@{#562816}
-
Aga Wronska authored
This typo needs to be fixed, because it fails google3 presubmit checks, when policy definitions are synced to google3. Change-Id: I15b26347984b98417600cafd4cdd5f80044e54b5 Reviewed-on: https://chromium-review.googlesource.com/1077663Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#562815}
-
vitaliii authored
Add ConsentSyncBridge (interface and implementation) without actually wiring it to the ConsentAuditor. The bridge itself is heavily based on UserEventSyncBridge, but the user event related bits were removed. Also I've tried to make tests easier to understand. This is the first change in a series to split user consents from user events into a separate datatype. Bug: 840357 Change-Id: Ief8d178d5aaf4b3bc3be68eb4580c811e8c50bb0 Reviewed-on: https://chromium-review.googlesource.com/1076248Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562814}
-
vitaliii authored
This is a follow-up to https://chromium-review.googlesource.com/1068528. Change-Id: Icec51b2b2c01812385b51d688888410904c7e65b Reviewed-on: https://chromium-review.googlesource.com/1078728Reviewed-by:
-
Mounir Lamouri authored
This is removing `PlaybackStateChanged()` from WebMediaPlayerClient and instead adds `RequestPlay()` and `RequestPause()`. HTMLMediaElement will notify the WebMediaPlayer when it states changes and there is no need for the WebMediaPlayer to change its internal state and then notifies the HTMLMediaEelement that things have changed. Indeed, it breaks some assumptions that the HTMLMediaElement has. The change also replaces some cast-related calls that are a by-product of this design change. Bug: 846490 Change-Id: Ibd60f571787e5f3a0d8a5ddfdbf4a35a2e53081e Reviewed-on: https://chromium-review.googlesource.com/1074807Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#562812}
-
Ken Rockot authored
There are public platform support and invitation APIs available in Mojo now, and they should be used exclusively in lieu of the old EDK APIs where possible. This converts most uses of the old APIs to the new ones. Note that there should be no functional difference in any of these components, and this does not change the underlying behavior of the system, e.g. internal IPC protocol is unchanged. Bug: 844763 Change-Id: I878f103041758d130c34bde046fa054b984feb8c Reviewed-on: https://chromium-review.googlesource.com/1070882Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#562811}
-
Kent Tamura authored
Bug: 843927 Change-Id: I7a4c7912ae535ce9afa2a2a0df433eea185a9cfd Reviewed-on: https://chromium-review.googlesource.com/1078407Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#562810}
-
Kim Paulhamus authored
The array represents all versions the RP supports. Bug: 840153 Change-Id: I150e80d2e9d5149fac39400eca69d680cc86307a Reviewed-on: https://chromium-review.googlesource.com/1060273Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#562809}
-
Bence Béky authored
Change-Id: Ie1025b480409650263c1592f28593b555e62e015 Reviewed-on: https://chromium-review.googlesource.com/1076410Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#562808}
-
Jeremy Roman authored
It is unused. Change-Id: Iff3a02c0a9fb1386ea77ca9da61ffdfa8b57a297 Reviewed-on: https://chromium-review.googlesource.com/1076985Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562807}
-
Mark Pilgrim authored
As part of the effort to bring the new Network Service online, we are deprecating URLFetcher in favor of SimpleURLLoader. Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1070110 Reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1073656 Refactoring exposed an underlying bug in the existing code (max_retries_on_5xx_ could be used before being initialized). This CL initializes it to 0 in the constructor. Bug: 844937 Change-Id: I419565dc899b2b48118b351206ade4f15090836a TBR: groby@chromium.org, charleszhao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1076407 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#562806}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/16f558d..21ca043 git log 16f558d..21ca043 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 robertphillips@google.com Allow CCPR in DDL1 images (since DDL itself now supports CCPR) 2018-05-29 robertphillips@google.com Add DDL to SKPBench Created with: gclient setdep -r src/third_party/skia@21ca043 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ie2cfa85e724c3d2ac9d83384c2cc0ede2868cc6c Reviewed-on: https://chromium-review.googlesource.com/1078630 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562805}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0ed2aa2..c518170 git log 0ed2aa2..c518170 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 lucferron@chromium.org Vulkan: generateMipmaps for 2D textures Created with: gclient setdep -r src/third_party/angle@c518170 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I1d18e49045724226eef319ff0d2eeac08150dd0b Reviewed-on: https://chromium-review.googlesource.com/1078629 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562804}
-
Koji Ishii authored
Following bot results are included. 5964 5973 5975 5977 No deflakes detected in the last 12 try jobs. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia61d0aa4873a5bf00c97874a2cdc9a47fef94d71 Reviewed-on: https://chromium-review.googlesource.com/1078088 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562803}
-
Takuto Ikuta authored
The issue was fixed by VS 2017 15.7.1 with 10.0.17134.0 SDK https://developercommunity.visualstudio.com/content/problem/131391/154-fails-to-define-deprecatedenumerator-2.html Bug: 773476 Change-Id: Ib90e99e9b3d69907aaaa994df92f7debd65105b3 Reviewed-on: https://chromium-review.googlesource.com/1078213 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#562802}
-
nednguyen authored
NOTRY=true # test covered by PRESUBMIT TBR=eyaich@chromium.org Bug: 846710 Change-Id: I7048aa075f46755a308db36917b05d86aadcd3ab Reviewed-on: https://chromium-review.googlesource.com/1078889Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#562801}
-
Bence Béky authored
There are 545 tests with names matching *WebSocket* (camel case), and only five matching *Websocket*. This CL renames those five to match the capitalization of the majority. Change-Id: Id366ccdd9625e361d12b8359a48dcd7a29cf38ea Reviewed-on: https://chromium-review.googlesource.com/1076411Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#562800}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3a3b9cc3. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" 6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm" 379eafdb "[LayoutNG] Need to pre-layout legacy orthogonal writing mode roots." 69a85361 "[css-grid] Disable paint containment for ruby-text elements" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18927 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I3e3fc3d89e6733306bc9143121c8433bc705441a Reviewed-on: https://chromium-review.googlesource.com/1078567 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#562799}
-
Mathieu Perreault authored
In the Payment Request sheet, icons should show as square and not squashed. Bug: 845929 Change-Id: I619f015d12e98d7cf8125a6cb8c99566e40f1d63 Reviewed-on: https://chromium-review.googlesource.com/1077450Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#562798}
-
Alexander Yashkin authored
This fix changes NetworkQualityObserverImpl logic so it does not send messages about network quality to renderers that are not connected - because they crashed, were discarded or by any other reason. This is done to lessen impact of memory leaks due to unbounded mojo message queuing described in details in linked issue. Bug: 813045 Change-Id: Idf5a470262e887d6559752ae1c0cfec168015f42 Reviewed-on: https://chromium-review.googlesource.com/1076148 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#562797}
-
Alexandr Ilin authored
This CL deletes the copy constructor and the copy assignment operator from the ppapi::proxy::SerializedHandle class replacing them with move operations. This is preparatory step to make SerializedHandle using the new shared memory classes that are move-only. SerializedHandle holds a system resource that should be properly closed after use. Move semantics allow to introduce the more clear ownership model and prevent resource leaks. Bug: 845985 Change-Id: Ie7202d18f4f0396133c53ee0faee111e07c58ee8 Reviewed-on: https://chromium-review.googlesource.com/1073200Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562796}
-
Colin Blundell authored
PrimaryAccountAccessTokenFetcher currently has the following flow: - wait for user to sign in - wait for primary account refresh token to become available - if during that waiting refresh tokens are loaded, fail (by making an access token request that will be guaranteed to fail) The third step above leads to inconsistency: Assume that a user is signed in but their token is not available on disk (e.g., it's been corrupted). If a PrimaryAccountAccessTokenFetcher is created *before* the tokens are loaded from disk, that fetcher will return an error to its client once tokens are loaded. If a PrimaryAccountAccessTokenFetcher is created after the tokens are loaded, that fetcher will wait until the refresh token actually becomes available (e.g., via a reauth). It will potentially wait forever. There seems no reason to have the distinction of whether a PrimaryAccountAccessTokenFetcher was created before or after tokens were loaded from disk result in behavioral differences that are visible to clients of PrimaryAccountAccessTokenFetcher. Note that by definition this change can result in behavioral changes for the cases where PrimaryAccountAccessTokenFetchers are created before tokens are loaded from disk. However, as clients of PrimaryAccountAccessTokenFetcher do not query whether tokens have been loaded from disk or not, any such resulting behaviors are already possible in the existing codebase (in the case where the fetchers happen to be created after tokens were loaded from disk, i.e., any time after startup). From treib@chromium.org, the original author of this code: "I've been trying to remember if I had any particular reason for adding this logic, but I think I just copied it from whatever I used as a model for the very first AccessTokenFetcher implementation. I completely agree with your reasoning that the distinction (based on whether tokens were already loaded from disk or not) doesn't make sense." Bug: 796544 Change-Id: I1bf855663ddee961ca68886500b92943df274f06 Reviewed-on: https://chromium-review.googlesource.com/1076289 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#562795}
-
Tetsui Ohkubo authored
This CL adds UnifiedSliderBubbleController, which implements slider bubbles e.g. volume slider and brightness slider triggered by hardware buttons. In old SystemTray, the impelmentation of the bubbles were tightly coupled with SystemTrayBubble. In terms of the feature, it's not strongly related to system tray, so in Unified, it does not use UnifiedSystemTrayBubble and instead has its own bubble. TEST=manual BUG=847730 Change-Id: I5f97ebb14efead8c3613ea7c4dfe6bb9760a1079 Reviewed-on: https://chromium-review.googlesource.com/1078032 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#562794}
-
Yoshifumi Inoue authored
This patch introduces |ReattachLegacyLayoutObjectList| class to patch NG layout tree to replaces LayoutNG objects to have legacy layout objects when assocaited elements return true for |Element::ShouldForeceLegacy()|. |Element::RebuildLayoutTree()| does this replacment in following two DOM tree traversals: 1. Collection phase: collects layout objects establish block formatting context containg elements return true for |Element::ShouldForeceLegacy()|. After treversing DOM tree, marks descendante elements in collected block foramtting context to |NeedsReattachLayoutTree|. 2. Patch phase: Attaches legacy layout object for makred elements which were LayoutNG objects. See https://goo.gl/8s5h96 for details. This patch also gets rid of following work arounds: - Change to inline-block for inline editable in |StyleAdjuster|. - Consider editable |LayotBlockFlow| to establish block formatting context. New Failed tests: * fast/block/child-not-removed-from-parent-lineboxes-crash.html This tests hits DCHECK in IsEmpty() in NGBlockLayoutAlgorithm::HandleInflow() for DETAIL with "position:absolute". * virtual/layout_ng_experimental/css3/flexbox/position-absolute-child-with-contenteditable.html # Background we have a few cases where we want to switch to old layout; forms, contenteditable, and a few others. A constraint we have here is that we can't collapse margins across engine boundary, and that all engine boundaries must create BFC. We somehow managed to force a BFC on forms (which strictly speaking is not the right thing to do for e.g., <legend>), but when we come to contenteditable, we can't force BFC there because it breaks layout too much. So the idea is, when we hit an element/box that needs to switch the layout engine, we look for its closest ancestor that creates a BFC, and switch the layout engine there, making sure the old layout handles all its subtree. Following patch will use this mechanism for <ruby> too. When we find a ruby, we can't run old layout only for ruby; needs to run old layout for its container block. But then if the container block has margin collapsing, we need to switch at the closest BFC boundary Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0769eab10f0dccf8aa00fc9e02aa6358f34d6a62 Reviewed-on: https://chromium-review.googlesource.com/1063891 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562793}
-
chrome://flagsMichael Lippautz authored
- Adds chrome://flags entry - Adds a FeatureFlag - Make existing Blink flag dependent on the Chrome flag Bug: chromium:757440, chromium:847735 Change-Id: Iccb63fc31b330a6bb69e95d5c0d7599cce10e2ee Reviewed-on: https://chromium-review.googlesource.com/1077870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562792}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/264182c..16f558d git log 264182c..16f558d --date=short --no-merges --format='%ad %ae %s' 2018-05-30 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8c361c7..0ed2aa2 (1 commits) Created with: gclient setdep -r src/third_party/skia@16f558d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I0b0371b2288c6b067d0999598cb334c213b98c29 Reviewed-on: https://chromium-review.googlesource.com/1078450Reviewed-by:
-
Arthur Hemery authored
This CL introduces a new interface called NavigationClient, implemented on the renderer side. This interface should allow to solve a number of race conditions as well as enabling other things. See the related BUG for more information on this. As a first step we replace two IPCs by reworking BeginNavigation. The idea is to send an interface pointer over BeginNavigation to allow for further control of the navigation. An important part of this CL is getting the proper lifetime for the Interface. We think that provisional_document_loader_ in the FrameLoader is a good candidate to own the binding. On the browser side,the NavigationRequest is in charge of holding the interface endpoint. BeginNavigation gets a new parameter: the AssociatedPtrInfo of the transmitted interface. FrameMsg_DroppedNavigation is replaced by the browser closing the pipe. FrameHostMsg_AbortNavigation is replaced by the renderer closing the pipe. The new interface duplicates the CommitNavigation and CommitFailedNavigation methods of the FrameNavigationControl interface. These new methods are used instead of the old interface ones for navigations that originated from a BeginNavigation. In future patches, it will be a complete replacement for both renderer and browser initiated navigations. Note: This patch is fully behind the PerNavigationMojoInterface flag. Please see https://chromium-review.googlesource.com/c/chromium/src/+/1072469 for the trybot runs with the PerNavigationMojoInterface flag on. Bug: 784904 Change-Id: Ifca1b3f6bdab1b3988f867c7cce44b7292e6668e Reviewed-on: https://chromium-review.googlesource.com/881043 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#562790}
-
Rune Lillesveen authored
We did not implement UA style as specified for form elements inside table elements. This CL removes the hardcoded way of not creating layout objects and instead add display:none to the UA style sheet as specified. We introduce a new internal pseudo class :-internal-is-html because the rule should only apply in html documents. This is also what Gecko does with its :-moz-is-html. The pseudo class is only allowed in UA sheets. The relationship with Squad is that we get rid of the dependency on ancestor layout objects in LayoutObjectIsNeeded. Bug: 847763, 843520 Change-Id: Ibc83b78493843b1a0503fbb65e509090fe295313 Reviewed-on: https://chromium-review.googlesource.com/1078348Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562789}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f45cf834..bb1f5f5e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I332c17babef2dafdf558145ba6aff67e0920af6d Reviewed-on: https://chromium-review.googlesource.com/1077929Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#562788}
-
Rune Lillesveen authored
Class is no longer in use. Change-Id: I68be39e998a6119ee56526460e2e6b2828b3dd9c Reviewed-on: https://chromium-review.googlesource.com/1078467Reviewed-by:
-
Egor Pasko authored
The main changes are: * Leave only a single on/off toggle for nostata-prefetch which maps to PRERENDER_MODE_NOSTATE_PREFETCH and PRERENDER_MODE_SIMPLE_LOAD_EXPERIMENT * Change the default mode to PRERENDER_MODE_NOSTATE_PREFETCH (affects tests) * Remove ability to set omnibox mode separately, only SetMode() remains * Since the java tests only use the default mode, allow them to work with nostate-prefetch (wait for appropriate FinalStatus instead of waiting for prerender to "finish loading") Along the way: * Remove the deprecated PRERENDER_MODE_DISABLED. * Deprecate the PRERENDER_MODE_ENABLED - it is still explicitly set in a few tests, will remove in a separate change. * The PRERENDER_MODE_NOSTATE_PREFETCH is more aggressive at marking as duplicate because the state is not cleared on "use". The workaround is to either clear prefetches_ or to avoid reusing the URL in a test. Both workarounds are used. * Small cleanups to pass stricter presubmit checks Bug: 755921 Change-Id: Ibfcccc61fe7f70f9a7087f29ba68a7263394c32f Reviewed-on: https://chromium-review.googlesource.com/1042571 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#562786}
-
Morten Stenshorne authored
The legacy layout engine expects a reversed block axis for objects in a vertical-rl container. We did it right for the LayoutObject itself, but not for the associated FloatingObject. Still, prior to this change, floats that were painted by NG (that's block flows with inline children) would be painted correctly. This worked because the legacy location was effectively ignored, because BlockFlowPainter::PaintFloats() miraculously ended up having no effect on the offset. Similarly, however, it also had no effect for legacy painting, so the offset wouldn't get primed for having the box's location (which has flipped block axis) added to it and end up at the right place. Now the flipping in BlockFlowPainter::PaintFloats() behaves as it should (i.e. has an effect on floats in vertical-rl containers), and we therefore have to make sure that we skip the flipping part if we're painting with NG, since all we're expected to do later on then, is add the true physical offset of the float. No flipping involved for LayoutNG. This fixes 14 tests. The multicol tests involved used to fail because the refs used vertical-rl floats (the actual tests rendered correctly also without this CL). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I705b89ae299a6474476ff0ea167cd5605e2c6357 Reviewed-on: https://chromium-review.googlesource.com/1075337 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#562785}
-
Jan Krcal authored
This reverts commit 6b0d759f. Reason for revert: Crashing on Canary https://crbug.com/847747. Original change's description: > [Typed URLs] Untrack entity from the processor when an URL gets expired > > This CL improves the bug fix for an issue with TYPED_URL. Before this > CL, one could hit DCHECK if typing an url that got expired in the > current running instance of Chrome. The DCHECK was due to the sync > entity still being tracked by ClientTagBasedModelTypeProcessor. > > Bug: 827111 > Change-Id: If040ed1657a5ec3b1bdada79c994f14ec63ce893 > Reviewed-on: https://chromium-review.googlesource.com/1076088 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562525} TBR=jkrcal@chromium.org,mastiz@chromium.org Change-Id: I34842135760215814aa30f88e1e5ac337a808cb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827111 Reviewed-on: https://chromium-review.googlesource.com/1078667Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562784}
-
Marc Treib authored
After Shutdown() has been called, it's not safe to use ProfileSyncService anymore (as with any KeyedService), so all observers must have unregistered themselves at that point. If they're KeyedServices themselves, then they should declare a dependency to PSS and unregister in their own Shutdown(). Others should use SyncServiceObserver::OnSyncShutdown to unregister. This CL adds a DCHECK to make sure that observers are gone, and fixes two places that didn't properly unregister. Bug: none Change-Id: Icc908f9293c2e2313663b1f135c5a7c96046ff3f Reviewed-on: https://chromium-review.googlesource.com/1070198Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#562783}
-
Tetsui Ohkubo authored
This CL rounds notification corners properly and adds separators between notifications. The notifications at the top and at the bottom should have rounded corners. This CL * Adds MessageView::UpdateCornerRadius(). Some subclasses e.g. ARC++ notification does not use default background of MessageView, so they override this method to implement their own corner rounding. * Removes sidebar_enabled flag and set border directly from UnifiedMessageCenterView. 1px #DFE0E0 solid border is added between notifications. (The color is not final but mentioned in the bug.) Screenshot: http://screen/ZbG9fzvZZ13 UX spec: http://shortn/_LO6ro9tLZK BUG=846181 TEST=manual Change-Id: Ib36ff38955a9d9351726134b4294c380570c3a90 Reviewed-on: https://chromium-review.googlesource.com/1078408Reviewed-by:
-
Roman Sorokin authored
This CL fixes the issue that user could not get into the session because policy fetch takes too long (>10 sec). Now if there is no cached policy it waits until gets response or D-Bus times out. BUG=chromium:845829 TEST=UserActiveDirectoryPolicyManagerTest.* Change-Id: I96db7e065564b8249b7eb0fa1f151ac5d2f4f27a Reviewed-on: https://chromium-review.googlesource.com/1070372Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#562781}
-
Colin Blundell authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1046847; I didn't realize that this method had no remaining clients at that time. Change-Id: I47a170884db4475a18088dc2ee815ff29b057b66 Reviewed-on: https://chromium-review.googlesource.com/1075789Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#562780}
-
